[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D70258#1780611 , @ABataev wrote: > Tests? This changes the implementation and does not add features. Thus, this is covered by the existing tests for the functionality, e.g. the un

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun updated this revision to Diff 233467. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Omit nodes from CFG instead of trying to make the states distinct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71371/new/ https://reviews.llvm.org/D71371 Files:

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun updated this revision to Diff 233468. xazax.hun added a comment. - Removed leftover code from previous approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71371/new/ https://reviews.llvm.org/D71371 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp

Re: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

On Wed, Dec 11, 2019 at 2:41 PM Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Michael Spencer > Date: 2019-12-11T14:40:51-08:00 > New Revision: f978ea498309adaebab8fbf1cd6e520e7e0e11f1 > > URL: > https://github.com/llvm/llvm-project/commit/f978ea498309adaebab8fbf

[clang] 5bcd34a - Revert "[clang][clang-scan-deps] Aggregate the full dependency information."

Author: Michael Spencer Date: 2019-12-11T16:35:55-08:00 New Revision: 5bcd34a03ff343674c106b9a6a0406bf249b9b31 URL: https://github.com/llvm/llvm-project/commit/5bcd34a03ff343674c106b9a6a0406bf249b9b31 DIFF: https://github.com/llvm/llvm-project/commit/5bcd34a03ff343674c106b9a6a0406bf249b9b31.dif

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + jdoerfert wrote: > ABataev wrote: > > `llvm::function_ref`? >

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert updated this revision to Diff 233472. jdoerfert marked an inline comment as done. jdoerfert added a comment. Update the unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 Files: clang/lib

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13047 + F->setUsesFPIntrin(true); + printf("Enclosing function uses fp intrinsics\n"); +} Looks like this is leftover debugging? I'm seeing log spam compiling some files -- this m

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13047 + F->setUsesFPIntrin(true); + printf("Enclosing function uses fp intrinsics\n"); +} rupprecht wrote: > Looks like this is leftover

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1318 case Expr::MSDependentExistsStmtClass: llvm_unreachable("Stmt should not be in analyzer evaluatio

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + ABataev wrote: >

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fdcae7c81f5: [analyzer] Do not cache out on some shared implicit AST nodes (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D71371?vs=233468&id=233475#toc Repository: rG LL

[clang] 9fdcae7 - [analyzer] Do not cache out on some shared implicit AST nodes

Author: Gabor Horvath Date: 2019-12-11T17:15:12-08:00 New Revision: 9fdcae7c81f5ff92ad694f5d993a042a525fd6bc URL: https://github.com/llvm/llvm-project/commit/9fdcae7c81f5ff92ad694f5d993a042a525fd6bc DIFF: https://github.com/llvm/llvm-project/commit/9fdcae7c81f5ff92ad694f5d993a042a525fd6bc.diff

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60744 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1779097 , @ABataev wrote: > In D71241#1778963 , @jdoerfert wrote: > > > In D71241#1778736 , @ABataev wrote: > > > > > In D71241#1778717 <

[clang] bc24014 - [c++20] Implement P1185R2 (as modified by P2002R0).

Hi Richard, http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1353 The bots are broken for a long time now. When do you expect the fix? Thanks, Alex On Wed, Dec 11, 2019 at 12:13 AM Yvan Roux via cfe-commits wrote: Hi Richard, ARM bots are broken after this commit, logs are a

[clang] 60590b1 - [Remarks][Driver] Ask for line tables when remarks are enabled

Author: Francis Visoiu Mistrih Date: 2019-12-11T17:59:46-08:00 New Revision: 60590b149b33eb80d0b52c1c6723fe35817ee897 URL: https://github.com/llvm/llvm-project/commit/60590b149b33eb80d0b52c1c6723fe35817ee897 DIFF: https://github.com/llvm/llvm-project/commit/60590b149b33eb80d0b52c1c6723fe35817ee

[PATCH] D71325: [Remarks][Driver] Ask for line tables when remarks are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG60590b149b33: [Remarks][Driver] Ask for line tables when remarks are enabled (authored by thegameg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71325/new/

[clang] 5d98695 - [IR] Split out target specific intrinsic enums into separate headers

Author: Reid Kleckner Date: 2019-12-11T18:02:14-08:00 New Revision: 5d986953c8b917bacfaa1f800fc1e242559f76be URL: https://github.com/llvm/llvm-project/commit/5d986953c8b917bacfaa1f800fc1e242559f76be DIFF: https://github.com/llvm/llvm-project/commit/5d986953c8b917bacfaa1f800fc1e242559f76be.diff

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. I have a Windows build directory and am motivated to debug this. I'll try to do it tomorrow, but I have a couple of other deadlines so I can't make a very firm promise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1778834 , @compnerd wrote: > Should probably add a check for `__block` variables. I looked into it, I am not sure if anything special needs to be done for block. ie: echo "void f() { __block int x = 42; void (^sum)(i

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen created this revision. khchen added reviewers: efriedma, lenary, asb, shiva0217, tejohnson. khchen added a project: clang. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, jocewei, PkmX, rkruppe, dexonsmith, the_o, brucehoult, MartinMosbeck, ro

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

ruiu added a comment. In D70919#1771198 , @sidneym wrote: > Remove quotes around check-not. > > -fuse-ld=lld is the correct usage. -fuse-ld=ld.lld results in an error > message: > error: invalid linker name in argument '-fuse-ld=ld.lld' `-fuse-ld` acc

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:212 bool UseG0 = false; + bool UseLLD = Args.getLastArgValue(options::OPT_fuse_ld_EQ).startswith("lld"); bool UseShared = IsShared && !IsStatic; bcain wrote: > Does this st

[clang] bdaf31e - [OpenMP][Docs] Mark 5.0 features worked on and list 5.1 features

Author: Johannes Doerfert Date: 2019-12-12T00:00:38-06:00 New Revision: bdaf31ec95e071b87e4cf160eb1ce570dc37a8c0 URL: https://github.com/llvm/llvm-project/commit/bdaf31ec95e071b87e4cf160eb1ce570dc37a8c0 DIFF: https://github.com/llvm/llvm-project/commit/bdaf31ec95e071b87e4cf160eb1ce570dc37a8c0.d

[PATCH] D71393: Default to -fno-use-init-array

MaskRay created this revision. MaskRay added reviewers: brad, kamleshbhalui, lenary, phosek, rnk. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, nios

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1777272 , @fedor.sergeev wrote: > In D70157#1776424 , @skan wrote: > > > > What if I insert explicit align(8) right *after* the sequence? > > > > If your insert explicit `.align 8`

[PATCH] D68161: [TimeProfiler] Fix "OptModule" section and add new "Backend" sections

anton-afanasyev closed this revision. anton-afanasyev added a comment. Commited long time ago (https://reviews.llvm.org/rL373142). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68161/new/ https://reviews.llvm.org/D68161 _

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

Jim accepted this revision. Jim added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Are you ready to land this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48921/new/ https://reviews.llvm.org/D48921

[clang] be14a22 - [Syntax] Build nodes for simple cases of top level declarations

Author: Ilya Biryukov Date: 2019-12-12T08:04:22+01:00 New Revision: be14a22b47e5c61ff36e4183dcb4f8b138466157 URL: https://github.com/llvm/llvm-project/commit/be14a22b47e5c61ff36e4183dcb4f8b138466157 DIFF: https://github.com/llvm/llvm-project/commit/be14a22b47e5c61ff36e4183dcb4f8b138466157.diff

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe14a22b47e5: [Syntax] Build nodes for simple cases of top level declarations (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7085

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen updated this revision to Diff 233508. khchen added a comment. update missed code.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71387/new/ https://reviews.llvm.org/D71387 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/Driv

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

ilya-biryukov added a comment. Landing as is, but happy to address any comments in the follow-up patches. @gribozavr2, please feel free to leave any suggestions in the review comments, despite it being closed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 7292c28 - Fix an error in the block ABI documentation sample code

Author: Akira Hatanaka Date: 2019-12-11T23:18:32-08:00 New Revision: 7292c2823063fdb9e2200ef7e4571d4f2443e6ca URL: https://github.com/llvm/llvm-project/commit/7292c2823063fdb9e2200ef7e4571d4f2443e6ca DIFF: https://github.com/llvm/llvm-project/commit/7292c2823063fdb9e2200ef7e4571d4f2443e6ca.diff

[PATCH] D71393: Default to -fno-use-init-array

echristo added a comment. Fan of this change, but let's definitely wait for more reviews :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71393/new/ https://reviews.llvm.org/D71393 ___ cfe-commits mail

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet updated this revision to Diff 233513. kadircet added a comment. - More tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71248/new/ https://reviews.llvm.org/D71248 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extr

[PATCH] D71393: Default to -fno-use-init-array

sberg added a comment. The title should probably read "Default to -fuse-init-array" (dropping the "no-")? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71393/new/ https://reviews.llvm.org/D71393 ___ c

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60657 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

ruiu added a comment. lld is not that Linux-centric as you implied in your comment. We have code for FreeBSD, OpenBSD, AMDGPU and Fuchsia (which isn't even a POSIX system), and adding code for NetBSD is OK and is appreciated. However, the thing we've been trying to avoid is to hard-code a platf

<    1   2   3