[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "9a3d576b08c13533597182498ba5e739924f892f". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. >> There is no evidence that this is more complicated. By all measures, this is >> less complicated (see also below). It is also actually doing the right thing >> when it comes to code emission. Take https://godbolt.org/z/sJiP3B for >> example. The calls are wrong and

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268 ___

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 233238. jdoerfert added a comment. Fix math problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/

[clang] bc24014 - [c++20] Implement P1185R2 (as modified by P2002R0).

Author: Richard Smith Date: 2019-12-10T17:24:27-08:00 New Revision: bc24014b9765a454cb5214f4871451a41ffb7d29 URL: https://github.com/llvm/llvm-project/commit/bc24014b9765a454cb5214f4871451a41ffb7d29 DIFF: https://github.com/llvm/llvm-project/commit/bc24014b9765a454cb5214f4871451a41ffb7d29.diff

[libunwind] 57fc8ec - Reland "Enable `-funwind-tables` flag when building libunwind"

Author: Sergej Jaskiewicz Date: 2019-12-11T04:27:04+03:00 New Revision: 57fc8ecdbaa7fbb1a13907ca3f7a3cb9f9459d27 URL: https://github.com/llvm/llvm-project/commit/57fc8ecdbaa7fbb1a13907ca3f7a3cb9f9459d27 DIFF: https://github.com/llvm/llvm-project/commit/57fc8ecdbaa7fbb1a13907ca3f7a3cb9f9459d27.d

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1778717 , @jdoerfert wrote: > >> There is no evidence that this is more complicated. By all measures, this > >> is less complicated (see also below). It is also actually doing the right > >> thing when it comes to code

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

merge_guards_bot added a comment. Build result: pass - 60692 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "9a3d576b08c13533597182498ba5e739924f892f". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

[PATCH] D71321: [analyzer] CStringChecker: Warning text fixes.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Fixes the problem mentioned in D66333#

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

NoQ added inline comments. Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:295-297 + OS << "Null pointer argument in call to " << CurrentFunctionDescription + << ' ' << IdxOfArg << llvm::getOrdinalSuffix(IdxOfArg) + << " parameter"; -

[clang] 2e48be0 - Fix mishandling of invalid-but-non-empty nested name specifiers in name

Author: Richard Smith Date: 2019-12-10T17:55:30-08:00 New Revision: 2e48be09b02e6d01b85d31704d768b6d0c751751 URL: https://github.com/llvm/llvm-project/commit/2e48be09b02e6d01b85d31704d768b6d0c751751 DIFF: https://github.com/llvm/llvm-project/commit/2e48be09b02e6d01b85d31704d768b6d0c751751.diff

Re: [PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

On Tue, 10 Dec 2019 at 13:24, Kian Moniri via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > kianm added a comment. > > Hi, I am still seeing problems with this assertion. Could we please get a > fix? I've posted the reduced test case and reproducible command on this > Phabrica

[PATCH] D71321: [analyzer] CStringChecker: Warning text fixes.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Cool, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71321/new/ https://reviews.llvm.org/D71321 ___ c

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

keryell added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:44 + +class KernelBodyTransform : public TreeTransform { +public: Feel free to add more comments in this area up to line 103. Comment at: clang/lib/Sema/SemaSYCL.cpp:417 +

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

Jim added a comment. @uweigand This is fixed by https://reviews.llvm.org/rG9c3966379813c198129c57aa3ebecd68d6af1ebd Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71049/new/ https://reviews.llvm.org/D71049 ___

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision: D71321: [a

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Could you write a test for `strcmp` please? I have found out the `evalMemcmp` behaves differently than `evalStrcmp`. However when the `memcmp` is going to be used like `strcmp`/`strncmp` t

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

NoQ updated this revision to Diff 233249. NoQ added a comment. Fair point. Yeah, i wonder what the real difference is :/ Added tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71322/new/ https://reviews.llvm.org/D71322 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

NoQ added a comment. > Instead, i conservatively assume that they don't overlap, unless they're > already known to certainly overlap on the current execution path. This loses > a bit of coverage but the lost path is where they do actually overlap. This > path is in my opinion not only rare but

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added a comment. Should probably add a check for `__block` variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 ___ cfe-commits mailing list cfe-

[clang] 8e0c9e2 - [c++20] Delete defaulted comparison functions if they would invoke an

Author: Richard Smith Date: 2019-12-10T19:28:30-08:00 New Revision: 8e0c9e21bf5f3e7a427b07e3eaf3bc80d2c74cb6 URL: https://github.com/llvm/llvm-project/commit/8e0c9e21bf5f3e7a427b07e3eaf3bc80d2c74cb6 DIFF: https://github.com/llvm/llvm-project/commit/8e0c9e21bf5f3e7a427b07e3eaf3bc80d2c74cb6.diff

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. In D71227#1778136 , @tra wrote: > I wonder if this patch will help with this case: > > https://godbolt.org/z/X4KdsV > > __device__ float fn(int) { return threadIdx.x; }; > __host__ float fn(float); > > float gvar1 = []()__dev

[PATCH] D70411: [analyzer] CERT: StrChecker: Implementing most of the STR31-C

Charusso updated this revision to Diff 233252. Charusso marked 7 inline comments as done. Charusso retitled this revision from "[analyzer] CERT: StrChecker: 31.c" to "[analyzer] CERT: StrChecker: Implementing most of the STR31-C". Charusso edited the summary of this revision. Charusso added a comm

[PATCH] D70411: [analyzer] CERT: StrChecker: Implementing most of the STR31-C

Charusso added a comment. In D70411#1776460 , @NoQ wrote: > Ok, so, what should the checker warn on? What should be the intended state > machine for this checker? > > We basically have two possible categories of answers to this question: > > - "The checke

[clang] ffe6129 - [c++20] Implement P1946R0: allow defaulted comparisons to take their

Author: Richard Smith Date: 2019-12-10T19:54:35-08:00 New Revision: ffe612922cb5aa2767c79d47a1b162811a08583f URL: https://github.com/llvm/llvm-project/commit/ffe612922cb5aa2767c79d47a1b162811a08583f DIFF: https://github.com/llvm/llvm-project/commit/ffe612922cb5aa2767c79d47a1b162811a08583f.diff

[clang] f7235ac - [cxx_status] Re-add missing cell.

Author: Richard Smith Date: 2019-12-10T19:56:07-08:00 New Revision: f7235ac1d3154d5cd82a9a6bfdfffd050e6f5d05 URL: https://github.com/llvm/llvm-project/commit/f7235ac1d3154d5cd82a9a6bfdfffd050e6f5d05 DIFF: https://github.com/llvm/llvm-project/commit/f7235ac1d3154d5cd82a9a6bfdfffd050e6f5d05.diff

[PATCH] D71325: [Remarks][Driver] Ask for line tables when remarks are enabled

thegameg created this revision. thegameg added reviewers: JDevlieghere, friss, aprantl. Herald added a project: clang. Serialized remarks contain debug locations for each remark, by storing a file path, a line, and a column. Also, remarks support being embedded in a .dSYM bundle using a separate

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In D71208#1776667 , @nhaehnle wrote: > > My concern is that there's something that's going to blow up or miscompile > > if we start passing in cons

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

ilya-biryukov added a comment. The fix itself LGTM. Just a few NITs and this is good to go. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:34 +// Covnert a Range to a Ref. +std::pair toRef(const clangd::Range &Range, +

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @george.burgess.iv : up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1778736 , @ABataev wrote: > In D71241#1778717 , @jdoerfert wrote: > > > >> There is no evidence that this is more complicated. By all measures, > > >> this is less complicated (

<    1   2   3