[PATCH] D70974: [clang-tidy] Fix PR26274

alexfh added a comment. In D70974#1769036 , @gribozavr2 wrote: > In D70974#1768902 , @aaron.ballman > wrote: > > > In D70974#1768871 , @gribozavr2 > > wrote: > > > > > I'm

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. @ABataev, thanks for your time and patient for the review! Could you land this patch for me when you have free time? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726

[clang] 7d0e111 - [HIP] Remove opencl.amdgcn.lib

Author: Yaxun (Sam) Liu Date: 2019-12-04T12:39:44-05:00 New Revision: 7d0e1117c9291863ab59d77e1ad6c9141a590e19 URL: https://github.com/llvm/llvm-project/commit/7d0e1117c9291863ab59d77e1ad6c9141a590e19 DIFF: https://github.com/llvm/llvm-project/commit/7d0e1117c9291863ab59d77e1ad6c9141a590e19.dif

[PATCH] D70980: [HIP] Remove opencl.amdgcn.lib

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d0e1117c929: [HIP] Remove opencl.amdgcn.lib (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70980/new/ h

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson created this revision. arichardson added reviewers: EricWF, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using the same approach as d0782a69ff4c04dc4f1dc1c11cb2fb43c6b638f5 and 91cef98d2c41eff0dea474a760d2dce5ba873209. Repository: rG LLVM Github Mo

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked 6 inline comments as done. Tyker added a comment. i did a few test on the linux kernel on prior version of this patchs and the mix of spaces and tabs caused some false positives. but i do believe there is still a bug here. for the mix of space and tabs. gcc has a -ftabstop=//X// to

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm added a comment. The reason for this whole patch was a bug in clang-tidy, which caused warning in the following code: #define SOME_RANDOM_MACRO macro namespace SOME_RANDOM_MACRO { } // namespace SOME_RANDOM_MACRO and clang-tidy suggested: namespace SOME_RANDOM_MACRO {

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

merge_guards_bot added a comment. Build result: pass - 60466 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69471: [Coverage] Revise format to reduce binary size

This revision was automatically updated to reflect the committed changes. Closed by commit rGe18531595bba: [Coverage] Revise format to reduce binary size (authored by vsk). Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

nickdesaulniers added a comment. In D70638#1768200 , @nathanchance wrote: > As an FYI, this appears to cause several false positive warnings with the > Linux kernel: > > ../drivers/video/fbdev/core/fbmem.c:665:3: warning: misleading indentation; > sta

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arphaman added a comment. Is the `Tooling/Transformer` library used by clang-format? The problem might be solved if the `Tooling/Transformer` library was its own module (just like Clang_ToolingInclusions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 232177. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - Move documents from release notes to header and proper rst, register test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. In D71001#1769071 , @baloghadamsoftware wrote: > In D71001#1769018 , @gribozavr2 > wrote: > > > ASan can help debug this issue, and more. > > > ASan is too heavyweight for this simple p

[PATCH] D70974: [clang-tidy] Fix PR26274

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:54 + const LangOptions &LangOpts) { + // Loc should be at the begin of the namespace decl (usually, `name

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

gribozavr2 added a comment. In D69855#1769318 , @twardakm wrote: > @alexfh, @gribozavr2, @aaron.ballman I think the best way out here is just to > implement the basic fix for the above problem and only allow to use macro > definition in closing comment a

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Eugene.Zelenko added a comment. In D71001#1769382 , @gribozavr2 wrote: > In D71001#1769071 , > @baloghadamsoftware wrote: > > > In D71001#1769018 , @gribozavr2 > > wrote: >

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall created this revision. sammccall added reviewers: kbobyrev, ilya-biryukov. sammccall added a project: clang. Herald added subscribers: ormris, mgorny. This was originally committed in 88bccded8fa169481fa367debf5ec615640635a1

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall updated this revision to Diff 232183. sammccall added a comment. Revert unneeded changes to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D70974: [clang-tidy] Fix PR26274

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:79 + } else { // Any other kind of token is unexpected here. +return llvm::None; + } How well do these test cases work? ``` name

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. @kbobyrev would you mind verifying this version of the patch also works? I don't expect changes vs the last one: it's been restructured a lot but the logic should be the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

merge_guards_bot added a comment. Build result: fail - 60479 tests passed, 1 failed and 726 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp Log files: console-log.txt

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

modocache added a comment. This seems like a outright improvement, but as mentioned above it would be nice to get @rsmith's take on it since I'm not an expert. Two nitpicks, though: 1. Could you please run clang-format on the lines you added/modified? 2. Could you apply these changes on top of t

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. In D71001#1769394 , @Eugene.Zelenko wrote: > With such logic, Clang-tidy is maintenance burden: 368 unaddressed request in > Bugzilla is very telling. Doesn't that just prove the point that we already have a problem with too

[PATCH] D70764: build: reduce CMake handling for zlib

JDevlieghere added a comment. In D70764#1767413 , @compnerd wrote: > In D70764#1767395 , @JDevlieghere > wrote: > > > Having one canonical variable controlling zlib support seems indeed > > desirable. > > > > In D

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM A little advice as you fix each comment check the "Done" button. I notice you are a new user, will you need help landing it? Repository: rG LLVM Github Monorepo CHANG

[clang] cdbed2d - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

Author: Melanie Blower Date: 2019-12-04T11:32:33-08:00 New Revision: cdbed2dd856c14687efd741c2d8321686102acb8 URL: https://github.com/llvm/llvm-project/commit/cdbed2dd856c14687efd741c2d8321686102acb8 DIFF: https://github.com/llvm/llvm-project/commit/cdbed2dd856c14687efd741c2d8321686102acb8.diff

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added a comment. I feel like there's something missing about this bug/issue - is there a good explanation/understanding for why does the bug only occur with the two levels of static member inline variable templates & not one? Perhaps there's some existing code that works for simple cas

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. In D70926#1769437 , @MyDeveloperDay wrote: > LGTM > > A little advice as you fix each comment check the "Done" button. > > I notice you are a new user, will you need help landing it? Thanks for the review! And yes I do need hel

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Eugene.Zelenko added a comment. In D71001#1769429 , @gribozavr2 wrote: > In D71001#1769394 , @Eugene.Zelenko > wrote: > > > With such logic, Clang-tidy is maintenance burden: 368 unaddressed request > > in Bugzill

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev updated this revision to Diff 232184. ABataev added a comment. Restored message + some small improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 Files: clang/include/clang/Basic/Attr.td

[PATCH] D71012: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/ToolChains/Clang.cpp:911 // bitcode file in the case of LTO. // FIXME: There should be a simpler way to find the object file for this //

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added a comment. I've pushed the updated patch, commit cdbed2dd856c14687efd741c2d8321686102acb8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

merge_guards_bot added a comment. Build result: pass - 60480 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

jkorous added a comment. The use of `xcrun` looks sound to me. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:53 + } + StringRef Path = Buf->get()->getBuffer().trim(); + if (Path.empty()) { The `trim()` is probably safe - just wondering if that cou

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

aaron.ballman added a comment. In D71001#1769048 , @gribozavr2 wrote: > In D71001#1769035 , @Eugene.Zelenko > wrote: > > > > ASan can help debug this issue, and more. > > > > This is dynamic analysis, and detection

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

xazax.hun added a comment. This might be a strange argument, but I did see this happen several times at different companies. When a company tries to decide which lint tools to use they are doing an evaluation. Usually, people doing the evaluation are not compiler/static analysis devs. Given th

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! I recently acquired commit access so I'll commit it after updating the unit test. Comment at: clang/lib/AST/TextNodeDumper.cpp:493 + case comments::InlineCommandComment::RenderAnchor:

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. Build result: pass - 60475 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 975a435 - [OPENMP]Update list of implemented features, NFC.

Author: Alexey Bataev Date: 2019-12-04T15:11:19-05:00 New Revision: 975a43512709a9e989dea11d2fefab9212e3a4f4 URL: https://github.com/llvm/llvm-project/commit/975a43512709a9e989dea11d2fefab9212e3a4f4 DIFF: https://github.com/llvm/llvm-project/commit/975a43512709a9e989dea11d2fefab9212e3a4f4.diff

[clang] 90fce46 - Fix crash-on-invalid-code in lambda constant evaluation.

Author: James Y Knight Date: 2019-12-04T15:12:17-05:00 New Revision: 90fce46fa6c9ccec86f642be0a75da2d0a5b11c1 URL: https://github.com/llvm/llvm-project/commit/90fce46fa6c9ccec86f642be0a75da2d0a5b11c1 DIFF: https://github.com/llvm/llvm-project/commit/90fce46fa6c9ccec86f642be0a75da2d0a5b11c1.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

thakis added a comment. The tests fail on Windows, http://45.33.8.238/win/3405/step_6.txt Please take a look, and if it takes a while to fix please revert while you investigte. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://revi

[clang] 5412913 - Revert " Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior=""

Author: Melanie Blower Date: 2019-12-04T12:21:23-08:00 New Revision: 5412913631feef74f7d52c092e947227c1cc7b04 URL: https://github.com/llvm/llvm-project/commit/5412913631feef74f7d52c092e947227c1cc7b04 DIFF: https://github.com/llvm/llvm-project/commit/5412913631feef74f7d52c092e947227c1cc7b04.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I reverted it again because build break on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing list cfe-com

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

erichkeane added a comment. In D62731#1769532 , @thakis wrote: > The tests fail on Windows, http://45.33.8.238/win/3405/step_6.txt > > Please take a look, and if it takes a while to fix please revert while you > investigte. It appears that only the 1st

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

andrewjcg updated this revision to Diff 232190. andrewjcg added a comment. rebase onto monorepo and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70219/new/ https://reviews.llvm.org/D70219 Files: clang/include/clang/Frontend/ASTUnit

[PATCH] D70764: build: reduce CMake handling for zlib

labath added a comment. `/usr/lib/x86_64-linux-gnu/libz.so` is definitely better than `-l/usr/lib/x86_64-linux-gnu/libz.so`, as it's at least a valid link line. It's not completely equivalent, and may not work in all cases -- last time I accidentally changed this, I got about a dozen emails fro

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

rnk added a comment. In D67463#1769238 , @tstellar wrote: > In D67463#1767919 , @rnk wrote: > > > @hans, are we still accepting 9.0.1 patches? I thought we'd already made a > > release candidate. > > > I'm still ac

[clang] 6120582 - [OPENMP50]Add support for if clause for simd part in taskloop simd

Author: Alexey Bataev Date: 2019-12-04T15:50:39-05:00 New Revision: 61205821ca20dbf1d9a4dc2c1c590955b249e8ee URL: https://github.com/llvm/llvm-project/commit/61205821ca20dbf1d9a4dc2c1c590955b249e8ee DIFF: https://github.com/llvm/llvm-project/commit/61205821ca20dbf1d9a4dc2c1c590955b249e8ee.diff

[PATCH] D70693: [scan-build-py] Set of small fixes

NoQ accepted this revision. NoQ added a comment. In D70693#1762137 , @xazax.hun wrote: > So after investigating the effects of this patch, the result is the following: > > Verbose mode (`-v`) that also prints findings to the command line will no > longer

Re: Github build status reporting

Hi Alex, Buildbot uses txgithub (https://github.com/tomprince/txgithub) to invoke Github API. Thanks Galina On Tue, Dec 3, 2019 at 12:36 PM Alex L wrote: > Hi Galina, > > Thanks for doing this! I'm curious as to how the buildbot CI communicates > with Github, is the buildbot itself capable o

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

eugenis added a comment. I meant you could define this path in the common lit config as something like "netbsd_noaslr_prefix" and then set up the %run substitution in subdirectories. > PaX ASLR on NetBSD is too aggressive with the layout randomization and we > cannot predict ranges of the heap

[PATCH] D70764: build: reduce CMake handling for zlib

beanz added a comment. @labath sorry for not replying on-list. I've actually been discussing offline with @compnerd. If `llvm-config` is printing an absolute path, I'm concerned about how that will interact with binary package distributions for the llvm-dev packages. Not sure if @tstellar has a

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

yaxunl updated this revision to Diff 232197. yaxunl marked 2 inline comments as done. yaxunl added a comment. remove unnecessary states added to Sema. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/lib/Sema/SemaDecl.cpp clang/t

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/deleting-dtor.cu:45-46 + +// Only MS has diagnostic since MS requires deleting dtor is emitted when +// vtable is emitted, even though dtor is not defined. +namespace MSEmitDeletingDtor { tra wrote: >

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso updated this revision to Diff 232198. Charusso added a comment. - Tweaking. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D70411 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/include/clang/StaticAnalyzer/Core/BugRe

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso added a comment. I have picked `curl` as an example, because it has a measurable amount of reports. I still recommend to make this alpha, because the expression-tracking cannot track members, and peoples are using members everywhere. F10966837: str31-c.tar.gz

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso updated this revision to Diff 232203. Charusso edited the summary of this revision. Charusso added a comment. - Add more tests. - Let us specify the descendant as allowing equality of symbols. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70805/new/ https://reviews.llvm.org/D70

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso updated this revision to Diff 232206. Charusso added a comment. - Add back a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70805/new/ https://reviews.llvm.org/D70805 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValHasDescendant.h clang/lib/StaticA

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso added a comment. Here is a possible piece of code from the Tidy world: `anyOf(declRefExpr(), hasDescendant(declRefExpr()), integerLiteral(), hasDescendant(integerLiteral()))`, that is why I recommend to allow equality of symbols to prevent boilerplate. CHANGES SINCE LAST ACTION htt

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

tstellar added a comment. In D67463#1769557 , @rnk wrote: > In D67463#1769238 , @tstellar wrote: > > > In D67463#1767919 , @rnk wrote: > > > > > @hans, are we still accepting

[PATCH] D69471: [Coverage] Revise format to reduce binary size

efriedma added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:53-56 +Error E = +zlib::compress(FilenamesStr, CompressedStr, zlib::BestSizeCompression); +if (E) + llvm_unreachable("Unexpected failure in zlib::compress"); -

[PATCH] D71033: [analyzer] CERT: StrChecker: 32.c

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This checker warns on most of the following rules: https://wiki

[PATCH] D71033: [analyzer] CERT: StrChecker: 32.c

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:357 + + // 'strlen(something) + something' is most likely fine. + // FIXME: Use the 'SValVisitor' to catch every such constructs of the s

[PATCH] D71033: [analyzer] CERT: StrChecker: 32.c

Charusso added a comment. Examples generated by CodeChecker from the `curl` project: F10966937: str32-c.tar.gz Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/ https://reviews.llvm.org/D71033 __

[clang] 9c29aed - Bug 43965 - Value of _MSVC_LANG doesn't match MSVC++ VS2019 /std:c++latest mode

Author: Soumi Manna Date: 2019-12-04T14:39:41-08:00 New Revision: 9c29aed6980dce42f2a071db09663c435ac21ad1 URL: https://github.com/llvm/llvm-project/commit/9c29aed6980dce42f2a071db09663c435ac21ad1 DIFF: https://github.com/llvm/llvm-project/commit/9c29aed6980dce42f2a071db09663c435ac21ad1.diff L

[PATCH] D70996: Bug 43965 - Value of _MSVC_LANG doesn't match MSVC++ VS2019 /std:c++latest mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c29aed6980d: Bug 43965 - Value of _MSVC_LANG doesn't match MSVC++ VS2019 /std:c++latest mode (authored by Manna, committed by rnk). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D70764: build: reduce CMake handling for zlib

beanz added a comment. I conferred off-list with @compnerd. He and I talked through my concerns, and I believe this patch is fine as-is, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764 _

[PATCH] D70726: [OpenMP50] Add parallel master construct

rnk added a comment. One of the new tests doesn't pass on Windows, so I reverted this in rG33f6d465d790ac5c9b949e6bc05127d356212079 . I made an attempt to fix the checks, but it wasn't trivial. Repository: rG LLVM Github M

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev reopened this revision. ABataev added a comment. This revision is now accepted and ready to land. Need to fix tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726 _

[PATCH] D70615: Add an -fno-temp-file flag for compilation

rnk added a comment. +more reviewers This doesn't add any code complexity, we already have the boolean UseTempFile flag, so I think we should do this. I would also point out that right now, in my LLVM build directory on Windows, I have 895 *.obj.tmp files: $ find . -iname '*.obj.tmp' | wc -l

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk reopened this revision. vsk marked an inline comment as done. vsk added a comment. This revision is now accepted and ready to land. I reverted this due to failures on Windows that I did not encounter in local testing. I suspect that there's an error in the coverage parsing logic, as the same

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. the warning was not affected by -ftabstop. i made a patch that fix this. https://reviews.llvm.org/D71037 and I agree that mixing tabs and space is a horrible idea for many reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rnk added a comment. In D70172#1746451 , @yaxunl wrote: > We are not using Itanium ABI when we do host compilation of CUDA/HIP on > windows. During the host compilation on windows only MS C++ ABI is used. > > This issue is not due to mixing MS ABI with It

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6587 + else if (!Size) +Size = MemVT.getStoreSize().getKnownMinSize(); In order for alias analysis to correctly handle a MachineMemOperand, the "Size" of an operati

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

NoQ added a comment. A while back I had a look into implementing some of the CERT checkers and my vague recollection from these attempts was that it's a bad idea to take CERT examples literally. Most of the CERT rules are explained in an informal natural language and it makes CERT great for dem

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

NoQ added a comment. In D70411#1769628 , @Charusso wrote: > F10966837: str31-c.tar.gz These reports seem to confirm my point. I took a look at first 5 and in all of them the code does in fact ensure that the buffer s

[clang] 07e4451 - [clang][IFS] Adding support for new clang interface stubs decl types.

Author: Puyan Lotfi Date: 2019-12-04T19:10:47-05:00 New Revision: 07e445103e363c85ce7313c542dee20b2294fe72 URL: https://github.com/llvm/llvm-project/commit/07e445103e363c85ce7313c542dee20b2294fe72 DIFF: https://github.com/llvm/llvm-project/commit/07e445103e363c85ce7313c542dee20b2294fe72.diff L

[PATCH] D70728: [clang][IFS] Adding support for new clang interface stubs decl types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07e445103e36: [clang][IFS] Adding support for new clang interface stubs decl types. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70728

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

thakis added a comment. > It appears that only the 1st failure there is the fault of this patch. The > 2nd seems to have come from some openmp patch (that didn't consider dso_local > on windows). > > The first (fpconstrained.cpp) likely just needs the check-lines to NOT > explicitly say the %

[clang] 3c50f25 - [analyzer] Fix more ObjC accessor body farms after 2073dd2d.

Author: Artem Dergachev Date: 2019-12-04T16:29:08-08:00 New Revision: 3c50f2544f7a8f0c41f4fc286064abce2d3629b5 URL: https://github.com/llvm/llvm-project/commit/3c50f2544f7a8f0c41f4fc286064abce2d3629b5 DIFF: https://github.com/llvm/llvm-project/commit/3c50f2544f7a8f0c41f4fc286064abce2d3629b5.dif

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. I am still trying to understand the patch. Just made some comments about the tests. Comment at: llvm/include/llvm/MC/MCFragment.h:663 + enum SubType : uint8_t { +// BranchPadding - The variable size fragment to insert NOP before branch. +Branc

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang created this revision. akhuang added reviewers: rnk, rsmith. Herald added subscribers: cfe-commits, nhaehnle, jvesely, jholewinski. Herald added a project: clang. This adds parsing of the qualifiers __ptr32, __ptr64, __sptr, and __uptr and lowers them to the corresponding address space poi

[clang-tools-extra] c0ee022 - [clangd] NFC, add getLangOpts helper to ParsedAST

Author: Alex Lorenz Date: 2019-12-04T16:55:25-08:00 New Revision: c0ee0224c4cf52bc6ba74dec88b30b850deca523 URL: https://github.com/llvm/llvm-project/commit/c0ee0224c4cf52bc6ba74dec88b30b850deca523 DIFF: https://github.com/llvm/llvm-project/commit/c0ee0224c4cf52bc6ba74dec88b30b850deca523.diff L

[clang-tools-extra] 27f1244 - [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

Author: Alex Lorenz Date: 2019-12-04T16:58:12-08:00 New Revision: 27f124445755a80e048a68d2fabbd2fa6f40a723 URL: https://github.com/llvm/llvm-project/commit/27f124445755a80e048a68d2fabbd2fa6f40a723 DIFF: https://github.com/llvm/llvm-project/commit/27f124445755a80e048a68d2fabbd2fa6f40a723.diff L

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions &getLangOpts() const { +return getASTContext().getLangOpts(); kadircet wrote: > arphaman wrote: > > kadircet

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rG27f124445755: [clangd] Add a tweak refactoring to wrap Objective-C string literals in… (authored by arphaman). Changed prior to commit: https://reviews.llvm.o

[clang] 4ef9110 - [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

Author: Puyan Lotfi Date: 2019-12-04T20:03:57-05:00 New Revision: 4ef9110b8d1004840d70477382c6bd10fb487fb6 URL: https://github.com/llvm/llvm-project/commit/4ef9110b8d1004840d70477382c6bd10fb487fb6 DIFF: https://github.com/llvm/llvm-project/commit/4ef9110b8d1004840d70477382c6bd10fb487fb6.diff L

[PATCH] D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ef9110b8d10: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 ___

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

thakis added a comment. In D69825#1768111 , @arphaman wrote: > @aganea Please disable the new behavior for the Darwin platform. We rely on > the fact that Clang `-cc1` processes crash to report crashes using system's > crash reporting infrastructure. W

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. I find another deficiency (infinite loop) with the current approach. Say, there is a `je 0` (0x0F 0x84 0x00 0x00 0x00 0x00) at byte 0x90. (0x90+6)%32 == 0, so it ends on a 32-byte boundary. MF.getMaxPrefixSize() is 4, so the size of MCMachineDependentFragment may vary f

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:1014 + unsigned EndAddr = StartAddr + Size; + return StartAddr / BoundarySize != ((EndAddr - 1) / BoundarySize); +} Division is slow. Pass in the power of 2 and use right shift instead. You

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun created this revision. xazax.hun added reviewers: NoQ, dcoughlin, Szelethus, baloghadamsoftware, haowei. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. I was running the Fuc

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked 7 inline comments as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:211 + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) +return; This one and i

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232250. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tool

[clang] a1d2611 - [c++17] Fix assert / wrong code when passing a noexcept pointer to

Author: Richard Smith Date: 2019-12-04T18:55:23-08:00 New Revision: a1d2611c046efa46cf32a10c9e9a8a7a8a06feba URL: https://github.com/llvm/llvm-project/commit/a1d2611c046efa46cf32a10c9e9a8a7a8a06feba DIFF: https://github.com/llvm/llvm-project/commit/a1d2611c046efa46cf32a10c9e9a8a7a8a06feba.diff

[clang] 11d1052 - Properly convert all declaration non-type template arguments when

Author: Richard Smith Date: 2019-12-04T18:55:24-08:00 New Revision: 11d10527852b4d3ed738aa90d8bec0f398160593 URL: https://github.com/llvm/llvm-project/commit/11d10527852b4d3ed738aa90d8bec0f398160593 DIFF: https://github.com/llvm/llvm-project/commit/11d10527852b4d3ed738aa90d8bec0f398160593.diff

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

<    1   2   3   >