[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet reclaimed this revision. courbet added a comment. Actually, thinking more about this, adding this to the existing warning might not be a very consensual change. In the case of the warning: S f() { T&& t = ...; ... return t; } there is no argument against doing the std::m

[PATCH] D70306: clang: Exherbo multiarch ajustments

Keruspe planned changes to this revision. Keruspe marked 3 inline comments as done. Keruspe added a comment. Will give llvm::sys::path::stem a look and try to drop the x86_64 part from the include dir selection Comment at: clang/lib/Driver/ToolChains/Linux.cpp:360 + addPa

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet added a comment. Adding @Quuxplusone (warning author) for opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 ___ cfe-commits mailing list cfe-com

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229986. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[clang] 8b5f6c1 - [clang-format] [NFC] add recent changes to release notes

Author: mydeveloperday Date: 2019-11-19T08:44:27Z New Revision: 8b5f6c16476c7a8f50b660fb6e1b549759a783b6 URL: https://github.com/llvm/llvm-project/commit/8b5f6c16476c7a8f50b660fb6e1b549759a783b6 DIFF: https://github.com/llvm/llvm-project/commit/8b5f6c16476c7a8f50b660fb6e1b549759a783b6.diff LOG

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b5f6c16476c: [clang-format] [NFC] add recent changes to release notes (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 229996. MyDeveloperDay added a comment. - Rebase - Add Release note - Remove repeated lines cause by patch creation artefact CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFo

[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: fail - 60136 tests passed, 2 failed and 729 were skipped. failed: LLVM.CodeGen/NVPTX/vectorize-misaligned.ll failed: LLVM.Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll Log files: console-log.txt

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:176 + const LocationContext *LCtx = C.getPredecessor()->getLocationContext(); + ConstraintManager &CM = C.getConstraintManager(); + auto *CE = dyn_cast_or_null(Call.getOri

[clang-tools-extra] 7db1230 - Reland "[clangd] Implement rename by using SelectionTree and findExplicitReferences."

Author: Haojian Wu Date: 2019-11-19T10:20:25+01:00 New Revision: 7db1230a9f5e0185a88019c9aa5b55bd85498285 URL: https://github.com/llvm/llvm-project/commit/7db1230a9f5e0185a88019c9aa5b55bd85498285 DIFF: https://github.com/llvm/llvm-project/commit/7db1230a9f5e0185a88019c9aa5b55bd85498285.diff LO

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

JonasToth added a comment. IMHO these two should just not overlap. It makes sense, to have controversial or configurable stuff in clang-tidy. It should just be consistent with the warnings, as those are "always right" and clang-tidy can be opinionated/specialized. Repository: rG LLVM Github

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! but again it looks as if rebasing went wrong :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70325/new/ https://reviews.llvm.org/D7

[PATCH] D70340: Add a key method to Sema to optimize debug info size

hans added a comment. Nice! Silly questions, but for my own education: I thought the key function concept only existed in the Itanium ABI, but from your numbers it sounds like it's a concept, at least for debug info, also on Windows? Comment at: clang/include/clang/Sema/Sema

[PATCH] D70359: [clangd] Show values of more expressions on hover

kadircet added a comment. it feels like rebasing went wrong :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://reviews.llvm.org/D70359 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang-tools-extra] f0021f9 - [clangd] Fix ps4 buildbot failure.

Author: Haojian Wu Date: 2019-11-19T10:42:27+01:00 New Revision: f0021f95a1f40369e30bb94be1b0322747631047 URL: https://github.com/llvm/llvm-project/commit/f0021f95a1f40369e30bb94be1b0322747631047 DIFF: https://github.com/llvm/llvm-project/commit/f0021f95a1f40369e30bb94be1b0322747631047.diff LO

[clang-tools-extra] 6ec0714 - [clangd] More sensible output for constructors/destructors in hover.

Author: Sam McCall Date: 2019-11-19T10:43:22+01:00 New Revision: 6ec07140980770fccfcdf53fe43e7425a9f51a7b URL: https://github.com/llvm/llvm-project/commit/6ec07140980770fccfcdf53fe43e7425a9f51a7b DIFF: https://github.com/llvm/llvm-project/commit/6ec07140980770fccfcdf53fe43e7425a9f51a7b.diff LO

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:374 + } else { +auto Offset = positionToOffset(SM.getBufferData(SM.getMainFileID()), Pos); +if (!Offset) { ---

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

JonasToth added inline comments. Comment at: clang/include/clang/Format/Format.h:1110 + /// Different const alignment styles. + enum ConstAlignmentStyle { +/// Don't change const to either East const or West const. Drive-By question: https://reviews.llvm.or

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet added a comment. > IMHO these two should just not overlap. It makes sense, to have controversial > or configurable stuff in clang-tidy. It should just be consistent with the > warnings, as those are "always right" and clang-tidy can be > opinionated/specialized. So to make sure I under

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec071409807: [clangd] More sensible output for constructors/destructors in hover. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D703

[clang-tools-extra] e51484a - [clangd] Fix hover 'local scope' to include class template params

Author: Sam McCall Date: 2019-11-19T10:52:38+01:00 New Revision: e51484abd402016a385e17896e87877b77bf4c7b URL: https://github.com/llvm/llvm-project/commit/e51484abd402016a385e17896e87877b77bf4c7b DIFF: https://github.com/llvm/llvm-project/commit/e51484abd402016a385e17896e87877b77bf4c7b.diff LO

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

This revision was automatically updated to reflect the committed changes. Closed by commit rGe51484abd402: [clangd] Fix hover 'local scope' to include class template params (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D70325?vs=229910&id=230004#toc Repository: r

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

sammccall added a comment. Sorry about the bad rebase, I landed the right version i think :-) In D70325#1750496 , @sammccall wrote: > In D70325#1749432 , @kadircet wrote: > > > LGTM, with a question. What about def

[libunwind] 4fb8ecd - [libunwind] Adjust the signal_frame test for Arm

Author: Mikhail Maltsev Date: 2019-11-19T09:58:46Z New Revision: 4fb8ecdef4c9b19563e428a151c376a4103d65fc URL: https://github.com/llvm/llvm-project/commit/4fb8ecdef4c9b19563e428a151c376a4103d65fc DIFF: https://github.com/llvm/llvm-project/commit/4fb8ecdef4c9b19563e428a151c376a4103d65fc.diff LO

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In D50147#1648786 , @sammccall wrote: > > First and forehand, I have a problem to solve in my organization : we have > > many projects, and maintaining the config file in some many repositories is > > not practical. > > In some cas

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm created this revision. arsenm added reviewers: yaxunl, scott.linder, t-tye. Herald added subscribers: tpr, dstuttard, wdng, kzhuravl. Enabling optimization should allow frame pointer elimination. https://reviews.llvm.org/D70424 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/

[clang] b6d7bbf - [RISCV] Support mutilib in baremetal environment

Author: Zakk Chen Date: 2019-11-19T02:10:39-08:00 New Revision: b6d7bbfa004310777cd41448ffc377aea082fc8c URL: https://github.com/llvm/llvm-project/commit/b6d7bbfa004310777cd41448ffc377aea082fc8c DIFF: https://github.com/llvm/llvm-project/commit/b6d7bbfa004310777cd41448ffc377aea082fc8c.diff LOG

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d7bbfa0043: [RISCV] Support mutilib in baremetal environment (authored by khchen, committed by Zakk Chen ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a4c74f1157: [clang-tidy] Added DefaultOperatorNewCheck. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D67545?vs=226206&id=230019#toc Repository: rG LLVM Github Monorepo

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

thakis added a comment. The test fails on Windows: http://45.33.8.238/win/2576/step_6.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 ___ cfe-commits mailin

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://reviews.llvm.org/D70183 ___ cfe-commits mailing list cfe-com

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } dnsampaio wrote: > miyuki wrote: > > dnsampaio wrote: > > > miyuki wrote: > > > > dnsampaio wrote: > > >

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey added a comment. Hi @aprantl. Can we drop C binding for this feature ? What will be the impact of this. As noted by @sammccall this does not conform / break LLVM-C ABI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://revi

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230031. lh123 edited the summary of this revision. lh123 added a comment. Address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230033. lh123 added a comment. fix typo in function document. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CompilationDatabase.

[PATCH] D70242: [OpenCL] Allow addr space qualifiers on lambda call expressions

Anastasia added a comment. In D70242#1748313 , @rjmccall wrote: > Well that was easy. > > Do we accept the address-space attribute in this position, or is that TBD? We accept the OpenCL one right at the end. I might need to test more in C++ though...

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar added a comment. Oops, it looks like I mixed up this ticket with https://reviews.llvm.org/D69238. Sorry about that. Would you like me to revert both commits and then re-commit with the correct links, etc.? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

lebedev.ri added a comment. In D70165#1751402 , @mitchell-stellar wrote: > Oops, it looks like I mixed up this ticket with > https://reviews.llvm.org/D69238. Sorry about that. Would you like me to > revert both commits and then re-commit with the correc

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai accepted this revision. nemanjai added a comment. LGTM. Thanks for adding the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 ___ cfe-commit

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

JonasToth added a comment. In D70390#1751159 , @courbet wrote: > > IMHO these two should just not overlap. It makes sense, to have > > controversial or configurable stuff in clang-tidy. It should just be > > consistent with the warnings, as those are "al

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reopening in order to correct the accidentally swapped commits between this ticket and https://reviews.llvm.org/D69238. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reopening in order to correct the accidentally swapped commits between this ticket and https://reviews.llvm.org/D70165. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang-tools-extra] 41ee54e - Revert "[clang-tidy] Fix readability-redundant-string-init for c++17/c++2a"

Author: Mitchell Balan Date: 2019-11-19T07:52:31-05:00 New Revision: 41ee54e5d18858c56725485ef637ad5a686368f4 URL: https://github.com/llvm/llvm-project/commit/41ee54e5d18858c56725485ef637ad5a686368f4 DIFF: https://github.com/llvm/llvm-project/commit/41ee54e5d18858c56725485ef637ad5a686368f4.diff

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf7086fe: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D70165?vs=229632&id=230040#toc Repos

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rG1315f4e009b0: [clang-tidy] Fix readability-redundant-string-init for c++17/c++2a (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69238?vs=229651&id=230039#toc Reposi

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. I know it has been a long time, but this patch is ready, i think :) i would appreciate some reviews ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 __

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 230048. JonasToth added a comment. - port patch to monorepo - Merge branch 'master' into feature_transform_const.patch - merge current master and new version for previous steps into this patch - fix compilation issues after type renaming - work on fixing sup

[clang] 3de7cc9 - Revert "[RISCV] Support mutilib in baremetal environment"

Author: Nico Weber Date: 2019-11-19T08:16:55-05:00 New Revision: 3de7cc9fc01c8eb19eb344691c4747def1e00311 URL: https://github.com/llvm/llvm-project/commit/3de7cc9fc01c8eb19eb344691c4747def1e00311 DIFF: https://github.com/llvm/llvm-project/commit/3de7cc9fc01c8eb19eb344691c4747def1e00311.diff LO

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

thakis added a comment. Reverted in 3de7cc9fc01c8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 ___

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked 2 inline comments as done. dnsampaio added a comment. Yes. It does return a non-valid FileID, and in builds without assert you get the expected error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://review

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

justinkb reopened this revision. justinkb added a comment. This revision is now accepted and ready to land. Herald added a project: LLVM. The check doesn't work correctly if LLVM is built as a dylib and the LLVMTestingSupport static library isn't installed (which it normally wouldn't be) On my

[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following intrinsics: - asr & asrd - insr -

[PATCH] D70175: [libTooling] Extend `buildASTFromCodeWithArgs` to take files argument.

ymandel added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70175/new/ https://reviews.llvm.org/D70175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D70183: Detect source location overflow due includes

miyuki added a comment. In D70183#1751552 , @dnsampaio wrote: > Yes. It does return a non-valid FileID, and in builds without assert you get > the expected error message. I was asking about "It will still reach an false assert in builds that enable the

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added a comment. @aaron.ballman, @Anastasia, could you take a look at new version of the patch, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 _

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong created this revision. martong added reviewers: NoQ, Szelethus, xazax.hun, dkrupp. Herald added subscribers: cfe-commits, Charusso, gamesh411, donat.nagy, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. We add a new c

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

kpn added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:262 Function *F = BB->getParent(); -if (!F->hasFnAttribute(Attribute::StrictFP)) { +if (F && !F->hasFnAttribute(Attribute::StrictFP)) { F->addFnAttr(Attribute::StrictFP);

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny added a comment. That sounds like a bug in llvm-config. It shouldn't really return dylib for components that aren't part of it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55891/new/ https://reviews.llvm.org/D55891

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro updated this revision to Diff 230054. djtodoro added a comment. -Update the lldb test for the entry values feature CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInf

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro added a comment. @vsk I have created the bug (llvm.org/pr44059), do you think this is OK? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall updated this revision to Diff 230058. sammccall added a comment. Fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://reviews.llvm.org/D70359 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/u

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a reviewer: chandlerc. krytarowski added a comment. Ping? We are in the process of switching our buildbot to newer NetBSD snapshot (-8 to -9) and we keep waiting for this patch to land. If we could get this patch merged, we could build and link the whole LLVM with lld on NetB

[PATCH] D70359: [clangd] Show values of more expressions on hover

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://reviews.llvm.org/D70359 __

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230060. lh123 added a comment. fixes some bug and add more test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CompilationDatab

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } miyuki wrote: > dnsampaio wrote: > > miyuki wrote: > > > d

[clang-tools-extra] 33d93c3 - [clangd] Show values of more expressions on hover

Author: Sam McCall Date: 2019-11-19T15:34:04+01:00 New Revision: 33d93c3d0b4a331632902f5fb9874f4e021a2f58 URL: https://github.com/llvm/llvm-project/commit/33d93c3d0b4a331632902f5fb9874f4e021a2f58 DIFF: https://github.com/llvm/llvm-project/commit/33d93c3d0b4a331632902f5fb9874f4e021a2f58.diff LO

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: llvm-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. This is a follow-up to 590f279c456bbde632eca8ef89a85c478f15a249

[PATCH] D70359: [clangd] Show values of more expressions on hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d93c3d0b4a: [clangd] Show values of more expressions on hover (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://re

[PATCH] D70319: [ARM,MVE] Add intrinsics for scalar shifts.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. > That makes even LSLL and ASRL different enough from standard LLVM IR shift > semantics that I couldn't see any better alternative than to simply model the > whole family as a set of MVE-sp

[PATCH] D69648: Add VFS support for sanitizers' blacklist' 2

ilya-biryukov added a comment. It turned out there are more places that attempt to construct `SpecialCaseList` and access corresponding file via the usual filesystem APIs. D70440 should take care of those. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added inline comments. Herald added a subscriber: ormris. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:100 + Contains(StrEq(std::string("-fsanitize-system-blacklist=") + + ASanBlacklist))); + // User blacklists s

[PATCH] D70183: Detect source location overflow due includes

miyuki requested changes to this revision. miyuki added a comment. This revision now requires changes to proceed. This essentially means that if there is a problem related to this change, say something goes wrong after `return FileID();` it would be impossible to debug until the corresponding as

[clang] 254b4f2 - [ARM,MVE] Add intrinsics for scalar shifts.

Author: Simon Tatham Date: 2019-11-19T14:47:29Z New Revision: 254b4f250007ef9f2d2377eb912963beafa39754 URL: https://github.com/llvm/llvm-project/commit/254b4f250007ef9f2d2377eb912963beafa39754 DIFF: https://github.com/llvm/llvm-project/commit/254b4f250007ef9f2d2377eb912963beafa39754.diff LOG:

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added inline comments. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:71 + prepareFS(llvm::ArrayRef ExtraFiles) { + +llvm::IntrusiveRefCntPtr FS = NIT to self: remove this newline and the one before return Repository: rG LLVM Gith

[PATCH] D70319: [ARM,MVE] Add intrinsics for scalar shifts.

This revision was automatically updated to reflect the committed changes. Closed by commit rG254b4f250007: [ARM,MVE] Add intrinsics for scalar shifts. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70319/new/ https://revie

[PATCH] D70441: [clangd] Speed up when building rename edit.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. We used to scan the code everytime when computing the LSP position to the offset (respect the LSP encoding). Repository:

[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: pass - 60178 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 230068. hokein marked an inline comment as done. hokein added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files: clang-tools-extra/clangd/Clangd

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm added a comment. In D69598#1742740 , @andrew.w.kaylor wrote: > Thanks. I understand your direction for denormal handling now, and I'm OK > with this patch apart from the remaining references to subnormal that Sanjay > mentioned. > > In D69598#173

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia added a comment. In D69938#1747735 , @rjmccall wrote: > > I was already planning to add this. I could look into it next and maybe > > just a add FIXME in the test for now. > > Sure. > > > Btw global lambda objects are in `__global` address space

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia updated this revision to Diff 230070. Anastasia added a comment. - Added FIXME to enhance testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69938/new/ https://reviews.llvm.org/D69938 Files: clang/lib/Sema/SemaLambda.cpp clang/lib/Sema/SemaType.cpp clang/test/SemaOp

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

Quuxplusone added a comment. Hi, I'm the main original author (although I would not claim "current maintainer") of the Clang warning. Clang doesn't warn about `const vector v; return v;` because in that case, adding `std::move` to the return would not help anything. I had not considered that we

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60175 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1110 + /// Different const alignment styles. + enum ConstAlignmentStyle { +/// Don't change const to either East const or West const. -

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. kbobyrev added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. The original bug report can be found here .

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske updated this revision to Diff 230076. balazske marked an inline comment as done. balazske added a comment. - Moved freopen after fopen, removed 'SValBuilder'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69948/new/ https://reviews.llvm.or

[PATCH] D70446: [clangd] Treat UserDefinedLiteral as a leaf in SelectionTree, sidestepping tokenization issues

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/203 Repository: rG LLVM Github Monorepo https://rev

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14926-14929 + } else if (((SemaRef.getLangOpts().OpenMP >= 50 && + DKind != OMPD_target_update) || + SemaRef.getLangOpts().OpenMP < 50) && + (AllowUnit

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

This revision was automatically updated to reflect the committed changes. Closed by commit rG980653621ef5: [clang-tidy] Give readability-redundant-member-init an option… (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69145?vs=229934&id=230077#toc Repository:

[PATCH] D70183: Detect source location overflow due includes

dnsampaio added a comment. Git diff 979ae80af7ec49624b932954d22cb91900f17121 did not send a test as well. Feel free to send me a reasonable sized reproducer, the one I have is about 36MB. Don't think it will be that well received. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:189-190 + // Check if error was generated. + if (C.isDifferent()) +return; + baloghadamsoftware wrote: > balazske wrot

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

This revision was automatically updated to reflect the committed changes. Closed by commit rGb81cc6032902: [clang][NFC] Make various uses of Regex const (authored by thopre). Changed prior to commit: https://reviews.llvm.org/D68155?vs=26&id=230079#toc Repository: rG LLVM Github Monorepo

[PATCH] D70446: [clangd] Treat UserDefinedLiteral as a leaf in SelectionTree, sidestepping tokenization issues

merge_guards_bot added a comment. Build result: pass - 60179 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] b81cc60 - [clang][NFC] Make various uses of Regex const

Author: Thomas Preud'homme Date: 2019-11-19T16:15:21Z New Revision: b81cc6032902c810e0fde485d3092a947dc38541 URL: https://github.com/llvm/llvm-project/commit/b81cc6032902c810e0fde485d3092a947dc38541 DIFF: https://github.com/llvm/llvm-project/commit/b81cc6032902c810e0fde485d3092a947dc38541.diff

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

thopre added a comment. My sincere apologies, I forgot to change the author in the commit. I don't often commit on behalf of others so didn't think enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155

[PATCH] D69878: Consoldiate internal denormal flushing controls

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1775 -if (getLangOpts().OpenCL) - FuncAttrs.addAttribute("denorms-are-zero", - llvm::toStringRef(CodeGenOpts.FlushDenorm)); so where would `denorms-are-

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

kiranchandramohan added a comment. Thanks @jdoerfert for working on this. Sorry for being late to the party. I am trying to implement one trivial directive (Flush) and one slightly more involved (not decided). I applied D69853 , D69785

[clang] 7fe9435 - Work on cleaning up denormal mode handling

Author: Matt Arsenault Date: 2019-11-19T22:01:14+05:30 New Revision: 7fe9435dc88050ee78eb1d4adec87610dce468f7 URL: https://github.com/llvm/llvm-project/commit/7fe9435dc88050ee78eb1d4adec87610dce468f7 DIFF: https://github.com/llvm/llvm-project/commit/7fe9435dc88050ee78eb1d4adec87610dce468f7.diff

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm closed this revision. arsenm added a comment. 7fe9435dc88050ee78eb1d4adec87610dce468f7 This does now need to be merged with the FPEnv.h header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69598/new/ https://

  1   2   3   >