[PATCH] D64874: [Sema] Improve handling of function pointer conversions

Mordante added a comment. @rsmith I now have commit access so I can commit the patch. Any suggestions regarding the previous remark? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64874/new/ https://reviews.llvm.org/D64874 ___ cfe-commits m

[PATCH] D70358: Add Cursor.get_reference_name_range to clang python binding.

arthurp created this revision. arthurp added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. arthurp added a comment. This is my first new revision here, and I guessed on the review based solely on resent reviews of related code. Please c

[PATCH] D70358: Add Cursor.get_reference_name_range to clang python binding.

arthurp added a comment. This is my first new revision here, and I guessed on the review based solely on resent reviews of related code. Please correct me as needed. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70358/new/ https://reviews.

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70359 Files: clang-tools-extra/cla

[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: fail - 60143 tests passed, 2 failed and 729 were skipped. failed: Clangd Unit Tests._/ClangdTests/FindExplicitReferencesTest.All failed: LLVM.Bindings/Go/go.test Log files: console-log.txt

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

sammccall added subscribers: ilya-biryukov, sammccall. sammccall added a comment. This seems to have broken clangd tests e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/58189/steps/test-check-all/logs/stdio FindExplicitReferences now finds duplicate refs

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

JonasToth added a comment. Hmm. I think this is fine, even though its not perfect. @aaron.ballman wdyt? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70144/new/ https://reviews.llvm.org/D70144 ___ cfe-c

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 229705. JonasToth marked 2 inline comments as done. JonasToth removed a subscriber: mgehre. JonasToth added a comment. - [Misc] port patch to monorepo - add more test cases for the transformation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Herald added a subscriber: mgehre. Comment at: clang-tidy/utils/FixItHintUtils.cpp:35 +static bool isValueType(QualType QT) { return isValueType(QT.getTypePtr()); } +static bool isArrayType(QualType QT)

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3493 +llvm::SmallVector &PL = PhaseList; +types::getCompilationPhases(types::TY_IFS_CPP, PL); +llvm::SmallVector CompilePhaseList; The reference binding is odd. Why not just pass

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:100 + const std::vector &getSkippedRanges() const { +return SkippedRanges; hokein wrote: > hokein wrote: > > Instead of adding new membe

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 229707. nridge added a comment. Support preamble as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/CollectMacros.h clang-tools-

[clang] c9276fb - Revert "[NFC] Refactor representation of materialized temporaries"

Author: Nico Weber Date: 2019-11-17T02:09:25-05:00 New Revision: c9276fbfdf0c7caf1576b2db562286d7cec7e53b URL: https://github.com/llvm/llvm-project/commit/c9276fbfdf0c7caf1576b2db562286d7cec7e53b DIFF: https://github.com/llvm/llvm-project/commit/c9276fbfdf0c7caf1576b2db562286d7cec7e53b.diff LO

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

thakis added a comment. Reverted in c9276fbfdf0c7caf1576b2 for now. Please watch the bots after landing things, and revert if something breaks and it takes you a while to fix. Repository: rG LLVM Github Monorepo CHANGES

<    1   2   3