[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. So use similar fix as I did: https://reviews.llvm.org/D69708 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing

[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

ilya-biryukov added a comment. NIT: we could probably add LLVM_NODISCARD attribute to ensure the return value is always consumed? Another NIT: maybe do this for all methods in the index that have the limit in their request (pretty much all of them, I guess)? Repository: rG LLVM Github Monore

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 229021. void added a comment. Adjust label references to account for in/out constraints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtens

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks great, thanks! Do you remember where you got the original code from? Would this work there too? Or does that not use the llvm diag classes? CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D70164: [Tooling][JSONCompilationDatabase] Fix backslash escaping on Windows

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/JSONCompilationDatabase.cpp:153 assert(Syntax == JSONCommandLineSyntax::Gnu); CommandLineArgumentParser parser(EscapedCommandLine); return parser.parse();

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

davezarzycki added a comment. Let's just fix the bug: 1d55c9e59ebf3f3ff572d42da433b2f72f1ce900 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder updated this revision to Diff 229023. MadCoder marked 8 inline comments as done. MadCoder edited the summary of this revision. MadCoder added a comment. Updated the patch to restrict `objc_direct` to methods and use `objc_direct_members` for containers, and several diagnostics improvemen

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder updated this revision to Diff 229024. MadCoder added a comment. Updated `clang/test/Misc/pragma-attribute-supported-attributes-list.test` that I had forgotten. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69991/new/ https://reviews.llvm.org/D69991 Files: clang/include/clan

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder marked an inline comment as done. MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:3885 +{ + // GNU runtime doesn't support direct calls at this time +} MadCoder wrote: > rjmccall wrote: > > This doesn't seem to be diagnosed i

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:225 tooling::Replacements FilteredChanges; - for (const tooling::SymbolOccurrence &Rename : - findOccurrencesWithinFile(AST, RenameDecl)) { -// Currently, we only support n

[clang] 2fe674b - [OpenCL] Add remaining vector data builtin functions

Author: Sven van Haastregt Date: 2019-11-13T10:16:33Z New Revision: 2fe674baa3f304b5fa497e71b51ea6315f89c5e0 URL: https://github.com/llvm/llvm-project/commit/2fe674baa3f304b5fa497e71b51ea6315f89c5e0 DIFF: https://github.com/llvm/llvm-project/commit/2fe674baa3f304b5fa497e71b51ea6315f89c5e0.diff

[PATCH] D70088: [ARM,MVE] Add intrinsics for contiguous load/stores.

dmgreen added a comment. Very nice Just to check, we don't have to care about big endian here? Is just works OK because the rest of llvm handles it OK? (I'm not sure if a vld1 is different to a vldr in big endian, for example). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70088: [ARM,MVE] Add intrinsics for contiguous load/stores.

simon_tatham added a comment. Yes, `vld1` has the same semantics as `vldrw_*32` or `vldrh_*16` or `vldrb_*8`. It's just a convenience alias that makes polymorphism easier – if I remember rightly the intended use case was people writing MVE intrinsics inside C++ templates. Repository: rG LLV

[PATCH] D49890: Clang-Tidy Export Problem

kfunk added a comment. Is someone willing to pick up this patch again? It's still an issue. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49890/new/ https://reviews.llvm.org/D49890 ___ cfe-commits maili

[PATCH] D70133: [ARM, MVE] Add intrinsics for 'administrative' vector operations.

dmgreen added a comment. Smaller patches are easier to review, if for example this could have the vgetq_lane/vsetq_lane split out. Comment at: clang/include/clang/Basic/arm_mve.td:384 + let params = !foldl([], T.All, tlist, srctype, !listconcat(tlist, + !if(!eq(!cast(desttyp

[PATCH] D70088: [ARM,MVE] Add intrinsics for contiguous load/stores.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK. vldr and vld1 working differently for Neon under BE, if I'm remembering correctly. LGTM then. Comment at: clang/utils/TableGen/MveEmitter.cpp:475 // Mostly, when a

[PATCH] D70133: [ARM, MVE] Add intrinsics for 'administrative' vector operations.

simon_tatham marked 3 inline comments as done. simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:384 + let params = !foldl([], T.All, tlist, srctype, !listconcat(tlist, + !if(!eq(!cast(desttype),!cast(srctype)),[],[srctype]))) in { +def "v

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. The Microsoft ABI requires that clang performs the destructor body checks (i.e. operator delete() lookup) when the vtable is marked used, as the deleting destructor is emitted with the vtable, not with the destructor definition a

[PATCH] D70173: [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. Flags that generate output could result in failures when creating syntax only actions. This patch introduces initial logic for filterin

[PATCH] D70173: [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster

merge_guards_bot added a comment. Build result: pass - 59822 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70173: [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:24 /// Add -fsyntax-only option to the command line arguments. ArgumentsAdjuster getClangSyntaxOnlyAdjuster() { -

[PATCH] D70173: [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster

kadircet updated this revision to Diff 229069. kadircet marked an inline comment as done. kadircet added a comment. - Update comment to mention droppage of options that generate output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70173/new/ https

[clang-tools-extra] 33e882d - [clangd] Add bool return type to Index::refs API.

Author: Haojian Wu Date: 2019-11-13T14:42:30+01:00 New Revision: 33e882d5ada0b42323be3277816b0817b8e6baa2 URL: https://github.com/llvm/llvm-project/commit/33e882d5ada0b42323be3277816b0817b8e6baa2 DIFF: https://github.com/llvm/llvm-project/commit/33e882d5ada0b42323be3277816b0817b8e6baa2.diff LO

[PATCH] D70173: [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster

merge_guards_bot added a comment. Build result: pass - 59822 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e882d5ada0: [clangd] Add bool return type to Index::refs API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70139/new/ https://revie

[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

hokein added a comment. In D70139#1743512 , @ilya-biryukov wrote: > NIT: we could probably add LLVM_NODISCARD attribute to ensure the return > value is always consumed? > Another NIT: maybe do this for all methods in the index that have the limit > in

[PATCH] D70175: [libTooling] Extend `buildASTFromCodeWithArgs` to take files argument.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Adds an optional parameter to `buildASTFromCodeWithArgs` that allows the user to pass additional files that the main code needs to compile. This change makes `buildASTFromCodeWithArgs` consistent wit

[PATCH] D70173: [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster

This revision was automatically updated to reflect the committed changes. Closed by commit rG16bdcc809c72: [clang][Tooling] Filter flags that generate output in SyntaxOnlyAdjuster (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D70180: [AArch64][SVE] Implement floating-point conversion intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - fcvt - fcvtzs & fcvtzu - scvtf & ucvtf - fcvtlt, f

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim marked an inline comment as done. dim added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:370 +: nullptr; +} return nullptr; jdoerfert wrote: > Consistent style please: > > ``` > if (Value *StrLen =

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall( AB

[PATCH] D70142: [OpenMP5.0] Fix a parsing issue for the extended defaultmap

ABataev added a comment. In D70142#1742984 , @cchen wrote: > Not sure how to test this change since the issue only happens after I add > more implicit-behaviors for extended defaultmap. Now > `ActOnOpenMPDefaultmapClause` is doing `M != > OMPC_DEFAULTMA

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

koalo added a comment. In D54628#1742781 , @MyDeveloperDay wrote: > sorry searching through old issues, are you still interested in this patch? Yes, would be nice to have either this or an equivalent possibility that implements the same feature. Repo

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM! Did you check on a real code-base that suffers from the issue, if that works as expected? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. I'm thinking this is the same as BraceWrapping.AfterEnum, if you think your use case is covered would you consider Abandoning this revision so we know this functionality exists already, if not let work out what is missing if (Right.is(TT_InlineASMBrace)) r

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

JonasToth added a comment. Please mention this improvement in the release notes as well :) Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:306 + if (ApplyFix) { +// Peek ahead to see if there's a semicolon after Body->getSourceRange() +Opti

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } For debug builds, I could not find any other way to not re

[PATCH] D70183: Detect source location overflow due includes

dnsampaio created this revision. dnsampaio added reviewers: rsmith, thakis, miyuki. Herald added a project: clang. Herald added a subscriber: cfe-commits. dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:58

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

koalo added a comment. The difference is that BraceWrapping.AfterEnum also wraps before the brace. With AfterEnum we have the following true: enum X : int { B }; false: enum X : int { B }; But what I want is this: enum X : int { B }; Repository: rC Clang CHANGES

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

poelmanc marked an inline comment as done. poelmanc added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:306 + if (ApplyFix) { +// Peek ahead to see if there's a semicolon after Body->getSourceRange() +Optional Token; --

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. It feels like it should somehow be following `BreakBeforeBraces` style but understand it might not Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4095 +Builder.CreateStore(result.getScalarVal(), +CGF.GetAddrOfLocalVar(OMD->getSelfDecl())); + MadCoder wrote: > rjmccall wrote: > > We should also be changin

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

koalo added a comment. Yes it does not. Therefore, I have followed the same pattern as the the other AllowShort* options. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

jdoerfert added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:370 +: nullptr; +} return nullptr; dim wrote: > jdoerfert wrote: > > Consistent style please: > > > > ``` > > if (Value *StrLen = emitStrLen(

[clang] 4e2ce22 - [BPF] Add preserve_access_index attribute for record definition

Author: Yonghong Song Date: 2019-11-13T08:23:44-08:00 New Revision: 4e2ce228ae7954a6499fbb8e4995c13ac8b60f9a URL: https://github.com/llvm/llvm-project/commit/4e2ce228ae7954a6499fbb8e4995c13ac8b60f9a DIFF: https://github.com/llvm/llvm-project/commit/4e2ce228ae7954a6499fbb8e4995c13ac8b60f9a.diff

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } dnsampaio wrote: > For debug builds, I could not find any other way to not reach an assert > failure oth

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:288 + " Clang to process. This may by a result from multiple" + " inclusions of unguarded header files.">; def err_unsupported_bom : Error<"%0 byte order mark detected in '%1', but " -

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:306 + if (ApplyFix) { +// Peek ahead to see if there's a semicolon after Body->getSourceRange() +Optional Token; poelmanc wrote: > JonasToth wro

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e2ce228ae79: [BPF] Add preserve_access_index attribute for record definition (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6975

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

aprantl added a comment. > In the affected test D68108 causes stubs of > getter and setter methods for property 'x' appear in both ObjCInterfaceDecl > and ObjCImplementationDecl for our toy ClassWithProperties. Previously they > were only present in ObjCInterfa

[PATCH] D70133: [ARM, MVE] Add intrinsics for 'administrative' vector operations.

simon_tatham updated this revision to Diff 229111. simon_tatham added a comment. Moved the get/set lane functions out into a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70133/new/ https://reviews.llvm.org/D70133 Files: clang/in

[PATCH] D70188: [ARM,MVE] Add intrinsics for vector get/set lane.

simon_tatham created this revision. simon_tatham added reviewers: ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. simon_tatham added a parent revision: D70133: [ARM,MVE] Add intrinsics for 'administrative' vector operations..

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:642 + } + bool mustBeFirstprivateBase(OpenMPDefaultmapClauseModifier M, + OpenMPDefaultmapClauseKind Kind) const { Static function Comment a

[PATCH] D70183: Detect source location overflow due includes

dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } miyuki wrote: > dnsampaio wrote: > > For debug builds, I could not find any other way to not reach an

[PATCH] D70183: Detect source location overflow due includes

dnsampaio updated this revision to Diff 229113. dnsampaio marked 2 inline comments as done. dnsampaio added a comment. - Add ", DefaultFatal"; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://reviews.llvm.org/D70183 Files: clang/

[clang] f582479 - [BPF] add missing attribute in pragma-attribute-supported-attributes-list.test

Author: Yonghong Song Date: 2019-11-13T08:50:42-08:00 New Revision: f5824799f612d9d3f19470a60533c2872bcc096b URL: https://github.com/llvm/llvm-project/commit/f5824799f612d9d3f19470a60533c2872bcc096b DIFF: https://github.com/llvm/llvm-project/commit/f5824799f612d9d3f19470a60533c2872bcc096b.diff

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } dnsampaio wrote: > miyuki wrote: > > dnsampaio wrote: > > > For debug builds, I could not find any other

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306 +// Imply vectorize.enable when it is not already disabled/enabled. +Args.push_back( +MDNode::get(Ctx, {MDString::get(Ctx, "llvm

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked an inline comment as done. sthibaul added a comment. Not sure what NFCI means, but for Linux the behavior should just not change at all, and the testsuite indeed behaved exactly the same on Linux indeed. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + i

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a reviewer: chandlerc. chandlerc added a comment. Thanks for sending this out! I've made a minor comment on the flag structure, but my bigger question would be: can you summarize the performance hit and code size hit you've seen across some benchmarks? SPEC and the LLVM test sui

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added a comment. Also, one common comment. It would be good to reduce copy-paste in tests and just add some new lines of codes, not to repeat existing one. Comment at: clang/test/OpenMP/target_defaultmap_messages.cpp:1 -// RUN: %clang_cc1 -verify -fopenmp %s -Wuninitia

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. In D54628#1744108 , @koalo wrote: > Yes it does not. Therefore, I have followed the same pattern as the the other > AllowShort* options. I'm not completely sure, but I don't think its quite the same, the AllowShort* opti

[clang] 3289352 - [RISCV] Use compiler-rt if no GCC installation detected

Author: Edward Jones Date: 2019-11-13T17:18:33Z New Revision: 3289352e6bb9d2949c678c625478024bf2a5fbfb URL: https://github.com/llvm/llvm-project/commit/3289352e6bb9d2949c678c625478024bf2a5fbfb DIFF: https://github.com/llvm/llvm-project/commit/3289352e6bb9d2949c678c625478024bf2a5fbfb.diff LOG:

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

This revision was automatically updated to reflect the committed changes. Closed by commit rG3289352e6bb9: [RISCV] Use compiler-rt if no GCC installation detected (authored by edward-jones). Changed prior to commit: https://reviews.llvm.org/D68407?vs=228268&id=229121#toc Repository: rG LLVM

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1583158 - [BPF] fix clang test failure for bpf-attr-preserve-access-index-4.c

Author: Yonghong Song Date: 2019-11-13T09:40:57-08:00 New Revision: 1583158042a7e1f8b4f5194b1db362328e6902f3 URL: https://github.com/llvm/llvm-project/commit/1583158042a7e1f8b4f5194b1db362328e6902f3 DIFF: https://github.com/llvm/llvm-project/commit/1583158042a7e1f8b4f5194b1db362328e6902f3.diff

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker created this revision. Tyker added a reviewer: rsmith. Tyker added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a parent revision: D69360: [NFC] Refactor representation of materialized temporaries. Add support for merging lifetime-extended temporaries Repository:

[PATCH] D70191: [AMDGPU][HIP] Change default DWARF version to 4

scott.linder created this revision. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, aprantl, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: clang. Tooling around DWARF 5 is still not mature enough for this to be a sane default, and the AMDGPU and HIP toolchains s

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added a comment. > 2. Change the constant expression representation for a pointer or reference > for a materialized temporary to refer to the temporary declaration instead. I analyzed change 2 in this list and this require changing a very significant number of users many of them being imp

[PATCH] D70191: [AMDGPU][HIP] Change default DWARF version to 4

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70191/new/ https://reviews.llvm.org/D70191 __

[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

kmclaughlin updated this revision to Diff 229129. kmclaughlin added a comment. - Rebased & removed unused //llvm.aarch64.sve.fcmla.lane.nxv2f64// from sve-intrinsics-fp-arith.ll CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69707/new/ https://reviews.llvm.org/D69707 Files: llvm/incl

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

tra added a subscriber: rnk. tra added a comment. Calling @rnk for Windows know-how. Comment at: clang/test/SemaCUDA/deleting-dtor.cu:45-46 + +// Only MS has diagnostic since MS requires deleting dtor is emitted when +// vtable is emitted, even though dtor is not defined. +name

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 229127. serge-sans-paille added a comment. First rework pass, sevral comments have been taken into account but not all of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://review

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang-tools-extra/clang-move/tool/ClangMove.cpp:113 move::MoveDefinitionSpec Spec; - Spec.Names = {Names.begin(), Names.end()}; + Spec.Names = (std::vector &)Names; Spec.OldHeader = OldHead

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea updated this revision to Diff 229136. aganea added a comment. Revert everything, but the change to `FrontendOptions::Inputs`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69959/new/ https://reviews.llvm.org/D69959 Files: clang/include/clang/Frontend/FrontendOptions.h Index:

[PATCH] D70123: [Analyzer][NFC] Separate white-box tests for iterator modelling from iterator checker tests

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, i love it! I wouldn't delete the old tests though, as long as they're correct and different from the new ones, as we could always use more test coverage. CHANGES SINCE LAST ACTION https:

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

rsmith added a comment. Functionally, this looks good, thanks. Comment at: clang/include/clang/Serialization/ASTReader.h:555 + /// Key used to identify LifetimeExtendedTemporaryDecl for merging. + /// containg the lifetime-extending declaration and the mangling number. + usi

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:905 + + const SmallVector &operator=(const std::vector &Vec) { +this->assign(Vec.begin(), Vec.end()); aganea wrote: > rnk wrote: > > +@dblaikie, who knows more about STL containe

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rjmccall added a reviewer: rsmith. rjmccall added a subscriber: rsmith. rjmccall added a comment. This seems like the wrong approach; @rsmith should take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 _

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent &Call, const CallContext &CallC, + CheckerContext &C) const { + unsigned DestPos = *CallC.DestinationP

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea marked an inline comment as done. aganea added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:905 + + const SmallVector &operator=(const std::vector &Vec) { +this->assign(Vec.begin(), Vec.end()); dblaikie wrote: > aganea wrote: > > r

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

sammccall created this revision. sammccall added reviewers: kadircet, lh123. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The DeclRefExpr for the callee of overloaded `operator()` and `operator[]` are assigned the rang

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks good subject to some comment fixes + a tiny change to `RecursiveASTVisitor`. Comment at: clang/include/clang/AST/DeclCXX.h:3055 +/// Implicit declartion of a

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim added a comment. I submitted D70193 for adding a `-disable-builtin` option to `opt`. Once that is committed, this review can continue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/ https://reviews

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 229137. yaxunl added a comment. Attempt to prefix the kernel stub name on the fly. If we do not want to create two Decl's during parsing, and do not want to change the mangler, it seems the least invasive way to get the prefixed kernel name is to change it o

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth marked 3 inline comments as done. amccarth added a comment. Friendly ping for any VFS experts to comment. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:657 + // slashes to match backslashes (and vice versa). + bool pathComponentMatches(llvm::StringRef lhs

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent &Call, const CallContext &CallC, + CheckerContext &C) const { + unsigned DestPos = *CallC.DestinationP

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth updated this revision to Diff 229144. amccarth marked an inline comment as done. amccarth added a comment. Modified comment per feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69958/new/ https://reviews.llvm.org/D69958 Files: clang/test/Index/index-module-with-vfs.m

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

rnk created this revision. rnk added reviewers: sammccall, bkramer. Herald added a project: clang. For some reason CMake includes entries for .rc files, but find-all-symbols handles them improperly. See PR43993 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70196 Files: cl

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

NoQ added a comment. In D69662#1736601 , @balazske wrote: > Anyway the checks that do not use BindExpr (all except the open functions) > could be moved into a PreCall or PostCall callback? Moving from evalCall to PreCall/PostCall has the additional effe

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent &Call, const CallContext &CallC, + CheckerContext &C) const { + unsigned DestPos = *CallC.Destina

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

leonardchan added a comment. Hi. I think this patch is causing some test failures for us: FAIL: Clang :: Driver/riscv64-toolchain.c (5479 of 16161) TEST 'Clang :: Driver/riscv64-toolchain.c' FAILED Script: -- : 'RUN: at line 3'; /b/s/w/ir/k/

[PATCH] D68578: [HIP] Fix device stub name

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1099-1108 +auto *FD = const_cast((ND)); +if (auto *TD = cast(FD)->getPrimaryTemplate()) + FD = TD->getTemplatedDecl(); +auto OldDeclName = FD->getDeclName(); +auto NewNameStr = std::st

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + int MaxVersion = 0; + std::string MaxVersionString = ""; + for (llvm::vfs::directory_iterator LI = vfs.dir_begin(base, EC), LE; sthibaul wrote: > kristina wrote: > > No need

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent &Call, const CallContext &CallC, + CheckerContext &C) const { + unsigned DestPos = *CallC.Destina

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 229156. Tyker marked 6 inline comments as done. Tyker added a comment. fixed most comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

sammccall created this revision. sammccall added reviewers: kadircet, lh123. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Semantically they're the same thing, and it's important when the underlying struct is anonymous. There d

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:1349-1350 + } + OS << " subexpr"; + dumpPointer(D); +} rsmith wrote: > We shouldn't need this: the address of the declaration is dumped anyway by > the infrastructure. (If you meant to

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems fine as a workaround, but will obviously only affect include-fixer. I'm wary of embedding it deeper without understanding the problem though. Can you paste the *.rc entry from

  1   2   >