[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

2019-11-07 Thread Eric Christopher via Phabricator via cfe-commits
echristo updated this revision to Diff 228338. echristo marked an inline comment as done. echristo added a comment. Herald added subscribers: aheejin, sbc100, nhaehnle, jvesely. I've gone ahead and enabled SROA here. In the testing I've done so far it's helped execute time quite a bit and compile

RE: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

2019-11-07 Thread Voss, Matthew via cfe-commits
Hi Jan, It looks like this commit is causing DFSAN failures on the sanitizer bots and our internal CI. Could you take a look? http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24312/steps/64-bit%20check-dfsan/logs/stdio Thanks, Matthew > -Original Message- > From: cfe-com

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-11-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. @NoQ: "Why not simply remove taint?" @boga95: //*removes taint*// @NoQ: "Hmm, now that i think about it, adding a 'no taint' marker might actually work correctly more often." Like, if you have taint on `$x` and try to remove taint from `derived<$x

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

2019-11-07 Thread Eric Christopher via Phabricator via cfe-commits
echristo updated this revision to Diff 228339. echristo added a comment. Update to remove comments around SROA addition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65410/new/ https://reviews.llvm.org/D65410 Files: clang/test/CodeGen/2008-07-30-implicit-initialization.c clang/tes

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

2019-11-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think my `strdup` comments weren't addressed >.< Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:378-379 + + using CheckFn = void (MallocChecker::*)(CheckerContext &C, const CallExpr *CE, + Progra

[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters

2019-11-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks again!~ In D68162#1705928 , @Szelethus wrote: > I guess you two are right. Maybe the best solution would be collapse `const > CallExpr *` and `Alloca

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

2019-11-07 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. Thanks for patiently working through this with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D69978: Separately track input and output denormal mode

2019-11-07 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: scanon, cameron.mcinally, spatel, andrew.w.kaylor, mibintc, SjoerdMeijer. Herald added subscribers: dexonsmith, hiraditya, tpr, nhaehnle, wdng, jvesely, jholewinski. Herald added a project: LLVM. arsenm added parent revisions: D69878: Consoldi

[clang] 7215b7e - [creduce] Fixed a typo in the error message we're looking for.

2019-11-07 Thread Artem Belevich via cfe-commits
Author: Artem Belevich Date: 2019-11-07T17:16:51-08:00 New Revision: 7215b7ef530bff896a1da70c6b062e9259f5fde7 URL: https://github.com/llvm/llvm-project/commit/7215b7ef530bff896a1da70c6b062e9259f5fde7 DIFF: https://github.com/llvm/llvm-project/commit/7215b7ef530bff896a1da70c6b062e9259f5fde7.diff

[clang] acac540 - [analyzer] PR41729: CStringChecker: Improve strlcat and strlcpy modeling.

2019-11-07 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2019-11-07T17:15:53-08:00 New Revision: acac540422e8cee4a77d10f087b2a2b67504b27b URL: https://github.com/llvm/llvm-project/commit/acac540422e8cee4a77d10f087b2a2b67504b27b DIFF: https://github.com/llvm/llvm-project/commit/acac540422e8cee4a77d10f087b2a2b67504b27b.dif

[clang] 5e0fb64 - [analyzer] Add test cases for the unsupported C++ constructor modeling.

2019-11-07 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2019-11-07T17:15:53-08:00 New Revision: 5e0fb648420702e47c94de53757928360a106e8c URL: https://github.com/llvm/llvm-project/commit/5e0fb648420702e47c94de53757928360a106e8c DIFF: https://github.com/llvm/llvm-project/commit/5e0fb648420702e47c94de53757928360a106e8c.dif

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

2019-11-07 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGacac540422e8: [analyzer] PR41729: CStringChecker: Improve strlcat and strlcpy modeling. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

2019-11-07 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5e0fb6484207: [analyzer] Add test cases for the unsupported C++ constructor modeling. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D69308?vs=227714&id=228344#toc Reposit

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

2019-11-07 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: spatel, craig.topper, RKSimon, hfinkel, probinson. Herald added a subscriber: wdng. arsenm added a parent revision: D69978: Separately track input and output denormal mode. This is to avoid performance regressions when the default attribute be

[PATCH] D69878: Consoldiate internal denormal flushing controls

2019-11-07 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 228348. arsenm added a comment. Fix name in documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h c

[PATCH] D69981: [www] More HTTPS and outdated link fixes.

2019-11-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: ldionne, zoecarver. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, arphaman, dexonsmith. Herald added projects: clang, LLVM. [www] More HTTPS and outdated link fixes. Repository: rG LLVM Github Monorepo https:/

[PATCH] D64024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

2019-11-07 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. Herald added subscribers: shchenz, wuzish. In D64024#1565190 , @jsji wrote: > LGTM. > BTW, looks like we are missing test cases all `vector float` `vec_all*` and > `vec_any*` and also non-vsx path? The non-VSX path is tested

[PATCH] D69981: [www] More HTTPS and outdated link fixes.

2019-11-07 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver added a comment. This LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69981/new/ https://reviews.llvm.org/D69981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

2019-11-07 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. I checked Redhat 7.4 that's on the server I'm using for work. And I had a coworker check his Ubuntu 18.04 system with this program. And both systems printed 1f80 as the value of MXCSR which shows FTZ and DAZ are both 0. Are you seeing something different? #inclu

[clang] 070e402 - [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

2019-11-07 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2019-11-07T20:40:32-06:00 New Revision: 070e4027b02453f0962e5b61335a517581c5528f URL: https://github.com/llvm/llvm-project/commit/070e4027b02453f0962e5b61335a517581c5528f DIFF: https://github.com/llvm/llvm-project/commit/070e4027b02453f0962e5b61335a517581c5528f.di

[PATCH] D64024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

2019-11-07 Thread Nemanja Ivanovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG070e4027b024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D64024?vs=207374&id=228354#toc Repository

[clang] e0407f5 - [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

2019-11-07 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2019-11-07T20:58:11-06:00 New Revision: e0407f54965318247c8fece2dfa5c9023acf0973 URL: https://github.com/llvm/llvm-project/commit/e0407f54965318247c8fece2dfa5c9023acf0973 DIFF: https://github.com/llvm/llvm-project/commit/e0407f54965318247c8fece2dfa5c9023acf0973.di

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

2019-11-07 Thread Nemanja Ivanovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe0407f549653: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst (authored by nemanjai). Herald added subscribers: shchenz, wuzish. Changed prior to commit: https://reviews.llvm.org/D63636?vs=206123&

[PATCH] D69984: [OpenMP][Opt] Annotate known runtime functions and deduplicate more

2019-11-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added a project: LLVM. jdoerfert removed a subscriber: cfe-commits. jdoerfert added a parent revision: D69930: [OpenMP]

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

2019-11-07 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu updated this revision to Diff 228361. rtrieu added a comment. Add -Wall tests to check that certain warning groups are active with it and a test to check all warning groups that are turned on by -Wall. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

2019-11-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 228364. jdoerfert added a comment. Do not eagerly create function declarations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/include/llvm/IR/OpenMPCon

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

2019-11-07 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Thanks. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

2019-11-07 Thread Ehud Katz via Phabricator via cfe-commits
ekatz added a comment. Yes, these changes regard to the same thing - the removal of the "Linkage-Spec LanguageIDs". As you described it nicely, it is for linkage only, meaning C vs C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ htt

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-07 Thread Gleb Popov via Phabricator via cfe-commits
6yearold created this revision. Herald added subscribers: cfe-commits, emaste. Herald added a project: clang. This allows `clang` to be used to compile CUDA programs. Compiled simple helloworld.cu with this. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69990 Files: clang/l

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

2019-11-07 Thread Pierre Habouzit via Phabricator via cfe-commits
MadCoder created this revision. MadCoder added reviewers: rjmccall, jfb, doug.gregor, dexonsmith. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. __attribute__((objc_direct)) is an attribute on methods declaration and implementation, categories, or extensions (

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

2019-11-07 Thread Pierre Habouzit via Phabricator via cfe-commits
MadCoder marked 2 inline comments as done. MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:1588 // interface, we cannot perform this check. + // + // Note that for direct methods, because objc_msgSend is skipped, doh I

[clang] 0f88cae - [Analyzer] Checker for Debugging Iterator Checkers

2019-11-07 Thread Adam Balogh via cfe-commits
Author: Adam Balogh Date: 2019-11-08T08:59:50+01:00 New Revision: 0f88caeef8f2d4708f442d03db7723396712a143 URL: https://github.com/llvm/llvm-project/commit/0f88caeef8f2d4708f442d03db7723396712a143 DIFF: https://github.com/llvm/llvm-project/commit/0f88caeef8f2d4708f442d03db7723396712a143.diff L

<    1   2   3