[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

xbolva00 added a comment. It was said Clang does not have to match gcc 1:1. Just because someone uses weird patterns and instead of using pragma push/pop diagnostic in his/her code, should we really change it in Clang? You should provide extra flag which controls this specific behaviour (and on

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 228275. jdoerfert marked an inline comment as done. jdoerfert added a comment. Use an llvm::IndexedMap instead of std::map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:6721 + if (getLangOpts().OpenCL) { + Anastasia wrote: > rjmccall wrote: > > Anastasia wrote: > > > rjmccal

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3310 +VariadicUnsignedArgument<"CtxSelectorSets">, +VariadicUnsignedArgument<"CtxSelectors">, VariadicStringArgument<"ImplVendors"> Is it possible to have a `VariadicObjec

[PATCH] D68578: [HIP] Fix device stub name

rjmccall added a comment. Distinguishing between multiple symbols associated with the same source-level declaration is the purpose of the GlobalDecl abstraction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68578/new/ https://reviews.llvm.org/D68578

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

arphaman added a comment. +1, Apple's clang has an `#ifdef 0` around this code. Comment at: clang/lib/Basic/Version.cpp:143 llvm::raw_string_ostream OS(buf); #ifdef CLANG_VENDOR OS << CLANG_VENDOR; This use of `CLANG_VENDOR` should be removed as well pre

[clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

Author: Reid Kleckner Date: 2019-11-07T10:39:29-08:00 New Revision: dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571 URL: https://github.com/llvm/llvm-project/commit/dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571 DIFF: https://github.com/llvm/llvm-project/commit/dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571.diff

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

arphaman added inline comments. Comment at: clang/lib/Basic/Version.cpp:143 llvm::raw_string_ostream OS(buf); #ifdef CLANG_VENDOR OS << CLANG_VENDOR; arphaman wrote: > This use of `CLANG_VENDOR` should be removed as well presumably. Please ignore my commen

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 6 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3310 +VariadicUnsignedArgument<"CtxSelectorSets">, +VariadicUnsignedArgument<"CtxSelectors">, VariadicStringArgument<"ImplVendors">

[clang] 90ecfa2 - Revert "[Sema] Suppress -Wchar-subscripts if the index is a literal char"

Author: Edward Jones Date: 2019-11-07T18:45:40Z New Revision: 90ecfa2f5f7feea6e3676d59fe6126e08c52d00e URL: https://github.com/llvm/llvm-project/commit/90ecfa2f5f7feea6e3676d59fe6126e08c52d00e DIFF: https://github.com/llvm/llvm-project/commit/90ecfa2f5f7feea6e3676d59fe6126e08c52d00e.diff LOG:

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. "The change introduced new external linkage languages ("C++11" and "C++14") which not supported in C++." Could you describe more what you mean by "not supported in C++"? These identifiers aren't part of the C++ standard/they're an implementation detail of the compiler

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

edward-jones added a comment. Okay I've reverted this in rG90ecfa2f5f7f . I'll make improvements and resubmit this for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5889

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

xbolva00 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58896/new/ https://reviews.llvm.org/D58896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D68578: [HIP] Fix device stub name

yaxunl added a comment. In D68578#1737351 , @rjmccall wrote: > Distinguishing between multiple symbols associated with the same source-level > declaration is the purpose of the GlobalDecl abstraction. It seems GlobalDecl is just a wrapper for concrete D

[PATCH] D68953: Enable most VFS tests on Windows

amccarth abandoned this revision. amccarth added a comment. I create a new review thread for my improved patch shortly. These changes were too wide-ranging. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68953/new/ https://reviews.llvm.org/D68953

[PATCH] D68578: [HIP] Fix device stub name

rjmccall added a comment. In D68578#1737415 , @yaxunl wrote: > In D68578#1737351 , @rjmccall wrote: > > > Distinguishing between multiple symbols associated with the same > > source-level declaration is the purpose

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. Re-ping @rtrieu CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. In D69853#1737319 , @jdoerfert wrote: > In D69853#1737264 , @ABataev wrote: > > > In D69853#1737218 , @jdoerfert > > wrote: > > > > > Are there blo

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228281. jdoerfert added a comment. Add driver test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files: clang/include/clang/Basic/LangOptions.def clang

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3310 +VariadicUnsignedArgument<"CtxSelectorSets">, +VariadicUnsignedArgument<"CtxSelectors">, VariadicStringArgument<"ImplVendors"> ABataev wrote: > jdoerfert wrote: > > I

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/test/Driver/fopenmp.c:130-131 +// CHECK-CC1-OPENMPIRBUILDER: "-cc1" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp-enable-irbuilder" +// `CHECK...-SAME`? Comme

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth created this revision. amccarth added reviewers: rnk, vsapsai, arphaman, Bigcheese. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: LLVM. Keys in a virtual file system can be in Posix or Windows form or even a combination of the two. Many VFS tests (and a few Cl

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. Comment at: clang/lib/Sema/SemaExpr.cpp:486 if (UO->getOpcode() == UO_Deref && -UO->getSubExpr()->IgnoreParenCasts()->

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

efriedma added inline comments. Herald added a subscriber: sameer.abuasal. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:498 +CmdArgs.push_back( +Args.MakeArgString(Twine("-plugin-opt=-target-abi=") + ABIName)); } I don't think this change i

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { jdoerfert wrote: > ABataev wrote: > > jdoe

[PATCH] D68578: [HIP] Fix device stub name

yaxunl added a comment. In D68578#1737419 , @rjmccall wrote: > In D68578#1737415 , @yaxunl wrote: > > > In D68578#1737351 , @rjmccall > > wrote: > > > > > Distinguishing bet

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

troyj added a comment. Wound up here while trying to use compiler-rt for static linking with our downstream compiler. It seems that compiler-rt's current approach of only providing these routines on certain platforms is problematic because libgcc always provides them, and thus compiler-rt is n

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

aaron.ballman added a comment. I think the new text is more clear than the old text, so I'm fine with the current direction you're going. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:584-587 def err_maybe_falloff_nonvoid_block : Error< "control may reach en

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

efriedma added a comment. Yes, it makes sense to provide these routines, but someone has to write the code to make it work. This patch is currently incomplete: > Took another look and seems like long double is hardcoded in many of the > builtins. So I think the current patch needs to rename a

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D69853#1737426 , @ABataev wrote: > In D69853#1737319 , @jdoerfert wrote: > > > In D69853#1737264 , @

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea created this revision. aganea added reviewers: STL_MSFT, rnk, dexonsmith. aganea added a project: clang. Herald added subscribers: cfe-commits, arphaman. This is an attempt to fix `clang/test/Index/crash-recovery-modules.m` when compiling a build with the MSVC STL & _ITERATOR_DEBUG_LEVEL =

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader updated this revision to Diff 228286. bader added a comment. Applied comments from Aaron. Two comments left unresolved: - Split diagnostic message for sycl_kernel attribute into multiple messages. Will do tomorrow. - Change attribute "subject" in TableGen file from "Function" to "Functio

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1034 + let Spellings = [Clang<"sycl_kernel">]; + let Subjects = SubjectList<[Function]>; + let LangOpts = [SYCL]; aaron.ballman wrote: > Shouldn't this be `FunctionTemplate` instead? @a

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:584-587 def err_maybe_falloff_nonvoid_block : Error< "control may reach end of non-void block">; def err_falloff_nonvoid_block : Error<

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

aaron.ballman added a comment. There's a design question about why it should accept the expanded macro name instead of requiring the user to write the macro. I am worried about allowing the expanded form because the presumable use of a macro is to control the name, so this invites name mismatch

[clang] 8d8f9c2 - [clang] Add -fdebug-default-version for specifying the default DWARF version

Author: David Blaikie Date: 2019-11-07T12:05:58-08:00 New Revision: 8d8f9c24407461fadf1730e80ebcf7c767254715 URL: https://github.com/llvm/llvm-project/commit/8d8f9c24407461fadf1730e80ebcf7c767254715 DIFF: https://github.com/llvm/llvm-project/commit/8d8f9c24407461fadf1730e80ebcf7c767254715.diff

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: llvm/include/llvm/IR/OpenMPConstants.h:1 +//===- IR/OpenMPConstants.h - OpenMP related constants & helper - C++ -*-===// +// Just

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:56 + OpenMPContextSelectorKind Ctx, const U &Names) + : CtxSet(CtxSet), Ctx(Ctx), Names(Names.begin(), Names.end()) {}

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8f9c244074: [clang] Add -fdebug-default-version for specifying the default DWARF version (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D69822?vs=228250&id=228287#toc Repos

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm a bit worried that this manual parsing technique will need fixing again in the future, but I think this is at least a reasonable incremental improvement. LGTM with a minor ni

[PATCH] D68578: [HIP] Fix device stub name

rjmccall added a comment. There are a number of places in IRGen that pass around `GlobalDecl`s with the expectation that that's sufficient to uniquely identify a symbol. The fact that IRGen breaks down the GD at the last second before passing it to the mangler, rather than passing it to the ma

[clang] 2b943c4 - [Sema] Fixes a crash with a templated destructor

Author: Mark de Wever Date: 2019-11-07T21:22:27+01:00 New Revision: 2b943c46873a6411c5a79dcd708d8c72ce5b3675 URL: https://github.com/llvm/llvm-project/commit/2b943c46873a6411c5a79dcd708d8c72ce5b3675 DIFF: https://github.com/llvm/llvm-project/commit/2b943c46873a6411c5a79dcd708d8c72ce5b3675.diff

[PATCH] D69225: Sema: Fixes a crash with a templated destructor

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b943c46873a: [Sema] Fixes a crash with a templated destructor (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69225/new/ https://revi

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. Thanks for the review. I also looked at some of the new warnings and I'm preparing patches to fix them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mai

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. There is a regression from https://reviews.llvm.org/D68467. Unlike class forward declarations, function ducomentation is w

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev updated this revision to Diff 228290. ABataev added a comment. Rebase + address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:584-587 def err_maybe_falloff_nonvoid_block : Error< "control may reach end of non-void block">; def err_falloff_nonvoid_block : Error< "control reaches end of non-void block

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers added a comment. In D69925#1737361 , @arphaman wrote: > +1, Apple's clang has an `#ifdef 0` around this code. Is that +1 in favor of the patch as is, or +1 to @eli.friedman 's comment? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

Quuxplusone added a comment. In D58896#1737242 , @edward-jones wrote: > In D58896#1737200 , @xbolva00 wrote: > > > Well, i am not sure if one twitter report is good motivation to criple > > warning. > > > The moti

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:579 def warn_maybe_falloff_nonvoid_function : Warning< - "control may reach end of non-void function">, + "not all control paths in this function return a value; non-void function

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked 4 inline comments as done. jdoerfert added inline comments. Comment at: clang/test/Driver/fopenmp.c:130-131 +// CHECK-CC1-OPENMPIRBUILDER: "-cc1" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp-enable-irbuilder" +//

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Formally unblocking this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits ma

[clang] b95bb08 - [CodeGenModule] Group blocks runtime globals together, NFC

Author: Vedant Kumar Date: 2019-11-07T12:46:26-08:00 New Revision: b95bb0847a1ea366dda69901c24415e0d00a9527 URL: https://github.com/llvm/llvm-project/commit/b95bb0847a1ea366dda69901c24415e0d00a9527 DIFF: https://github.com/llvm/llvm-project/commit/b95bb0847a1ea366dda69901c24415e0d00a9527.diff

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers added a comment. Just grabbed a version string off a MBP: $ clang --version Apple LLVM version 10.0.1 (clang-1001.0.46.4) Target: x86_64-apple-darwin18.7.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin So it looks like the Apple distribut

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

xbolva00 added a comment. int('i') is nice fixit we could emit in this case! Thanks for this idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58896/new/ https://reviews.llvm.org/D58896 ___ cfe-commi

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using an end iterator of an empty CFG block boiled down to dereferencing a garbage pointer.

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

lebedev.ri added a comment. As far as i can tell the builder does not add any debug info. Should it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 ___ cfe-com

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:579 def warn_maybe_falloff_nonvoid_function : Warning< - "control may reach end of non-void function">, + "not all control paths in this func

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/Analysis/a_flaky_crash.cpp:19 + +// 256 copies of the same run-line to make it crash more often when it breaks. + This is a trade-off between reliability and not increasing te

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added a comment. In D69878#1736865 , @Anastasia wrote: > > Stop emitting the denorms-are-zero attribute for the OpenCL flag. It > > has no in-tree users. The meaning would also be target dependent, such > >

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

easyaspi314 added a comment. How about "this non-void {function|block} {may|does} not return a value" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 ___ cfe-co

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. With this change (current trunk) you can write code as follows: extern "C++11" int x; And it will pass compilation. No other compiler support it, nor it should, as there is no such thing as `extern "C++11"` nor `extern "C++14"`. Repository: rG LLVM Github Monorepo

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + SourceLocation SourceLocationBeg = + SM.getMacroArgExpandedLocation(getBeginningOfIdentifier( + RInputs.Pos, SM, AST.getASTContext().getLangOpts())); ilya-

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

Quuxplusone added a comment. In D69762#1737612 , @easyaspi314 wrote: > How about "this non-void {function|block} {may|does} not return a value" FWIW, I am happy with this clear and concise suggestion. :) Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 228294. hokein marked 13 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files: clang-tools-extra/cl

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur updated this revision to Diff 228297. Meinersbur added a comment. - Switch to monorepo - Move Transform.h/cpp to clangBasic - Separate Transform and TransformClause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69089/new/ https://reviews

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228298. xbolva00 added a comment. More tests. Handle __attribute__((address_space(0))). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExp

[PATCH] D69958: Improve VFS compatibility on Windows

rnk added a comment. This looks good to me. I had one suggestion, and I would also like to hear from another reviewer who has more ownership over VFS. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:657 + // slashes to match backslashes (and vice versa). + bool pat

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228303. xbolva00 added a comment. Fixed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs.c Inde

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 added a comment. I am not sure if "may" is ideal, it could suggest that compiler is not very sure and emits just some conservative message. "not all paths in this non-void {function,block} return a value" gives some extra confidence that compiler knows there is a buggy control path.

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228301. xbolva00 added a comment. Removed unused variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG01b10bc7b149: [Diagnostics] Teach -Wnull-dereference about address_space attribute (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6966

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > jdoerfert wrote: > > >

[clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Author: Jan Korous Date: 2019-11-07T14:06:43-08:00 New Revision: 03b84e4f6d0e1c04f22d69cc445f36e1f713beb4 URL: https://github.com/llvm/llvm-project/commit/03b84e4f6d0e1c04f22d69cc445f36e1f713beb4 DIFF: https://github.com/llvm/llvm-project/commit/03b84e4f6d0e1c04f22d69cc445f36e1f713beb4.diff LO

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I don't have experience with clang-tidy tests, but I think these two small, test-only changes are small enough that you can go ahead and commit them without review from a clang-tidy owner. lgtm CH

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. In D68720#1733839 , @serge-sans-paille wrote: > @sylvestre.ledru did the testing and benchmarking on firefox (see > https://bugzilla.mozilla.org/show_bug.cgi?id=1588710#c12), everything seems > ok, let's move forward?

[PATCH] D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG03b84e4f6d0e: [clang] Report sanitizer blacklist as a dependency in cc1 (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { jdoerfert wrote: > ABataev wrote: > > jdoe

[PATCH] D69969: [SEH] Defer checking filter expression types until instantiaton

rnk created this revision. rnk added a reviewer: amccarth. Herald added a project: clang. While here, wordsmith the error a bit. Now clang says: error: filter expression has non-integral type 'Foo' Fixes PR43779 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69969 Files:

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk created this revision. vsk added reviewers: aprantl, djtodoro, dblaikie. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Currently, clang emits subprograms for declared functions when the target debugger or DWARF standard is known to support entry values (DW_OP_entry_val

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. In D69935#1737615 , @ekatz wrote: > With this change (current trunk) you can write code as follows: > > extern "C++11" int x; > > > And it will pass compilation. No other compiler support it, nor it should, as > there is no suc

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. If we expect that CLANG_VERSION_STRING and BACKEND_PACKAGE_STRING are going to be the same, then the extra note isn't really buying us anything. LGTM Repository: rG LLVM Github Monorep

[PATCH] D69969: [SEH] Defer checking filter expression types until instantiaton

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69969/new/ https://reviews.llvm.org/D69969 __

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers added a comment. Thanks for the review, leaving open for final comments, will merge tomorrow. FWIW, I think we can now purge "svn" from `BACKEND_PACKAGE_STRING` and other places in the tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[libunwind] d3c7443 - Correctly update isSignalFrame when unwinding the stack via dwarf.

Author: Sterling Augustine Date: 2019-11-07T14:48:35-08:00 New Revision: d3c744313c3cca0c076f031ec71e66ca74b12f2a URL: https://github.com/llvm/llvm-project/commit/d3c744313c3cca0c076f031ec71e66ca74b12f2a DIFF: https://github.com/llvm/llvm-project/commit/d3c744313c3cca0c076f031ec71e66ca74b12f2a.

[clang] 7177ce9 - [SEH] Defer checking filter expression types until instantiaton

Author: Reid Kleckner Date: 2019-11-07T14:52:04-08:00 New Revision: 7177ce978e8f8e5409cec90bad07df92441656e3 URL: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3 DIFF: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3.diff

[PATCH] D69971: clang-format: [JS] support null operators.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. JavaScript / TypeScript is adding two new operators: the null propagating operator `?.` and the nullish coalescing operator `??`. const x = foo ?? 'default'; const z = foo?.bar?.baz; This change

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. The failure I am investigating from the original commit of this at Google probably isn't related to the assertion failure that caused the revert of this patch/being addressed by this recommit. So if you could hold off a bit while I try to help provide a reproduction or

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert added a comment. In D69785#1737581 , @lebedev.ri wrote: > As far as i can tell the builder does not add any debug info. > Should it? It does now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk added a comment. In D69970#1737814 , @dblaikie wrote: > The failure I am investigating from the original commit of this at Google > probably isn't related to the assertion failure that caused the revert of > this patch/being addressed by this recommi

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228320. jdoerfert added a comment. Use source location information to build the ident string and debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files:

[PATCH] D69972: clang-format: [JS] test declared fields.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. TypeScript now supports declaring fields: class Foo { declare field: string; } clang-format happens to already format this fine, so this change just adds a regression test. Repository: r

[PATCH] D69969: [SEH] Defer checking filter expression types until instantiaton

This revision was automatically updated to reflect the committed changes. Closed by commit rG7177ce978e8f: [SEH] Defer checking filter expression types until instantiaton (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69969/new/ ht

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4435-4437 +if (DMIB == DMIB_alloc) Kind = OMPC_MAP_alloc; +else if (DMIB == DMIB_to) Kind = OMPC_MAP_to; +else if (DMIB == DMIB_from) Kind = OMPC

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228328. jdoerfert added a comment. Remove accidental newline change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/include/llvm/IR/OpenMPConstants.h

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228327. jdoerfert added a comment. Adjust RTL attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/include/llvm/IR/DebugInfoMetadata.h llvm/incl

[PATCH] D69972: clang-format: [JS] test declared fields.

MyDeveloperDay added a comment. Thanks for this patch, this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69972/new/ https://reviews.llvm.org/D69972 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D69971: clang-format: [JS] support null operators.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69971/new/ https://reviews.llvm.org/D69971 ___

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228331. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Herald added a project: LLVM. Adjust tests as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

gribozavr2 accepted this revision. gribozavr2 added a comment. LGTM for ClangTidy, assuming you ran `ninja check-all`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69950/new/ https://reviews.llvm.org/D69950 ___ cfe-commits mailing list cfe

<    1   2   3   >