[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked 12 inline comments as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1978 + DSAStack->getDefaultDMIBAtLevel(Level, OMPC_DEFAULTMAP_scalar) == + DMIB_firstprivate) || DSAStack->hasExplicitDSA( --

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

You could hack it to standardize the yaml output to forward slashes with sed, or clang might wish to do it internally. My current position is that we should pick the path style and slash direction closest to the point at which the path will be emitted. In the past we've tried to make arguments tha

[PATCH] D69582: Let clang driver support parallel jobs

aganea added a comment. This is somehow similar to what I was proposing in D52193 . Would you possibly provide tests and/or an example of your usage please? Comment at: clang/lib/Driver/Compilation.cpp:303 +} +std::thread Th(Work); +

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

epastor added a comment. Thanks, Reid; I'm not 100% sure I've checked all the corner cases either, but this at least seems like a step forward. As a reminder: I don't have commit access. Could someone else commit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm added a comment. In D69666#1728946 , @yaxunl wrote: > Is the description reversed? > > This attempts to preserve the source address space instead of always using > the default address space for void pointer type. I don't think so? This now preser

[PATCH] D68351: [profile] Add a mode to continuously sync counter updates to a file

This revision was automatically updated to reflect the committed changes. Closed by commit rGd889d1efefe9: [profile] Add a mode to continuously sync counter updates to a file (authored by vsk). Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Changed pr

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + auto &AddedLine = DiffedLines.back(); + for (auto Iter = AddedLine.Tokens.begin(); + Iter != AddedLine.Tokens.end();) { hokein wrote: > it took m

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 227374. nridge marked 3 inline comments as done. nridge added a comment. Addressed some nits and got existing tests to pass Will follow up with new tests in the next update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Alright then. (Although I don't know whether the redeclaration chain always models that wording in the standard, and what that wording means when we don't have a linear ordering of tex

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:82 +Stencil makeStencil(RangeSelector Selector); +inline Stencil makeStencil(Stencil S) { return S; } ymandel wrote: > gribozavr2 wrote: > > I feel like this should

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. Introduces a clang builtins and LLVM intrinsics representing integer min/max instructio

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. I fully agree about passing a Stencil to `access`. However whether to call `makeStencil` inside is an interesting question. On one hand, such implicit conversions increase the convenience. On the other, they increase the API surface (more possible argument types), an

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

jdoerfert added a comment. Communication problem: > This attempted to always use the default address space void pointer type > instead of preserving the source address space. Where "This" is the old code. Replace "This" in the commit message with some more descriptive wording and the confusion

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Ac

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. This instruction is not merged to the spec proposal, but we need it to be implemented i

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel marked 8 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:154 +/// for more details. +template MatchConsumer stencil(Ts &&... Parts) { + Stencil S = cat(std::forward(Parts)...); griboz

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel added a comment. In D69625#1729634 , @gribozavr2 wrote: > I fully agree about passing a Stencil to `access`. However whether to call > `makeStencil` inside is an interesting question. On one hand, such implicit > conversions increase the convenie

[clang] bb1616b - [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

Author: Yaxun (Sam) Liu Date: 2019-10-31T22:27:35-04:00 New Revision: bb1616ba47261a0767063e85718d546165972120 URL: https://github.com/llvm/llvm-project/commit/bb1616ba47261a0767063e85718d546165972120 DIFF: https://github.com/llvm/llvm-project/commit/bb1616ba47261a0767063e85718d546165972120.dif

[PATCH] D69678: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb1616ba4726: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Is this https://github.com/WebAssembly/simd/pull/27 ? Can you please include the spec (even if it's still an unmerged PR) in the CL description next time? LGTM. Repository: rG LLVM Githu

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

tlively added a comment. In D69696#1729676 , @aheejin wrote: > Is this https://github.com/WebAssembly/simd/pull/27 ? Can you please include > the spec (even if it's still an unmerged PR) in the CL description next time? > LGTM. Yes, that's right. Will

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively added a comment. This is https://github.com/WebAssembly/simd/pull/127 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69697/new/ https://reviews.llvm.org/D69697 ___ cfe-commits mailing list cfe-c

[clang] b9903ec - [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

Author: Heejin Ahn Date: 2019-10-31T19:52:41-07:00 New Revision: b9903ec8979fc43f1484e1ee8749c7d18ce90bf0 URL: https://github.com/llvm/llvm-project/commit/b9903ec8979fc43f1484e1ee8749c7d18ce90bf0 DIFF: https://github.com/llvm/llvm-project/commit/b9903ec8979fc43f1484e1ee8749c7d18ce90bf0.diff LO

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

aheejin created this revision. aheejin added reviewers: vsk, tlively. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! After D68351

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9903ec8979f: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69699/new/ https:

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69699/new/ https://reviews.llvm.org/D69699

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

aheejin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:135 +TARGET_BUILTIN(__builtin_wasm_dot_s_i32x4_i16x8, "V4iV8s", "nc", "simd128") + We talked offline. There should be two arguments :) Repository: rG LLVM Github Mo

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. > Which idiom do you think we should encourage, then, for text and > range-selectors -- the named combinator or the single-argument cat? That is You are making a very interesting point! It sounds very appealing to me to remove the special `text` and `selection` func

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

gribozavr2 added a comment. I see. Some decoupling is desirable, I agree. Maybe move `StencilInterface` and `Stencil` into a separate header that `RewriteRule` can depend on, and then define the library of stencils in another header? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm closed this revision. arsenm added a comment. c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] c6da9ec - clang: Fix assert on void pointer arithmetic with address_space

Author: Matt Arsenault Date: 2019-10-31T20:07:23-07:00 New Revision: c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f URL: https://github.com/llvm/llvm-project/commit/c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f DIFF: https://github.com/llvm/llvm-project/commit/c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f.diff

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively added a comment. https://github.com/WebAssembly/simd/pull/127 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69697/new/ https://reviews.llvm.org/D69697 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa07019a275cd: [WebAssembly] SIMD integer min and max instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69696/new/ https://re

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively updated this revision to Diff 227393. tlively added a comment. - Add second argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69697/new/ https://reviews.llvm.org/D69697 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clan

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song updated this revision to Diff 227400. yonghong-song edited the summary of this revision. yonghong-song added a comment. minor update to only support address_space 1 for user pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69393/n

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song added a comment. During experimenting with linux kernel codes, I found that clang does not allow address_space attribute for function pointers, specifically, in `clang/lib/Sema/SemaType.cpp`, // ISO/IEC TR 18037 S5.3 (amending C99 6.7.3): "A function type shall not be // quali

<    1   2