[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 225104. akhuang marked an inline comment as done. akhuang added a comment. Address comment about bad decrementing iterator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D677

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. Ah sorry. While preparing this for commit I realized that the CGDebugInfo change is untested. Can you add a Clang test that checks that CFE is emitting the expected LLVM IR? CHAN

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. But i was inactive for a long time, if @aaron.ballman accepts as well you can commit instantly. Otherwise please let the other people that commented some time to react. :) Reposi

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

probinson added a comment. Apologies for missing this until now. Our email system keeps dropping stuff sent by Phabricator. FTR, since @rnk has mentioned my years-ago writings, what Sony has internally nowadays is a little different than what I said back then. We have an option spelled `-gno

r374952 - Remove unnecessary and inappropriate forward-declaration of Sema from

Author: rsmith Date: Tue Oct 15 14:50:24 2019 New Revision: 374952 URL: http://llvm.org/viewvc/llvm-project?rev=374952&view=rev Log: Remove unnecessary and inappropriate forward-declaration of Sema from AST. Modified: cfe/trunk/include/clang/AST/ExprCXX.h Modified: cfe/trunk/include/clang/AS

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:4127 + + case Expr::ConceptSpecializationExprClass: { +// ::= L E # external name These mangling changes look like they could be separated out from the rest of the patch. These plus the

r374954 - PR43674: fix incorrect constant evaluation of 'switch' where no case

Author: rsmith Date: Tue Oct 15 15:23:11 2019 New Revision: 374954 URL: http://llvm.org/viewvc/llvm-project?rev=374954&view=rev Log: PR43674: fix incorrect constant evaluation of 'switch' where no case label corresponds to the condition. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/tr

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

efriedma added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68838/new/ https://reviews.llvm.org/D68838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

vsapsai added a comment. The plan is to instrument `llvm::sys::fs::status` with `ALWAYS_ENABLED_STATITSTIC` to be able to catch regressions causing lots of `stat` calls. That's why replacing current `stat` calls. And it seems to be a good change regardless of future plans. CHANGES SINCE LAST

[PATCH] D69012: [Headers] Fix compatibility between arm_acle.h and intrin.h

efriedma created this revision. efriedma added reviewers: rnk, chill. Herald added a subscriber: kristof.beyls. Herald added a project: clang. Make sure they don't both define __nop. We use a similar pattern for other functions in arm_acle.h. Repository: rC Clang https://reviews.llvm.org/D6

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

vsapsai created this revision. vsapsai added reviewers: bruno, sammccall. Herald added subscribers: ributzka, arphaman, dexonsmith, jkorous. vsapsai added a comment. The plan is to instrument `llvm::sys::fs::status` with `ALWAYS_ENABLED_STATITSTIC` to be able to catch regressions causing lots of

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

NoQ added a comment. I think it's worth it to commit the patch as-is, because the crash seems to be fairly popular. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68591/new/ https://reviews.llvm.org/D68591 ___

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

nick updated this revision to Diff 225133. nick added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69000/new/ https://reviews.llvm.org/D69000 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-to

LLVM buildmaster will be updated tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

nick marked 2 inline comments as done. nick added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedIteratorBaseCheck.cpp:218 + // Requires C++. + if (!getLangOpts().CPlusPlus) +return; Eugene.Zelenko wrote: > Should it check fo

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1709712 , @probinson wrote: > In D68117#1709557 , @SouraVX wrote: > > > Their's not much information available behind the suggestion or intention > > for adding this feature to S

r374962 - [libTooling] Put all Transformer declarations in a single namespace.

Author: ymandel Date: Tue Oct 15 18:06:46 2019 New Revision: 374962 URL: http://llvm.org/viewvc/llvm-project?rev=374962&view=rev Log: [libTooling] Put all Transformer declarations in a single namespace. Summary: This revision introduces a new namespace, `clang::transformer`, to hold the declarati

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bb47cd8c30c: [libTooling] Put all Transformer declarations in a single namespace. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne marked 2 inline comments as done. mhorne added inline comments. Comment at: libunwind/src/Registers.hpp:3756 +inline double Registers_riscv::getFloatRegister(int regNum) const { +#ifdef __riscv_float_abi_double + assert(validFloatRegister(regNum)); lenary

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert updated this revision to Diff 225147. aaronpuchert added a comment. Add tests suggested by @Quuxplusone and add fallback to call by lvalue reference. The latter turned out more complicated than I thought, because there seems to be no easy way to just try building a call expression

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert updated this revision to Diff 225149. aaronpuchert added a comment. Apply clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68845/new/ https://reviews.llvm.org/D68845 Files: clang/lib/Sema/SemaCoroutine.cpp clang/test/Se

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert marked 15 inline comments as done. aaronpuchert added a comment. Given the complexities of this implementation, I'm beginning to doubt whether implicit moves make sense for `co_return` at all. Since there can never be any kind of RVO, why not always require an explicit `std::move`?

r374967 - [Concepts] ConceptSpecializationExprs mangling

Author: saar.raz Date: Tue Oct 15 19:33:41 2019 New Revision: 374967 URL: http://llvm.org/viewvc/llvm-project?rev=374967&view=rev Log: [Concepts] ConceptSpecializationExprs mangling Implement mangling for CSEs to match regular template-ids. Reviewed as part of D41569. Added: cfe/trunk/test/C

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. I need this for the demo at the dev me

r374971 - Fix failing mangle-concept.cpp test.

Author: saar.raz Date: Tue Oct 15 19:56:40 2019 New Revision: 374971 URL: http://llvm.org/viewvc/llvm-project?rev=374971&view=rev Log: Fix failing mangle-concept.cpp test. Modified: cfe/trunk/test/CodeGenCXX/mangle-concept.cpp Modified: cfe/trunk/test/CodeGenCXX/mangle-concept.cpp URL: htt

[PATCH] D69017: Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk updated this revision to Diff 225153. kousikk added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69017/new/ https://reviews.llvm.org/D69017 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D69017: Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk created this revision. kousikk added reviewers: arphaman, dexonsmith, Bigcheese, jkorous. Herald added a project: clang. Herald added a subscriber: cfe-commits. kousikk updated this revision to Diff 225153. kousikk added a comment. Lint fixes Clang's -M mode includes these extra dependen

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I was not sure why this is not opaque in case of LLDB usage, but now it is perfect, thanks! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:3079 +

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added a comment. I did a quick search of the LLVM code base and found dozens of `const StringRef &`, including the `Twine` API . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https:

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX updated this revision to Diff 225159. SouraVX added a comment. Added test case in CFE for checking expected LLVM IR emission. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68697/new/ https://reviews.llvm.org/D68697 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

Charusso added a comment. > i'd much rather enable graph dumping in noassert builds. Totally! When I am not an advanced developer I definitely would like to print the graph with the release pre-built binaries to measure my stuff when I analyze. Like after someone watch your tutorial and starts

<    1   2