[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

2019-10-04 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

2019-10-04 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. In D68448#1694284 , @sylvestre.ledru wrote: > More dynamic, less static usage :) More dynamic, less static isn't always a good thing. It saves disk space at the expense of performance. The option that controls this is `CLANG_LIN

r373785 - [clang] [cmake] Use add_clang_tool() to install all tools

2019-10-04 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Fri Oct 4 13:28:59 2019 New Revision: 373785 URL: http://llvm.org/viewvc/llvm-project?rev=373785&view=rev Log: [clang] [cmake] Use add_clang_tool() to install all tools Switch clang-check, clang-extdef-mapping and clang-offload-bundler to use add_clang_tool() rather than add

[clang-tools-extra] r373786 - [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

2019-10-04 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Fri Oct 4 13:30:02 2019 New Revision: 373786 URL: http://llvm.org/viewvc/llvm-project?rev=373786&view=rev Log: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible Use clang_target_link_libraries() in order to support linking against libclang-cpp instead o

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

2019-10-04 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373785: [clang] [cmake] Use add_clang_tool() to install all tools (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

2019-10-04 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373786: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible (authored by mgorny, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Herald added a project: LLVM. Ch

[PATCH] D68482: [clang] fix a typo from r372531

2019-10-04 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen created this revision. ychen added a reviewer: xbolva00. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68482 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-integer-constants-in-ternary

[PATCH] D68482: [clang] fix a typo from r372531

2019-10-04 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68482/new/ https://reviews.llvm.org/D68482 __

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

2019-10-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 12 inline comments as done. yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:17618 + + if (LangOpts.CUDA) { +// When compiling for device, host functions are never emitted. Similarly, ABataev wrote: > Are you going to handle `#p

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

2019-10-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 223284. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revised by Alexey's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cp

[PATCH] D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

2019-10-04 Thread Mitchell via Phabricator via cfe-commits
mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:1617 +if (Tok.Next->isOneOf(tok::kw_noexcept, tok::kw_volatile, tok::kw_const, +

r373792 - [clang] fix a typo from r372531

2019-10-04 Thread Yuanfang Chen via cfe-commits
Author: yuanfang Date: Fri Oct 4 14:37:20 2019 New Revision: 373792 URL: http://llvm.org/viewvc/llvm-project?rev=373792&view=rev Log: [clang] fix a typo from r372531 Reviewers: xbolva00 Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68482 Modified:

[PATCH] D68482: [clang] fix a typo from r372531

2019-10-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373792: [clang] fix a typo from r372531 (authored by yuanfang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

2019-10-04 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added a reviewer: beanz. Herald added a subscriber: mgorny. Herald added a project: clang. We were linking all the clang objects and shared libraries into libclang-cpp.so, which was causing the command line options to be registered twice. Repository: rG

LLVM buildmaster will be updated and restarted tonight

2019-10-04 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

2019-10-04 Thread James Clarke via Phabricator via cfe-commits
jrtc27 created this revision. jrtc27 added reviewers: rsmith, xbolva00. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68526 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/div-sizeof-array.cpp Index

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

2019-10-04 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev updated this revision to Diff 223335. sdmitriev added a comment. Rebased patch and changed clang-offload-wrapper CMakeLists.txt to use add_clang_tool() rather than add_clang_executable() with a custom install rule. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ http

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths.

2019-10-04 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese created this revision. Bigcheese added reviewers: rsmith, bruno. Herald added a subscriber: dexonsmith. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D68528 Files: include/clang/Driver/CC1Options.td include/clang/Lex/HeaderSearchOptions.h lib/Fron

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

2019-10-04 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese updated this revision to Diff 223345. Bigcheese retitled this revision from "[Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths." to "[Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.". Bigcheese added

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

2019-10-04 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. I think this is reasonable change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68526/new/ https://reviews.llvm.org/D68526 _

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

2019-10-04 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. This clang builtin and corresponding LLVM intrinsic are necessary to expose the exact se

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-10-04 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. Herald added a subscriber: usaxena95. "Extend our extension to support detecting these files as C++ files based on the first line (-*- C++ -*-), it will make clangd work on C++ standard headers (e.g. iostream)." This is not in the standard right? I don't see this in MS

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

2019-10-04 Thread Eric Christopher via Phabricator via cfe-commits
echristo created this revision. echristo added reviewers: chandlerc, hfinkel. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier. Herald added projects: clang, LLVM. In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a f

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

2019-10-04 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. In D63397#1696000 , @malaperle wrote: > "Extend our extension to support detecting these files as C++ files based on > the first > line (-*- C++ -*-), it will make clangd work on C++ standard headers > (e.g. iostream)." > > Th

<    1   2