[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

rjmccall added a comment. That looks great. I'm probably not the best person to validate that the OMP / CUDA logic is still right, but it seems like the right technical design. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67983/new/ https://reviews.llvm.org/D67983 __

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67982/new/ https://reviews.llvm.org/D67982 __

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

rnk created this revision. rnk added reviewers: rjmccall, rsmith, hans. Herald added subscribers: s.egerton, simoncook, fedor.sergeev, aheejin. Herald added a project: clang. I noticed that compiling on Windows with -fno-ms-compatibility had the side effect of defining __GNUC__, along with __EXCEP

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. The code looks correct. I have some nitpicks about how the functions are named, but you don't need to go with my suggestions specifically. Comment at: clang/lib/Lex

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

dexonsmith added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:247-248 -static const char *reverseOverSpaces(const char *First, const char *Last) { +static const char *reverseOverSpacesUntilFirstSpace(const char *First, +

[PATCH] D68049: Propeller: Clang options for basic block sections

mehdi_amini added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:52 + ///< Produce unique section names with + ///< basic block sections. ENUM_CODEGENOPT(FramePointer, FramePoin

r372925 - Fix memory leak in DeclTest.

Author: eugenis Date: Wed Sep 25 15:38:20 2019 New Revision: 372925 URL: http://llvm.org/viewvc/llvm-project?rev=372925&view=rev Log: Fix memory leak in DeclTest. Fixes a leak introduced in r372903, detected on the ASan bot. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/354

Re: r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

FYI I've fixed a memory leak in the new test in r372925. On Wed, Sep 25, 2019 at 10:58 AM Vedant Kumar via cfe-commits wrote: > > Author: vedantk > Date: Wed Sep 25 11:00:31 2019 > New Revision: 372903 > > URL: http://llvm.org/viewvc/llvm-project?rev=372903&view=rev > Log: > [Mangle] Add flag to

Re: r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

Thank you, sorry for the trouble. vedant > On Sep 25, 2019, at 3:36 PM, Evgenii Stepanov > wrote: > > FYI I've fixed a memory leak in the new test in r372925. > > On Wed, Sep 25, 2019 at 10:58 AM Vedant Kumar via cfe-commits > wrote: >> >> Author: vedantk >> Date: Wed Sep 25 11:00:31 2019 >

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation step."); +MergerInputs.push_back(Current); compnerd wrote: > Does

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221851. plotfi marked 6 inline comments as done. plotfi added a comment. addressing cindy and saleem's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files:

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. The three way split looks great, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

r372926 - Simplify -fms-compatibility include lookup logic, NFC

Author: rnk Date: Wed Sep 25 15:50:50 2019 New Revision: 372926 URL: http://llvm.org/viewvc/llvm-project?rev=372926&view=rev Log: Simplify -fms-compatibility include lookup logic, NFC This include search logic has an extra parameter to deal with Windows includes with backslashes, which get normal

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

hfinkel added a comment. In D64943#1683368 , @JonChesterfield wrote: > The three way split looks great, thanks. Makes sense to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev abandoned this revision. sdmitriev added a comment. This patch is no longer relevant since it was agreed to split https://reviews.llvm.org/D64943 into pieces in a different way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 __

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 updated this revision to Diff 221860. xbolva00 added a comment. addressed review notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67919/new/ https://reviews.llvm.org/D67919 Files: lib/Sema/SemaChecking.cpp test/Sema/warn-conditional-emum-types-mismatch.c Index: test/S

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 marked 6 inline comments as done. xbolva00 added inline comments. Comment at: test/Sema/warn-conditional-emum-types-mismatch.c:19 + +int get_flag_anon_enum(int cond) { + return cond ? A : C; aaron.ballman wrote: > xbolva00 wrote: > > Gcc warns here, but

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. In D55326#1342412 , @nemanjai wrote: > A couple of questions since I am not all that familiar with clang and am > certainly not familiar with this unusual SUSE 32-bit situation: > > - We seem to be changing the set of aliases

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/template-namespace-function.cpp:2 // REQUIRES: x86-registered-target -// RUN: %clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs \ -// RUN: -interface-stu

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach added a comment. Any other comments on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

r372936 - [libTooling] Add `run` combinator to Stencils.

Author: ymandel Date: Wed Sep 25 17:53:56 2019 New Revision: 372936 URL: http://llvm.org/viewvc/llvm-project?rev=372936&view=rev Log: [libTooling] Add `run` combinator to Stencils. Summary: This revision adds `run`, a StencilPart that runs a user-defined function that computes a result over `Matc

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rL372936: [libTooling] Add `run` combinator to Stencils. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6721 + if (getLangOpts().OpenCL) { + rjmccall wrote: > Since you're moving this code anyway, can this be split into its own > function? I'm n

Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Hi, this change breaks the build with /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/clang/lib/Format/Format.cpp:737:44: error: missing field 'SortPriority' initializer [-Werror,-Wmissing-field-initializers] {"^\"(llvm|llvm-c|clang|clang-c)/", 2}, h

r372939 - [clang-format] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919

Author: maskray Date: Wed Sep 25 19:02:17 2019 New Revision: 372939 URL: http://llvm.org/viewvc/llvm-project?rev=372939&view=rev Log: [clang-format] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919 Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unitte

Buildbot numbers for the week of 09/01/2019 - 09/07/2019

Hello everyone, Below are some buildbot numbers for the week of 09/01/2019 - 09/07/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the last week of 09/08/2019 - 09/14/2019

Hello everyone, Below are some buildbot numbers for the week of 09/08/2019 - 09/14/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Re: r372939 - [clang-format] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919

Thank you for fixing this... On Thu, Sep 26, 2019 at 3:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Wed Sep 25 19:02:17 2019 > New Revision: 372939 > > URL: http://llvm.org/viewvc/llvm-project?rev=372939&view=rev > Log: > [clang-format] Add Sor

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6721 + if (getLangOpts().OpenCL) { + Anastasia wrote: > rjmccall wrote: > > Since you're moving this code anyway, can this be split into its own > > function? I'm not sure if it's actual

Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Hi, On 2019-09-26 03:16, Evgenii Stepanov via cfe-commits wrote: > Hi, > > this change breaks the build with > > /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/clang/lib/Format/Format.cpp:737:44: > error: missing field 'SortPriority' initializer > [-Werror,

r372942 - [analyzer] Avoid small vectors of non-default-constructibles.

Author: dergachev Date: Wed Sep 25 23:33:21 2019 New Revision: 372942 URL: http://llvm.org/viewvc/llvm-project?rev=372942&view=rev Log: [analyzer] Avoid small vectors of non-default-constructibles. Unconfuses certain compilers. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensit

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

AndWass created this revision. AndWass added reviewers: klimek, owenpan, krasimir, timwoj. AndWass added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following code struct f { template void bar() && noexcept {} }; will be format

r372944 - [SortIncludesTest] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919

Author: uabelho Date: Wed Sep 25 23:49:37 2019 New Revision: 372944 URL: http://llvm.org/viewvc/llvm-project?rev=372944&view=rev Log: [SortIncludesTest] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919 Modified: cfe/trunk/unittests/Format/SortIncludesTest.cpp

Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Fixed the testcase in r372944. On 2019-09-26 08:14, Mikael Holmén via cfe-commits wrote: > Hi, > > On 2019-09-26 03:16, Evgenii Stepanov via cfe-commits wrote: >> Hi, >> >> this change breaks the build with >> >> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-proj

<    1   2