r372773 - [HIP] Support new kernel launching API

Author: yaxunl Date: Tue Sep 24 12:16:40 2019 New Revision: 372773 URL: http://llvm.org/viewvc/llvm-project?rev=372773&view=rev Log: [HIP] Support new kernel launching API Differential Revision: https://reviews.llvm.org/D67947 Modified: cfe/trunk/include/clang/Basic/LangOptions.def cfe/t

[PATCH] D67947: [HIP] Support new kernel launching API

This revision was automatically updated to reflect the committed changes. Closed by commit rL372773: [HIP] Support new kernel launching API (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl added a comment. In D67509#1679524 , @tra wrote: > In D67509#1678394 , @yaxunl wrote: > > > A reduced test case is > > > > struct A { > > A(); > > }; > > > > template > > struct B > > { > >

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh created this revision. lildmh added reviewers: ABataev, Meinersbur, hfinkel, jdoerfert. lildmh added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This patches fixes the case when a user-defined mapper is attached to the elements of an a

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. What happens without this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 221578. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: include/clang/AST/OpenMPClause.h lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/C

r372775 - [NFC] Strenghten preconditions for warning

Author: xbolva00 Date: Tue Sep 24 13:10:57 2019 New Revision: 372775 URL: http://llvm.org/viewvc/llvm-project?rev=372775&view=rev Log: [NFC] Strenghten preconditions for warning Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL: http://llvm.org/

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

zturner added a reviewer: krasimir. zturner added a comment. What's the status of this patch, out of curiosity? It doesn't seem there were any objections to the original idea, just that nobody with ownership over clang-format is still actively participating in the review. +krasimir to maybe sh

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField +

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 221583. nridge added a comment. Updated to use a new "dependent type" highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/Sema

[PATCH] D67980: [WIP][CLANG][BPF] implement clang __builtin_bitfield_info() intrinsic

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added a project: clang. Herald added a subscriber: cfe-commits. The patch is still work in progress. The signature: u64 __builtin_bitfield_info(bitfield_member_access) return value: ret >> 16 : bitfi

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. Without this patch, it cannot recognize array with mapper, for instance, `#pragma omp target map(mapper(a),to: arr[0:2])` won't work without this patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1681318 , @lildmh wrote: > Without this patch, it cannot recognize array with mapper, for instance, > `#pragma omp target map(mapper(a),to: arr[0:2])` won't work without this > patch. What if we have a mapper for the

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

jyknight created this revision. jyknight added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is especially important for Objective-C++, which is entirely missing this testing at the moment. This annotates with "FIXME" the cases which I change in

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight created this revision. jyknight added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example, in Objective-C mode, the initialization of 'x' in: @implementation MyType + (void)someClassMethod { MyType *x = self; } @end is cor

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1681319 , @ABataev wrote: > In D67978#1681318 , @lildmh wrote: > > > Without this patch, it cannot recognize array with mapper, for instance, > > `#pragma omp target map(mapper(a),

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. Note that the test-case diffs are on top of https://reviews.llvm.org/D67982, which I split out to make the actual change in behavior in this commit clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67983/new/ https:/

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

jyknight added a comment. (See https://reviews.llvm.org/D67983 for the proposed behavior change.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67982/new/ https://reviews.llvm.org/D67982 ___ cfe-commit

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

dmikulin created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, Prazek. Herald added projects: clang, Sanitizers, LLVM. Fix for https://bugs.llvm.org/show_bug.cgi?id=43390 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67985 Files: clang/lib/

[PATCH] D67980: [WIP][CLANG][BPF] implement clang __builtin_bitfield_info() intrinsic

yonghong-song updated this revision to Diff 221598. yonghong-song edited the summary of this revision. yonghong-song added a comment. builtin return u32 instead of u64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new/ https://reviews.llvm.o

[PATCH] D67573: Fix __atomic_is_lock_free's return type.

jyknight added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67573/new/ https://reviews.llvm.org/D67573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1681333 , @lildmh wrote: > In D67978#1681319 , @ABataev wrote: > > > In D67978#1681318 , @lildmh wrote: > > > > > Without this patch, it ca

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102 // expected-error@-2{{implicit declaration of function 'get_sub_group_size' is invalid in Open

[PATCH] D67992: [Sema] Add FunctionTypeUnwrapper

leonardchan created this revision. leonardchan added a reviewer: rsmith. leonardchan added a project: clang. Herald added a subscriber: kristof.beyls. This is a fix for PR43315. An assertion error is hit for this minimal example: //clang -cc1 -triple x86_64-- -S tstVMStructRC-min.cpp #define

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

phosek added a comment. @dankm is it OK if we take over this change to push it forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk added inline comments. Comment at: clang/lib/AST/Mangle.cpp:130 + return; +} + rjmccall wrote: > This is actually backwards, right? A literal label is one that doesn't get > the global prefix and therefore potentially needs the `\01` prefix to > s

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: llvm/test/Feature/load_extension.ll:1 +; RUN: not test -f %llvmshlibdir/libBye%shlibext || opt %s -load=%llvmshlibdir/libBye%shlibext -good

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1681388 , @ABataev wrote: > In D67978#1681333 , @lildmh wrote: > > > In D67978#1681319 , @ABataev wrote: > > > > > In D67978#1681318

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/lib/AST/Mangle.cpp:130 + return; +} + vsk wrote: > rjmccall wrote: > > This is actually backwards, right? A literal label is one that doesn't get > > the global prefix and therefore potentially needs th

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

efriedma added a subscriber: rsmith. efriedma added a comment. Does this have any significant impact on -fsyntax-only performance? Hopefully @rsmith can take a quick look at the use of ConstantExpr here; I think it's fine, but we don't use ConstantExpr like that elsewhere. Co

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

vsk updated this revision to Diff 221645. vsk retitled this revision from "[Mangle] Add flag to asm labels to disable global prefixing" to "[Mangle] Add flag to asm labels to disable '\01' prefixing". vsk edited the summary of this revision. vsk added a comment. - Address latest round of comment

r372802 - [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64

Author: pengfei Date: Tue Sep 24 19:24:05 2019 New Revision: 372802 URL: http://llvm.org/viewvc/llvm-project?rev=372802&view=rev Log: [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64 Summary: Adding support for some missing intrinsics: _ca

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. Keep in mind that for static linking you will need something that pulls-in a symbol from the pass static library. In this patch, `NewPMDriver.cpp` does it for `opt` by calling `get##Ext##PluginInfo()`. In clang, it is `BackendUtil.cpp`. But nothing for `bugpoint` hen

[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

MaskRay created this revision. MaskRay added reviewers: jakehehrlich, mcgrathr, phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. The option was added to lld in D67481 /372807. Repository: rC Clang https://reviews.llvm.org/D68009

[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68009/new/ https://reviews.llvm.org/D68009 ___ cfe-co

<    1   2