[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. The clang intrinsic __builtin_preserve_access_index() currently has signature: const void * __builtin_preserve_access_index(const void * ptr)

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

arichardson added a comment. Herald added a project: clang. Ping? I'm not sure if this is still required now that D63508 has been committed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49091/new/ https://reviews.llvm.org/D4909

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Please be sure the watch the lldb (and other debugger) bots after committing this.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman updated this revision to Diff 220751. mwyman added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLin

r372263 - fix build, adjust test also for Windows path separator

Author: llunak Date: Wed Sep 18 14:41:45 2019 New Revision: 372263 URL: http://llvm.org/viewvc/llvm-project?rev=372263&view=rev Log: fix build, adjust test also for Windows path separator Introduced in 1e9c1d2b7bfc. Modified: cfe/trunk/test/Frontend/rewrite-includes-conditions.c cfe/trun

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

NoQ added a comment. Btw, `evalCall` is not deprecated. In fact, there are no alternatives for it in many cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67480/new/ https://reviews.llvm.org/D67480 __

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

NoQ added a comment. Thanks! Woohoo, tests! You can go one step further to have a `CallDescriptionMap`, like in D62557 . This would replace the whole chain of `if`s with a map lookup (which is currently still a chain of `if`s under the hood, but a lot less code

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 220756. akhuang marked 3 inline comments as done. akhuang added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files: clang/include/cla

r372269 - [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Author: szelethus Date: Wed Sep 18 15:24:26 2019 New Revision: 372269 URL: http://llvm.org/viewvc/llvm-project?rev=372269&view=rev Log: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction Summary: https://bugs.llvm.org/show_bug.cgi?id=43102 In to

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372269: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic… (authored by Szelethus, committed

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. We have no solid evidence to conclude that such an event should not occur at a `BlockEntrance`, so fixing this error mustn't be that bad. I certainly should've used `llvm::isa_or_nonnull`, so the patch overall makes sense, so I'm commiting it as is. With that said, th

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:69 +// MEM +CheckFactories.registerCheck("cert-mem57-cpp"); I find `DefaultOperatorNewCheck` to be insufficiently explanative. Maybe `DefaultOperatorNewAl

[PATCH] D67730: [CUDA][HIP] Fix typo in `BestViableFunction`

tra added a comment. LGTM. You may want to wait a bit for Justin's feedback, in case he has some concerns. Comment at: clang/test/SemaCUDA/function-overload.cu:406 + +// Two irrelevant classes with `operator-` defined. One of them is device only. +struct C1 { int m; }; ---

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Apple documentation states that: "If two objects are equal, they must have the same hash value. This last point is particularly important if you define isEqual: in a subcla

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

tlively created this revision. tlively added reviewers: dschuff, aheejin. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67739 Files: clang/include/clang/Basic/Diagnos

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

sunfish added a comment. Would it be better to do this check in LLVM, in the backend, with a `report_fatal_error`? Clang for its part already supports what we expect wasm64 will need already, and we have a bunch of tests for it, so it'd be nice to keep that code around and tested. And, doing t

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex created this revision. comex added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by FIXME comments, fix commented-out diagnostic in Sema and remove the equivalent check within the consumed analysis. The diagnostic in question is t

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

yonghong-song updated this revision to Diff 220772. yonghong-song edited the summary of this revision. yonghong-song added a comment. does not change arg type and make result type the same as arg type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. that's indeed much better. Thanks for adding all the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67734/new/ https://reviews.llvm.org/D67734

[PATCH] D67635: Fix for stringized function-macro args continued across lines

kousikk added a comment. Ping on the review for this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex updated this revision to Diff 220771. comex added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Here's a new version of the patch that uses iterator ranges instead of `ArrayRef`, to avoid adding new uses of `CallExpr::getArgs()` in case it has

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:40 +void MissingHashCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + objcMethodDecl( Should check if language is Objective-C. See

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:105 +- New :doc:`objc-missing-hash + ` check. Wrong place. Please move to new checks list (in alphabetical order). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs.

comex created this revision. comex added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also, fix the order of `if` statements so that an explicit `return_typestate` annotation takes precedence over the default behavior for rvalue refs. Note that for

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1674745 , @comex wrote: > Here's a new version of the patch that uses iterator ranges instead of > `ArrayRef`, to avoid adding new uses of `CallExpr::getArgs()` in case it has > to be removed in the future due to the s

r372281 - Initialize all fields in ABIArgInfo.

Author: serge_sans_paille Date: Wed Sep 18 17:54:40 2019 New Revision: 372281 URL: http://llvm.org/viewvc/llvm-project?rev=372281&view=rev Log: Initialize all fields in ABIArgInfo. Due to usage of an uninitialized fields, we end up with a Conditional jump or move depends on uninitialised value F

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex added a comment. In D67647#1674773 , @dblaikie wrote: > I wasn't expecting it to involve all this work - but instead to change > "arguments()" to return ArrayRef. Though perhaps you didn't go that route to > allow future fixes to the strict aliasin

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex updated this revision to Diff 220784. comex added a comment. Fixed a mistake where the diagnostic would print the wrong parameter type. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67740/new/ https://reviews.llvm.org/D67740 Files: include/clang/Analysis

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1674781 , @comex wrote: > In D67647#1674773 , @dblaikie wrote: > > > I wasn't expecting it to involve all this work - but instead to change > > "arguments()" to return ArrayRef.

[PATCH] D67744: [clang-tidy] Fix bugprone-argument-comment-check to correctly ignore implicit constructors.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. After revision 370919, this check incorrectly flags certain cases of implicit constructors. Specifically, if an argument is annotated with an argument-comment an

r372294 - [CLANG][BPF] change __builtin_preserve_access_index() signature

Author: yhs Date: Wed Sep 18 19:59:43 2019 New Revision: 372294 URL: http://llvm.org/viewvc/llvm-project?rev=372294&view=rev Log: [CLANG][BPF] change __builtin_preserve_access_index() signature The clang intrinsic __builtin_preserve_access_index() currently has signature: const void * __builtin

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

This revision was automatically updated to reflect the committed changes. Closed by commit rL372294: [CLANG][BPF] change __builtin_preserve_access_index() signature (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60748: Fix i386 struct and union parameter alignment

LiuChen3 updated this revision to Diff 220793. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/x86_32-align-linux.c clang/test/CodeGen/x86_32-align-linux.cpp clang/test/CodeGen/x86

r372299 - [Builtins] Delete setjmp_syscall and qsetjmp

Author: maskray Date: Wed Sep 18 21:41:38 2019 New Revision: 372299 URL: http://llvm.org/viewvc/llvm-project?rev=372299&view=rev Log: [Builtins] Delete setjmp_syscall and qsetjmp Similar to the resolution of gcc PR71876. Nobody uses them or needs the [-Wincomplete-setjmp-declaration] diagnostic.

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.o

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

aheejin added a comment. +1 on erroring out on the backend side. And how about "wasm64 is not supported"? wasm64... is still a registered target in the frontend, so... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67739/new/ https://reviews.llvm.o

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674902 , @SouraVX wrote: > In D67613#1674597 , @aprantl wrote: > > > Please be sure the watch the lldb (and other debugger) bots after > > committing this.. > > > Thanks a lot!

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. To be used by define-inline code action to determine whether the function/method body will still be valid

<    1   2