[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

2019-09-17 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67683/new/ https://reviews.llvm.org/D67683 ___ cfe-commits mailing list

r372191 - [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

2019-09-17 Thread Volodymyr Sapsai via cfe-commits
Author: vsapsai Date: Tue Sep 17 17:05:45 2019 New Revision: 372191 URL: http://llvm.org/viewvc/llvm-project?rev=372191&view=rev Log: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328. Starting from r324788 timer groups aren't cleared automatically when printed out. As a re

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

2019-09-17 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372191: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

2019-09-17 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the fast review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67683/new/ https://reviews.llvm.org/D67683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

2019-09-17 Thread Nicholas Allegra via Phabricator via cfe-commits
comex added a comment. Ugh, it looks like `getArgs()` is a massive strict aliasing violation. And it's used in enough different places in Clang that fixing the violation may require extensive refactoring... I've reported the issue as https://bugs.llvm.org/show_bug.cgi?id=43344, but I don't rea

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

2019-09-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D66121#1673233 , @aprantl wrote: > I'm afraid I'm going to give up on fixing the AST and return to my > debuginfo-only patch. > > While I was correct in figuring out that ObjCMethodDecl implementations are > not linked up as

r372197 - [X86] Prevent assertion when calling a function that returns double with -mno-sse2 on x86-64.

2019-09-17 Thread Craig Topper via cfe-commits
Author: ctopper Date: Tue Sep 17 18:57:46 2019 New Revision: 372197 URL: http://llvm.org/viewvc/llvm-project?rev=372197&view=rev Log: [X86] Prevent assertion when calling a function that returns double with -mno-sse2 on x86-64. As seen in the most recent updates to PR10498 Added: cfe/trunk/

Re: r372185 - Revert "Create UsersManual section entitled 'Controlling Floating Point"

2019-09-17 Thread Richard Smith via cfe-commits
On Tue, 17 Sep 2019, 15:25 Erich Keane via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Tue Sep 17 14:27:07 2019 > New Revision: 372185 > > URL: http://llvm.org/viewvc/llvm-project?rev=372185&view=rev > Log: > Revert "Create UsersManual section entitled 'Controlli

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

2019-09-17 Thread Tim Wojtulewicz via Phabricator via cfe-commits
timwoj updated this revision to Diff 220610. timwoj added a comment. Marked failing tests as FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 Files: clang/docs/ClangFormatStyleOptions.rst clang/inc

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

2019-09-17 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX updated this revision to Diff 220613. SouraVX added a comment. Updated AST to use DWARF language enums. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: include/clang/AST/DeclCXX.h lib/AST/DeclPrinter.cpp lib/AST/JSONNodeDump

<    1   2