[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

2019-09-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } calculateAttributeSpellingListIndex is defined in clangSema. This can

r371917 - [Driver] Improve Clang::getDependencyFileName and its tests after rC371853

2019-09-13 Thread Fangrui Song via cfe-commits
Author: maskray Date: Fri Sep 13 21:13:15 2019 New Revision: 371917 URL: http://llvm.org/viewvc/llvm-project?rev=371917&view=rev Log: [Driver] Improve Clang::getDependencyFileName and its tests after rC371853 The test file name metadata-with-dots.c is confusing because -MD and -MMD have nothing t

r371918 - [Driver] Fix multiple bugs related to dependency file options: -M -MM -MD -MMD -MT -MQ

2019-09-13 Thread Fangrui Song via cfe-commits
Author: maskray Date: Fri Sep 13 23:01:22 2019 New Revision: 371918 URL: http://llvm.org/viewvc/llvm-project?rev=371918&view=rev Log: [Driver] Fix multiple bugs related to dependency file options: -M -MM -MD -MMD -MT -MQ -M -o test.i => dependency file is test.d, not test.i -MM -o test.i => depe

<    1   2