[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Szelethus added a comment. Yes, thank you! I've been keeping my mailbox open and commiting slowly, it seems like the buildbots have a wrong email address set up for me. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67140/new/ https://reviews.llvm.org/D67140 __

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 220002. poelmanc added a comment. Nice catch, that simplifies the code quite a bit! I added two more nested, complex multiple-template-argument tests and am happy to add more. (We could do a case fallthrough after tok::l_brace, though some linters warn abo

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 220007. poelmanc added a comment. Sorry one more test at the end to make sure a multi-typedef with all that Variadic stuff still doesn't get changed to using. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

NoQ added a comment. `SimpleStreamChecker` is a historical tutorial example , i don't think we should be updating it other than for modernizing checker API use. It was supposed to handle a few simple examples correctly but it wasn't supposed to suppo

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

jonathanmeier added a comment. Nice! I don't have commit access, so we'll need someone else have another look. @alexfh, since you previously worked on this, would you mind taking a look at this patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

rsmith added a comment. In D67414#1668475 , @mstorsjo wrote: > In D67414#1668443 , @rsmith wrote: > > > Seems very surprising to me that the `gnu_inline` attribute has different > > behavior in their C and C++ fron

[PATCH] D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

NoQ added a comment. Umm, this test fails for me locally because i see `osx` checkers displayed in the list. Which is weird because they're supposed to be enabled based on the target platform, not on the host platform. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org

r371781 - [analyzer] Fix the 'analyzer-enabled-checkers.c' test on non-linux machines.

Author: dergachev Date: Thu Sep 12 15:11:15 2019 New Revision: 371781 URL: http://llvm.org/viewvc/llvm-project?rev=371781&view=rev Log: [analyzer] Fix the 'analyzer-enabled-checkers.c' test on non-linux machines. '-Xclang -triple' doesn't seem to override the default target triple as reliably as

[PATCH] D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

NoQ added a comment. rC371781 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66714/new/ https://reviews.llvm.org/D66714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jfb accepted this revision. jfb added a comment. Sounds like this is ready to land again! Thanks for fixing everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:517 +if (V) + State = addTaint(State, *V, TaintTagNotTainted); + } Why not simply remove taint? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5951

r371785 - Add -Wpoison-system-directories warning

Author: manojgupta Date: Thu Sep 12 15:36:13 2019 New Revision: 371785 URL: http://llvm.org/viewvc/llvm-project?rev=371785&view=rev Log: Add -Wpoison-system-directories warning When using clang as a cross-compiler, we should not use system headers to do the compilation. This CL adds support of a

[PATCH] D52524: Add -Wpoison-system-directories warning

manojgupta closed this revision. manojgupta added a comment. Submitted as https://reviews.llvm.org/rL371785. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 ___ cfe-commits mail

r371787 - [libclang] Expose abort()-ing LLVM fatal error handler

Author: jkorous Date: Thu Sep 12 15:55:55 2019 New Revision: 371787 URL: http://llvm.org/viewvc/llvm-project?rev=371787&view=rev Log: [libclang] Expose abort()-ing LLVM fatal error handler Differential Revision: https://reviews.llvm.org/D66775 Added: cfe/trunk/include/clang-c/FatalErrorHandl

[PATCH] D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

dblaikie added a comment. Some more ping (: Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63031/new/ https://reviews.llvm.org/D63031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

r371794 - [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test

Author: jkorous Date: Thu Sep 12 16:51:48 2019 New Revision: 371794 URL: http://llvm.org/viewvc/llvm-project?rev=371794&view=rev Log: [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test Modified: cfe/trunk/unittests/libclang/CrashTests/LibclangCrashTest.cpp Modified: cfe/trunk/unittes

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rjmccall added a comment. The exact sequence of volatile accesses is observable behavior, and it's the ABI's right to define correct behavior for compliant implementations, so we do need to do this. Diogo, IRGen breaks up bit-field storage units in CGRecordLowering::accumulateBitFields. I'm s

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain &ToolChain, + const llvm::opt::ArgList &Args, kito-cheng wrote: > MaskRay wrote: > > gold doesn't supp

r371799 - Revert r371785.

Author: manojgupta Date: Thu Sep 12 17:28:37 2019 New Revision: 371799 URL: http://llvm.org/viewvc/llvm-project?rev=371799&view=rev Log: Revert r371785. r371785 is causing fails on clang-hexagon-elf buildbots. Removed: cfe/trunk/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/ cfe/t

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

rsmith abandoned this revision. rsmith added a comment. This patch doesn't work, and the ARM NEON intrinsic header emitter is too opaque and mysterious for me to be able to fix this, and it's not even clear that the generator knows what the actual parameter types of the compiler builtins are. F

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rsmith added a comment. In D67399#1668759 , @rjmccall wrote: > The exact sequence of volatile accesses is observable behavior, and it's the > ABI's right to define correct behavior for compliant implementations, so we > do need to do this. I'm not conv

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. LGTM. - Maybe we can lower these to these new instructi

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

tlively added a comment. In D67425#1668831 , @aheejin wrote: > LGTM. > > - Maybe we can lower these > > to these new ins

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: test/Sema/typo-correction-ambiguity.cpp:7 + +namespace AmibguousCorrection +{ Is the typo in "Ambiguous" here intentional? :) Repository:

r371805 - For PR17164: split -fno-lax-vector-conversion into three different

Author: rsmith Date: Thu Sep 12 19:20:00 2019 New Revision: 371805 URL: http://llvm.org/viewvc/llvm-project?rev=371805&view=rev Log: For PR17164: split -fno-lax-vector-conversion into three different levels: -- none: no lax vector conversions [new GCC default] -- integer: only conversions betwe

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rjmccall added a comment. I have to say that I disagree. The ABI certainly doesn't get to control the language and define what constitutes a volatile access, but when the language has decided that a volatile access is actually performed, I think ABIs absolutely ought to define how they should

r371813 - Revert "For PR17164: split -fno-lax-vector-conversion into three different"

Author: jdevlieghere Date: Thu Sep 12 22:16:59 2019 New Revision: 371813 URL: http://llvm.org/viewvc/llvm-project?rev=371813&view=rev Log: Revert "For PR17164: split -fno-lax-vector-conversion into three different" This breaks the LLDB build. I tried reaching out to Richard, but haven't gotten a

r371814 - Remove reliance on lax vector conversions from altivec.h and its test.

Author: rsmith Date: Thu Sep 12 22:19:12 2019 New Revision: 371814 URL: http://llvm.org/viewvc/llvm-project?rev=371814&view=rev Log: Remove reliance on lax vector conversions from altivec.h and its test. Modified: cfe/trunk/include/clang/Basic/BuiltinsPPC.def cfe/trunk/lib/Headers/altivec

r371816 - Fix interaction between r371813 and r371814.

Author: rsmith Date: Thu Sep 12 22:29:16 2019 New Revision: 371816 URL: http://llvm.org/viewvc/llvm-project?rev=371816&view=rev Log: Fix interaction between r371813 and r371814. Modified: cfe/trunk/test/CodeGen/builtins-ppc-altivec.c Modified: cfe/trunk/test/CodeGen/builtins-ppc-altivec.c UR

[PATCH] D67490: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67490/new/ https://reviews.llvm.org/D67490 __

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge created this revision. nridge added reviewers: sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. nridge added a comment. This patch adds server-side support for greying out code in inactive preproce

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. This patch adds server-side support for greying out code in inactive preprocessor branches (issue #132 ). I didn't write test yet. I wanted to post the patch for feedback first, to see if the general approach is ok. Reposit

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67537 Files: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge added a comment. This is not for review yet, I'm just posting it to illustrate the client side of D67536 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. For reference, I also posted a proof-of-concept client impl in D67537 , which I used to test/validate this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llv

Re: r371813 - Revert "For PR17164: split -fno-lax-vector-conversion into three different"

Thanks for the revert, re-landed in r371817 with a (hopeful) fix for lldb (which I can't build; cmake seems unable to enable it in a monorepo checkout?) On Thu, 12 Sep 2019 at 22:15, Jonas Devlieghere via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jdevlieghere > Date: Thu Sep 12 2

r371817 - For PR17164: split -fno-lax-vector-conversion into three different

Author: rsmith Date: Thu Sep 12 23:02:15 2019 New Revision: 371817 URL: http://llvm.org/viewvc/llvm-project?rev=371817&view=rev Log: For PR17164: split -fno-lax-vector-conversion into three different levels: -- none: no lax vector conversions [new GCC default] -- integer: only conversions betwe

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:414 + +CmdArgs.push_back(Args.MakeArgString(Twine("-plugin-opt=--" + "mattr=") + The single-dash form of `mattr`: `-plugin-opt=

<    1   2