[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

2019-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371658: [analyzer] NFC: Re-implement stack hints as a side map in BugReport. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67418: [analyzer] NFC: Move PathDiagnostic::resetDiagnosticLocationToMainFile to bug reporter.

2019-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371660: [analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

2019-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371659: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

r371663 - Start porting ivfsoverlay tests to Windows

2019-09-11 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Sep 11 13:56:25 2019 New Revision: 371663 URL: http://llvm.org/viewvc/llvm-project?rev=371663&view=rev Log: Start porting ivfsoverlay tests to Windows Part of PR43272, the changes are: 1. Use @ as the sed pattern delimiter instead of : so that the drive letter in lit substi

[PATCH] D67454: Start porting ivfsoverlay tests to Windows

2019-09-11 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371663: Start porting ivfsoverlay tests to Windows (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

r371664 - [clang-scan-deps] cast Result to ErrorOr> explicitly to avoid s390x-linux buildbot failure

2019-09-11 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Sep 11 14:00:13 2019 New Revision: 371664 URL: http://llvm.org/viewvc/llvm-project?rev=371664&view=rev Log: [clang-scan-deps] cast Result to ErrorOr> explicitly to avoid s390x-linux buildbot failure Modified: cfe/trunk/lib/Tooling/DependencyScanning/DependencyScann

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

2019-09-11 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. In D64943#1666849 , @sdmitriev wrote: > In D64943#136 , @JonChesterfield > wrote: > > > I'm not sure copying the crtbegin/crtend mechanism from the early days of C > > runtime

r371665 - Fix up a test updated in r371655 - require case-insensitive file system.

2019-09-11 Thread Volodymyr Sapsai via cfe-commits
Author: vsapsai Date: Wed Sep 11 14:19:27 2019 New Revision: 371665 URL: http://llvm.org/viewvc/llvm-project?rev=371665&view=rev Log: Fix up a test updated in r371655 - require case-insensitive file system. On case-sensitive file systems include with wrong case is not found instead of showing a w

[PATCH] D67467: [ARM] Update clang for removal of vfp2d16 and vfp2d16sp

2019-09-11 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added a reviewer: ostannard. Herald added a subscriber: kristof.beyls. Herald added a project: clang. Matching fix for https://reviews.llvm.org/D67375 . Repository: rC Clang https://reviews.llvm.org/D67467 Files: lib/Basic/Targets/ARM.cpp lib/Driv

LLVM buildmaster will be updated and restarted tonight

2019-09-11 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

2019-09-11 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. In D66856#116 , @aaron.ballman wrote: > The reflector discussion is still happening and there are issues with > ambiguities that we are pretty sure we want to correct. I've got a paper out > that touches on some of t

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

2019-09-11 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington updated this revision to Diff 219815. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Update the diagnostic text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 Files: clang/include/clang/Bas

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

2019-09-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 219821. NoQ added a comment. Unforget to do the same for the text consumer. As a side effect, the factory function for the text consumer is no longer special, which will be less confusing when put in libAnalysis. Address minor comments, don't address major comm

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

2019-09-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 219824. NoQ added a comment. Rename `BugType` to `WarningMessage`, add comments. Get rid of an unnecessary `SourceManager` parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 Files: clang/include/clang

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

2019-09-11 Thread Jonathan Meier via Phabricator via cfe-commits
jonathanmeier added a comment. With non-type template parameters we can have expressions inside template arguments, including comparison operators like `<`, `<=`, `>` and `>=`, which lets us write typedefs like this: template struct S {}; typedef S<(0 < 0)> S_t, *S_p; Unfortunately,

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

2019-09-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 219826. NoQ added a comment. Clean up a tiny bit of dead code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/ https://reviews.llvm.org/D67420 Files: clang/include/clang/Analysis/PathDiagnostic.h clang/include/clang/StaticAnalyzer/Core/Ana

[PATCH] D67249: [Modules][PCH] Hash input files content

2019-09-11 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added a comment. Did you try xxHash64? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67249/new/ https://reviews.llvm.org/D67249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

2019-09-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. @dankm do you still plan to work on this? We would really like to see this landed and we could help if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

2019-09-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 219829. NoQ added a comment. Herald added a subscriber: mgorny. Unforget to actually move the consumer implementations to `libAnalysis`, not just their headers. Casually rename `ClangDiagPathDiagConsumer

r371694 - [X86] Enable -mprefer-vector-width=256 by default for Skylake-avx512 and later Intel CPUs.

2019-09-11 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Sep 11 16:54:36 2019 New Revision: 371694 URL: http://llvm.org/viewvc/llvm-project?rev=371694&view=rev Log: [X86] Enable -mprefer-vector-width=256 by default for Skylake-avx512 and later Intel CPUs. AVX512 instructions can cause a frequency drop on these CPUs. This can

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

2019-09-11 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin created this revision. aheejin added a reviewer: NoQ. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This fixes build failures with `-DBUILD_SHARED_LIB=ON` after D67419 . Repository: rG LLVM Github Monorepo ht

Buildbot numbers for the week of 08/18/2019 - 08/24/2019

2019-09-11 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 08/18/2019 - 08/24/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 08/25/2019 - 08/31/2019

2019-09-11 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 08/25/2019 - 08/31/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

2019-09-11 Thread Conrad Poelman via Phabricator via cfe-commits
poelmanc updated this revision to Diff 219834. poelmanc edited the summary of this revision. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460/new/ https://reviews.llvm.org/D67460 Files: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

2019-09-11 Thread Conrad Poelman via Phabricator via cfe-commits
poelmanc added a comment. Wow, thanks for the super-quick testing, feedback and a new test case! I added a slightly enhanced version of your test case to the modernize-use-using.cpp test file and got it passing by treating tok::less and tok::right as AngleBrackets //only when ParenLevel == 0//.

r371697 - [clang-scan-deps] Add dependency targets

2019-09-11 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Sep 11 17:48:45 2019 New Revision: 371697 URL: http://llvm.org/viewvc/llvm-project?rev=371697&view=rev Log: [clang-scan-deps] Add dependency targets Differential Revision: https://reviews.llvm.org/D67475 Modified: cfe/trunk/test/ClangScanDeps/Inputs/subframework_hea

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

2019-09-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, nice, thank you!! Is this http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/10728 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

2019-09-11 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev added a comment. In D64943#1666924 , @JonChesterfield wrote: > In D64943#1666849 , @sdmitriev wrote: > > > In D64943#136 , > > @JonChesterfield wrote: > > > >

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

2019-09-11 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Nice! Hopefully this is rare enough that putting it under an existing warning flag won't be too inconvenient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] r371706 - [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

2019-09-11 Thread Heejin Ahn via cfe-commits
Author: aheejin Date: Wed Sep 11 20:10:57 2019 New Revision: 371706 URL: http://llvm.org/viewvc/llvm-project?rev=371706&view=rev Log: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON Summary: This fixes build failures with `-DBUILD_SHARED_LIB=ON` after D67419. Reviewers: NoQ Subscribers: mgorn

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

2019-09-11 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. I think that's it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67473/new/ https://reviews.llvm.org/D67473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

2019-09-11 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371706: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

r371708 - [WebAssembly] Add -fwasm-exceptions for wasm EH

2019-09-11 Thread Heejin Ahn via cfe-commits
Author: aheejin Date: Wed Sep 11 21:01:37 2019 New Revision: 371708 URL: http://llvm.org/viewvc/llvm-project?rev=371708&view=rev Log: [WebAssembly] Add -fwasm-exceptions for wasm EH Summary: This adds `-fwasm-exceptions` (in similar fashion with `-fdwarf-exceptions` or `-fsjlj-exceptions`) that t

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

2019-09-11 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371708: [WebAssembly] Add -fwasm-exceptions for wasm EH (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D66862: Make lround builtin constexpr (and others)

2019-09-11 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver added a comment. Ping. Anything else I am missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/ https://reviews.llvm.org/D66862 ___ cfe-commits mailing list cfe-commits@lists.llvm

r371710 - [WebAssembly] Add REQUIRES to test

2019-09-11 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Wed Sep 11 23:50:33 2019 New Revision: 371710 URL: http://llvm.org/viewvc/llvm-project?rev=371710&view=rev Log: [WebAssembly] Add REQUIRES to test Modified: cfe/trunk/test/CodeGenCXX/wasm-eh.cpp Modified: cfe/trunk/test/CodeGenCXX/wasm-eh.cpp URL: http://llvm.org/

r371711 - [WebAssembly] Make wasm-eh.cpp requires WebAssembly

2019-09-11 Thread Heejin Ahn via cfe-commits
Author: aheejin Date: Wed Sep 11 23:52:24 2019 New Revision: 371711 URL: http://llvm.org/viewvc/llvm-project?rev=371711&view=rev Log: [WebAssembly] Make wasm-eh.cpp requires WebAssembly D67208 added a new test line to wasm-eh.cpp that invokes the LLVM backend and this test fails on bots that don'

[PATCH] D67480: [Clang][Checkers] Add 'freopen' support to SimpleStreamChecker.

2019-09-11 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. The checker now recognizes 'freopen' as file opening function. Added support for binding the return value to the passed stream. Repository: rG LLVM Github Monorep

r371712 - [WebAssembly] Delete duplicate REQUIRES line

2019-09-11 Thread Heejin Ahn via cfe-commits
Author: aheejin Date: Wed Sep 11 23:56:17 2019 New Revision: 371712 URL: http://llvm.org/viewvc/llvm-project?rev=371712&view=rev Log: [WebAssembly] Delete duplicate REQUIRES line r371710 and r371711 committed the same line, so this deletes one of them. Modified: cfe/trunk/test/CodeGenCXX/was

<    1   2