[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. Adds clang builtins and LLVM intrinsics for these experimental instructions. They are no

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 218168. paulkirth added a comment. Remove extra include from CodeGenFunction.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include/clang/Basic/Di

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

leonardchan added a comment. *ping* This patch also seems to fix an issue with mismatched PC table and inline counters: ./out/Fuzz2/region_deserialize

r370535 - Revert [Clang Interpreter] Initial patch for the constexpr interpreter

Author: nand Date: Fri Aug 30 14:32:00 2019 New Revision: 370535 URL: http://llvm.org/viewvc/llvm-project?rev=370535&view=rev Log: Revert [Clang Interpreter] Initial patch for the constexpr interpreter This reverts r370531 (git commit d4c1002e0ab50f6891cdd2f5bd3a8f3a3584) Removed: cfe/tr

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

aheejin added a comment. Could you point to the spec of these instructions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67020/new/ https://reviews.llvm.org/D67020 ___ cfe-commits mailing list cfe-com

[PATCH] D67019: [analyzer] pr43179: CallDescription: Check number of parameters as well as number of arguments.

NoQ added a comment. For the actual variadic functions i'm thinking of something like `{CDF_Variadic, "fprintf", 2}` which will match all calls to variadic functions named "fprintf" that have //exactly// two non-variadic parameters and //at least// two arguments on the call site [which occupy t

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

teemperor added a comment. Seems like this patch introduced a cyclic dependency between Basic and AST when building with LLVM_ENABLE_MODULES=On: While building module 'Clang_AST' imported from llvm/lldb/include/lldb/Symbol/ClangUtil.h:14: While building module 'Clang_Basic' imported from l

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 218171. paulkirth added a comment. Fix comment for misexpect option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively added a comment. The context for this CL is https://github.com/emscripten-core/emscripten/issues/9340. The code that does the undesirable optimization is around llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18776. I think it is a reasonable assumption that what you put in is what you g

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert added a comment. > IIRC, when we rolled out `-Wstrict-prototypes` we explicitly excluded this > case since it hit a lot of code without finding bugs. I'm not a historian, but I believe this was suggested by @rsmith in https://bugs.llvm.org/show_bug.cgi?id=20796#c8, and I think we a

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

boga95 added a comment. Should I do anything or it is ready? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

NoQ added a comment. I have a few immediate style issues but otherwise it looks good :) Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:237 -const char GenericTaintChecker::MsgUncontrolledFormatString[] = +const llvm::StringLiteral GenericTaintChecker::MsgUnco

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek accepted this revision. phosek added a comment. In D66324#1653198 , @paulkirth wrote: > In D66324#1652364 , @lebedev.ri > wrote: > > > Trying to start reviewing this. > > The llvm side of the patch is self

[PATCH] D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. You can probably write a test for it via `-analyzer-display-progress`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66714/new/ https://reviews.llvm.o

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, jyknight, joerg. Herald added a subscriber: jfb. The `ATOMIC_VAR_INIT` was deprecated in C17 (C17 7.31.8p2), largely because it is fundamentally broken. It has already been proposed to be removed from C2x (http://www.ope

[PATCH] D65239: [analyzer] RangeConstraintManager: Apply constraint ranges of bitwise operations

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:488-489 +static ProgramStateRef applyBitwiseRanges(ProgramStateRef State, + BasicValueFactory &BV, + R

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. Missing tests for `__builtin_unpredictable()`. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:626 + unsigned Line, Column; + bool BadDebugInfo = false; + FullSourceLoc Loc = paulkirth wrote: > lebedev.ri wrote: > > This should be

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, dylanmckay. Herald added a project: clang. They are said to be more e

[PATCH] D66999: [ASTImporter][NFC] Add comments to code where we cannot use HandleNameConflict

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3454 << FoundField->getType(); - + // This case is not handled with HandleNameConflict, because by the time + // when we reach here, the enclosing class is already imported. If there --

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:75 /// individual bug reports. class BugReport : public llvm::ilist_node { public: NoQ wrote: > gribozavr wrote: > >

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

rsmith added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:523 + llvm::sys::path::filename(getSourceManager().getFilename( + M.getLocalDirective()->getLocation())) == "stdatomic.h") { +Diag(Identifier, diag::warn_pp_macro_deprecated)

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:523 + llvm::sys::path::filename(getSourceManager().getFilename( + M.getLocalDirective()->getLocation())) == "stdatomic.h") { +Diag(Ident

r370544 - [c++20] Implement semantic restrictions for C++20 designated

Author: rsmith Date: Fri Aug 30 15:52:55 2019 New Revision: 370544 URL: http://llvm.org/viewvc/llvm-project?rev=370544&view=rev Log: [c++20] Implement semantic restrictions for C++20 designated initializers. This has some interesting interactions with our existing extensions to support C99 design

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb added a comment. In D66834#1652756 , @compnerd wrote: > I think that this is pretty easy to forget. Fortunately, last argument wins. > Why not sink this into the `%clang` substitution in lit? That ensures that > we run with an empty sysro

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL370544: [c++20] Implement semantic restrictions for C++20 designated (authored by rsmith, committed by ). Herald added a p

[PATCH] D67025: Add .inl as valid C++ header type

abbaswasim created this revision. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. `clangd` doesn't consider `.inl` a valid C++ source (https://github.com/clangd/clangd/issues/16#issuecomment-512942589) this pull request adds support for that. Until

r370546 - ASTReader: Bypass overridden files when reading PCHs

Author: dexonsmith Date: Fri Aug 30 15:59:25 2019 New Revision: 370546 URL: http://llvm.org/viewvc/llvm-project?rev=370546&view=rev Log: ASTReader: Bypass overridden files when reading PCHs If contents of a file that is part of a PCM are overridden when reading it, but weren't overridden when the

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

dexonsmith closed this revision. dexonsmith marked an inline comment as done. dexonsmith added a comment. r370546. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66710/new/ https://reviews.llvm.org/D66710 ___ cfe-commits mailing list cfe-com

[PATCH] D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry

arphaman created this revision. arphaman added reviewers: Bigcheese, bruno, dexonsmith. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. This patch is similar to the FileEntryRef patch, in that it introduces a parallel API to get the directory entry, without replacing a

[PATCH] D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. A few minor comments. Assuming the `FIXME` I point out was intentionally left for later, this LGTM. Comment at: clang/include/clang/Basic/FileManager.h:59 +public:

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

tlively added a comment. https://github.com/WebAssembly/simd/pull/79/files They need benchmarking data before they can be merged into the proposal, and they need to be supported in the toolchain for us to get good benchmarking data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

aheejin added a comment. In D66983#1653226 , @tlively wrote: > The code that does the undesirable optimization is around > llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18776. Now line 18776 is a blank line :) You can take a permalink from the https://

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively added a comment. Link to DAGCombiner.cpp code: https://github.com/llvm/llvm-project/blob/802aab5/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp#L19014 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66983/new/ https://reviews.llvm.org/D66983

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

sunfish added a comment. In D66983#1651981 , @craig.topper wrote: > DAG combine is supposed to check with TargetLowering::isShuffleMaskLegal. In @tlively's example, it is DAGCombine, and it does check isShuffleMaskLegal. However for wasm, it appears th

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

aheejin added a comment. Should we handle these too? - There seems to be a generic intrinsic for fused multiply-add: https://github.com/llvm/llvm-project/blob/d21a3e41a4cfd52e3c5c9341f0b5ce8a173198bf/llvm/include/llvm/Target/GenericOpcodes.td#L612-L619 - There are FMA related nodes in ISDOpcode.

r370555 - [c++20] Disallow template argument deduction from a braced-init-list

Author: rsmith Date: Fri Aug 30 17:05:50 2019 New Revision: 370555 URL: http://llvm.org/viewvc/llvm-project?rev=370555&view=rev Log: [c++20] Disallow template argument deduction from a braced-init-list containing designators. The C++20 wording doesn't actually say what happens in this case, but tr

[PATCH] D67028: Use musttail for variadic method thunks when possible

rnk created this revision. rnk added reviewers: rsmith, hans, efriedma. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. This avoids cloning variadic virtual methods when the target supports musttail and the return type is not covariant. I think we never implemented this pr

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

tlively added a comment. In D67020#1653403 , @aheejin wrote: > Should we handle these too? > > - There seems to be a generic intrinsic for fused multiply-add: > https://github.com/llvm/llvm-project/blob/d21a3e41a4cfd52e3c5c9341f0b5ce8a173198bf/llvm/includ

r370556 - [WebAssembly] Add SIMD QFMA/QFMS

Author: tlively Date: Fri Aug 30 17:12:29 2019 New Revision: 370556 URL: http://llvm.org/viewvc/llvm-project?rev=370556&view=rev Log: [WebAssembly] Add SIMD QFMA/QFMS Summary: Adds clang builtins and LLVM intrinsics for these experimental instructions. They are not implemented in engines yet, but

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

This revision was automatically updated to reflect the committed changes. Closed by commit rL370556: [WebAssembly] Add SIMD QFMA/QFMS (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D67020?vs=218167&id=218193#toc Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively added a comment. @sunfish That sounds like a useful mechanism to me. I'd be happy to work on that next week. Is the consensus that we should not merge this change and instead pursue that idea? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

jfb added a comment. Is atomic initialization now correct in all modes (including C++) without this macro? I don’t think we should diagnose until such a time because some code uses to macro to be portably correct. IIRC we only ended up fixing C++ in 20 with Nico’s paper (after Olivier and I fai

[PATCH] D67029: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese. Herald added subscribers: llvm-commits, ributzka, kadircet, jkorous, hiraditya. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: LLVM. Change the APIs in SourceManager retur

[PATCH] D67028: Use musttail for variadic method thunks when possible

efriedma added a comment. Do we have test coverage for a variadic, covariant thunk for a function without a definition? I don't think there's any way for us to actually emit that, but we should make sure the error message is right. I'm a little concerned that using musttail thunks with the Ita

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, rsmith. Herald added a subscriber: ributzka. This changes ContentCache::Buffer to use `std::unique_ptr` instead of the PointerIntPair. It drops the (mostly unused) `DoNotFree` bit in favour of creating a new, non-o

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

aheejin added a comment. Yeah I think that can be a more generalized solution too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66983/new/ https://reviews.llvm.org/D66983 ___ cfe-commits mailing list

r370558 - [c++20] Add support for designated direct-list-initialization syntax.

Author: rsmith Date: Fri Aug 30 18:00:37 2019 New Revision: 370558 URL: http://llvm.org/viewvc/llvm-project?rev=370558&view=rev Log: [c++20] Add support for designated direct-list-initialization syntax. This completes the implementation of P0329R4. Added: cfe/trunk/test/Parser/cxx2a-designat

r370562 - Introduce a DirectoryEntryRef that stores both a reference and an

Author: arphaman Date: Fri Aug 30 18:26:04 2019 New Revision: 370562 URL: http://llvm.org/viewvc/llvm-project?rev=370562&view=rev Log: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry This commit introduces a parallel API that returns a Direct

[PATCH] D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry

arphaman marked 4 inline comments as done. arphaman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:299 StringRef DirectoryLookup::getName() const { + // FIXME: Use the name from \c DirectoryEntryRef. if (isNormalDir()) dexonsmith wrote: >

[PATCH] D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rL370562: Introduce a DirectoryEntryRef that stores both a reference and an (authored by arphaman, committed by ). Herald added subscribers: llvm-commits, jsji, Mas

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3449 + if (Diags.isIgnored(diag::warn_profile_data_misexpect, SourceLocation())) +Res.FrontendOpts.LLVMArgs.push_back("-pgo-warn-misexpect"); lebedev.ri wrote: > Err, th

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 2 inline comments as done. paulkirth added inline comments. Comment at: llvm/test/Transforms/LowerExpectIntrinsic/basic.ll:141 %tobool = icmp ne i64 %expval, 0 -; CHECK: !prof !1 +; CHECK: !prof !2 ; CHECK-NOT: @llvm.expect lebedev.ri wrote:

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 218197. paulkirth added a comment. Update LowerExpectIntrinsic/basic.ll to generate misexpect metadata for a switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Fi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 218198. paulkirth added a comment. Add inline checks for misexpect tags to LowerExpectIntrinstic test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include/clang/Basic/DiagnosticFrontendKi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 218200. paulkirth added a comment. Add clang and LLVM tests for __builtin_unpredictable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include/clang/B

[PATCH] D67031: [Clang][Bundler] Error reporting improvements [NFC]

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D67031 Files: clang/test/Driver/cl

<    1   2