[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 updated this revision to Diff 214940. xbolva00 added a comment. Explicit memcpy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 Files: test/CodeGen/struct-copy.c Index: test/CodeGen/struct-copy.c

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214945. jcai19 marked an inline comment as done. jcai19 added a comment. Updates based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Ba

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

tstellar created this revision. tstellar added reviewers: dyung, rsmith, hansw. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66176 Files: clang/test/Driver/modules.cpp Index: clang/test/Driver/modules.cpp =

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1922 + const bool Thumb = Opcode == ARM::tBL_PUSHLR; + MachineOperand ReturnAddr = MI.getOperand(0); + assert(ReturnAddr.getReg() == ARM:

[PATCH] D66151: [clang-doc] Fix bitcode writer

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. One comment then LGTM Comment at: clang-tools-extra/clang-doc/Serialize.cpp:507 Reference{ParentUSR, Parent->getNameAsString(), InfoType::IT_record}; - Fu

[PATCH] D66173: [Codegen] Updated test for D66158

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. In D66173#1628079 , @xbolva00 wrote: > hm.. memset? When I say memset, here and in the other review, I mean memmove. In D66173#1628088

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

mgehre marked an inline comment as done. mgehre added inline comments. Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:172 T &operator*(); + T &value(); +}; xazax.hun wrote: > I actually was a bit lazy when I added these tests. Both `value` and

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

xazax.hun added inline comments. Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:172 T &operator*(); + T &value(); +}; mgehre wrote: > xazax.hun wrote: > > I actually was a bit lazy when I added these tests. Both `value` and > > `operator*` is o

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre created this revision. mgehre added a reviewer: gribozavr. Herald added a subscriber: Szelethus. Herald added a project: clang. This fixes inference of gsl::Pointer on std::set::iterator with libstdc++ (the typedef for iterator on the template is a DependentNameType - we can only put the g

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

mgehre updated this revision to Diff 214950. mgehre marked 2 inline comments as done. mgehre added a comment. Fix commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66164/new/ https://reviews.llvm.org/D66164 Files: clang/lib/Sema/SemaInit.cpp

r368761 - [clang] DirectoryWatcher for Windows stubs (to fix build break).

Author: jkorous Date: Tue Aug 13 15:39:26 2019 New Revision: 368761 URL: http://llvm.org/viewvc/llvm-project?rev=368761&view=rev Log: [clang] DirectoryWatcher for Windows stubs (to fix build break). This is just a code skeleton for DirectoryWatcher-windows.cpp so the build on Windows stops breaki

r368762 - [clang][DirectoryWatcher] Fix Windows stub after LLVM change

Author: jkorous Date: Tue Aug 13 15:39:50 2019 New Revision: 368762 URL: http://llvm.org/viewvc/llvm-project?rev=368762&view=rev Log: [clang][DirectoryWatcher] Fix Windows stub after LLVM change r367979 changed DirectoryWatcher::Create to return an llvm::Expected. Adjust the Windows stub accordin

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

dyung added a comment. It's probably a pathological case, but wouldn't this still fail if the build directory contained ".s" followed by a space in the name? Something like "build-foo.s bar"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. Hmm, the patch doesn't pass its own test for me, could you double-check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 ___ cfe-commits ma

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

mgehre marked 3 inline comments as done. mgehre added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6583 .Cases("end", "rend", "cend", "crend", true) -.Cases("c_str", "data", "get", true) +.Cases("c_str", "data", "get", "value", true)

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

mgehre updated this revision to Diff 214954. mgehre marked an inline comment as done. mgehre added a comment. Add tests for rvalue-ref overloads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66164/new/ https://reviews.llvm.org/D66164 Files: clan

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:846 +print(' $ dot -Tsvg input.dot -o output.svg') +print() +write_temp_file('.dot', self.output()) --

r368765 - [analyzer] Disable the checker-plugins test on Darwin.

Author: dergachev Date: Tue Aug 13 16:04:44 2019 New Revision: 368765 URL: http://llvm.org/viewvc/llvm-project?rev=368765&view=rev Log: [analyzer] Disable the checker-plugins test on Darwin. Fixes a buildbot. Modified: cfe/trunk/test/Analysis/checker-plugins.c Modified: cfe/trunk/test/Analy

r368768 - [analyzer] exploded-graph-rewriter: Implement manual graph trimming.

Author: dergachev Date: Tue Aug 13 16:04:53 2019 New Revision: 368768 URL: http://llvm.org/viewvc/llvm-project?rev=368768&view=rev Log: [analyzer] exploded-graph-rewriter: Implement manual graph trimming. When -trim-egraph is unavailable (say, when you're debugging a crash on a real-world code th

r368766 - [analyzer] exploded-graph-rewriter: Open the converted graph immediately.

Author: dergachev Date: Tue Aug 13 16:04:47 2019 New Revision: 368766 URL: http://llvm.org/viewvc/llvm-project?rev=368766&view=rev Log: [analyzer] exploded-graph-rewriter: Open the converted graph immediately. Change the default behavior: the tool no longer dumps the rewritten .dot file to stdout

r368767 - [analyzer] exploded-graph-rewriter: NFC: Refactor explorers into trimmers.

Author: dergachev Date: Tue Aug 13 16:04:50 2019 New Revision: 368767 URL: http://llvm.org/viewvc/llvm-project?rev=368767&view=rev Log: [analyzer] exploded-graph-rewriter: NFC: Refactor explorers into trimmers. Explorers aren't the right abstraction. For the purposes of displaying svg files we do

r368769 - [analyzer] exploded-graph-rewriter: Implement displaying Store pointers.

Author: dergachev Date: Tue Aug 13 16:04:56 2019 New Revision: 368769 URL: http://llvm.org/viewvc/llvm-project?rev=368769&view=rev Log: [analyzer] exploded-graph-rewriter: Implement displaying Store pointers. They're useful when trying to understand what's going on inside your LazyCompoundValues.

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

tstellar updated this revision to Diff 214960. tstellar added a comment. Another attempt to fix this that depends less on the build directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new/ https://reviews.llvm.org/D66176 Files: clang/

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368766: [analyzer] exploded-graph-rewriter: Open the converted graph immediately. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D65345: [analyzer] exploded-graph-rewriter: Implement manual graph trimming.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368768: [analyzer] exploded-graph-rewriter: Implement manual graph trimming. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65344: [analyzer] exploded-graph-rewriter: NFC: Replace explorers with trimmers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368767: [analyzer] exploded-graph-rewriter: NFC: Refactor explorers into trimmers. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D65427: [analyzer] exploded-graph-rewriter: Implement Store pointers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368769: [analyzer] exploded-graph-rewriter: Implement displaying Store pointers. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:")

rtrieu marked an inline comment as done. rtrieu added inline comments. Comment at: test/Sema/parentheses.c:148 + + (void)(x | b ? 1 : 2); // expected-warning {{operator '?:' has lower precedence than '|'}} expected-note 2{{place parentheses}} + (void)(x & b ? 1 : 2); // expect

Re: r367940 - [Sema] Add -Wpointer-compare

This seems a bit narrow - could it be generalized to all cases of '\0' as a null pointer? On Mon, Aug 5, 2019 at 3:14 PM George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date: Mon Aug 5 15:15:40 2019 > New Revision: 367940 > > URL: http://llvm.org/viewvc/ll

[PATCH] D66186: Fix warning on printf('%hd', [char])

Nathan-Huckleberry created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Nathan-Huckleberry added a reviewer: rsmith. Nathan-Huckleberry added a subscriber: nickdesaulniers. Link: https://bugs.llvm.org/show_bug.cgi?id=41467 Repository: rG LLVM Github Mon

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.h:372 + REQUIRES_DESTRUCTION = 0x4, }; Does `llvm::Value*` actually guarantee three bits? Presumably on 64-bit platforms, but we do support 32-bit hosts. Fortunately, I don't actu

[PATCH] D66186: Fix warning on printf('%hd', [char])

Nathan-Huckleberry updated this revision to Diff 214966. Nathan-Huckleberry added a comment. - Add comment in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm.org/D66186 Files: clang/lib/AST/FormatString.cpp c

r368771 - [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Author: szelethus Date: Tue Aug 13 16:22:33 2019 New Revision: 368771 URL: http://llvm.org/viewvc/llvm-project?rev=368771&view=rev Log: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value During the evaluation of D62883, I noticed a bunch of totally mean

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

This revision was automatically updated to reflect the committed changes. Szelethus marked 5 inline comments as done. Closed by commit rL368771: [analyzer] Prune calls to functions with linear CFGs that return a non-zero… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald

[PATCH] D65349: [analyzer] Be more careful with destructors of non-regions.

NoQ updated this revision to Diff 214972. NoQ marked 2 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65349/new/ https://reviews.llvm.org/D65349 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h clang/lib/Sta

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

dyung added a comment. Taking a step back and thinking about this, the compile command uses "-S", but explicitly specifies the output file to be "%t/module.pcm.o" (even though it is generating an assembly file instead of an object file), could we change the test to just check for "-o {{.*}}modu

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

erik.pilkington updated this revision to Diff 214977. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27165/new/ https://reviews.llvm.org/D27165 Files: clang/include/clang/AST/FormatString.h clang/include/clang/Basic/Identifie

r368773 - [analyzer] Track the right hand side of the last store regardless of its value

Author: szelethus Date: Tue Aug 13 16:48:10 2019 New Revision: 368773 URL: http://llvm.org/viewvc/llvm-project?rev=368773&view=rev Log: [analyzer] Track the right hand side of the last store regardless of its value Summary: The following code snippet taken from D64271#1572188 has an issue: namely

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

This revision was automatically updated to reflect the committed changes. Szelethus marked 2 inline comments as done. Closed by commit rG0df9c8c57802: [analyzer] Track the right hand side of the last store regardless of its value (authored by Szelethus). Changed prior to commit: https://reviews

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders marked an inline comment as done. dsanders added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:26 void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { +using readability::NamespaceCommentCheck; + --

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. One minor request (which will be dead code in your patch), but otherwise LGTM. Comment at: clang/include/clang/Basic/IdentifierTable.h:754 + /// If this selector is the

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1750 + // [B1] -> [B2] -> [B3] -> [sink] + // assert(A && B || C);\ \ \ + // ---> [go on with the executi

[PATCH] D66131: [analyzer] Don't track the condition of foreach loops

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Do it! 8) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66131/new/ https://reviews.llvm.org/D66131 ___

r368777 - [analyzer][NFC] Prepare visitors for different tracking kinds

Author: szelethus Date: Tue Aug 13 17:48:57 2019 New Revision: 368777 URL: http://llvm.org/viewvc/llvm-project?rev=368777&view=rev Log: [analyzer][NFC] Prepare visitors for different tracking kinds When we're tracking a variable that is responsible for a null pointer dereference or some other sin

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Szelethus added a comment. If you have no major objections, could you please accept formally? :) And I'll promise to draw CFG graphs all day tomorrow as an exercise after reading the order of operator evaluation rules >.< CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65287/new/ https:

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

This revision was automatically updated to reflect the committed changes. Closed by commit rL368777: [analyzer][NFC] Prepare visitors for different tracking kinds (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Wish granted! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65287/new/ https://reviews.llvm.org/D65287 ___ cfe-commits mailing list cfe-commit

[PATCH] D66192: [analyzer] Don't delete TaintConfig copy constructor

xiaobai created this revision. xiaobai added reviewers: compnerd, Szelethus, boga95, NoQ, alexshap. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Explicitly deleting the copy constructor ma

[PATCH] D66192: [analyzer] Don't delete TaintConfig copy constructor

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This really shouldn't matter much. Go for it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66192/new/ https://reviews.llvm.org/D66192

r368778 - [ORC] Fix clang-interpreter example code broken by r368707.

Author: dyung Date: Tue Aug 13 18:03:35 2019 New Revision: 368778 URL: http://llvm.org/viewvc/llvm-project?rev=368778&view=rev Log: [ORC] Fix clang-interpreter example code broken by r368707. Modified: cfe/trunk/examples/clang-interpreter/main.cpp Modified: cfe/trunk/examples/clang-interpret

[PATCH] D66192: [analyzer] Don't delete TaintConfig copy constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL368779: [analyzer] Don't delete TaintConfig copy constructor (authored by xiaobai, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D66192?vs=214998&id=214

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ abandoned this revision. NoQ added a comment. Merged into D64274 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ updated this revision to Diff 215000. NoQ added a comment. I'll merge D65180 into this patch because it's otherwise too painful to update. Like, D65180 untangles bug types and controls enabledness by initializing bug types,

[PATCH] D66045: Improve detection of same value in comparisons

rtrieu updated this revision to Diff 215002. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66045/new/ https://reviews.llvm.org/D66045 Files: include/clang/AST/Expr.h lib/AST/Expr.cpp lib/Analysis/CFG.cpp lib/Sema/SemaExpr.cpp test/Analysis/array-struct-region.cpp test/Sema/wa

Re: r368739 - Don't use std::errc

>From the review: This is for gcc 4.8 compat, not for the other reasons mentioned in the CL description. On Tue, Aug 13, 2019 at 3:31 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev > Date: Tue Aug 13 12:32:36 2019 > New Revision: 368739 > > URL: http://llv

[PATCH] D66045: Improve detection of same value in comparisons

rtrieu marked an inline comment as done. rtrieu added inline comments. Comment at: test/SemaCXX/self-comparison.cpp:87 +}; +} // namespace member_tests jfb wrote: > rtrieu wrote: > > rtrieu wrote: > > > jfb wrote: > > > > The test only has `==`. Do other operator

[PATCH] D66143: Don't use std::errc

thakis added a comment. FWIW it looks like 4.8 support is going away in days, not weeks, see D66188 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143

Re: r368739 - Don't use std::errc

Sorry, forgot to change the description. Been busy switching to the newer version of the compiler. Best regards, Alexey Bataev 13 авг. 2019 г., в 21:32, Nico Weber mailto:tha...@chromium.org>> написал(а): From the review: This is for gcc 4.8 compat, not for the other reasons mentioned in the

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ updated this revision to Diff 215007. NoQ added a comment. Make the checkers independent and extract modeling into a dependency. This means that you can potentially enable the non-pure-virtual call checker without enabling the pure virtual call checker. This doesn't contradict backwards com

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 215011. NoQ added a comment. Rebase! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/ https://reviews.llvm.org/D65182 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def

r368785 - Add __has_builtin support for builtin function-like type traits.

Author: rsmith Date: Tue Aug 13 19:30:11 2019 New Revision: 368785 URL: http://llvm.org/viewvc/llvm-project?rev=368785&view=rev Log: Add __has_builtin support for builtin function-like type traits. Summary: Previously __has_builtin(__builtin_*) would return false for __builtin_*s that we modeled

[PATCH] D66100: Add __has_builtin support for builtin function-like type traits.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368785: Add __has_builtin support for builtin function-like type traits. (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions

rtrieu updated this revision to Diff 215021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66044/new/ https://reviews.llvm.org/D66044 Files: lib/Analysis/CFG.cpp lib/Analysis/ReachableCode.cpp test/Analysis/cfg.cpp test/Sema/warn-overlap.c test/Sema/warn-unreachable.c test/Se

[PATCH] D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions

rtrieu marked an inline comment as done. rtrieu added a comment. In D66044#1626008 , @NoQ wrote: > Looks great, thanks! I'd appreciate direct CFG tests for the part that > changes the CFG (cf. `test/Analysis/cfg.cpp`), but i don't insist. Let's make > su

r368796 - Remove unreachable blocks before splitting a coroutine.

Author: rjmccall Date: Tue Aug 13 20:54:13 2019 New Revision: 368796 URL: http://llvm.org/viewvc/llvm-project?rev=368796&view=rev Log: Remove unreachable blocks before splitting a coroutine. The suspend-crossing algorithm is not correct in the presence of uses that cannot be reached on some succe

[PATCH] D66068: cmake: Make building clang-shlib optional

jvesely added a comment. In D66068#1627706 , @beanz wrote: > I want to dissect this a bit. > > In D66068#1627451 , @E5ten wrote: > > > I am in favour of adding a user-facing option to disable generating this > > du

[PATCH] D66045: Improve detection of same value in comparisons

jfb added inline comments. Comment at: test/SemaCXX/self-comparison.cpp:87 +}; +} // namespace member_tests rtrieu wrote: > jfb wrote: > > rtrieu wrote: > > > rtrieu wrote: > > > > jfb wrote: > > > > > The test only has `==`. Do other operators trigger? > > > > A

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

arsenm created this revision. arsenm added reviewers: rampitec, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. arsenm added a parent revision: D66197: AMDGPU: Add intrinsics for address space identification. https://reviews.llvm.org/D66198

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: fhahn, Meinersbur, dorit, hsaito. Following our discussion on the cfe dev list (http://lists.llvm.org/pipermail/cfe-dev/2019-August/063054.html), I have added a paragraph that is explicit about transformation options implying the co

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65975/new/ https://reviews.llvm.org/D65975

<    1   2   3