[PATCH] D66068: cmake: Make building clang-shlib optional

beanz added a comment. In D66068#1626266 , @jvesely wrote: > That's your workflow. I need to run 'make install' because the modifications > are used by an external project. If there's an option to skip shlib during > 'make install' I'd be happy to use it

r368725 - [NFC] Updated tests after r368724

Author: xbolva00 Date: Tue Aug 13 10:19:16 2019 New Revision: 368725 URL: http://llvm.org/viewvc/llvm-project?rev=368725&view=rev Log: [NFC] Updated tests after r368724 Modified: cfe/trunk/test/CodeGen/tbaa-struct.cpp Modified: cfe/trunk/test/CodeGen/tbaa-struct.cpp URL: http://llvm.org/vie

[PATCH] D66068: cmake: Make building clang-shlib optional

E5ten added a comment. I am in favour of adding a user-facing option to disable generating this duplicate library for users that don't need it, like @jvesely says, there should be an option to disable linking a library that takes a long time to link and isn't necessary for a lot of users. Rep

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Bitcode writer was not emitting the corresponding record for the Access attribute of a FunctionInfo. This is added and corresponding test is incl

[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, mgehre. Herald added subscribers: Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

xiaobai added inline comments. Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:74 +TaintConfiguration() = default; +TaintConfiguration(const TaintConfiguration &) = delete; +TaintConfiguration(TaintConfiguration &&) = default; ---

[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7130 -bool IsGslPtrInitWithGslTempOwner = -IsTempGslOwner && pathOnlyInitializesGslPointer(Path); +bool IsGslPtrInitWithGslTempOwner = false; +

r368728 - clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are off.

Author: nico Date: Tue Aug 13 10:37:09 2019 New Revision: 368728 URL: http://llvm.org/viewvc/llvm-project?rev=368728&view=rev Log: clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are off. This fixes a regression from r365860: As that commit message states, there are 3 va

[PATCH] D66142: clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are off.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368728: clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are… (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D65878: [Refactor] Moving SourceExtraction header from lib to include

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65878/new/ https://reviews.llvm.org/D65878 ___

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.h:406 + CGBuilderTy &Builder, + const ObjCContainerDecl *CD = nullptr); rjmccall wrote: > Why does

[PATCH] D66143: Don't use std::errc

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Should we revert the change in lld then? LLVM has a global policy for this; if 4.8 is still supported then regex can't be used yet. Please mention in the commit message that this is a workarou

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214884. jcai19 added a comment. Mark LR as live-in at (t)BL_PUSHLR instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

Szelethus added a comment. Apologies for going off-topic, but would it make sense to start lifetime related patches with the tag [LifetimeAnalysis] or similar (like [analyzer] for static analyzer patches)? I dont feel knowledgable enough to participate, but would gladly add a herald rule to be

r368732 - [clang] Refactor doc comments to Decls attribution

Author: jkorous Date: Tue Aug 13 11:11:44 2019 New Revision: 368732 URL: http://llvm.org/viewvc/llvm-project?rev=368732&view=rev Log: [clang] Refactor doc comments to Decls attribution - Create ASTContext::attachCommentsToJustParsedDecls so we don't have to load external comments in Sema when tr

[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

xazax.hun added a comment. In D66152#1627572 , @Szelethus wrote: > Apologies for going off-topic, but would it make sense to start lifetime > related patches with the tag [LifetimeAnalysis] or similar (like [analyzer] > for static analyzer patches)? I do

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked 4 inline comments as done. jcai19 added inline comments. Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1927 +.add(predOps(ARMCC::AL)) +.addReg(ARM::LR); + efriedma wrote: > I think you need to ensure that lr actual

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added a comment. I see. Is the deduction rule recursive or something, where a pointer to pointer is inferred to point to the same address space as the pointee? I still don't understand why pointers and references are handled differently here, instead of having the rule be "don't infe

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.h:406 + CGBuilderTy &Builder, + const ObjCContainerDecl *CD = nullptr); aprantl wrote: > rjmccall wrote: > > Why does this have to be an ex

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214889. jcai19 added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Basic/Targets/ARM.cpp llvm/include/llvm/IR/IntrinsicsAR

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. In D65819#1627036 , @ABataev wrote: > In D65819#1627032 , @Hahnfeld wrote: > > > In D65819#1617736 , @Hahnfeld > > wrote: > > > > > Will this patch

[PATCH] D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}

gribozavr created this revision. gribozavr added a reviewer: jkorous. Herald added subscribers: cfe-commits, arphaman, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66156 Files: clang/tools/libclang/CXIndexDataConsumer.cpp clang/to

r368734 - [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

Author: zer0 Date: Tue Aug 13 11:42:03 2019 New Revision: 368734 URL: http://llvm.org/viewvc/llvm-project?rev=368734&view=rev Log: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases This patch removes usage of FinalPhase from anywhere outside of the scope where it is

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added inline comments. Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:541-549 std::vector ClangArgs = {"clang", -"-r", +"-c", "-

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

This revision was automatically updated to reflect the committed changes. Closed by commit rL368734: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1010 + StringRef Str = PragmaName.getIdentifierInfo()->getName(); + StringRef ClangLoopStr = "clang loop " + Str.str(); + Str = llvm::StringSwitch(Str) [serious] Use-after-free here

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev marked an inline comment as done. ABataev added a comment. In D65819#1627600 , @Hahnfeld wrote: > In D65819#1627036 , @ABataev wrote: > > > In D65819#1627032 , @Hahnf

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Driver.h:264 + const InputList &Inputs, ActionList &Actions, + llvm::opt::Arg *YcArg, llvm::opt::Arg *YuArg) const; +

r368735 - [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

Author: szelethus Date: Tue Aug 13 11:48:08 2019 New Revision: 368735 URL: http://llvm.org/viewvc/llvm-project?rev=368735&view=rev Log: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const When I'm new to a file/codebase, I personally find C++'s strong static type s

[PATCH] D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

This revision was automatically updated to reflect the committed changes. Closed by commit rL368735: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. In D65819#1627620 , @ABataev wrote: > In D65819#1627600 , @Hahnfeld wrote: > > > In D65819#1627036 , @ABataev wrote: > > > > > In D65819#1627032

r368737 - [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

Author: szelethus Date: Tue Aug 13 12:01:33 2019 New Revision: 368737 URL: http://llvm.org/viewvc/llvm-project?rev=368737&view=rev Log: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects In D65379, I briefly described the construction of bug path

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev marked an inline comment as done. ABataev added a comment. In D65819#1627631 , @Hahnfeld wrote: > In D65819#1627620 , @ABataev wrote: > > > In D65819#1627600 , @Hahnf

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi updated this revision to Diff 214894. plotfi added a comment. Moved the initialization of YcArg and YuArg and initial handling of those args into handleArguments. ninja check-clang passes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://r

[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

This revision was automatically updated to reflect the committed changes. Closed by commit rL368737: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r368738 - Revert "Fix crash on switch conditions of non-integer types in templates"

Author: gribozavr Date: Tue Aug 13 12:07:28 2019 New Revision: 368738 URL: http://llvm.org/viewvc/llvm-project?rev=368738&view=rev Log: Revert "Fix crash on switch conditions of non-integer types in templates" This reverts commit r368706. It broke ClangTidy tests. Removed: cfe/trunk/test/Sem

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi updated this revision to Diff 214897. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp =

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Driver.h:264 + const InputList &Inputs, ActionList &Actions, + llvm::opt::Arg *YcArg, llvm::opt::Arg *YuArg) const; +

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi updated this revision to Diff 214896. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp =

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

gribozavr added a comment. Sorry, but this change broke ClangTidy tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16398. I reverted it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 _

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi added a comment. @aaron.ballman Good catch on the /Yc /Yu args. I like the way its looking a lot more now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 ___ cfe-comm

[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Oh, crap, forgot to address inlines. I'll see how buildbots react to these changes and will follow up in a smaller patch. Reopening as a reminder. Repository: rL LLVM CHANGES SINCE L

Re: r368354 - Mark clang-scan-deps test as requiring thread support

Thanks! On Mon, Aug 12, 2019 at 5:37 PM Alex L wrote: > Hi Reid, > > I have fixed this issue in r368640, clang-scan-deps will no longer spawn > threads if threading if disabled. > > Cheers, > Alex > > > On Thu, 8 Aug 2019 at 15:13, Alex L wrote: > >> Thanks for fixing this! >> >> I think changi

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. In D61027#1627655 , @gribozavr wrote: > Sorry, but this change broke ClangTidy tests: > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16398. I > reverted it. Yes I've been trying to reproduce it locally. Co

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

fhahn accepted this revision. fhahn added reviewers: hfinkel, reames. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Please wait a few days with committing, in case any additional comments come in via the mailing list. CHANGES SINCE LAST ACTION https://r

r368739 - Don't use std::errc

Author: abataev Date: Tue Aug 13 12:32:36 2019 New Revision: 368739 URL: http://llvm.org/viewvc/llvm-project?rev=368739&view=rev Log: Don't use std::errc Summary: As noted on Errc.h: // * std::errc is just marked with is_error_condition_enum. This means that // common patters like AnErrorCode

[PATCH] D66143: Don't use std::errc

This revision was automatically updated to reflect the committed changes. Closed by commit rL368739: Don't use std::errc (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. In D65819#1627638 , @ABataev wrote: > In D65819#1627631 , @Hahnfeld wrote: > > > In D65819#1627620 , @ABataev wrote: > > > > > In D65819#1627600

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. In D65819#1627693 , @Hahnfeld wrote: > In D65819#1627638 , @ABataev wrote: > > > In D65819#1627631 , @Hahnfeld > > wrote: > > > > > In D65819#162762

[PATCH] D66068: cmake: Make building clang-shlib optional

beanz added a comment. I want to dissect this a bit. In D66068#1627451 , @E5ten wrote: > I am in favour of adding a user-facing option to disable generating this > duplicate library for users that don't need it Why do you call this duplicate? It is uni

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added a comment. In D66042#1627193 , @alexfh wrote: > Should this be different with clang and this patch? Nope. Moreover, this patch in fact introduces the same problem in scan-build :) In D66042#1627193 , @a

r368743 - [Refactor] Moving SourceExtraction header from lib to include

Author: sureyeaah Date: Tue Aug 13 13:21:00 2019 New Revision: 368743 URL: http://llvm.org/viewvc/llvm-project?rev=368743&view=rev Log: [Refactor] Moving SourceExtraction header from lib to include Summary: - Moved the SourceExtraction header from lib to include so that it can be used in clangd.

[PATCH] D65878: [Refactor] Moving SourceExtraction header from lib to include

This revision was automatically updated to reflect the committed changes. Closed by commit rL368743: [Refactor] Moving SourceExtraction header from lib to include (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added a comment. In D66042#1626631 , @Szelethus wrote: > In D66042#1626513 , @Charusso wrote: > > > I really appreacite your ideas. It is unbelievable you guys bring up 20 > > different ideas for 5 LOC. I canno

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

riccibruno added a comment. I think that you have to run `check-clang-tools`. I too was surprised that it was not included in `check-clang`. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 __

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Szelethus added a comment. In D66042#1627765 , @NoQ wrote: > In D66042#1626631 , @Szelethus wrote: > > > In D66042#1626513 , @Charusso > > wrote: > > > > > I really appreaci

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1931 + +// bl__gnu_mcount_nc +MIB = BuildMI(MBB, MBBI, MI.getDebugLoc(), TII->get(ARM::tBL)); should there be a space in this comment (and the one on l

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Szelethus added a comment. We might also want to change the revision title, but the commit message for sure, to make it clear that this affects all checkers, something along the lines of "[analyzer] Add an analyzer config to silence diagnostics from user specified checkers/packages" CHANGES S

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

gribozavr added a comment. Like @riccibruno said, `check-clang-tools` will run them. However, before committing a patch, please run `check-all` -- you never know what your patch can affect. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews

r368745 - [analyzer][NFC] Address inlines of D65484

Author: szelethus Date: Tue Aug 13 13:42:48 2019 New Revision: 368745 URL: http://llvm.org/viewvc/llvm-project?rev=368745&view=rev Log: [analyzer][NFC] Address inlines of D65484 Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporte

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214908. jcai19 added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Basic/Targets/ARM.cpp llvm/include/llvm/IR/IntrinsicsARM

[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

Szelethus closed this revision. Szelethus marked 5 inline comments as done. Szelethus added a comment. The deed is done. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:111 +/// getters and some well placed asserts for extra security. +class BugReportConstruct { + //

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1931 + +// bl__gnu_mcount_nc +MIB = BuildMI(MBB, MBBI, MI.getDebugLoc(), TII->get(ARM::tBL)); nickdesaulniers wrote: >

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

Szelethus added a comment. In D61027#1627785 , @gribozavr wrote: > Like @riccibruno said, `check-clang-tools` will run them. However, before > committing a patch, please run `check-all` -- you never know what your patch > can affect. And also you'll ne

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:94-98 + // If cast is implicit LValueToRValue, no conversion is taking place, + // and theref

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1922 + const bool Thumb = Opcode == ARM::tBL_PUSHLR; + MachineOperand ReturnAddr = MI.getOperand(0); + assert(ReturnAddr.getReg() == ARM::LR && "expect LR register!"); -

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added a comment. In D66042#162 , @Szelethus wrote: > Yup. We will be able to present the drastic improvement made on LLVM > analyses, while giving us some breathing room to polish a long-term solution. > I suspect `-analyzer-config silence-checke

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.h:406 + CGBuilderTy &Builder, + const ObjCContainerDecl *CD = nullptr); rjmccall wrote: > aprantl

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso added a comment. Any analyzer config flag is equally accessible to anyone as the driver flags as they are both flags. The only difference is the config flags are more code to implement, and a lot more difficult to use. @NoQ, why the hell would we pick another type of flag which makes z

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

mgehre created this revision. mgehre added a reviewer: gribozavr. Herald added a project: clang. Diagnose dangling pointers that come from std::stack::top() and std::optional::value(). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66164 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus accepted this revision. Szelethus added a comment. LGTM, thanks! Do you need someone to commit this on your behalf? Also, could you please make the comments capitalized, terminated, and fitting in 80 columns? Comment at: clang/test/Analysis/enum-cast-out-of-range.c:1

[PATCH] D66168: [WebAssembly] Make clang emit correct va_arg code for structs

quantum created this revision. quantum added reviewers: tlively, sbc100, kripken, aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, dschuff. Herald added a project: clang. In the WebAssembly backend, when lowering variadic function calls, non-single member aggregate type a

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LG! But let's wait for Dmitri :) Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:172 T &operator*(); + T &value();

[PATCH] D66168: [WebAssembly] Make clang emit correct va_arg code for structs

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. LGTM. Nice that we had a test which tested the wrong thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66168/new/ https://reviews.llvm.org/

r368748 - Remove the extra `;`.

Author: hliao Date: Tue Aug 13 14:26:42 2019 New Revision: 368748 URL: http://llvm.org/viewvc/llvm-project?rev=368748&view=rev Log: Remove the extra `;`. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugR

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added a comment. In D66042#1627842 , @Charusso wrote: > @Szelethus, here is a really cool example: > https://clang.llvm.org/docs/ClangCommandLineReference.html. These are driver flags. They are indeed well-documented and user-facing. Frontend flags

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.h:406 + CGBuilderTy &Builder, + const ObjCContainerDecl *CD = nullptr); aprantl wrote: > rjmccall wrote: > > aprantl wrote: > > > rjmccall

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. Sorry, should have done my std::string, StringRef, and Twine homework a lot better! Thanks for your help and suggestions, will fix this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 __

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran updated this revision to Diff 214923. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Default value of AccessSpecifier attributes is now AS_public. Multiple tests modified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66151/new/ htt

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. Thanks for your help! And I will wait a few days. After this, I will look at that PR, will have a look at diagnostics, and then at the LLVM side of things. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65776/new/ https://reviews.llvm.org/D65776 ___

r368750 - [WebAssembly] Make clang emit correct va_arg code for structs

Author: quantum Date: Tue Aug 13 14:41:11 2019 New Revision: 368750 URL: http://llvm.org/viewvc/llvm-project?rev=368750&view=rev Log: [WebAssembly] Make clang emit correct va_arg code for structs Summary: In the WebAssembly backend, when lowering variadic function calls, non-single member aggrega

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

erik.pilkington commandeered this revision. erik.pilkington added a reviewer: arphaman. erik.pilkington added a comment. Herald added subscribers: dexonsmith, jkorous. Herald added a project: LLVM. Stealing this (with Alex's permission). I think it makes more sense to add a special case for the m

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Szelethus added a comment. In D66042#1627842 , @Charusso wrote: > Any analyzer config flag is equally accessible to anyone as the driver flags > as they are both flags. The only difference is the config flags are more code > to implement, and a lot more

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 214924. plotfi edited the summary of this revision. plotfi added a comment. Herald added a subscriber: mgorny. Updated. Much better cleaner implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

erik.pilkington updated this revision to Diff 214925. erik.pilkington added a comment. Special case localizedStringForKey instead of using an attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27165/new/ https://reviews.llvm.org/D27165 Files: clang/include/clang/AST/FormatStrin

[PATCH] D66168: [WebAssembly] Make clang emit correct va_arg code for structs

This revision was automatically updated to reflect the committed changes. Closed by commit rL368750: [WebAssembly] Make clang emit correct va_arg code for structs (authored by quantum, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D66173 Files: test/CodeGen/struct-copy.c Index: test/CodeGen/struct-copy.c ==

r368752 - [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of interestingness propagation

Author: szelethus Date: Tue Aug 13 14:48:17 2019 New Revision: 368752 URL: http://llvm.org/viewvc/llvm-project?rev=368752&view=rev Log: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of interestingness propagation Apparently this does literally nothing. When you think about

[PATCH] D65487: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of interestingness propagation

This revision was automatically updated to reflect the committed changes. Closed by commit rL368752: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd added a comment. Tests? Comment at: clang/lib/Driver/Driver.cpp:3420 + // Add a link action if necessary. + if (!MergerInputs.empty()) { This isn't really a link action ... Comment at: clang/lib/Driver/Driver.cpp:3423 +Action

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added a comment. I'm convinced, let's keep everything as is but turn this into an `-analyzer-config` flag. We generally wanted to reduce the number of frontend flags because they are more taxing on backwards compatibility, so it makes perfect sense. CHANGES SINCE LAST ACTION https://rev

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

rjmccall added a comment. I agree with just special-casing this for now. Comment at: clang/lib/Sema/SemaChecking.cpp:6800 +MD->getSelector() == +S.NSAPIObj->getLocalizedStringForKeySelector()) { + IgnoreStringsWithoutSpecifiers = true; -

[PATCH] D66173: [Codegen] Updated test for D66158

jdoerfert added a comment. Might not be the best test given that this should arguably be a memset not a memcpy. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 ___ cfe-commit

[PATCH] D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}

jkorous added a reviewer: akyrtzi. jkorous added a subscriber: akyrtzi. jkorous added a comment. LGTM but let's wait for @akyrtzi to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66156/new/ https://reviews.llvm.org/D66156 __

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

compnerd added a comment. Ugh, this is still not the most structured handling of the arguments. But, yeah, this seems like it should be equivalent. Fine by me if @aaron.ballman has no more comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ htt

r368754 - Add a missing header comment, NFC

Author: epilk Date: Tue Aug 13 15:01:39 2019 New Revision: 368754 URL: http://llvm.org/viewvc/llvm-project?rev=368754&view=rev Log: Add a missing header comment, NFC Modified: cfe/trunk/lib/AST/FormatStringParsing.h Modified: cfe/trunk/lib/AST/FormatStringParsing.h URL: http://llvm.org/view

r368755 - [analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces

Author: szelethus Date: Tue Aug 13 15:03:08 2019 New Revision: 368755 URL: http://llvm.org/viewvc/llvm-project?rev=368755&view=rev Log: [analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces I feel this is kinda important, because in a followup

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6583 .Cases("end", "rend", "cend", "crend", true) -.Cases("c_str", "data", "get", true) +.Cases("c_str", "data", "get", "value", true) // Map and set types.

[PATCH] D65578: [analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces

This revision was automatically updated to reflect the committed changes. Closed by commit rL368755: [analyzer][NFC] Make sure that the BugReport is not modified during the… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 added a comment. hm.. memset? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

<    1   2   3   >