[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske updated this revision to Diff 214772. balazske added a comment. - Moved SVEBuiltins test instantiation to non-different position. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65999/new/ https://reviews.llvm.org/D65999 Files: clang/lib/

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5373 +INSTANTIATE_TEST_CASE_P(ParameterizedTests, SVEBuiltins, +::testing::Values(ArgVector{"-target", a_sidor

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214774. jvikstrom added a comment. Rebased into master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-tools-extra/clangd/clients/clangd-vscode/src/se

r368655 - [ASTImporter] Import additional flags for functions.

Author: balazske Date: Tue Aug 13 01:04:06 2019 New Revision: 368655 URL: http://llvm.org/viewvc/llvm-project?rev=368655&view=rev Log: [ASTImporter] Import additional flags for functions. Summary: At AST import of function delcarations import the flags for defaulted and deleted. Reviewers: marto

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

This revision was automatically updated to reflect the committed changes. balazske marked an inline comment as done. Closed by commit rL368655: [ASTImporter] Import additional flags for functions. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214778. jvikstrom added a comment. Updated to use string[][] as scopes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-tools-extra/clangd/clients/clan

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214779. jvikstrom added a comment. Updated patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-tools-extra/clangd/clients/clangd-vscode/

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Szelethus added a comment. Too bad we're in different time zones, I can only respond in a giant comment, but I wouldn't want to make anyone feel left out :) The conclusion to my responses is this: - I recently sent out a mail to cfe-dev (I hope to have added your correct email adresses!) that

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. In D65591#1625744 , @aaron.ballman wrote: > The problem is: those bits are not infinite and we only have a handful left > until bumping the allocation size; is this use case critical enough to use > one of those bits? I do

r368658 - [NFC] Updated tests after r368657

Author: xbolva00 Date: Tue Aug 13 02:12:07 2019 New Revision: 368658 URL: http://llvm.org/viewvc/llvm-project?rev=368658&view=rev Log: [NFC] Updated tests after r368657 Modified: cfe/trunk/test/CodeGen/tbaa-struct.cpp cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/C

[PATCH] D66131: [analyzer] Don't track the condition of foreach loops

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, dcoughlin, rnkovacs, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. As discussed on t

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

hokein added a comment. I think we could make the layering clearer: - we now have a list of theme color rules, and scope names provided by clangd; and we we want to find the best match theme rule for a particular clangd scope; - we could define a function like `getBestThemeRule(clangd_scope_name

[PATCH] D66136: Remove no-op callbacks from TemplateInstantiationCallback

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is not clear to me that these callbacks ever did anything, they were empty even in the original implementation (r324808). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

hans added a comment. In D64672#1623784 , @xbolva00 wrote: > Maybe this ABI issue should be fixed for 9.0 ? Not sure how important, but > @hans maybe should track this one. IIUC, this is not a new issue, so I'd prefer not trying to rush it in for llvm

[PATCH] D66137: [OpenCL][PR42385] Improve addr space deduction for pointers/references to arrays

Anastasia created this revision. Anastasia added reviewers: svenvh, rjmccall. Herald added subscribers: ebevhan, yaxunl. Anastasia retitled this revision from "[OpenCL][PR42385]Improve addr space deduction for pointers/references to arrays" to "[OpenCL][PR42385] Improve addr space deduction for p

Re: [clang-tools-extra] r366541 - [clangd] cleanup: unify the implemenation of checking a location is inside main file.

Merged to release_90 in r368669 to help subsequent merges. On Fri, Jul 19, 2019 at 10:33 AM Haojian Wu via cfe-commits wrote: > > Author: hokein > Date: Fri Jul 19 01:33:39 2019 > New Revision: 366541 > > URL: http://llvm.org/viewvc/llvm-project?rev=366541&view=rev > Log: > [clangd] cleanup: unif

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hans added a comment. In D66074#1624885 , @hokein wrote: > @hans is there still any chance to merge this patch into the release? I tried to merge this to release_90, but I got a test failure. Does this rely on more patches that need merging? Can you try

Re: [clang-tools-extra] r368581 - [clangd] Separate chunks with a space when rendering markdown

Sure, merged in r368670. On Mon, Aug 12, 2019 at 5:12 PM Ilya Biryukov wrote: > > +Hans Wennborg, could we merge this into the release? > > On Mon, Aug 12, 2019 at 4:34 PM Ilya Biryukov via cfe-commits > wrote: >> >> Author: ibiryukov >> Date: Mon Aug 12 07:35:30 2019 >> New Revision: 368581 >>

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added a comment. In D65744#1626563 , @rjmccall wrote: > Isn't the general rule for template argument deduction (which this devolves > to) just to ignore top-level qualifiers? And then you can substitute in the > substituted type and end up wit

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein added a comment. In D66074#1626856 , @hans wrote: > In D66074#1624885 , @hokein wrote: > > > @hans is there still any chance to merge this patch into the release? > > > I tried to merge this to release_90, bu

r368675 - [CodeGen] Disable UBSan for coroutine functions

Author: modocache Date: Tue Aug 13 05:02:25 2019 New Revision: 368675 URL: http://llvm.org/viewvc/llvm-project?rev=368675&view=rev Log: [CodeGen] Disable UBSan for coroutine functions Summary: As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html, the LLVM coroutines tra

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368675: [CodeGen] Disable UBSan for coroutine functions (authored by modocache, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache added a comment. Thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44672/new/ https://reviews.llvm.org/D44672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

chrish_ericsson_atx marked an inline comment as done. chrish_ericsson_atx added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:94-98 + // If cast is implicit LValueToRValue, no conversion is taking place, + // and therefore no rang

r368681 - [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

Author: ymandel Date: Tue Aug 13 05:31:29 2019 New Revision: 368681 URL: http://llvm.org/viewvc/llvm-project?rev=368681&view=rev Log: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers. Summary: This patch removes an (artificial) limitation of `applyFi

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rL368681: [libTooling] In Transformer, generalize `applyFirst` to admit rules with… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214813. jvikstrom added a comment. Lazy load the best theme rule for a scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-tools-extra/clangd/client

Re: [clang-tools-extra] r367303 - [clangd] Ignore diags from builtin files

Merged to release_90 in r368682. On Tue, Jul 30, 2019 at 12:26 PM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Tue Jul 30 03:26:51 2019 > New Revision: 367303 > > URL: http://llvm.org/viewvc/llvm-project?rev=367303&view=rev > Log: > [clangd] Ignore diags from builtin files

Re: [clang-tools-extra] r368549 - [clangd] Drop diags from non-written #include.

Merged to release_90 in r368683. On Mon, Aug 12, 2019 at 11:34 AM Haojian Wu via cfe-commits wrote: > > Author: hokein > Date: Mon Aug 12 02:35:04 2019 > New Revision: 368549 > > URL: http://llvm.org/viewvc/llvm-project?rev=368549&view=rev > Log: > [clangd] Drop diags from non-written #include. >

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214814. jvikstrom added a comment. Added a missing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-tools-extra/clangd/clients/clangd-vscode/

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hans added a comment. > thanks for the information, I suspect that this patch may depend on rL367303 > (which is not merged in the release), I > will double check. Yes, that seems to be it. I've merged that, and then I could merge this one in r368683. Repo

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:26 void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { +using readability::NamespaceCommentCheck; + I would rather use the fully-qu

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein added a comment. In D66074#1626932 , @hans wrote: > > thanks for the information, I suspect that this patch may depend on > > rL367303 (which is not merged in the > > release), I will double check. > > Yes, that

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

dkrupp marked 3 inline comments as done. dkrupp added a comment. Thanks for the comments @NoQ , all of them addressed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66049/new/ https://reviews.llvm.org/D66049 ___ cfe-

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

dkrupp updated this revision to Diff 214817. dkrupp added a comment. Fix comments from @NoQ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66049/new/ https://reviews.llvm.org/D66049 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-strin

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

aaron.ballman added a comment. In D65591#1626638 , @ilya-biryukov wrote: > In D65591#1625744 , @aaron.ballman > wrote: > > > The problem is: those bits are not infinite and we only have a handful left > > until b

r368689 - [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting symbols/regions in a simple set

Author: szelethus Date: Tue Aug 13 06:09:48 2019 New Revision: 368689 URL: http://llvm.org/viewvc/llvm-project?rev=368689&view=rev Log: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting symbols/regions in a simple set The goal of this refactoring effort was to better understand

[PATCH] D65378: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting symbols/regions in a simple set

This revision was automatically updated to reflect the committed changes. Closed by commit rL368689: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65997: Add options rounding and exceptions to pragma fp

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2697 PP.Lex(Tok); +StringRef ExpectedArgumentText; +switch (*FlagKind) { sepavloff wrote: > aaron.ballman wrote: > > Same here. > This case is different from the above,

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Driver.h:264 + const InputList &Inputs, ActionList &Actions, + llvm::opt::Arg *YcArg, llvm::opt::Arg *YuArg) const; + I think the presence of t

r368690 - [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

Author: hubert.reinterpretcast Date: Tue Aug 13 06:38:15 2019 New Revision: 368690 URL: http://llvm.org/viewvc/llvm-project?rev=368690&view=rev Log: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX Summary: Some tests perform deep recursion, which requires a larger pthread stack size than th

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rL368690: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL L

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:65 +const name = +vscode.workspace.getConfiguration('workbench').get('colorTheme'); +if (typeof name != 'string') { maybe just `

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

r368692 - Fix -Wdocumentation typo. NFCI.

Author: rksimon Date: Tue Aug 13 06:52:20 2019 New Revision: 368692 URL: http://llvm.org/viewvc/llvm-project?rev=368692&view=rev Log: Fix -Wdocumentation typo. NFCI. Modified: cfe/trunk/include/clang/CrossTU/CrossTranslationUnit.h Modified: cfe/trunk/include/clang/CrossTU/CrossTranslationUni

r368694 - [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report

Author: szelethus Date: Tue Aug 13 06:56:12 2019 New Revision: 368694 URL: http://llvm.org/viewvc/llvm-project?rev=368694&view=rev Log: [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report This patch refactors the utility functions an

[PATCH] D66136: Remove no-op callbacks from TemplateInstantiationCallback

xazax.hun added reviewers: Szelethus, sabel83. xazax.hun added a comment. The changes look good to me. Added some folks who might have more knowledge about the original purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66136/new/ https://revi

[PATCH] D65379: [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report

This revision was automatically updated to reflect the committed changes. Closed by commit rL368694: [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. In D65819#1617736 , @Hahnfeld wrote: > Will this patch change the ability to consume a bundled object file without > calling the unbundler? Using known ELF tools on the produced object files was > an important design decision an

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. In D65819#1627032 , @Hahnfeld wrote: > In D65819#1617736 , @Hahnfeld wrote: > > > Will this patch change the ability to consume a bundled object file without > > calling the unbundler? Usin

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. updated diff, implemented requested changes Comment at: clang/include/clang/Basic/LangOptions.def:291-294 +BENIGN_LANGOPT(EnableClangInterp, 1, 0, + "enable the experimental clang interpreter") +BENIGN_LANGOPT(ForceClangInterp, 1, 0, +

r368696 - [AArch64] Make the memtag sanitizer require the memtag extension

Author: chill Date: Tue Aug 13 07:20:06 2019 New Revision: 368696 URL: http://llvm.org/viewvc/llvm-project?rev=368696&view=rev Log: [AArch64] Make the memtag sanitizer require the memtag extension ... or otherwise we get an ICE. Differential Revision: https://reviews.llvm.org/D65508 Modified:

r368697 - Enable memtag sanitizer in all AArch64 toolchains

Author: chill Date: Tue Aug 13 07:20:23 2019 New Revision: 368697 URL: http://llvm.org/viewvc/llvm-project?rev=368697&view=rev Log: Enable memtag sanitizer in all AArch64 toolchains That sanitizer does not have runtime library or other dependencies. Differential Revision: https://reviews.llvm.or

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. The old path-based approach is slow for most operations, while the new pointer-based approach is fast for the most common ones. For read/write/update operations, it is enough to check the pointer and at most a single descriptor to ensure whether the operation can be perfo

[PATCH] D66136: Remove no-op callbacks from TemplateInstantiationCallback

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. They are used by Templight, which we are planning to eventually move to clang-tools extra, though our resources are a bit limited at the time :) https://github.com/mikael-s-per

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214833. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-tools-

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214834. jvikstrom added a comment. Removed stray edits from loadTheme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-tools-extra/clangd/clients/clang

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:131 +this.rules.forEach((rule) => { + if (rule.scope.length <= scope.length && + scope.substr(0, rule.scope.length) === rule.scope && --

[PATCH] D65879: [clang-tidy] Update `TransformerClangTidyCheck` to use new `buildMatchers` functionality.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368700: [clang-tidy] Update `TransformerClangTidyCheck` to use new `buildMatchers`… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[clang-tools-extra] r368700 - [clang-tidy] Update `TransformerClangTidyCheck` to use new `buildMatchers` functionality.

Author: ymandel Date: Tue Aug 13 07:48:13 2019 New Revision: 368700 URL: http://llvm.org/viewvc/llvm-project?rev=368700&view=rev Log: [clang-tidy] Update `TransformerClangTidyCheck` to use new `buildMatchers` functionality. Summary: `buildMatchers` is the new, more general way to extract the mat

[PATCH] D66142: clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are off.

thakis created this revision. thakis added a reviewer: hans. This fixes a regression from r365860: As that commit message states, there are 3 valid states targeted by the combination of -f(no-)omit-frame-pointer and -m(no-)omit-leaf-frame-pointer. After r365860 it's impossible to get from

[PATCH] D66143: Don't use std::errc

ABataev created this revision. ABataev added reviewers: thakis, rnk. Herald added a project: clang. As noted on Errc.h: // * std::errc is just marked with is_error_condition_enum. This means that // common patters like AnErrorCode == errc::no_such_file_or_directory take // 4 virtual calls ins

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:131 +this.rules.forEach((rule) => { + if (rule.scope.length <= scope.length && + scope.substr(0, rule.scope.length) === rule.scope && -

[PATCH] D66143: Don't use std::errc

thakis added a comment. This isn't in a hot codepath, so the virtual calls aren't super important. This not working in some libstdc++s is important of course, but llvm's Errc.h claims "std::error_code works OK on all platforms we use". I guess that's not true? Can you include more details on wh

[PATCH] D66143: Don't use std::errc

ABataev added a comment. In D66143#1627157 , @thakis wrote: > This isn't in a hot codepath, so the virtual calls aren't super important. > > This not working in some libstdc++s is important of course, but llvm's Errc.h > claims "std::error_code works OK o

[PATCH] D66143: Don't use std::errc

ABataev added a comment. `std::error_code` works correctly, it is `std::make_error_code` leads to something strange in some cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___

[PATCH] D66143: Don't use std::errc

thakis added a comment. That's Trusty and Trusty is on 4.8 which we no longer support, right? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-

[PATCH] D66143: Don't use std::errc

ABataev added a comment. In D66143#1627165 , @thakis wrote: > That's Trusty and Trusty is on 4.8 which we no longer support, right? It is still supported with some extra cmake flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D66143: Don't use std::errc

xbolva00 added a comment. GCC 4.8 is still supported Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D66143: Don't use std::errc

xbolva00 added a comment. This small change is okay anyway Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214844. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Changed variable name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang-t

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:128 + // Find the rule wich is the longest prefix of scope. + if (rule.scope.length <= scope.length && + scope.substr(0, rule.scope.length)

[PATCH] D66143: Don't use std::errc

ABataev added a comment. Also, there is a clang unit test that fails because of the same reason. Can I include the changes in this test into this patch too or better to make a separate patch? The test is `unittests/Basic/FileManagerTest.cpp` Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

alexfh added a comment. In D66042#1625898 , @NoQ wrote: > While we're here: i poked your silencing mechanism a little bit and even > though i'm still pretty sure you couldn't have done it perfectly without our > help, it sounds as if the only problem you

[PATCH] D66143: Don't use std::errc

thakis added a comment. As far as I know 4.8 is no longer supported. In D66143#1627168 , @ABataev wrote: > In D66143#1627165 , @thakis wrote: > > > That's Trusty and Trusty is on 4.8 which we no longer support, rig

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 214845. jvikstrom marked an inline comment as done. jvikstrom added a comment. Added fixme for ranking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856 Files: clang

[PATCH] D66143: Don't use std::errc

ABataev added a comment. In D66143#1627195 , @thakis wrote: > As far as I know 4.8 is no longer supported. > > In D66143#1627168 , @ABataev wrote: > > > In D66143#1627165 , @

[PATCH] D66143: Don't use std::errc

lebedev.ri added a comment. In D66143#1627221 , @ABataev wrote: > In D66143#1627195 , @thakis wrote: > > > As far as I know 4.8 is no longer supported. > > > > In D66143#1627168

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL368706: Fix crash on switch conditions of non-integer types in templates (authored by eandrews, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D66142: clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are off.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/Driver/frame-pointer-elim.c:1 +// KEEP-ALL-NOT: warning: // KEEP-ALL: "-mframe-pointer=all" This is the first time I've seen t

[PATCH] D66143: Don't use std::errc

jfb added a comment. In D66143#1627226 , @lebedev.ri wrote: > In D66143#1627221 , @ABataev wrote: > > > In D66143#1627195 , @thakis wrote: > > > > > As far as I know 4.8 is n

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jdenny added a comment. In D61466#1613571 , @jdenny wrote: > Note the reproducer in the implementation's FIXME. The other FIXME points > there, so I figure it's best not to duplicate the note. @jkorous, is this change sufficient? Thanks. CHANGES SIN

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

efriedma added a comment. > If variable A's initializer references variable B, then it will call B's > initializer. I'm considering a testcase like this: struct S { int x; }; void bar(S**); void baz(void()); void f() { thread_local S s = {1}; thread_local S* p = &s; b

[libunwind] r368708 - Creating release candidate rc2 from release_900 branch

Author: hans Date: Tue Aug 13 09:08:45 2019 New Revision: 368708 URL: http://llvm.org/viewvc/llvm-project?rev=368708&view=rev Log: Creating release candidate rc2 from release_900 branch Added: libunwind/tags/RELEASE_900/rc2/ - copied from r368707, libunwind/branches/release_90/ ___

[libclc] r368708 - Creating release candidate rc2 from release_900 branch

Author: hans Date: Tue Aug 13 09:08:45 2019 New Revision: 368708 URL: http://llvm.org/viewvc/llvm-project?rev=368708&view=rev Log: Creating release candidate rc2 from release_900 branch Added: libclc/tags/RELEASE_900/rc2/ - copied from r368707, libclc/branches/release_90/ _

r368706 - Fix crash on switch conditions of non-integer types in templates

Author: eandrews Date: Tue Aug 13 08:53:19 2019 New Revision: 368706 URL: http://llvm.org/viewvc/llvm-project?rev=368706&view=rev Log: Fix crash on switch conditions of non-integer types in templates Clang currently crashes for switch statements inside a template when the condition is a non-integ

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:222 +// GenType definitions. +def FGenTypeN : GenericType<"FGenTypeN", TLFloat, VecAndScalar>; +// Generate basic GenTypes. Names are like: GenTypeFloatVecAndScalar. svenvh wrote: >

Re: r368561 - [OpenCL] Ignore parentheses for sampler initialization

Hi Hans, Can this be merged into the release 9.0 branch please? Thank you! Anastasia From: cfe-commits on behalf of Sven van Haastregt via cfe-commits Sent: 12 August 2019 13:44 To: cfe-commits@lists.llvm.org Subject: r368561 - [OpenCL] Ignore parentheses fo

Re: r368552 - [OpenCL] Fix lang mode predefined macros for C++ mode.

Hi Hans, Can this be merged into the release 9.0 branch please? Thank you! Anastasia From: cfe-commits on behalf of Anastasia Stulova via cfe-commits Sent: 12 August 2019 11:44 To: cfe-commits@lists.llvm.org Subject: r368552 - [OpenCL] Fix lang mode predefi

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

twoh updated this revision to Diff 214855. twoh added a comment. Avoid -O2 from the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65975/new/ https://reviews.llvm.org/D65975 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Misc/printer

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

twoh added a comment. @fedor.sergeev Sorry for the late reply. I missed your comment. I found that with the new pass manager module verifier is not scheduled by default, and AlwaysInlinerPass is the only one scheduled if I provide no -O option. I removed -O2 from the test command and replaced F

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

sepavloff updated this revision to Diff 214857. sepavloff added a comment. Added tests for 'pragma clang fp' in template instantiations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66092/new/ https://reviews.llvm.org/D66092 Files: clang/lib/Cod

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

sepavloff added a comment. In D66092#1625380 , @kpn wrote: > Does this work for anything that uses TreeTransform, like C++ templates? Added such tests. > Also, if any constrained intrinsics are used in a function then the entire > function needs to be

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. I did some experiments with adding something similar to the `ErrorExpr` Aaron suggest. It has this flag set and does not get removed from the AST. I believe the best way to address Aaron's comments is to add tests mentioning this expression instead of trying to cat

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. thanks @Meinersbur and @fhahn for the discussions on this, also on the dev list. It looks like we are happy with this behaviour? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65776/new/ https://reviews.llvm.org/D65776 __

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

Prince781 added a comment. In D66122#1627252 , @efriedma wrote: > > If variable A's initializer references variable B, then it will call B's > > initializer. > > I don't think this patch adds any code that would address that, although I > could be missin

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. this is not important at all, but might be nice clean up, so friendly ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-commits@l

r368717 - [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef

Author: szelethus Date: Tue Aug 13 09:45:48 2019 New Revision: 368717 URL: http://llvm.org/viewvc/llvm-project?rev=368717&view=rev Log: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef find clang/ -type f -exec sed -i 's/std::shared_ptr/PathDiagnost

[PATCH] D65381: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef

This revision was automatically updated to reflect the committed changes. Closed by commit rL368717: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

  1   2   3   >