[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rsmith added a comment. Looks good. Can you add a test to `test/CXX/drs/dr23xx.cpp` with a suitable `dr2386: 10` comment to track that we've implemented DR2386 in Clang 10, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://r

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso updated this revision to Diff 214490. Charusso added a comment. - Remove one misleading 'no-warning' comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang/include/clang/Driv

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214491. jcai19 added a comment. Lower the intrinsic to pseudo instructions directly, instead of SelectDAG nodes first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 F

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked 4 inline comments as done. jcai19 added a comment. @efriedma I have changed my implementation to lower llvm.gnu.eabi.mcount intrinsic into pseudo instructions directly, instead of first lowering them into SelectionDAG call nodes. Thanks. Comment at: llvm/lib/Tar

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214496. jcai19 marked 2 inline comments as done. jcai19 added a comment. clang-format the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Basic

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:561 +CmdLineOption `Show` -> `Enable`? > **recursion**, //n.,// see "recursion" I think it's valuable when the object and the documentation describe the same idea in //different//

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 214495. NoQ marked 3 inline comments as done. NoQ added a comment. Fix un-singed options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/ https://reviews.llvm.org/D65182 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added reviewers: alexfh, Szelethus. NoQ added a subscriber: alexfh. NoQ added a comment. +@alexfh because clang-tidy now finally has a way of safely disabling core checkers without causing crashes all over the place! Would you like to take the same approach as we picked in scan-build, i.e. w

[PATCH] D65182: [analyzer] Add fix-it hint support.

Charusso accepted this revision. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:103 void enableWerror() { ShouldEmitAsError = true; } + void enableFixitsAsRemarks() { FixitsAsRemarks = true; } NoQ wrote: >

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso added inline comments. Comment at: clang/include/clang/Driver/CC1Options.td:127-128 +def analyzer_disable_warning : Separate<["-"], "analyzer-disable-warning">, + HelpText<"Choose analyzer checkers of the warnings to disable">; +def analyzer_disable_warning_EQ : Joine

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso updated this revision to Diff 214498. Charusso marked 5 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang/include/clang/

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso updated this revision to Diff 214500. Charusso added a comment. - Fix a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang/include/clang/Driver/CC1Options.td clang/incl

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1750 + // [B1] -> [B2] -> [B3] -> [sink] + // assert(A && B || C);\ \ \ + // ---> [go on with the executi

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192-197 + /// Pair of checker name and enable/disable to do analysis. + std::vector> CheckerAnalysisVector; + + /// Vector of checker names to do not emit warnings. + std::vector

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. But i definitely like it how smooth this patch turned out to be! Also recent bugzilla requests for this feature: https://bugs.llvm.org/show_bug.cgi?id=42816 https://bugs.llvm.org/show_bug.cgi?id=418

[PATCH] D66045: Improve detection of same value in comparisons

NoQ added a reviewer: NoQ. NoQ added a comment. I like where this is going! I'll add myself so that not to forget to review the CFG bits next week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66045/new/ https://reviews.llvm.org/D66045 __

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192-197 + /// Pair of checker name and enable/disable to do analysis. + std::vector> CheckerAnalysisVector; + + /// Vector of checker names to do not emit warnings. + std::ve

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

Jeroen added a comment. In the reproduction of https://bugs.llvm.org/show_bug.cgi?id=33236 there is explicit mentioning of `const T`. It would be nice if the test cases for this fix would also have coverage for that. Comment at: clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp:15 t

<    1   2   3