jfb updated this revision to Diff 214298.
jfb marked an inline comment as done.
jfb added a comment.
- Address more comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65986/new/
https://reviews.llvm.org/D65986
Files:
clang/include/clang/Dri
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Thanks for bearing with me, JF!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65986/new/
https://reviews.llvm.org/D65986
___
cfe-commi
Author: gribozavr
Date: Thu Aug 8 23:14:54 2019
New Revision: 368399
URL: http://llvm.org/viewvc/llvm-project?rev=368399&view=rev
Log:
Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit
Summary: ASSERT_THAT_ERROR looks like the intended helper for use in tests.
Reviewers: plotfi, jkoro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL368399: Use ASSERT_THAT_ERROR instead of
logAllUnhandledErrors/exit (authored by gribozavr, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
sepavloff created this revision.
sepavloff added reviewers: anemet, kpn, aaron.ballman, hfinkel, rsmith,
rjmccall.
Herald added a project: clang.
This change added two new attributes, rounding mode and exception
behavior to the structure FPOptions. These attributes allow more
flexible treatment o
This change broke compiling Qt.
A repro case looks like this:
mkdir -p fake-qtincl/5.13.1/QtCore/private
touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h
touch fake-qtincl/QtCore
echo "#include " > qtincl.cpp
bin/clang++ -c qtincl.cpp -Ifake-qtincl -Ifake-qtincl/5.13.1
Previously this igno
labath added inline comments.
Comment at: clang/test/Driver/vfsmode.py:4
+
+# UNSUPPORTED: system-windows
+
jfb wrote:
> I'm not sure what the best way to test this on Windows would be, and without
> a machine handy I can't really test this :-(
Unsupported might
201 - 207 of 207 matches
Mail list logo