[PATCH] D65770: hwasan: Instrument globals.

pcc created this revision. pcc added reviewers: hctim, vitalybuka. Herald added subscribers: Sanitizers, cfe-commits, hiraditya, kubamracek, srhines. Herald added projects: clang, Sanitizers, LLVM. Globals are instrumented by adding a pointer tag to their symbol values and emitting metadata into

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 213435. Nathan-Huckleberry added a comment. - Remove 'maybe', remove boolean and fix other call to ParseSimpleDeclaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm

r367914 - [docs] don't use :option: for C++ compat

Author: jfb Date: Mon Aug 5 12:45:23 2019 New Revision: 367914 URL: http://llvm.org/viewvc/llvm-project?rev=367914&view=rev Log: [docs] don't use :option: for C++ compat The bots are sad that they're not documented. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersMan

Re: r367889 - [docs] document -Weveything more betterer

Fixed. I guess we should document those... > On Aug 5, 2019, at 10:51 AM, Nico Weber wrote: > > This breaks the sphinx bot: > > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio > >

[PATCH] D65753: Builtins: Add some v2f16 variants

rjmccall added a comment. Hmm. I think there are two reasonable concerns here, both arising from the fact that these names occupy (the builtin namespace parallel to) a namespace that the committee might want to occupy in the future: - Is a `v2fN` suffix sufficiently likely to avoid interfering

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 213437. dgoldman added a comment. Fix test failure via `TransformTypos` - Add a new property on Sema to track newly created Typos and use this from within TransformTypos in order to delete any Typos that are unreachable (tested in typo-correction-cxx11.cpp

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 213438. dgoldman added a comment. - remove extra newline Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: include/clang/Sema/Sema.h lib/Sema/SemaExprCXX.cpp lib/Sema/Sema

[PATCH] D65753: Builtins: Add some v2f16 variants

rjmccall added a comment. You might want to look into ISO/IEC TS 19570 - 2018 to see what they're thinking. If it looks like there's a potential conflict, then maybe these should have an OpenCL-specific prefix on them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/ https://

Re: r367889 - [docs] document -Weveything more betterer

Still sad, now with a different message: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220 /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:1002: WARNING: unknown option: -Wall On Mon, Aug 5, 2019 at 3:46 PM JF Bastien wrote: > Fixed. I gu

r367918 - [docs] don't use :option: for Wall Wextra

Author: jfb Date: Mon Aug 5 12:59:07 2019 New Revision: 367918 URL: http://llvm.org/viewvc/llvm-project?rev=367918&view=rev Log: [docs] don't use :option: for Wall Wextra The bots are sad that they're not documented. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersMa

Re: r367889 - [docs] document -Weveything more betterer

Ugh this is silly… fixed again. > On Aug 5, 2019, at 12:55 PM, Nico Weber wrote: > > Still sad, now with a different message: > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220 > > > /home/buildbot/llvm-build-d

[PATCH] D65753: Builtins: Add some v2f16 variants

rjmccall added a comment. Hmm, sorry, that's a C++ spec, and it looks like the (abandoned) C attempt at data parallelism (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2081.htm) doesn't introduce vector types. Talking about it internally, I think there are two reasonable approaches: - Add a

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

efriedma added a comment. For the "=x" thing I was talking about, try the following testcase: void a() { struct S { unsigned x[4]; } z; asm volatile("%0":"=x"(z)); } void a2() { struct S { unsigned x[8]; } z; asm volatile("%0":"=x"(z)); } clang trunk gives "error: couldn't allocate output re

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1613268 , @NoQ wrote: > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText > It got suddenly fixed in > http://

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek added a comment. This looks reasonable to me; I'd prefer to clean up Clang's internal headers to be compatible with both FreeBSD's and musl's standard headers as suggested in http://lists.llvm.org/pipermail/llvm-dev/2019-August/134353.html, but I'm not sure how feasible or doable that is

[PATCH] D65770: hwasan: Instrument globals.

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:221 + s32 gv_relptr; + u32 info; +}; Can this be just following? u32 size:24; u8 tag; Comment at: compiler-rt/lib/hwasan/hwasan.cpp:236 -using namespace __h

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: Meinersbur, hsaito, fhahn. New pragma "vectorize_predicate(enable)" now implies "vectorize(enable)", and it is ignored when vectorization is disabled with e.g. "vectorize(disable) vectorize_predicate(enable)". https://reviews.llvm

[PATCH] D65770: hwasan: Instrument globals.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1203 + Constant *Initializer = GV->getInitializer(); + uint64_t SizeInBytes = + M.getDataLayout().getTypeAllocSize(Initializer->getType()); what is goi

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. Forgot that this requires a doc change too. Will add that once we're happy with the proposed behaviour. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65776/new/ https://reviews.llvm.org/D65776 ___ cfe-commits

[PATCH] D65770: hwasan: Instrument globals.

pcc marked 3 inline comments as done. pcc added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:221 + s32 gv_relptr; + u32 info; +}; vitalybuka wrote: > Can this be just following? > u32 size:24; > u8 tag; It could, but since these structs ar

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

a_sidorin accepted this revision. a_sidorin added a comment. Hi Artem, The patch looks good to me. I prefer a fully qualified name, however, but it is a matter of taste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180

[PATCH] D65770: hwasan: Instrument globals.

pcc updated this revision to Diff 213472. pcc added a comment. - Switch to an enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65770/new/ https://reviews.llvm.org/D65770 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/fsanitize.c

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

dalias added a comment. It's not just infeasible; it's impossible by design. musl's headers do not support any contract with compiler-provided versions of the std headers, and won't. Attempting to use them in place of the libc ones is unsupported usage and will periodically break. Repository:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void added a comment. In D60943#1612083 , @joerg wrote: > The combination of D60942 , D06943 and > D65280 solves the problems for me on all > targets I have. Excellent! I submitted D609

r367940 - [Sema] Add -Wpointer-compare

Author: gbiv Date: Mon Aug 5 15:15:40 2019 New Revision: 367940 URL: http://llvm.org/viewvc/llvm-project?rev=367940&view=rev Log: [Sema] Add -Wpointer-compare This patch adds a warning that diagnoses comparisons of pointers to '\0'. This is often indicative of a bug (e.g. the user might've forgo

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

Meinersbur added a comment. Mmmh, I would have expected this to work the same way as `vectorize_width`. According to the docs: > The following example implicitly enables vectorization and interleaving by > specifying a vector width and interleaving count: > `#pragma clang loop vectorize_width(

[PATCH] D65770: hwasan: Instrument globals.

pcc updated this revision to Diff 213477. pcc added a comment. - Increment num_descriptions_printed in the right place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65770/new/ https://reviews.llvm.org/D65770 Files: clang/lib/Driver/SanitizerArgs

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

xbolva00 added a comment. In D65300#1608147 , @lebedev.ri wrote: > Thank you for working on this! > > I'm guessing this doesn't have a `-Werror=` mode? > > I still believe this should output a remark. > It will still be visible in the compiler console out

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 213481. sdmitriev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.ll clang/tools/CMakeLists.txt clang/tools/clang-offload-wrapp

r367947 - [Sema] attempt to appease buildbots after r367940

Author: gbiv Date: Mon Aug 5 16:19:15 2019 New Revision: 367947 URL: http://llvm.org/viewvc/llvm-project?rev=367947&view=rev Log: [Sema] attempt to appease buildbots after r367940 A buildbot got angry about this new test, with error messages like: warn-nullchar-nullptr.c Line 16: use of undecla

[PATCH] D65770: hwasan: Instrument globals.

pcc added a comment. The AOSP side of this is https://android-review.googlesource.com/c/platform/bionic/+/1096613 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65770/new/ https://reviews.llvm.org/D65770 _

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/include/clang/Driver/Action.h:74 OffloadUnbundlingJobClass, +OffloadWrapperJobClass, Do we really need this new kind of job here, can we use bundler instead? Comment at: clang/lib/Code

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry marked an inline comment as done. Nathan-Huckleberry added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:352 SetParamDefaultArgument(Param, DefaultArg, EqualLoc); + CurContext->removeDecl(Param); + CurContext = Cur; rsmith wr

[PATCH] D65628: [clang-doc] Parallelize reducing phase

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72 +static llvm::cl::opt ThreadCount( +"thread-count", Can we use the pre-existing concurrency flag instead (https://github.com/llvm/llvm-project/blob/91e5cdf

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); + Node->Children.emplace_back(llvm::make_unique("

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett accepted this revision. juliehockett added a comment. LGTM with a comment correction Comment at: clang-tools-extra/clang-doc/Representation.h:117 Reference(llvm::StringRef Name) : Name(Name) {} - Reference(llvm::StringRef Name, StringRef Path) : Name(Name), Pat

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + DiegoAstiazaran wrote: > juliehockett wrote: > > Formatting is a bit weird for sublists > Fi

[PATCH] D65545: Handle some fs::remove failures

jfb added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1444-1445 // Remove the file. - llvm::sys::fs::remove(File->path()); + if ((EC = llvm::sys::fs::remove(File->path( +break; vsapsai wrote: > jfb wrote: >

[PATCH] D65545: Handle some fs::remove failures

jfb updated this revision to Diff 213497. jfb marked 8 inline comments as done. jfb added a comment. - Return llvm::Error from ASTUnit::Save - Update per comments. - Address Volodymyr's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65545/n

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213498. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files: clang-tools-extra/clang-doc/BitcodeRe

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.cpp:79 + +bool Generator::createResources(ClangDocContext &CDCtx) { + std::error_code OK; Why is this implementation in the generic Generator? It's fairly HTML-specific -- ne

[PATCH] D64958: [clang-doc] Fix link generation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367958: [clang-doc] Fix link generation (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[clang-tools-extra] r367958 - [clang-doc] Fix link generation

Author: diegoastiazaran Date: Mon Aug 5 17:11:34 2019 New Revision: 367958 URL: http://llvm.org/viewvc/llvm-project?rev=367958&view=rev Log: [clang-doc] Fix link generation Before making a link to a reference it is required to check that the reference has a path (eg. primitives won't have paths)

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

jkorous added a comment. Thanks for the patch! Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 /// Returns nullptr if \param Path doesn't exist or isn't a directory. /// Returns nullptr if OS kernel API told us we can't start watching. In such --

[PATCH] D65622: [clang-doc] Update documentation

juliehockett added a comment. Sorry for the delayed review, but a few things I caught :) Also, please make sure to update the the release notes/flag documentation for the patches you have in progress that add features or flags. Comment at: clang-tools-extra/trunk/docs/Release

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

jkorous added a comment. Please just update the comment, otherwise LGTM. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; jkorous wrote: > IIUC this is silently dropping errors.

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 /// Returns nullptr if \param Path doesn't exist or isn't a directory. /// Returns nullptr if OS kernel API told us we can't star

[PATCH] D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable.

jkorous added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65708/new/ https://reviews.llvm.org/D65708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

chandlerc added a comment. One high level point that is at least worth clarifying, and maybe others will want to suggest a different approach: The overall approach here is to have as small of a difference between the O1 and O2

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D65690 replaces this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65003/new/ https://reviews.llvm.org/D65003 ___ cfe-comm

Buildbot numbers for the week of 07/21/2019 - 07/27/2019

Hello everyone, Below are some buildbot numbers for the week of 07/21/2019 - 07/27/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 07/28/2019 - 08/03/2019

Hello everyone, Below are some buildbot numbers for the last week of 07/28/2019 - 08/03/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

r367968 - [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable

Author: zer0 Date: Mon Aug 5 18:26:46 2019 New Revision: 367968 URL: http://llvm.org/viewvc/llvm-project?rev=367968&view=rev Log: [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable This should not affect actual behavior, but should pessimize the threading less by av

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213509. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a parent revision: D65690: [clang-doc] Add index in each info html file. DiegoAstiazaran added a comment. Changed depe

[PATCH] D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367968: [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable (authored by zer0, committed by )

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:156 +/// this subclass. +class MinimizedVFSFile final : public llvm::vfs::File { +public: aganea wrote: > This makes only a short-lived objects, is

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 213511. arphaman marked 3 inline comments as done. arphaman added a comment. Fix comment typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files: clang/include/clang/Basic/FileManager.h clang/include

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 213513. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Moved serialization of Index to HTML generator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 Files: cla

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a reviewer: rnk. smeenai added a subscriber: rnk. smeenai added a comment. Adding @rnk as someone familiar with the driver/frontend :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.cpp:79 + +bool Generator::createResources(ClangDocContext &CDCtx) { + std::error_code OK; juliehockett wrote: > Why is this implementation in the generic Generator? It's fa

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + juliehockett wrote: > DiegoAstiazaran wrote: > > juliehockett wrote: > > > Formatting is

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213515. plotfi added a comment. Improve comments, change Path.empty() errors for asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/Di

[PATCH] D65545: Handle some fs::remove failures

bruno added a comment. Thanks for working on this JF! Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:107-111 TemporaryFiles::~TemporaryFiles() { llvm::MutexGuard Guard(Mutex); for (const auto &File : Files) -llvm::sys::fs::remove(File.getKey()); +if (std:

[PATCH] D65597: WIP: Builtins: Start adding half versions of math builtins

arsenm closed this revision. arsenm added a comment. r367973 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65597/new/ https://reviews.llvm.org/D65597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

r367973 - Builtins: Start adding half versions of math builtins

Author: arsenm Date: Mon Aug 5 20:28:37 2019 New Revision: 367973 URL: http://llvm.org/viewvc/llvm-project?rev=367973&view=rev Log: Builtins: Start adding half versions of math builtins The implementation of the OpenCL builtin currently library uses 2 different hacks to get to the corresponding

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp:218 +return llvm::make_error( +std::string("Path.empty() error: ") + strerror(errno), +llvm::inconvertibleErrorCode()); compnerd wrote: > Simil

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213520. plotfi added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. add another assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704

r367979 - [clang][DirectoryWatcher] Adding llvm::Expected error handling to create.

Author: zer0 Date: Mon Aug 5 22:12:23 2019 New Revision: 367979 URL: http://llvm.org/viewvc/llvm-project?rev=367979&view=rev Log: [clang][DirectoryWatcher] Adding llvm::Expected error handling to create. Prior to this patch Unix style errno error reporting from the inotify layer was used by Dire

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367979: [clang][DirectoryWatcher] Adding llvm::Expected error handling to create. (authored by zer0, committed by ). Chan

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. Thanks for pointing this all out! I am not entirely sure yet what to think about all this as I am new to the loop pragma business, but I think it looks inconsistent to me! I think I find `allowReordering()` a little bit ugly, because it is also checking `getWidth(

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65699/new/ https://reviews.llvm.org/D65699 ___ cfe-commits ma

[PATCH] D65545: Handle some fs::remove failures

jfb marked 2 inline comments as done. jfb added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:107-111 TemporaryFiles::~TemporaryFiles() { llvm::MutexGuard Guard(Mutex); for (const auto &File : Files) -llvm::sys::fs::remove(File.getKey()); +

[PATCH] D62445: [test] Fix plugin tests

davezarzycki added a comment. Just FYI – Having LLVM_ENABLE_PLUGINS_default depend on LLVM_ENABLE_PIC is a hack that should go away someday. Doing so requires that plugin dependencies either always build PIC (and therefore ignore LLVM_ENABLE_PIC), or are linked into the executables that load th

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

This revision was automatically updated to reflect the committed changes. Closed by commit rL367981: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

r367981 - [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

Author: maskray Date: Mon Aug 5 23:25:32 2019 New Revision: 367981 URL: http://llvm.org/viewvc/llvm-project?rev=367981&view=rev Log: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl On a musl-based Linux distribution, stdalign.h stdarg.h stdbool.h stddef.h stdint.

[PATCH] D62445: [test] Fix plugin tests

davezarzycki added a comment. In D62445#1616218 , @davezarzycki wrote: > Just FYI – Having LLVM_ENABLE_PLUGINS_default depend on LLVM_ENABLE_PIC is a > hack that should go away someday. Doing so requires that plugin dependencies > either always build PI

r367982 - [Driver] Introduce -stdlib++-isystem

Author: smeenai Date: Mon Aug 5 23:48:43 2019 New Revision: 367982 URL: http://llvm.org/viewvc/llvm-project?rev=367982&view=rev Log: [Driver] Introduce -stdlib++-isystem There are times when we wish to explicitly control the C++ standard library search paths used by the driver. For example, when

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

This revision was automatically updated to reflect the committed changes. Closed by commit rL367982: [Driver] Introduce -stdlib++-isystem (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

<    1   2