[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213233. phosek added a comment. I've decided to go with the original `-f[no-]sanitize-link-deps`: `-fsanitize-minimal-runtime` is also a cc1 flag which affects codegen, `-fshared-libsan` and `-fstatic-libsan` are orthogonal, e.g. it's possible to have minima

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213235. phosek added a comment. One more change, I went with `-fsanitize-runtime` and `-fno-sanitize-runtime` in the end which seems like the best fit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files:

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

mcgrathr created this revision. mcgrathr added reviewers: phosek, MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. These "sanitizers" are hardened ABIs that are wholly orthogonal to the SanitizerCoverage instrumentation. Repository: rG LLVM Github Monorepo https

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

MaskRay added a comment. Does this change affect `test/Driver/fsanitize-coverage.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65715/new/ https://reviews.llvm.org/D65715 ___ cfe-commits mailing lis

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213237. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/sanit

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

This revision was automatically updated to reflect the committed changes. sepavloff marked an inline comment as done. Closed by commit rL367779: [Parser] Emit descriptive diagnostic for misplaced pragma (authored by sepavloff, committed by ). Herald added a project: LLVM. Herald added a subscriber

r367779 - [Parser] Emit descriptive diagnostic for misplaced pragma

Author: sepavloff Date: Sun Aug 4 03:08:51 2019 New Revision: 367779 URL: http://llvm.org/viewvc/llvm-project?rev=367779&view=rev Log: [Parser] Emit descriptive diagnostic for misplaced pragma If a class or struct or union declaration contains a pragma that is not valid in this context, compiler

[PATCH] D65582: IR: accept and print numbered %N names for function args

t.p.northover accepted this revision. t.p.northover marked an inline comment as done. t.p.northover added a comment. Thanks Reid, committed as r367755. Comment at: llvm/utils/add_argument_names.py:5 +def fix_string(s): +TYPE = re.compile('\s*(i[0-9]+|float|double|x86_fp80|

Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

https://reviews.llvm.org/D65704 https://reviews.llvm.org/D65708 Thanks! PL On Thu, Aug 1, 2019 at 5:42 PM Jan Korous wrote: > Oh! Interesting! Thanks for investigating this. > > I'm happy to review the patch. > > On Aug 1, 2019, at 5:17 PM, Puyan Lotfi > wrote: > > Hi Jan, Thanks for the foll

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro added a comment. In D64793#1613063 , @rnk wrote: > lgtm > > If I interpret @jyknight correctly, having failed to dissuade you, he doesn't > feel strongly enough about this to block it, he just wants to reduce legacy > when feasible. Fully understood

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added inline comments. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, rnk wrote: > ro wrote: > > rnk wrote: > > > Is it feasible to make this an `enum class`? I'm worried about namespace > >

[clang-tools-extra] r367785 - [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

Author: zinovy.nis Date: Sun Aug 4 06:32:39 2019 New Revision: 367785 URL: http://llvm.org/viewvc/llvm-project?rev=367785&view=rev Log: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor Differential Revision: https://reviews.llvm.org/D65104 Added: clang-tools-extra/trun

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro updated this revision to Diff 213243. ro marked 2 inline comments as done. ro added a comment. - Restrict enum class Languge to uint8_t to save space. - Filter patch through clang-format-diff.py Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65562/new/ https://

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL367785: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor (authored by zinovy.nis, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added a comment. I've now submitted the lldb patch to reflect the `LangStandard.h` move. It turns out the part of isl (included in polly) that uses `InputKind::C` isn't even compiled inside the llvm tree. Nonetheless, I've submitted a patch upstream

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:103-105 + // A local variable cannot be odr-used (6.2) in a default argument. + if (DRE->isNonOdrUse() != NOUR_None) +return false; --

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> I'll properly update this file as explained in D65696. Repository: rG LLVM Github Mo

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

compnerd added a comment. `-ldl` doesn't work on all platforms (e.g. android, FreeBSD, etc). `-lpthread` is wrong - if you want to add that, I think that we need to improve the `-thread-model` flag in clang first (it currently just always passes `posix`, which is ignored; but would identify th

[PATCH] D65723: [analyzer][NFC] Add different interestingness kinds

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, Charusso, dcoughlin, baloghadamsoftware, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added pa

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

ziangwan added a comment. In D64666#1613356 , @mgorny wrote: > In D64666#1613057 , @ziangwan wrote: > > > The warning is actually correct here. This implicit integral to float > > conversion loses precision. Is it

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, Charusso, baloghadamsoftware, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added a

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem added a comment. In D65572#1610169 , @rengolin wrote: > This is a tricky one which may vary depending on the libraries available on > different systems. Which toolchain is this? Can you add more context? @rengolin this is when building linux sy

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem added a comment. In D65572#1614003 , @compnerd wrote: > `-ldl` doesn't work on all platforms (e.g. android, FreeBSD, etc). > `-lpthread` is wrong - if you want to add that, I think that we need to > improve the `-thread-model` flag in clang fir

[PATCH] D65725: [analyzer] Mention whether an event is about a condition in a bug report part 2

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added a

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213267. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolCh

r367794 - [Driver] Support for disabling sanitizer runtime linking

Author: phosek Date: Sun Aug 4 15:24:14 2019 New Revision: 367794 URL: http://llvm.org/viewvc/llvm-project?rev=367794&view=rev Log: [Driver] Support for disabling sanitizer runtime linking This change introduces a pair of -fsanitize-link-runtime and -fno-sanitize-link-runtime flags which can be

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

This revision was automatically updated to reflect the committed changes. Closed by commit rL367794: [Driver] Support for disabling sanitizer runtime linking (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:111 +/// getters and some well placed asserts for extra security. +class BugReportConstruct { + /// The consumer we're constructing the bug repo

r367796 - [Driver] Always use -z separate-code with lld on Fuchsia

Author: phosek Date: Sun Aug 4 18:15:33 2019 New Revision: 367796 URL: http://llvm.org/viewvc/llvm-project?rev=367796&view=rev Log: [Driver] Always use -z separate-code with lld on Fuchsia Previously -z separate-code was the default lld behavior, but now it has to be explicitly requested by spec

r367797 - [Driver] Derive Fuchsia Linker directly from Tool

Author: phosek Date: Sun Aug 4 18:36:51 2019 New Revision: 367797 URL: http://llvm.org/viewvc/llvm-project?rev=367797&view=rev Log: [Driver] Derive Fuchsia Linker directly from Tool Fuchsia Linker tool doesn't need any of the GnuTool behavior. Modified: cfe/trunk/lib/Driver/ToolChains/Fuchs

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

dalias added a comment. Just chiming in to confirm that the requested change is correct for musl. musl does not support use/mixing of compiler-provided std headers with its headers, and intentionally has no mechanism for communicating with such headers as to which types have already been define

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

MaskRay added a comment. If libunwind is configured with `-DLIBUNWIND_ENABLE_THREADS=Off` / it is on Windows / `-DLIBUNWIND_USE_WEAK_PTHREAD=On`, libpthread is not a hard dependency. If you use lld: #if _LIBUNWIND_USE_DLADDR #include #if defined(__unix__) && defined(__ELF__) && defined

[PATCH] D65597: WIP: Builtins: Start adding half versions of math builtins

arsenm updated this revision to Diff 213276. arsenm added a comment. Change naming scheme, add more and tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65597/new/ https://reviews.llvm.org/D65597 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpe

[PATCH] D65706: [docs] Better documentation for -Weverything

jfb updated this revision to Diff 213278. jfb marked 5 inline comments as done. jfb added a comment. - Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65706/new/ https://reviews.llvm.org/D65706 Files: clang/docs/UsersManu

[PATCH] D65706: [docs] Better documentation for -Weverything

jfb added inline comments. Comment at: clang/docs/UsersManual.rst:999-1000 +diagnostics contradict each other, users of :option:`-Weverything` therefore +often disable many diagnostics such as :option:`-Wno-c++98-compat` +:option:`-Wno-c++-compat`. + aaron.ballma

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

phosek updated this revision to Diff 213280. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65715/new/ https://reviews.llvm.org/D65715 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/fsanitize-coverage.c Index: clang/test/Driver/fsanitize-coverage.c =

Re: [PATCH] D62445: [test] Fix plugin tests

Just saw this. I'll take a look, and thanks for pointing it out... On Fri, Aug 2, 2019 at 6:24 PM Artem Dergachev via Phabricator < revi...@reviews.llvm.org> wrote: > NoQ added a comment. > > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/gr

r367799 - [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

Author: phosek Date: Sun Aug 4 21:48:56 2019 New Revision: 367799 URL: http://llvm.org/viewvc/llvm-project?rev=367799&view=rev Log: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack These "sanitizers" are hardened ABIs that are wholly orthogonal to the SanitizerCove

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

MaskRay added a comment. Can you also take a quick look at https://reviews.llvm.org/D65699 :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65715/new/ https://reviews.llvm.org/D65715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

This revision was automatically updated to reflect the committed changes. Closed by commit rL367799: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

ebrevnov added a comment. Please be aware about build bot failure (http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/2185) most likely caused by this change. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1613268 , @NoQ wrote: > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText > > FAIL: Clang :: Analysis/checker-plu

[clang-tools-extra] r367800 - Rename F_{None, Text, Append} to OF_{None, Text, Append}. NFC

Author: maskray Date: Sun Aug 4 22:43:48 2019 New Revision: 367800 URL: http://llvm.org/viewvc/llvm-project?rev=367800&view=rev Log: Rename F_{None,Text,Append} to OF_{None,Text,Append}. NFC F_{None,Text,Append} are kept for compatibility since r334221. Modified: clang-tools-extra/trunk/cl

r367800 - Rename F_{None,Text,Append} to OF_{None,Text,Append}. NFC

Author: maskray Date: Sun Aug 4 22:43:48 2019 New Revision: 367800 URL: http://llvm.org/viewvc/llvm-project?rev=367800&view=rev Log: Rename F_{None,Text,Append} to OF_{None,Text,Append}. NFC F_{None,Text,Append} are kept for compatibility since r334221. Modified: cfe/trunk/lib/ARCMigrate/Fi

[libclc] r367800 - Rename F_{None, Text, Append} to OF_{None, Text, Append}. NFC

Author: maskray Date: Sun Aug 4 22:43:48 2019 New Revision: 367800 URL: http://llvm.org/viewvc/llvm-project?rev=367800&view=rev Log: Rename F_{None,Text,Append} to OF_{None,Text,Append}. NFC F_{None,Text,Append} are kept for compatibility since r334221. Modified: libclc/trunk/utils/prepare-

r367802 - [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences

Author: baloghadamsoftware Date: Sun Aug 4 23:45:41 2019 New Revision: 367802 URL: http://llvm.org/viewvc/llvm-project?rev=367802&view=rev Log: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences Iterators differences were mistakenly handled as random decrements which causes an

[PATCH] D65650: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences

baloghadamsoftware closed this revision. baloghadamsoftware added a comment. Closed by commit: [[ https://reviews.llvm.org/rG8557f17d887a | https://reviews.llvm.org/rG8557f17d887a: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences ]] Repository: rC Clang CHANGES SINCE LAS