[PATCH] D64958: [clang-doc] Fix link generation

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. The code looks fine to me but I don't understand the global details of this. Hopefully Julie can still review things from there but if not we don't get timely reviews then we can s

r367708 - Remove a dead diagnostic, NFC

Author: epilk Date: Fri Aug 2 12:25:58 2019 New Revision: 367708 URL: http://llvm.org/viewvc/llvm-project?rev=367708&view=rev Log: Remove a dead diagnostic, NFC This was issued in Objective-C 1 mode, but we not longer support that, so this is just unreachable. Modified: cfe/trunk/include/cl

r367709 - [Driver][test] Avoid undefined grep in darwin-ld.c

Author: hubert.reinterpretcast Date: Fri Aug 2 12:26:05 2019 New Revision: 367709 URL: http://llvm.org/viewvc/llvm-project?rev=367709&view=rev Log: [Driver][test] Avoid undefined grep in darwin-ld.c Summary: question-mark is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates

[PATCH] D65668: [Driver][test] Avoid undefined grep in darwin-ld.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL367709: [Driver][test] Avoid undefined grep in darwin-ld.c (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev added a comment. Pinging for review.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

Buildmaster cleaning/ removing long time off-line builders

Hello everyone, I am going to remove builders/slaves which are off-line for a long time now: clang-x64-ninja-win7 clang-x86_64-freebsd11 clang-x86_64-linux-selfhost-modules-2 openmp-clang-ppc64le-linux-debian openmp-clang-ppc64le-linux-rhel Please feel free to bring them back any time you need i

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added a comment. Hi David, An extra bit is needed to be added to `IdentifierNamespace`, and I could not find another field to shrink its width. As a result, it ends up larger than a word now. If you have a better solution, I'll be happy to know. Thanks, Lingda Repository: rC Clang

[PATCH] D65664: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

yonghong-song updated this revision to Diff 213122. yonghong-song added a comment. set metadata unless metadata is non-NULL. I have not found a case where metadata is NULL. But nevertheless, let us do this to avoid set a potential NULL metadata. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D65627: [clang-doc] Add flag to continue after mapping errors

DiegoAstiazaran updated this revision to Diff 213126. DiegoAstiazaran retitled this revision from "[clang-doc] Continue after mapping error" to "[clang-doc] Add flag to continue after mapping errors". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. A flag has

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

mgorny added subscribers: krytarowski, EricWF, mclow.lists, howard.hinnant, mgorny. mgorny added a comment. This change seems to have broken libc++ tests when run with trunk clang: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/21221/steps/run%20unit%20tests/logs/FAIL%3A%20libc%2B%2B%3A%3A

r367724 - [BPF] annotate DIType metadata for builtin preseve_array_access_index()

Author: yhs Date: Fri Aug 2 14:28:28 2019 New Revision: 367724 URL: http://llvm.org/viewvc/llvm-project?rev=367724&view=rev Log: [BPF] annotate DIType metadata for builtin preseve_array_access_index() Previously, debuginfo types are annotated to IR builtin preserve_struct_access_index() and pres

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

sammccall added a comment. Thanks, this looks a lot better. There are a bunch of details that can be simplified and names that could be clearer, but I think this is the right shape. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:161 + +Callback FoundCB = nullptr;

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good either way. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, ro wrote: > rnk wrote: >

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213128. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files: clang-tools-extra/clang-doc/BitcodeRea

[PATCH] D65664: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

This revision was automatically updated to reflect the committed changes. Closed by commit rL367724: [BPF] annotate DIType metadata for builtin preseve_array_access_index() (authored by yhs, committed by ). Changed prior to commit: https://reviews.llvm.org/D65664?vs=213122&id=213129#toc Reposi

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

ziangwan added a comment. The two failing cases I am seeing are: /home/motus/netbsd8/netbsd8/llvm/projects/libcxx/include/random:3648:40: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-

[PATCH] D65582: IR: accept and print numbered %N names for function args

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/utils/add_argument_names.py:5 +def fix_string(s): +TYPE = re.compile('\s*(i[0-9]+|float|double|x86_fp80|fp128|ppc_fp128|\[\[.*?\]\]|\[2 x \[\[[A-Z_0-9]+

[clang-tools-extra] r367729 - [clang-doc] Add flag to continue after mapping errors

Author: diegoastiazaran Date: Fri Aug 2 15:02:36 2019 New Revision: 367729 URL: http://llvm.org/viewvc/llvm-project?rev=367729&view=rev Log: [clang-doc] Add flag to continue after mapping errors The tool used to stop execution if there was an error in the mapping phase. It will now show the erro

[PATCH] D65627: [clang-doc] Add flag to continue after mapping errors

This revision was automatically updated to reflect the committed changes. Closed by commit rL367729: [clang-doc] Add flag to continue after mapping errors (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65003: [clang-doc] Add index in each info html file

jakehehrlich added a comment. I think everything but the implementation of `genIndex` being confusing looks good to me. I haven't actually groked how that code works yet other than the fact that it generates the index tree that I expect and all the surrounding code looks good to me. I understan

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. This looks awesome! Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:257 +genTypeReference(const Reference &Type, StringRef CurrentDirectory, +

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

ziangwan added a comment. In D64666#1612947 , @mgorny wrote: > This change seems to have broken libc++ tests when run with trunk clang: > > http://lab.llvm.org:8011/builders/netbsd-amd64/builds/21221/steps/run%20unit%20tests/logs/FAIL%3A%20libc%2B%2B%3A%

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm If I interpret @jyknight correctly, having failed to dissuade you, he doesn't feel strongly enough about this to block it, he just wants to reduce legacy when feasible. Repository: rC Clan

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

jakehehrlich added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:376 + LocNumberNode->Attributes.try_emplace( + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode));

r367733 - The MinGW linker supports response files

Author: rnk Date: Fri Aug 2 15:55:00 2019 New Revision: 367733 URL: http://llvm.org/viewvc/llvm-project?rev=367733&view=rev Log: The MinGW linker supports response files This affects both LLD and ld.bfd. This isn't testable with a normal driver test with -### because those command lines are pri

[PATCH] D65628: [clang-doc] Parallelize reducing phase

jakehehrlich added a comment. LGTM other than a couple atomicity issues. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:244 + llvm::errs() << toString(ReadInfos.takeError()) << "\n"; + Error = true; + return; use std::a

[PATCH] D65622: [clang-doc] Update documentation

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. This looks fine to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65622/new/ https://reviews.llvm.org/D65622 ___ cfe-commi

[PATCH] D65650: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fair enough! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65650/new/ https://reviews.llvm.org/D65650 ___ cfe-commits

[PATCH] D65545: Handle some fs::remove failures

vsapsai added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:2315-2316 if (Out.has_error()) { Out.clear_error(); -return true; +return llvm::createStringError(Out.error(), "AST serialization failed"); } Will `Out.error()` still wor

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: xingxue, daltenty, jasonliu. Herald added subscribers: jfb, arphaman. Herald added a project: clang. Some tests perform deep recursion, which requires a larger pthread stack size than the relatively low default

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett, phosek. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, mgorny. An index structure is created while generating the output file for each info

[PATCH] D65597: WIP: Builtins: Start adding half versions of math builtins

rjmccall added a comment. In N2405 (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2405.pdf), these are called `truncf16`, `cosf16`, etc., which I think is appropriate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65597/new/ https://reviews.llvm.org/D65597 ___

[PATCH] D65622: [clang-doc] Update documentation

DiegoAstiazaran updated this revision to Diff 213162. DiegoAstiazaran added a comment. Specify that `stylesheets` flag is only required for html format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65622/new/ https://reviews.llvm.org/D65622 Files: clang-tools-extra/docs/ReleaseNotes

[PATCH] D62445: [test] Fix plugin tests

NoQ added a comment. Ugh, there seems to be one more forgotten buildbot with plugins problems: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText FAIL: Clang :: Analysis/checker-plugins.c (467 of 14955) TEST 'Clang :: Analysis/checker-plugins.c

[PATCH] D65690: [clang-doc] Add index in each info html file

phosek added inline comments. Comment at: clang-tools-extra/clang-doc/assets/index.js:17 + return FilePath.substring(Path.length + 1) + Path = Path.substring(0, Path.lastIndexOf("/")); + } Wrong indentation? CHANGES SINCE LAST ACTION https://review

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

NoQ added a comment. Aha, aha, looks reasonable. If we're describing a variable, we should only highlight that variable. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2420 + if (!IsAssuming) { +PathDiagnosticLocation Loc(BExpr->getLHS(), BRC.getSourceM

[PATCH] D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Do it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65382/new/ https://reviews.llvm.org/D65382 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. *bows down to those who bestow documentation upon this code* Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:111 +/// getters and some well placed asserts for extra secur

[clang-tools-extra] r367743 - [clang-doc] Update documentation

Author: diegoastiazaran Date: Fri Aug 2 19:18:06 2019 New Revision: 367743 URL: http://llvm.org/viewvc/llvm-project?rev=367743&view=rev Log: [clang-doc] Update documentation HTML generator has been included in clang-tools-extra release notes. clang-doc documentation file has been updated. Diffe

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth updated this revision to Diff 213164. paulkirth added a comment. Address feedback from review 1. Fixed comments in License headers 2. removed excess {} 3. Changed conditional assignment to ternary operation 4. Moved local functions into anonymous namespace 5. Added reference to the orig

[PATCH] D65622: [clang-doc] Update documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367743: [clang-doc] Update documentation (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth updated this revision to Diff 213167. paulkirth added a comment. Update documentation and fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65300/new/ https://reviews.llvm.org/D65300 Files: clang/include/clang/Basic/CodeGenOption

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213169. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran added a comment. Change http to https as the default fix to the repository link. Add new flags to clang-doc documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213170. phosek edited the summary of this revision. phosek added a comment. Herald added a subscriber: cryptoad. I've updated the change and renamed the flag to `-fsanitize-no-runtime` although I'm not sure if it's necessarily better. I was thinking that ideal

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/assets/index.js:17 + return FilePath.substring(Path.length + 1) + Path = Path.substring(0, Path.lastIndexOf("/")); + } phosek wrote: > Wrong indentation? Yes, clang-format "

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran added a subscriber: phosek. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); +

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 213171. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix format of index.js file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 Files: clang-tools-extra/clang

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

MaskRay added a comment. In D65029#1613315 , @phosek wrote: > I've updated the change and renamed the flag to `-fsanitize-no-runtime` > although I'm not sure if it's necessarily better. I was thinking that ideal > interface might be `-fsanitize-runtime=(

[PATCH] D65545: Handle some fs::remove failures

abrachet added a comment. > I haven't updated all ignored instances of fs::remove, I therefore can't mark > it LLVM_NODISCARD for now. I think I remember reading that casting a `[[nodiscard]]` functions return to void was broken on some compilers, ie still warns. You cast `fs::remove` to void

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

mgorny added a comment. In D64666#1613057 , @ziangwan wrote: > The warning is actually correct here. This implicit integral to float > conversion loses precision. Is it the intended behavior of the code? If so, > we can simply add an explicit type cast t

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 213176. serge-sans-paille added a comment. Also fix symbol redefinition during static builds on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 Files:

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65616/new/ https://reviews.llvm.org/D65616 _

<    1   2