[PATCH] D65545: Handle some fs::remove failures

vsapsai added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:647-649 + if (std::error_code EC = llvm::sys::fs::remove(OF.TempFilename)) +getDiagnostics().Report(diag::err_fe_error_removing) + << OF.TempFilename << EC.message

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Buildbot failed for x86_64 target. Fix in progress. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:240 +auto File = SourceMgr.getFileManager().getFile(FilePath); +if (!File) + return SourceLocation(); Previously we'd hit the assert in `translateFile()` called fro

r367502 - [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

Author: ziangwan725 Date: Wed Jul 31 18:39:21 2019 New Revision: 367502 URL: http://llvm.org/viewvc/llvm-project?rev=367502&view=rev Log: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss Fix one test case for it to be system-independent. Modified: cfe/

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Fixed. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

MaskRay marked an inline comment as done. MaskRay added a comment. Ping :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65192/new/ https://reviews.llvm.org/D65192 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

rjmccall added a comment. In D65286#1606441 , @Anastasia wrote: > In D65286#1606071 , @mantognini > wrote: > > > In `vector_literals_nested.cl`, we have tests for (global) constants. Do > > you think it would be w

[PATCH] D65406: [Parser] Change parameter type from int to enum

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65406/new/ https://reviews.llvm.org/D65406 ___

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

rjmccall added inline comments. Comment at: clang/lib/Basic/TokenKinds.cpp:15 #include "llvm/Support/ErrorHandling.h" +#include using namespace clang; This is no longer necessary, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D65405: [Parser] Use special definition for pragma annotations

rjmccall added a comment. LGTM, although I don't think it would be ridiculous to make this an inline function definition like `isAnnotation`. (I like your generated implementation much better than the sequential `if`s used there, though.) Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D65556: Phabricator D49466

dankm created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, emaste. Herald added projects: clang, LLVM. path prefix mapping: enforce path matching Force the prefix string to match a complete prefix in the path to remap, and strip any trailing path separators from

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1586140 , @manojgupta wrote: > @dankm are you still working on this patch? Yes, I've been afk for a bit due to family circumstances, but I just uploaded more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 212723. dankm added a comment. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. Latest changes. I've been sitting on these for months, so I don't remember all that changed. The path remapping contract changed somewhat, an

<    1   2