Re: [clang-tools-extra] r367137 - [clang-format] Fix style of css file paths

Hello Galina, Sorry about that, I didn't notice that test wasn't passing on Windows. I just created this revision that should fix the issue. Thanks, Diego On Mon, Jul 29, 2019 at 12:12 PM Galina Kistanova wrote: > Hello Diego, > > This commit added broken test

[clang-tools-extra] r367263 - [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

Author: ericwf Date: Mon Jul 29 14:38:56 2019 New Revision: 367263 URL: http://llvm.org/viewvc/llvm-project?rev=367263&view=rev Log: [clang-tidy]: Google: new check 'google-upgrade-googletest-case' Introduce a new check to upgrade user code based on API changes in Googletest. The check finds use

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

EricWF closed this revision. EricWF added a comment. Committed in r367263. Thanks for the change, sorry about the delay. I'll go watch the bots now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62977/new/ https://reviews.llvm.org/D62977 _

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

rsmith added a comment. For the `&&` vs `||` and `&` vs `|` warnings, it seems extremely implausible to me that they meet the "few or no false-positives" criterion for an enabled-by-default warning. Even assuming that people don't know the relative precedences of those operators, we'd expect a

[clang-tools-extra] r367264 - [clang-doc] Fix failing tests on Windows

Author: diegoastiazaran Date: Mon Jul 29 15:03:39 2019 New Revision: 367264 URL: http://llvm.org/viewvc/llvm-project?rev=367264&view=rev Log: [clang-doc] Fix failing tests on Windows Tests on Windows were failing due to path separator differences. Links in HTML should use posix-style paths. Diff

[PATCH] D65419: [clang-doc] Fix failing tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL367264: [clang-doc] Fix failing tests on Windows (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D65349: [analyzer] Be more careful with destructors of non-regions.

NoQ added a comment. In D65349#1604363 , @baloghadamsoftware wrote: > Is there any real-world use-case for casting concrete integers to class > instances? How did you find this crashing case? I think in original code this value was produced by doing po

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur marked 3 inline comments as done. xur added a comment. I'm sorry that I missed this review for this long! In D64029#1581952 , @chandlerc wrote: > Sorry for the delay here. > > It'd be nice to land the LLVM patch first and with its own testing -- we >

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur updated this revision to Diff 212237. xur marked an inline comment as done. xur added a comment. Integrated Chandler's review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64029/new/ https://reviews.llvm.org/D64029 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/P

r367269 - [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627)

Author: vedantk Date: Mon Jul 29 15:49:55 2019 New Revision: 367269 URL: http://llvm.org/viewvc/llvm-project?rev=367269&view=rev Log: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627) The `this` parameter of a thunk requires adjustment. Stop emitting an incorrect dbg.declare

r367270 - [docs] Add a note about where UBSan emits logs

Author: vedantk Date: Mon Jul 29 15:54:43 2019 New Revision: 367270 URL: http://llvm.org/viewvc/llvm-project?rev=367270&view=rev Log: [docs] Add a note about where UBSan emits logs Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst

r367271 - [DependencyCollector] Make maybeAddDependency virtual (NFC)

Author: jdevlieghere Date: Mon Jul 29 16:02:11 2019 New Revision: 367271 URL: http://llvm.org/viewvc/llvm-project?rev=367271&view=rev Log: [DependencyCollector] Make maybeAddDependency virtual (NFC) Make DependencyCollector::maybeAddDependency, just like its other methods, which I made virtual a

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rsmith added a comment. In D64799#1605211 , @ilya-biryukov wrote: > @rsmith, emitting the typos on pop expression evaluation context resulted in > a bunch of failures when trying to transform the resulting errors, see a > typical stacktrace below. > I

r367274 - [NFC] avoid AlignedCharArray in clang

Author: jfb Date: Mon Jul 29 16:12:48 2019 New Revision: 367274 URL: http://llvm.org/viewvc/llvm-project?rev=367274&view=rev Log: [NFC] avoid AlignedCharArray in clang As discussed in D65249, don't use AlignedCharArray or std::aligned_storage. Just use alignas(X) char Buf[Size];. This will allow

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov added a comment. Thanks for the suggestion. Sounds reasonably simple, I'll try this and report back with the result. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64799/new/ https://reviews.llvm.org/D64799

r367276 - Fix Linux build

Author: jfb Date: Mon Jul 29 16:28:44 2019 New Revision: 367276 URL: http://llvm.org/viewvc/llvm-project?rev=367276&view=rev Log: Fix Linux build r367274 broke it Modified: cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp Modified: cfe/trunk/lib/DirectoryWatcher/linux/Directo

[PATCH] D65425: [clang-doc] Fix expected output in tests

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Removes conversion of html paths in output. These will always be in posix-style paths. https://reviews.llvm.org/D65425 Files: clang-tools-extra/unittests

[PATCH] D65426: [Coverage] Hide coverage for regions with incorrect end locations (PR39942)

vsk created this revision. vsk added reviewers: rnk, phosek, manojgupta. ... instead of crashing. The real bug here is due to clang generating coverage for a conditional operator expanded from a macro. The location of the end of the conditional expression is not correct. The actual fix for this r

[PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1603431 , @BillyONeal wrote: > (In fact I observe many patterns in this review like: > > enum { Foo = alignof(void*); } > aligned_storage_t<1234, Foo> x; > > and then a bunch of casting to treat it as a char buffer; if it wa

[PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb updated this revision to Diff 212252. jfb added a comment. Significantly simplify the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 Files: llvm/include/llvm/Support/AlignOf.h llvm/unittests

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

cpplearner added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65050/new/ https://reviews.llvm.org/D65050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r367279 - [clang-doc] Fix expected output in tests

Author: diegoastiazaran Date: Mon Jul 29 17:07:34 2019 New Revision: 367279 URL: http://llvm.org/viewvc/llvm-project?rev=367279&view=rev Log: [clang-doc] Fix expected output in tests Removes conversion of html paths in output. These will always be in posix-style paths. Differential Revision: htt

[PATCH] D65425: [clang-doc] Fix expected output in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL367279: [clang-doc] Fix expected output in tests (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D65427: [analyzer] exploded-graph-rewriter: Implement Store pointers.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Those are useful for understanding contents of `LazyCompoundVal`s. F9

[PATCH] D65378: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting symbols/regions in a simple set

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I dunno why rC162028 was doing this. That's some advanced archeology down there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D65427: [analyzer] exploded-graph-rewriter: Implement Store pointers.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Thanks! Is it working in dark-mode as expected? Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:647 else: +self._dump(' (%s)' % st.ptr)

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov added a comment. Tried the suggested approach and ran into the issue described above. Either we make the diagnostics less useful ('did you mean foo::bar?' turns into 'unresolved identifier bar'; without mentioning the correction) or we even stop providing some corrections in addit

[PATCH] D65427: [analyzer] exploded-graph-rewriter: Implement Store pointers.

NoQ updated this revision to Diff 212257. NoQ added a comment. Hmm, on second thought... Make the pointers a bit darker in dark mode. F9692102: Screen Shot 2019-07-29 at 5.31.14 PM.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65427/new/ https:/

[PATCH] D65427: [analyzer] exploded-graph-rewriter: Implement Store pointers.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:647 else: +self._dump(' (%s)' % st.ptr) if prev_st is not None: Charusso wrote: > Extra space at the sta

[PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I have concerns that some of the patches that you landed prior to this will cause issues with old versions of MSVC, but in isolation, this is fine, and if anyone complains, we can address it on a ca

[PATCH] D65427: [analyzer] exploded-graph-rewriter: Implement Store pointers.

Charusso accepted this revision. Charusso added a comment. Oh, of course. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65427/new/ https://reviews.llvm.org/D65427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D65426: [Coverage] Hide coverage for regions with incorrect end locations (PR39942)

rnk added a comment. I did some digging and I figured out where things go wrong. The issue is the repeated string-izing of the macro argument, the repetition of `#func` here. This hacky patch seems to fix the issue: diff --git a/clang/lib/Lex/MacroArgs.cpp b/clang/lib/Lex/MacroArgs.cpp inde

[PATCH] D65379: [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. If only somebody could explain to me why do even need trimming in the first place :/ I was only keeping it around for easier exploded graph dumps reading, but these days we can trivially replace it

[PATCH] D65381: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > find clang/ -type f -exec sed -i > 's/std::shared_ptr/PathDiagnosticPieceRef/g' {} \; > git diff -U3 --no-color HEAD^ | clang-format-diff -p1 -i All you need to know about the state of C++ ref

[PATCH] D65428: Remove cache for macro arg stringization

rnk created this revision. rnk added reviewers: vsk, rsmith. Herald added a project: clang. The cache recorded the wrong expansion location for all but the first stringization. It seems uncommon to stringize the same macro argument multiple times, so this cache doesn't seem that important. Fixes

[PATCH] D65426: [Coverage] Hide coverage for regions with incorrect end locations (PR39942)

rnk added a comment. PTAL: https://reviews.llvm.org/D65428 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65426/new/ https://reviews.llvm.org/D65426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

NoQ added a comment. It's counter-idiomatic to pass manager objects (`ProgramStateManager`, `SValBuilder`, etc.) as const-references because it tells you pretty much nothing about what you can or cannot do with them. You don't really ever semantically mutate them in the first place. But when i

[PATCH] D65239: [analyzer] RangeConstraintManager: Apply constraint ranges of bitwise operations

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:496 + // as a bitwise operation result could be null. + if (RS.getConcreteValue() && RS.getConcreteValue()->getExtValue() == 0) +return State; Instead of "we kno

r367281 - [PowerPC] [Clang] Add platform guards to PPC vector intrinsics headers

Author: chaofan Date: Mon Jul 29 19:18:11 2019 New Revision: 367281 URL: http://llvm.org/viewvc/llvm-project?rev=367281&view=rev Log: [PowerPC] [Clang] Add platform guards to PPC vector intrinsics headers Move the platform check out of PPC Linux toolchain code and add platform guards to the intri

[PATCH] D64849: Add platform guards to PPC vector intrinsics headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367281: [PowerPC] [Clang] Add platform guards to PPC vector intrinsics headers (authored by chaofan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656 def warn_addition_in_bitshift : Warning< "operator '%0' has lower precedence than '%1'; " + "'%1' will be evaluated first">, InGroup, Def

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

MaskRay updated this revision to Diff 212265. MaskRay edited the summary of this revision. MaskRay added a comment. keep -Woverloaded-shift-op-parentheses enabled by default Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65192/new/ https://reviews.llvm.org/D65192

[PATCH] D65182: [analyzer] WIP: Add fix-it hint support.

NoQ added a comment. In D65182#1604280 , @baloghadamsoftware wrote: > Hmm, I was thinking on the same for some time but I wonder how many checkers > could find the correct fixits? Maybe the removal fixits of double frees or > double file closes, but I a

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

MaskRay marked 3 inline comments as done. MaskRay added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5647-5650 def warn_overloaded_shift_in_comparison :Warning< "overloaded operator %select{>>|<<}0 has higher precedence than " "comparison operato

[PATCH] D65182: [analyzer] WIP: Add fix-it hint support.

xazax.hun added a comment. The direction looks good to me. I wonder if it is worth to add some warnings somewhere that it is really tricky to come up with reasonable fixits for most path sensitive checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/ https://reviews.llvm.or

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

pcc added a comment. It doesn't seem sound to create the distinction between translation unit and linkage unit visibility and then allow passes to relax visibility. For example, imagine that you have an executable with (compiled with `-fvisibility=default`): struct PluginInterface { virtu

[PATCH] D65378: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting symbols/regions in a simple set

xazax.hun accepted this revision. xazax.hun added a comment. LGTM! I also do not see much value in the old code at this point. I would expect PathDiagnosticConsumers to be independent of the interesting symbols/regions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D65379: [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report

xazax.hun accepted this revision. xazax.hun added a comment. Looks good, some nits inline. I agree with Artem, we should consider omitting the trimming and document how to get something similar if desired for debugging. Just a random idea: maybe the original purpose of the trimming was to be abl

[PATCH] D65349: [analyzer] Be more careful with destructors of non-regions.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65349/new/ https://reviews.llvm.org/D65349 ___ cfe-commi

[PATCH] D65381: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef

xazax.hun added a comment. Just wondering, did you check if we actually need shared ownership for this type? If not, do not waste your time checking for now :) Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:244 +

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

xazax.hun added a comment. I like the change. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:630 +(const RegionBindings::TreeTy *)((uintptr_t)store & ~(uintptr_t)1), +RBFactory.getTreeFactory(), (bool)((uintptr_t)store & (uintptr_t)1)); } -

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/CFG.h:860 + /// child CFG blocks in a depth-first manner and see if all paths eventually + /// end up in an immediate sink block. + bool isInevitablySinking() const; Is it obvious what s

[PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1605523 , @rnk wrote: > I have concerns that some of the patches that you landed prior to this will > cause issues with old versions of MSVC, but in isolation, this is fine, and > if anyone complains, we can address it on a

[PATCH] D65290: [analyzer][NFC] Prove that we only track the evaluated part of the condition

xazax.hun accepted this revision. xazax.hun added a comment. More tests are always welcome :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65290/new/ https://reviews.llvm.org/D65290 ___ cfe-commits ma

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ReachingDefinitions.h:30 + }; + const VarDecl *Var; + CFGBlock::ConstCFGElementRef E; In the future we might also want to reason about `FieldDecl`s. Comment a

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

jfb added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup; aaron.ballman wrote: > xbolva00 wrote: > > aaron.ballman wrote: > > > I wo

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1590948 , @Manikishan wrote: > In D64695#1589818 , @lebedev.ri > wrote: > > > In D64695#1589740 , @Manikishan > > wrote: > > > > > In

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

jfb added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8192 +def warn_unreachable_stmt_in_switch : Warning< + "statement will be never executed">, InGroup>; def warn_bool_switch_condition : Warning< aaron.ballman wrote: > I thought w

<    1   2