[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

vsk created this revision. vsk added reviewers: ahatanak, JDevlieghere, friss. Herald added a subscriber: dexonsmith. rdar://53267670 https://reviews.llvm.org/D65116 Files: clang/lib/Driver/ToolChains/MSVC.h clang/test/Misc/win32-macho.c Index: clang/test/Misc/win32-macho.c ==

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Ping. I am going to submit this patch if nobody objects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nathanchance added a comment. I tested this patch on top of r366728 and saw no regressions in my set of kernel builds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list cf

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

JDevlieghere added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.h:81 /// Set CodeView as the default debug info format. Users can use -gcodeview /// and -gdwarf to override the default. Let's update the comment. CHANGES SINCE LAST ACTI

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

davide accepted this revision. davide added a comment. Minor otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65116/new/ https://reviews.llvm.org/D65116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Looks good! Sorry for the delay :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241 ___

r366744 - [Driver] Set the default win32-macho debug format to DWARF

Author: vedantk Date: Mon Jul 22 14:46:45 2019 New Revision: 366744 URL: http://llvm.org/viewvc/llvm-project?rev=366744&view=rev Log: [Driver] Set the default win32-macho debug format to DWARF rdar://53267670 Differential Revision: https://reviews.llvm.org/D65116 Modified: cfe/trunk/lib/Dri

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rL366744: [Driver] Set the default win32-macho debug format to DWARF (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran updated this revision to Diff 211201. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Use printHTMLEscaped() in ADT/StringExtras.h to write HTML entities. CHANGES SINCE LAST ACTION https://r

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, Thank you again for working on this patch. I think it can be committed after minor stylish issues are fixed. Comment at: clang/lib/AST/ASTImporter.cpp:1677 +

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. @jfb’s comment seems to be not addressed. In D64666#1583629 , @jfb wrote: > I think you want to default-ignore the "may lose precision" warnings, but not > the ones that you know always lose precision. CHANGES SINCE LAST AC

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

efriedma edited reviewers, added: aaron.ballman; removed: doug.gregor, eli.friedman, lvoufo. efriedma added a comment. Is this the only place where a compound type can contain a PackExpansionType? The code could probably use a brief comment explaining why we need to check this explicitly, even

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

rsmith added a comment. Thanks, LGTM. Do you need someone to commit this for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211213. Nathan-Huckleberry added a comment. - Add tracking of declaration of initializers in Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: c

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman added a comment. In D62648#1596535 , @rsmith wrote: > Thanks, LGTM. Do you need someone to commit this for you? Nope, I can commit it. There's still one outstanding issue though: typo-correction-cxx11.cpp is still failing with the `DelayedTypos

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. This patch extends the warnings for additional cases: 1. When the temporary is the res

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/inner-pointer.cpp:2 // RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.InnerPointer \ -// RUN: %s -analyzer-output=text -verify I had to disable

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman accepted this revision. aaron.ballman added a comment. In D64666#1583629 , @jfb wrote: > I think you want to default-ignore the "may lose precision" warnings, but not > the ones that you know always lose precision. We don't often add off-b

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1689 + void popDeclForInitializer() { +DeclForInitializer.pop_back(); + } might be nice to return the result, but maybe YAGNI? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1698 +} +return nullptr; + } Does: `return DeclForInitializer.empty() ? DeclForInitializer.back() : nullptr;` fit on one line? Comment at: clang/lib/Sem

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. I think @jfb wanted to say that if we know we always lose the precision, we should warn even without -Wxyz, no? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-comm

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; george.burgess.iv wrote: > aaron.ballman wrote: > > george.burgess.iv

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman added a comment. In D64666#1596619 , @xbolva00 wrote: > I think @jfb wanted to say that if we know we always lose the precision, we > should warn even without -Wxyz, no? Oh, good catch! I hadn't noticed that *both* diagnostics were `Defaul

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211221. Nathan-Huckleberry added a comment. - Style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: clang/include/clang/Parse/Parser.h clang

r366761 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 1.

Author: zer0 Date: Mon Jul 22 16:10:10 2019 New Revision: 366761 URL: http://llvm.org/viewvc/llvm-project?rev=366761&view=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. Moves list of phases into Types.def table: Currently Types.def contains a table of strings that are use

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. In D64666#1596512 , @xbolva00 wrote: > @jfb’s comment is not addressed yet. > > In D64666#1583629 , @jfb wrote: > > > I think you want to default-ignore the "may lose precision" warnings, b

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211224. Nathan-Huckleberry added a comment. - Style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: clang/include/clang/Parse/Parser.h clang

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366761: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. I think we should warn in that case even if GCC does not warn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2009 +AnalysisDeclContext &AC, +SmallVector PUDs) { + is `clang` namespace required here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D65125: clang-format: Fix namespace end comments for namespaces with attributes and macros

thakis created this revision. thakis added reviewers: klimek, sammccall. Fixes PR39247. While here, also make C++20 `namespace A::inline B::inline C` nested inline namespaced definitions work. Before: #define DEPRECATE_WOOF [[deprecated("meow")]] namespace DEPRECATE_WOOF woof { void f(

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Nathan-Huckleberry updated this revision to Diff 211230. Nathan-Huckleberry added a comment. - Disable self reference checking for C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64678/new/ https://reviews.llvm.org/D64678 Files: clang/lib/Sema/S

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

alexfh added a comment. LessClangTidyError only compares location and message, but it could also compare other things like notes, fixes, etc. For the problem outlined in the description of this patch we can probably include the checker name into the key. WDYT? Repository: rCTE Clang Tools E

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs());

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6564 +static bool shouldTrackImplicitObjectArg(const CXXMethodDecl *Callee, + const CXXMemberCallExpr *MCE) { + if (auto *

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. xazax.hun added a parent revision: D65120: More warnings regarding gsl::Pointer and gsl

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

george.burgess.iv added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > george.burgess.iv wrote: > > aaron.ballman

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 211245. ziangwan added a comment. Update diff 1. Fix trailing whitespaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaChe

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev created this revision. sdmitriev added reviewers: hfinkel, ABataev. Herald added subscribers: cfe-commits, guansong, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. This is the first set of changes for eliminating OpenMP linker script that adds new clang-offlo

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Final review ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

<    1   2