[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. A new function will be added to get the original SourceLocation for a SourceLocation that was impor

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske added a comment. New patch: https://reviews.llvm.org/D65064 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-inline-asm.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -emit-llvm -target-feature +sve -o - %s | FileCheck %s + rovka wrote: > Can you also add a test without +sve, to make su

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib created this revision. bruntib added reviewers: alexfh, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, mgrang, rnkovacs, whisperity. Herald added a project: clang. In case a checker is registered multiple times as an alias, the emitted warnings are uniqued by the report mess

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added reviewers: srhines, danalbert. peter.smith added a comment. I think that this may not apply for Android as AFAIK their ABI still requires 128-bit alignment in some cases. Adding some more reviewers from Android. Comment at: lib/Basic/Targets/ARM.cpp:311

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

martong added a comment. `ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me! Comment at: lib/AST/ASTImporter.cpp:1286 - return Importer.getToContext().getAutoType(*ToDeducedTypeOrErr, - T->getKeyword(), -

[PATCH] D65067: [clangd] Fix auto expand not work on "const au^to s = 123;"

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65067 Files: clang-tools-extra/clangd/refactor/tweaks/

r366670 - [OpenCL] Improve destructor support in C++ for OpenCL

Author: mantognini Date: Mon Jul 22 02:39:13 2019 New Revision: 366670 URL: http://llvm.org/viewvc/llvm-project?rev=366670&view=rev Log: [OpenCL] Improve destructor support in C++ for OpenCL This re-applies r366422 with a fix for Bug PR42665 and a new regression test. Added: cfe/trunk/test/C

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65064/new/ https://reviews.llvm.org/D65064

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2332 S->isSemanticForm() ? S->getSyntacticForm() : S, Queue)); TRY_TO(TraverseSynOrSemInitListExpr( S->isSemanticForm() ? S : S->getSemanticForm(), Queue)); ---

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211034. dnsampaio added a comment. - Set androideabi alignment to 128 bits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/ARM.cpp test/CodeGen/ARM/exce

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

ilya-biryukov updated this revision to Diff 211035. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Rewrite code as suggested in the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64762/new/ https://reviews.ll

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:476 + NewImporter->setFileIDImportHandler( + [this, Unit](FileID ToID, FileID FromID, ASTImporter &Importer) { +assert(ImportedFileIDs.find(ToID) == ImportedFileIDs.end() && --

r366672 - [AST] Treat semantic form of InitListExpr as implicit code in traversals

Author: ibiryukov Date: Mon Jul 22 02:58:53 2019 New Revision: 366672 URL: http://llvm.org/viewvc/llvm-project?rev=366672&view=rev Log: [AST] Treat semantic form of InitListExpr as implicit code in traversals Summary: In particular, do not traverse the semantic form if shouldVisitImplicitCode() r

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

This revision was automatically updated to reflect the committed changes. Closed by commit rL366672: [AST] Treat semantic form of InitListExpr as implicit code in traversals (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[clang-tools-extra] r366674 - [clangd] Log input code of failed highlighting tests. NFC

Author: ibiryukov Date: Mon Jul 22 03:05:11 2019 New Revision: 366674 URL: http://llvm.org/viewvc/llvm-project?rev=366674&view=rev Log: [clangd] Log input code of failed highlighting tests. NFC Modified: clang-tools-extra/trunk/clangd/unittests/SemanticHighlightingTests.cpp Modified: clang-t

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked 2 inline comments as done. dnsampaio added a comment. Set android-abi default to 128. Added tests for android and not-android. Comment at: lib/Basic/Targets/ARM.cpp:311 // Maximum alignment for ARM NEON data types should be 64-bits (AAPCS) if (IsAAPCS &

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 211042. SjoerdMeijer added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Moved the codegen test to a separate file - Added a langref description for this new metadata node. CHANGES SINCE LAST ACTION https://review

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added a comment. Thanks for the update. Will be worth adding some reviewers from Apple to see if this change should be IsAAPCS only. I've no more further comments myself besides a small nit on style. Comment at: lib/Basic/Targets/ARM.cpp:331 + // but Android

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

rovka added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-inline-asm.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -emit-llvm -target-feature +sve -o - %s | FileCheck %s + sdesmalen wrote: > rovka wrote: > > Can you also add a test without

[clang-tools-extra] r366675 - [clangd] Set buffer name for main file. NFCI

Author: sammccall Date: Mon Jul 22 04:12:16 2019 New Revision: 366675 URL: http://llvm.org/viewvc/llvm-project?rev=366675&view=rev Log: [clangd] Set buffer name for main file. NFCI Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 FillDiagBase(*LastDiag); -adjustDiagFromHeader(*LastDiag, Info, *LangOpts); +if (!InsideMainFile) + LastDiagWasAdjusted = adjustDiagFromHeader(*LastDiag, Info, *LangOpt

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

balazske updated this revision to Diff 211059. balazske marked an inline comment as done. balazske added a comment. Removed ASTImporter from "callback" function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65064/new/ https://reviews.llvm.org/D650

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:476 + NewImporter->setFileIDImportHandler( + [this, Unit](FileID ToID, FileID FromID, ASTImporter &Importer) { +assert(ImportedFileIDs.find(ToID) == ImportedFileIDs.end() && -

r366682 - Revert the change to the [[nodiscard]] feature test macro value.

Author: aaronballman Date: Mon Jul 22 05:49:28 2019 New Revision: 366682 URL: http://llvm.org/viewvc/llvm-project?rev=366682&view=rev Log: Revert the change to the [[nodiscard]] feature test macro value. This value only gets bumped once both P1301 and P1771 are implemented. Modified: cfe/tru

Re: r366626 - Implement P1301R4, which allows specifying an optional message on the [[nodiscard]] attribute.

On Sun, Jul 21, 2019 at 7:40 AM Richard Smith wrote: > > On Sat, 20 Jul 2019 at 09:55, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Sat Jul 20 00:56:34 2019 >> New Revision: 366626 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=366626&view=rev >> Log: >> Impleme

r366683 - Updated the signature for some stack related intrinsics (CLANG)

Author: cdevadas Date: Mon Jul 22 05:50:30 2019 New Revision: 366683 URL: http://llvm.org/viewvc/llvm-project?rev=366683&view=rev Log: Updated the signature for some stack related intrinsics (CLANG) Modified the intrinsics int_addressofreturnaddress, int_frameaddress & int_sponentry. This commit

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366683: Updated the signature for some stack related intrinsics (CLANG) (authored by cdevadas, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

aaron.ballman added a comment. Is it intentional that this review has no reviewers listed (like, is this a work in progress you don't expect review on yet)? Comment at: clang/include/clang/Basic/Attr.td:2985 + "pipeline", "pipeline_initiation_interval

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM alongside NS_ENUM.

heijink updated this revision to Diff 211065. heijink edited the summary of this revision. heijink added a comment. Also added support for formatting CF_CLOSED_ENUM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65012/new/ https://reviews.llvm.org/

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer added a comment. > Is it intentional that this review has no reviewers listed (like, is this a > work in progress you don't expect review on yet)? No, sorry about this, that's not intentional. It started indeed as a work-in-progress patch when I wrote to the clang/llvm with an idea

[clang-tools-extra] r366687 - Update documentation for all CERT checks that correspond to a recommendation.

Author: aaronballman Date: Mon Jul 22 06:22:08 2019 New Revision: 366687 URL: http://llvm.org/viewvc/llvm-project?rev=366687&view=rev Log: Update documentation for all CERT checks that correspond to a recommendation. CERT removed their C++ secure coding recommendations from public view and so th

[PATCH] D65067: [clangd] Fix auto expand not work on "const au^to s = 123;"

hokein abandoned this revision. hokein added a comment. as discussed, this is an issue of selection tree (selection tree should give the `AutoTypeLoc` on `const aut^o`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65067/new/ https://reviews.llvm

[PATCH] D63126: [clangd] Implement "prepareRename"

hokein updated this revision to Diff 211080. hokein added a comment. Update the patch, and add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63126/new/ https://reviews.llvm.org/D63126 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

r366689 - [OPENMP]Add support for analysis of firstprivate variables.

Author: abataev Date: Mon Jul 22 06:51:07 2019 New Revision: 366689 URL: http://llvm.org/viewvc/llvm-project?rev=366689&view=rev Log: [OPENMP]Add support for analysis of firstprivate variables. Summary: Firstprivate variables are the variables, for which the private copies must be created in the

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366689: [OPENMP]Add support for analysis of firstprivate variables. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHAN

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev added a project: clang. This patch adds isDirectlyDerivedFrom AST-matcher which is similar to isDerivedFrom but only matches against direct base classes. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D64914: Implement P1771

erichkeane updated this revision to Diff 211094. erichkeane marked an inline comment as done. erichkeane added a comment. Rebased and did all the comments (including the www_status). @aaron.ballman : Wasn't positive what you meant about the conversion functions, but I think I got one? I would

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 211096. SjoerdMeijer added a comment. More doc changes added to `AttrDocs.td` and `LangRef.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64744/new/ https://reviews.llvm.org/D64744 Files: clang/docs/LanguageExtensions.rst clang/include

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. @a_sidorin, @shafik This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D44100 ___ cfe-commits mailing list cfe-commits@lis

r366694 - [NFC] Relaxed regression tests for PR42665

Author: mantognini Date: Mon Jul 22 07:47:36 2019 New Revision: 366694 URL: http://llvm.org/viewvc/llvm-project?rev=366694&view=rev Log: [NFC] Relaxed regression tests for PR42665 Following up on the buildbot failures, this commits relaxes some tests: instead of checking for specific IR output, i

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added a comment. FYI In order to fix buildbot test failures, I've pushed https://reviews.llvm.org/rG1b2da771f561affe36eb5eb0c7a3d2862c5a5c1c. I'll keep an eye on buildbots for additional fallout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211103. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/A

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong added a comment. @a_sidorin This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

kmclaughlin updated this revision to Diff 24. kmclaughlin added a comment. - Updated test to remove unused variable 't' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64739/new/ https://reviews.llvm.org/D64739 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/CodeGen/aarch64

r366698 - [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp

Author: sammccall Date: Mon Jul 22 08:55:53 2019 New Revision: 366698 URL: http://llvm.org/viewvc/llvm-project?rev=366698&view=rev Log: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp Summary: SelectionTree is a RecursiveASTVisitor which processes getSourceRange() f

[clang-tools-extra] r366698 - [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp

Author: sammccall Date: Mon Jul 22 08:55:53 2019 New Revision: 366698 URL: http://llvm.org/viewvc/llvm-project?rev=366698&view=rev Log: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp Summary: SelectionTree is a RecursiveASTVisitor which processes getSourceRange() f

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 29. Szelethus added a comment. I plan to split this patch up eventually, but here's where I'm standing right now: - Correct the algorithm that by accident did this: `GEN[B] = GEN[B] union (IN[B] - KILL[B])` instead of this: `OUT[B] = GEN[B] union (IN[

r366699 - [X86] Remove const from some intrinsics that shouldn't have them

Author: probinson Date: Mon Jul 22 09:14:09 2019 New Revision: 366699 URL: http://llvm.org/viewvc/llvm-project?rev=366699&view=rev Log: [X86] Remove const from some intrinsics that shouldn't have them Modified: cfe/trunk/lib/Headers/emmintrin.h Modified: cfe/trunk/lib/Headers/emmintrin.h URL

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211127. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Address the rest of the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/

[PATCH] D65100: [clangd] Fix SelectionTree traversal of qualified types

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. QualifiedTypeLoc isn't treated like a regular citizen by RecursiveASTVisitor. This meant we weren't inter

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added a comment. test case missing A8 aside this looks ok to me. Would like to see if there are any comments from the Pacific time zone. Comment at: test/CodeGen/ARM/exception-alignment.cpp:8 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include +

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65012/new/ https://reviews.llvm.org/D65012

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

benhamilton added a comment. Oh, I forgot there's one more place you should touch — the Objective-C style guesser for headers will need to be updated to understand that `NS_CLOSED_ENUM` indicates Objective-C: https://reviews.llvm.org/source/llvm-github/browse/master/clang/lib/Format/Format.cpp$

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211132. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment - Added missing align 8 test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked an inline comment as done. dnsampaio added a comment. True. Thx again. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list cfe-commit

[libunwind] r366701 - [libunwind][ARM] Fix types in _Unwind_VRS_Get.

Author: miyuki Date: Mon Jul 22 09:43:03 2019 New Revision: 366701 URL: http://llvm.org/viewvc/llvm-project?rev=366701&view=rev Log: [libunwind][ARM] Fix types in _Unwind_VRS_Get. This is a small fix for https://reviews.llvm.org/D64996. The types of w0 and w1 in _Unwind_VRS_Get must be uint64_t,

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

heijink updated this revision to Diff 211135. heijink added a comment. Adds NS_CLOSED_ENUM to the keywords that cause LLVM to detect Objective-C. Changed NSInteger to int in the unit tests, because NSInteger also signals Objective-C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

r366702 - [OPENMP][MSVC]Enable /openmp[:experimental] to compile OpenMP.

Author: abataev Date: Mon Jul 22 09:49:59 2019 New Revision: 366702 URL: http://llvm.org/viewvc/llvm-project?rev=366702&view=rev Log: [OPENMP][MSVC]Enable /openmp[:experimental] to compile OpenMP. Mapped /openmp[:experimental] to -fopenmp option and /openmp- option to -fno-openmp Modified: c

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rsmith added a comment. In D64799#1592263 , @rnk wrote: > In D64799#1591732 , @ilya-biryukov > wrote: > > > @rsmith, I'll look into emitting the typos when we pop expression > > evaluation context, but do we expec

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

heijink updated this revision to Diff 211137. heijink added a comment. Fixed formatting of Format.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65012/new/ https://reviews.llvm.org/D65012 Files: clang/lib/Format/Format.cpp clang/lib/Format

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia created this revision. Anastasia added reviewers: svenvh, neil.hickey, kpet. Herald added subscribers: ebevhan, yaxunl. This suggestion was made in https://reviews.llvm.org/D64418?id=210101#inline-579453 but I am changing this standalone here. I see two benefits for this rename: - Al

[PATCH] D65101: [clangd] SelectionTree treats TranslationUnitDecl consistently with other containers.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously TranslationUnitDecl would never be selected. This means root() and commonAncestor() are now ne

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 211140. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp clang/lib/B

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211142. xazax.hun added a comment. - Fix a TODO and add some more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaInit.

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2637 internal::Matcher, Base) { - return Finder->classIsDerivedFrom(&Node, Base, Builder); + return Finder->classIsDerivedFrom(&Node, Base, Builder, false); } ---

Re: r366474 - [OPENMP]Provide correct data sharing attributes for loop control

Merged to Clang 9 in r366705. On Thu, Jul 18, 2019 at 10:48 AM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Thu Jul 18 10:49:13 2019 > New Revision: 366474 > > URL: http://llvm.org/viewvc/llvm-project?rev=366474&view=rev > Log: > [OPENMP]Provide correct data sharing attributes

Re: r366483 - [OPENMP]Fix sharing of threadprivate variables with TLS support.

Merged to Clang 9 in r366706. On Thu, Jul 18, 2019 at 12:39 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Thu Jul 18 12:40:24 2019 > New Revision: 366483 > > URL: http://llvm.org/viewvc/llvm-project?rev=366483&view=rev > Log: > [OPENMP]Fix sharing of threadprivate variables

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

zinovy.nis created this revision. zinovy.nis added reviewers: alexfh, rsmith, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D65104 Files: clang-tidy/performance/NoexceptMoveConstruct

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

zinovy.nis updated this revision to Diff 211147. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65104/new/ https://reviews.llvm.org/D65104 Files: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp test/clang-tidy/performance-noexcept-move-constructor-fix.cpp Index: test/clang-ti

Re: r366699 - [X86] Remove const from some intrinsics that shouldn't have them

Merged to clang 9 in r366711. On Mon, Jul 22, 2019 at 9:13 AM Paul Robinson via cfe-commits wrote: > > Author: probinson > Date: Mon Jul 22 09:14:09 2019 > New Revision: 366699 > > URL: http://llvm.org/viewvc/llvm-project?rev=366699&view=rev > Log: > [X86] Remove const from some intrinsics that s

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211148. AntonBikineev added a comment. Manuel, I left some cases which deviated from the isDerivedFrom matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files: clang/do

Re: [clang-tools-extra] r366443 - [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670

Merged to the 9 branch in r366713. On Thu, Jul 18, 2019 at 8:00 AM Sam McCall via cfe-commits wrote: > > Author: sammccall > Date: Thu Jul 18 08:00:38 2019 > New Revision: 366443 > > URL: http://llvm.org/viewvc/llvm-project?rev=366443&view=rev > Log: > [clangd] Disable DumpRecordLayout by default

Re: [clang-tools-extra] r366451 - [Clangd] Changed ExtractVariable to only work on non empty selections

Merged to the 9 branch in r366714 On Thu, Jul 18, 2019 at 8:37 AM Shaurya Gupta via cfe-commits wrote: > > Author: sureyeaah > Date: Thu Jul 18 08:38:03 2019 > New Revision: 366451 > > URL: http://llvm.org/viewvc/llvm-project?rev=366451&view=rev > Log: > [Clangd] Changed ExtractVariable to only w

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211150. xazax.hun added a comment. - Fix a false positive from previous change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/Se

Re: r366448 - [ASTUnit] Fix a regression in cached completions

Merged together with r366457 to Clang 9 in r366717. On Thu, Jul 18, 2019 at 8:21 AM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Thu Jul 18 08:21:34 2019 > New Revision: 366448 > > URL: http://llvm.org/viewvc/llvm-project?rev=366448&view=rev > Log: > [ASTUnit] Fix a regressi

Re: [clang-tools-extra] r366455 - [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

Merged this and r366559 to the 9 branch in r366718. On Thu, Jul 18, 2019 at 9:13 AM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Thu Jul 18 09:13:23 2019 > New Revision: 366455 > > URL: http://llvm.org/viewvc/llvm-project?rev=366455&view=rev > Log: > [clangd] Get rid of dot

r366719 - Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

Author: benhamilton Date: Mon Jul 22 11:20:01 2019 New Revision: 366719 URL: http://llvm.org/viewvc/llvm-project?rev=366719&view=rev Log: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM. Summary: Addresses the formatting of NS_CLOSED_ENUM and CF_CLOSED

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366719: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM… (authored by benhamilton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[PATCH] D65106: [OPENMP]Add support for analysis of reduction variables.

ABataev created this revision. ABataev added a reviewer: NoQ. Herald added subscribers: jdoerfert, guansong. Herald added a project: clang. Reduction variables are the variables, for which the private copies must be created in the OpenMP regions. Then they are initialized with the predefined value

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek requested changes to this revision. klimek added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/LibASTMatchersReference.html:5277 +MatcherCXXRecordDecl>isDirectlyDe

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Replace <, > and " with its corresponding html entities before rendering text nodes. https://reviews.llvm.org/D65107 Files: clang-tools-extr

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis created this revision. thakis added a reviewer: rnk. This relands r365703 (and r365714), originally reviewed at https://reviews.llvm.org/D64527. The problem with the old approach was that clang would now warn about -Wa flags that the integrated assembler didn't understand even when -fno-in

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis added a comment. Note to self: Check https://github.com/ClangBuiltLinux/linux/issues/598 before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list cfe-

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) (This jus

[PATCH] D64655: [Clang][Driver] don't error for unsupported as options for -no-integrated-as

thakis added a comment. I think https://reviews.llvm.org/D65108 is a better fix, for the reason rnk gave above. I think this one can be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64655/new/ https://reviews.llvm.org/D64655

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > (This just wraps all the

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) nickdesau

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

george.burgess.iv added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > george.burgess.iv wrote: > > nit: I'd just

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > nickdesaulniers wrote: >

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs()); I think it would be better

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

NoQ added a comment. In D64991#1595853 , @Szelethus wrote: > `CFGElementRef` Wait, is it a thing already?? Did i miss anything??? > This analysis isn't conservative enough yet, I really should include function > calls with non-const references into the

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus added a comment. In D64991#1596292 , @NoQ wrote: > In D64991#1595853 , @Szelethus wrote: > > > `CFGElementRef` > > > Wait, is it a thing already?? Did i miss anything??? Oh, yea, I have it locally, still

[PATCH] D65110: [NewPM] Run avx*-builtins.c tests under the new pass manager only

leonardchan created this revision. leonardchan added reviewers: chandlerc, craig.topper, spatel, RKSimon. leonardchan added a project: clang. This patch changes the following tests to run under the new pass manager only: Clang :: CodeGen/avx512-reduceMinMaxIntrin.c (1 of 4) Clang :: CodeGen/a

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. I created D65110 if we're ok with just using the new PM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 ___ cfe-commits mailing list c

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

aaron.ballman added inline comments. Comment at: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:57 + assert(Decl->getNumParams() > 0); + SourceLocation NoexceptLoc = Decl->getParamDecl(Decl->getNumParams() - 1) + ->getSourc

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:181 +std::string TextNode::getHTMLEntity(const char &C) { + switch (C) { There is printHTMLEscaped() in ADT/StringExtras.h. May b it could be used or common code m

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 211184. dgoldman added a comment. - Bug fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.cpp Index: test

[libunwind] r366734 - [runtimes] Don't depend on libpthread on Android

Author: kongyi Date: Mon Jul 22 13:41:03 2019 New Revision: 366734 URL: http://llvm.org/viewvc/llvm-project?rev=366734&view=rev Log: [runtimes] Don't depend on libpthread on Android r362048 added support for ELF dependent libraries, but broke Android build since Android does not have libpthread.

  1   2   >