[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1110 PathRef File, std::vector Highlightings) { + llvm::ArrayRef Prev; + { hokein wrote: > this seems unsafe, we get a reference of the map value, we might access it

[PATCH] D64850: Remove use of malloc in PPC mm_malloc.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64850/new/ https://reviews.llvm.org/D64850 ___ cfe-commits

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210253. jvikstrom marked 15 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files: clang-tools

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 210257. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741 Files: clang-tools-

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:170 +return; + Loc = SM.getSpellingLoc(Loc); +} hokein wrote: > The Loc here maybe not in the main file, co

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 210259. jvikstrom marked an inline comment as done. jvikstrom added a comment. Fixed edge case when removing conflicting tokens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.o

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 updated this revision to Diff 210258. boga95 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom added a comment. In D64741#1587204 , @ilya-biryukov wrote: > How should this behave when if the same token is used multiple times inside a > macro and the uses are different? Could we add this to tests? > E.g. > > #define W(a) class a { void

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 updated this revision to Diff 210260. boga95 marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 210261. jvikstrom added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang-too

[clang-tools-extra] r366304 - Replace CRLF with LF.

Author: ruiu Date: Wed Jul 17 01:31:51 2019 New Revision: 366304 URL: http://llvm.org/viewvc/llvm-project?rev=366304&view=rev Log: Replace CRLF with LF. Modified: clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp Modified: clang-tools-extra/trunk/unittests/cl

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

ilya-biryukov added a comment. > I had completely missed that there could be conflicting tokens when only > highlighting macro arguments as well. Added code to just remove conflicting > tokens. Picking one of the highlightings looks fine, but we probably want to make sure it's deterministic. G

[PATCH] D64491: [Driver] Enable __cxa_atexit on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL366305: [Driver] Enable __cxa_atexit on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

r366305 - [Driver] Enable __cxa_atexit on Solaris

Author: ro Date: Wed Jul 17 01:37:00 2019 New Revision: 366305 URL: http://llvm.org/viewvc/llvm-project?rev=366305&view=rev Log: [Driver] Enable __cxa_atexit on Solaris Starting with Solaris 11.4 (which is now the required minimal version), Solaris does support __cxa_atexit. This patch reflects

r366306 - [OpenCL][Sema] Minor refactoring and constraint checking

Author: mantognini Date: Wed Jul 17 01:52:09 2019 New Revision: 366306 URL: http://llvm.org/viewvc/llvm-project?rev=366306&view=rev Log: [OpenCL][Sema] Minor refactoring and constraint checking Summary: Simplify code a bit and add assertion to address post-landing comments from D64083. Subscribe

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:255 + // ArrayRefs to the current line in the highlights. + ArrayRef NewLine(Highlightings.data(), + Highlightings.data()), jvikstro

[PATCH] D64804: [OpenCL][Sema] Minor refactoring and constraint checking

This revision was automatically updated to reflect the committed changes. Closed by commit rL366306: [OpenCL][Sema] Minor refactoring and constraint checking (authored by mantognini, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64855: [clangd] Added highlightings for template parameters and specializations.

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Template parameters and specializations were not being highlighted before. This adds highlighti

[PATCH] D53191: [clang] Introduce new completion context types

nik added a comment. Herald added a project: clang. I've bisected https://bugs.llvm.org/show_bug.cgi?id=42646 to this change. Reverting it fixes the issue. Please look into it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53191/new/ https://reviews.llvm.org/D5

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:170 +return; + Loc = SM.getSpellingLoc(Loc); +} jvikstrom wrote: > hokein wrote: > > The Loc here maybe not in the main file, considering the case > > >

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 210273. serge-sans-paille marked 5 inline comments as done and 2 inline comments as done. serge-sans-paille added a comment. Added a `Bye` project in examples/ Fixed linking of plugins into core tools Fixed dependency issue Repository: rG LLVM G

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Szelethus added a comment. Hmm, okay, so we convert `-1` from the config file to `UINT_MAX` in the code, I like it! I wrote a couple nits but they really are just that. In general, for each different error message, a different test case would be great. Comment at: include/cl

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Beside my two comments, I think this looks good. Comment at: docs/LanguageExtensions.rst:1614 + +By default references will refer to ``__generic`` address space objec

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

yurybura added a comment. Dear @aganea, Do you have any plans to make this PR compatible with trunk? Now MSVC with /MP builds much faster than clang-cl (at least 2x faster for our project)... Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52193/new/ http

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia updated this revision to Diff 210277. Anastasia added a comment. Fixed typo in the comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 Files: lib/Sema/SemaDecl.cpp lib/Sema/SemaType.cpp lib/Sema/TreeTransform.h test/SemaOpe

[PATCH] D64801: [analyzer] Add CTU user docs

dkrupp requested changes to this revision. dkrupp added a comment. This revision now requires changes to proceed. Thanks Gabor for writing this. I suggested some minor changes to the txt. Otherwise LGTM. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:98 + +

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

hans added a comment. I will try to take a look, but can you please expand the patch description a little to make it more clear exactly what you're proposing to change? Sorry for all the questions below, I'm just trying to understand exactly what the issue is. > Previously, -fdiagnostics-absol

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked an inline comment as done. martong added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/c/ast/TestAST.py:57 +# This expr command imports __sFILE with definition +# (FILE is a typedef to __sFILE.) +self.expect(

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 210281. martong marked 5 inline comments as done. martong added a comment. - Applied clang-format on lldb parts (this changed two lines) - Added a comment for predicate - Merged the test into TestCModules.py Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

hans added a comment. Thanks for polishing the UX! :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64504/new/ https://reviews.llvm.org/D64504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

hans added a comment. I think this is going to be my favourite new feature in clang 9 :-) Do you want to put a small note in docs/ReleaseNotes.rst? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64253/new/ https://reviews.llvm.org/D64253 ___

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210282. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Rewrote test to be more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:281 + )cpp"}}, +{{5}, + { hokein wrote: > so the empty lines are stored separately, which is not easy to figure out

[clang-tools-extra] r366311 - [clangd] Fix error message in tweaktests to be useful. NFC

Author: sammccall Date: Wed Jul 17 03:17:47 2019 New Revision: 366311 URL: http://llvm.org/viewvc/llvm-project?rev=366311&view=rev Log: [clangd] Fix error message in tweaktests to be useful. NFC Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Modified: clang-tools-extra/tru

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom added a comment. In D64741#1588987 , @ilya-biryukov wrote: > > I had completely missed that there could be conflicting tokens when only > > highlighting macro arguments as well. Added code to just remove conflicting > > tokens. > > Picking one

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

nik added a comment. Herald added a subscriber: arphaman. Herald added a project: clang. I've bisected https://bugs.llvm.org/show_bug.cgi?id=42649 to this change. Reverting this change fixes the issue. Please look into it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1588154 , @rnk wrote: > > To avoid a similar inconsistence with host compilers that don't predefine > > _FILE_OFFSET_BITS=64 > > (e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted > > shortly. > > I'm

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

angushewlett added a comment. In D52193#1457612 , @aganea wrote: > That is strange. As you can’t mix /Yc and /Yu on the command line, MSBuild > should issue two different calls to clang-cl, one with /Yc and one /Yu /MP. > Can you check with ProcMon that

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:275 +bool operator<(const HighlightingToken &L, const HighlightingToken &R) { + return std::tie(L.R, L.Kind) < std::tie(R.R, R.Kind);; +} nit: remove the redundant `;`.

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

ilya-biryukov added a comment. Thanks for pointing out I missed stuff. The strategy for conflicting highlightings LG, just a few NITs left from my side. In D64741#1589144 , @jvikstrom wrote: > Already added the case you sent a comment on in the test case

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. > You may not like them, but there are plenty of examples in OSTargets.h (for > kFreeBSD, Hurd, Linux, RTEMS, AIX, Windows, NaCl and several more). Why take offense in the Solaris case if this is already common practice? I used that as an example. Defining _GNU_SOURCE

[PATCH] D64415: Consistent types and naming for AArch64 target features (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366315: [AArch64] Consistent types and naming for AArch64 target features (NFC) (authored by chill, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r366315 - [AArch64] Consistent types and naming for AArch64 target features (NFC)

Author: chill Date: Wed Jul 17 04:24:37 2019 New Revision: 366315 URL: http://llvm.org/viewvc/llvm-project?rev=366315&view=rev Log: [AArch64] Consistent types and naming for AArch64 target features (NFC) Differential Revision: https://reviews.llvm.org/D64415 Committed as obvious. Modified:

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware updated this revision to Diff 210287. baloghadamsoftware added a comment. Herald added a subscriber: jfb. Tests for `volatile`, atomics and noreturn functions added. Check fixed to make these tests pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64736/new/ https:

[PATCH] D64415: Consistent types and naming for AArch64 target features (NFC)

chill updated this revision to Diff 210286. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64415/new/ https://reviews.llvm.org/D64415 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h Index: clang/lib/Basic/Targets/AArch64.h

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1589174 , @MaskRay wrote: > >> Even if it were, this would only affect future releases. The user experience >> of "you need to upgrade to Solaris 11.x" or install update y to get this" >> seems pretty dismal to me. Besid

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

koldaniel added a comment. Hi, do you have any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 __

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:170 +return; + Loc = SM.getSpellingLoc(Loc); +} hokein wrote: > jvikstrom wrote: > > hokein wrote: > > > The Loc here maybe not in the main file, consider

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

alexfh added a comment. In D33841#1589212 , @koldaniel wrote: > Hi, do you have any additional comments? Could you mark "Done" the comments you've addressed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210297. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files: clang-tools-

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

alexfh added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:38-40 +Message = "'extern' keyword has no effect"; + } else { +Message = "redundant 'extern' keyword"; These messages alone will be quite confusing unless the user

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64860 Files: clang-tools-extra/clangd/GlobalCo

[PATCH] D64861: [clang-tidy] Adjust location of namespace comment diagnostic

ilya-biryukov created this revision. ilya-biryukov added reviewers: alexfh, hokein. Herald added subscribers: kadircet, xazax.hun. Herald added a project: clang. If there is no comment, place it at the closing brace of a namespace definition. Previously it was placed at the next character after th

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:221-230 + if (BoundNumVal.isUnknown()) { +if (const auto *BoundDeclRefExpr = dyn_cast(BoundExpr)) { + // FIXME: Add other

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 __

[PATCH] D64712: [clangd][NFC] Refactor background-index shard loading

kadircet updated this revision to Diff 210303. kadircet added a comment. - As discussed offline, moved the "staleness" detection back to background index - A renaming within Rebuilder, "LoadedTUs -> LoadedShards" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

baloghadamsoftware updated this revision to Diff 210302. baloghadamsoftware added a comment. Test case added for loop conditions written in reverse order and code fixed to make the test pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63279/new/ https://reviews.llvm.org/D63279 File

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

baloghadamsoftware added a comment. I am a bit afraid of the performance of the feature because of the extensive use of matchers. Based on my previous experiences matcher creation and disposition are expensive operations. Matchers are meant to be a kind of "static" structures created only once

[clang-tools-extra] r366320 - [clangd] Handle windows line endings in QueryDriver

Author: kadircet Date: Wed Jul 17 06:14:02 2019 New Revision: 366320 URL: http://llvm.org/viewvc/llvm-project?rev=366320&view=rev Log: [clangd] Handle windows line endings in QueryDriver Summary: fixes second case of https://github.com/clangd/clangd/issues/93 Reviewers: sammccall Subscribers: i

[PATCH] D64789: [clangd] Handle windows line endings in QueryDriver

This revision was automatically updated to reflect the committed changes. Closed by commit rL366320: [clangd] Handle windows line endings in QueryDriver (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[clang-tools-extra] r366321 - [clangd] Force the required interpretation of #import on windows tests.

Author: sammccall Date: Wed Jul 17 06:21:25 2019 New Revision: 366321 URL: http://llvm.org/viewvc/llvm-project?rev=366321&view=rev Log: [clangd] Force the required interpretation of #import on windows tests. Summary: NFC but should fix a bunch of tests. Reviewers: kadircet Subscribers: ilya-bir

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. This fixes a case where we show diagnostics on arbitrary lines, in an internal codebase. Open for ideas on unittesting this.

r366322 - [AArch64] Add support for Transactional Memory Extension (TME)

Author: chill Date: Wed Jul 17 06:23:27 2019 New Revision: 366322 URL: http://llvm.org/viewvc/llvm-project?rev=366322&view=rev Log: [AArch64] Add support for Transactional Memory Extension (TME) TME is a future architecture technology, documented in https://developer.arm.com/architectures/cpu-ar

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366322: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D64416?v

[PATCH] D64744: #pragma clang loop predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 210314. SjoerdMeijer retitled this revision from "Loop #pragma tail_predicate" to " #pragma clang loop predicate(enable|disable)". SjoerdMeijer edited the summary of this revision. Herald added a subscriber: zzheng. CHANGES SINCE LAST ACTION https://re

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

Anastasia created this revision. Anastasia added reviewers: neil.hickey, svenvh. Herald added subscribers: ebevhan, yaxunl. https://reviews.llvm.org/D64867 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/LangOptions.def i

[PATCH] D64744: #pragma clang loop predicate(enable|disable)

SjoerdMeijer added a comment. So I went for: predicate(enable) as I think that is most general, best capturing it, but I am of course completely open to bikeshedding names :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64744/new/ https://reviews.llvm.org/D64744 __

r366325 - [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

Author: martong Date: Wed Jul 17 06:47:46 2019 New Revision: 366325 URL: http://llvm.org/viewvc/llvm-project?rev=366325&view=rev Log: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src Summary: With LLDB we use localUncachedLookup(), however, that fails to find Decls when a transpa

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

This revision was automatically updated to reflect the committed changes. Closed by commit rL366325: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} jpakkane wrote: > alexfh wrote: > > jpakkane wrote: > >

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. Thank you guys for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

kpet requested changes to this revision. kpet added a comment. This revision now requires changes to proceed. Very useful to have all of this documented! Thanks! Comment at: docs/LanguageExtensions.rst:1527 +This functionality is built on top of OpenCL C v2.0 and C++17. Regular

[PATCH] D64861: [clang-tidy] Adjust location of namespace comment diagnostic

alexfh accepted this revision. alexfh added a comment. LG. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64861/new/ https://reviews.llvm.org/D64861 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added a comment. In D59474#1561161 , @lildmh wrote: > Change the type of size from `size_t` to `int64_t`, and rebase Lingda, could you rebase it again? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.ll

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. Jenkins looks okay: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31157/ .The build is red but the the previous run has the very same failing test case: expression_command/weak_symbols/TestWeakSymbols.py Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong added a comment. @shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64075/

r366332 - [ASTImporter] Fix structural eq of lambdas

Author: martong Date: Wed Jul 17 07:40:09 2019 New Revision: 366332 URL: http://llvm.org/viewvc/llvm-project?rev=366332&view=rev Log: [ASTImporter] Fix structural eq of lambdas Summary: The structural equivalence check reported false eq between lambda classes with different parameters in their ca

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rL366332: [ASTImporter] Fix structural eq of lambdas (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. I think you forgot to remove `/* */` and clang formatting before uploading the patch. Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:214-216 + const Expr *BoundExpr = CondOp->getLHS()->IgnoreParenImpCasts(); + if (BoundExpr == Matches[0].get

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia added a comment. In D64418#1589401 , @kpet wrote: > Very useful to have all of this documented! Thanks! Would it be ok if I fix those in a separate commit? I would really like to commit the core part before the release branch is taken. CHANG

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

alexfh added a comment. Seems good now. Haojian, do you have any concerns? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. Thanks! Can you update the documentation too? Comment at: lib/Tooling/Inclusions/HeaderIncludes.cpp:211 + Ret = 0; +} + return Ret; I think you can drop the else block and just return immediately from the for loop. Reposi

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1589497 , @rdwampler wrote: > Thanks! Can you update the documentation too? Thanks! So, is this Implementation fine? But there is a thing, The values which we give two Priority does not really matter they need to be

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

lebedev.ri added a comment. Is there sufficient test coverage as to what happens if `SortPriority` is not set? Comment at: lib/Format/Format.cpp:455-456 Style.KeepEmptyLinesAtTheStartOfBlocks); -IO.mapOptional("BitFieldDeclarationsOnePerLine", Style.Bi

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus updated this revision to Diff 210330. Szelethus added a comment. Rebase on top master. Putting this on the bottom of the patch stack because this really deserves it's own analysis. (Side note, I completely messed up like ~40 hrs worth of analysis because I didn't check which branches d

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

Szelethus updated this revision to Diff 210333. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64287/new/ https://reviews.llvm.org/D64287 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang/test/Analysis/track-control-dependency-conditions.cpp clang/test/Analysis/unin

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov added a comment. I tried to find a good place to emit unresolved typos earlier (to make sure CodeGen does not ever get `TypoExpr`), but couldn't find one. Please let me know if there's some obvious place I'm missing. Also open to suggestions for putting assertions on whether codege

r366336 - [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

Author: mikerice Date: Wed Jul 17 08:18:45 2019 New Revision: 366336 URL: http://llvm.org/viewvc/llvm-project?rev=366336&view=rev Log: [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field checkDecl is only valid for VarDecls or FieldDecls, since getCanonicalDecl expects

[PATCH] D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

This revision was automatically updated to reflect the committed changes. Closed by commit rL366336: [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field (authored by mikerice, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64861: [clang-tidy] Adjust location of namespace comment diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rL366337: [clang-tidy] Adjust location of namespace comment diagnostic (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r366337 - [clang-tidy] Adjust location of namespace comment diagnostic

Author: ibiryukov Date: Wed Jul 17 08:22:14 2019 New Revision: 366337 URL: http://llvm.org/viewvc/llvm-project?rev=366337&view=rev Log: [clang-tidy] Adjust location of namespace comment diagnostic Summary: If there is no comment, place it at the closing brace of a namespace definition. Previously

[clang-tools-extra] r366338 - [clangd] Type hierarchy: don't resolve parents if the client only asked for children

Author: nridge Date: Wed Jul 17 08:26:49 2019 New Revision: 366338 URL: http://llvm.org/viewvc/llvm-project?rev=366338&view=rev Log: [clangd] Type hierarchy: don't resolve parents if the client only asked for children Summary: Also reorganize the code for computing supertypes to make it more sy

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus updated this revision to Diff 210337. Szelethus marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64270/new/ https://reviews.llvm.org/D64270 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h clang/lib/StaticAnalyz

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov updated this revision to Diff 210338. ilya-biryukov added a comment. - Remove -disable-free from the test, it is no longer required to workaround the crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64799/new/ https://reviews.llvm

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

This revision was automatically updated to reflect the committed changes. Closed by commit rL366338: [clangd] Type hierarchy: don't resolve parents if the client only asked for… (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

Szelethus updated this revision to Diff 210340. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64272/new/ https://reviews.llvm.org/D64272 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang/test

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

sbc100 added a comment. In D64537#1586614 , @quantum wrote: > In D64537#1586577 , @dschuff wrote: > > > Another high-level question (based just on reading the CL description): The > > TLS-size intrinsic is per-func

[clang-tools-extra] r366339 - Fix MSVC 'implicitly capture' compile error. NFCI.

Author: rksimon Date: Wed Jul 17 08:31:53 2019 New Revision: 366339 URL: http://llvm.org/viewvc/llvm-project?rev=366339&view=rev Log: Fix MSVC 'implicitly capture' compile error. NFCI. Modified: clang-tools-extra/trunk/clangd/QueryDriverDatabase.cpp Modified: clang-tools-extra/trunk/clangd/Q

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

kpet accepted this revision. kpet added a comment. This revision is now accepted and ready to land. > Would it be ok if I fix those in a separate commit? I would really like to > commit the core part before the release branch is taken. I'm fine with this as long as we can continue the discussion

  1   2   3   >