[PATCH] D64804: [OpenCL][Sema] Minor refactoring and constraint checking

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64804/new/ https://reviews.llvm.org/D64804

[PATCH] D64780: Disallow most calling convention attributes on PS4.

rjmccall added a comment. I'm fine with the idea of targets making unsupported CCs hard errors. Comment at: test/Sema/no_callconv.cpp:44 +void __attribute__((sysv_abi)) funcI() {} +void __attribute__((cdecl)) funcC() {} Please include a newline at the end of th

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ymandel marked 2 inline comments as done. ymandel added a comment. In D64518#1585917 , @ilya-biryukov wrote: > This clearly increases the utility of the library, but also seems to add > corner cases that the library won't handle (see the comment about un

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ymandel updated this revision to Diff 210148. ymandel added a comment. tweaks in response to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64518/new/ https://reviews.llvm.org/D64518 Files: clang/lib/Tooling/Refactoring/Transformer.cpp

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak added inline comments. Comment at: clang/test/Frontend/rewrite-includes-conditions.c:17 +line4 +#elif value2 < value2 +line5 rsmith wrote: > Did you mean for this to be `value1 < value2` rather than `value2 < value2`? Yes, not that it'd matter in practice.

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively added a comment. LGTM apart from one last comment Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:193 + +if (!Features[WebAssembly::FeatureBulkMemory]) Stripped |= stripThreadLocals(M); quantum wrote: > tlively wrote: > >

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. > To avoid a similar inconsistence with host compilers that don't predefine > _FILE_OFFSET_BITS=64 > (e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted > shortly. I'm curious

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman planned changes to this revision. emmettneyman added a comment. Changes planned: - Move diagnostics into a diagnostic group. - Add behavior and test cases for private members of structs/classes. - Investigate behavior of GCC `designated_init` attribute Repository: rG LLVM Github

[PATCH] D64780: Disallow most calling convention attributes on PS4.

rnk added a comment. Some suggestions, you don't have to take all of them. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2961 +def error_cconv_unsupported : Error< + "%0 calling convention not supported %select{" + // Use CallingConventionIgnoredReason Enum to specif

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 210166. quantum added a comment. More fine-grainted stripping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.de

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreEliminationExpGlobal.cpp:27 +static const char GlobalArgumentMemAccess[] = { +// grep -P -o "(?<=FUNCTION_INFO: ).*" | sort -u > +// ../llvm-project/ll

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: lld/wasm/Writer.cpp:400 + StringRef name = segment->getName(); + if (name.startswith(".tdata.") || name.startswith(".tbss.")) +tlsUsed = tru

Re: r366123 - ARM MTE stack sanitizer.

I could not reproduce this on Linux nor on Mac. I wonder if triggering a clean build would help? I don't see a way to do that though. On Tue, Jul 16, 2019 at 10:50 AM Evgenii Stepanov wrote: > > Hi, > > thanks for letting me know! Is this reproducible on Linux? It is > possible to extract a repro

[clang-tools-extra] r366265 - [clang-tidy] initial version of readability-convert-member-functions-to-static

Author: mgehre Date: Tue Jul 16 14:19:00 2019 New Revision: 366265 URL: http://llvm.org/viewvc/llvm-project?rev=366265&view=rev Log: [clang-tidy] initial version of readability-convert-member-functions-to-static Summary: Finds non-static member functions that can be made ``static``. I have run t

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

mgehre added a comment. Thank you for the review, Aaron! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

This revision was automatically updated to reflect the committed changes. Closed by commit rL366265: [clang-tidy] initial version of readability-convert-member-functions-to-static (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64820: Avoids an assertion failure when an invalid conversion declaration is used

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. When using a user-defined conversion function template with a deduced return type the compiler gives a set of warnings: bug.cc:252:44: error: cannot specify any part of a return type in the dec

r366267 - [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

Author: benhamilton Date: Tue Jul 16 14:29:40 2019 New Revision: 366267 URL: http://llvm.org/viewvc/llvm-project?rev=366267&view=rev Log: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier Summary: Previously, clang-format detected something like the following as

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL366267: [clang-format] Don't detect call to ObjC class method as C++11 attribute… (authored by benhamilton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked an inline comment as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} alexfh wro

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added a comment. Submitted as r366267. Thanks! Comment at: clang/lib/Format/TokenAnnotator.cpp:389 bool isCpp11AttributeSpecifier(const FormatToken &Tok) { if (!Style.isCpp() || !Tok.startsSequence(tok::l_square, tok::l_square)) return false;

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 210184. quantum added a comment. Removed the trailing `.`. I would add a test to make sure things work without `-fdata-sections`, but `this->Options.DataSections = true;` is hard-coded in `WebAssemblyTargetMachine.cpp`. Repository: rG LLVM Github Monorep

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 210187. quantum added a comment. Remove extra braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/

r366272 - [WebAssembly] Implement thread-local storage (local-exec model)

Author: quantum Date: Tue Jul 16 15:00:45 2019 New Revision: 366272 URL: http://llvm.org/viewvc/llvm-project?rev=366272&view=rev Log: [WebAssembly] Implement thread-local storage (local-exec model) Summary: Thread local variables are placed inside a `.tdata` segment. Their symbols are offsets fro

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively accepted this revision. tlively added a comment. Nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366272: [WebAssembly] Implement thread-local storage (local-exec model) (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D64537?vs=210188&id=210191#toc Repository

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 210188. quantum added a comment. Disable atomics when TLS is stripped Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAsse

[PATCH] D64828: AMDGPU: Add some missing builtins

arsenm created this revision. arsenm added reviewers: rampitec, yaxunl, kzhuravl, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely. https://reviews.llvm.org/D64828 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/bu

[PATCH] D64491: [Driver] Enable __cxa_atexit on Solaris

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64491/new/ https://reviews.llvm.org/D64491 ___ cfe-commits mailing

r366276 - Fix a typo in target features

Author: gbiv Date: Tue Jul 16 15:32:17 2019 New Revision: 366276 URL: http://llvm.org/viewvc/llvm-project?rev=366276&view=rev Log: Fix a typo in target features There was a slight typo in r364352 that ended up causing our backend to complain on some x86 Android builds. This CL fixes that. Differ

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rnk added a comment. I'm in favor of this as is. We should loop in and get confirmation from @rsmith though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64799/new/ https://reviews.llvm.org/D64799 __

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed extraneous matches of non-NullStmt Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64838 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Parse

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry added a comment. Revival of https://reviews.llvm.org/D63260 and https://reviews.llvm.org/D63299. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 210215. Nathan-Huckleberry added a comment. - Fixed formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 Files: clang/include/clang/Basic/Attr.td c

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ added a comment. In D64274#1584974 , @baloghadamsoftware wrote: > Hmm, I still fail to understand the problem with the current `VirtualCall` > checker. Is it unstable? Does it report many false positives? Yeah, pretty much. It's basically defined t

[PATCH] D64828: AMDGPU: Add some missing builtins

arsenm updated this revision to Diff 210216. arsenm added a comment. Drop one and fix missing test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64828/new/ https://reviews.llvm.org/D64828 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/b

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:2131 + ParseGNUAttributes(attrs, nullptr, nullptr); + if (attrs.size() <= 0) { +return TPResult::False; Negative size() ? Did you mean “== 0”? Not sure if “empty()” exists ther

[PATCH] D64828: AMDGPU: Add some missing builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64828/new/ https://reviews.llvm.org/D64828 ___ cfe-commits mailing list cfe-commi

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 210218. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Tooling/Inclusions/HeaderIncludes.h include/clang/Tooling/Inclusions/IncludeStyle.h lib/Format/Form

r366282 - Fix darwin-ld.c if dsymutil.exe exists on PATH

Author: rnk Date: Tue Jul 16 16:38:05 2019 New Revision: 366282 URL: http://llvm.org/viewvc/llvm-project?rev=366282&view=rev Log: Fix darwin-ld.c if dsymutil.exe exists on PATH Modified: cfe/trunk/test/Driver/darwin-ld.c Modified: cfe/trunk/test/Driver/darwin-ld.c URL: http://llvm.org/viewv

r366284 - Fix OpenCLCXX test on 32-bit Windows where thiscall is present

Author: rnk Date: Tue Jul 16 16:44:33 2019 New Revision: 366284 URL: http://llvm.org/viewvc/llvm-project?rev=366284&view=rev Log: Fix OpenCLCXX test on 32-bit Windows where thiscall is present Modified: cfe/trunk/test/SemaOpenCLCXX/address-space-deduction.cl Modified: cfe/trunk/test/SemaOpen

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. Thanks, I think this is fine solution for now. Probably not ideal (@aaron.ballman mentioned the ideal solution - rewrite the parser), but “suboptimal” parser should not stop any progress in this area. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:2146 +bool Parser::isNullStmtWithAttributes() { + RevertingTentativeParsingAction PA(*this); + return TryParseNullStmtWithAttributes() == TPResult::True; Is this “cheap” in terms of

[PATCH] D41412: [libcxx] implement concat() and split()

timshen added a comment. In D41412#1586966 , @grosser wrote: > Hi @timshen, > > I am very interested in these patches. Any chance you can take up the > upstreaming process again? I'm glad to spend time upstreaming these patches. Now we just need a libc+

r366286 - AMDGPU: Add some missing builtins

Author: arsenm Date: Tue Jul 16 17:01:03 2019 New Revision: 366286 URL: http://llvm.org/viewvc/llvm-project?rev=366286&view=rev Log: AMDGPU: Add some missing builtins Added: cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-gfx10.cl cfe/trunk/test/SemaOpenCL/builtins-amdgcn-error-gfx10-param.c

[PATCH] D64828: AMDGPU: Add some missing builtins

arsenm closed this revision. arsenm added a comment. r366286 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64828/new/ https://reviews.llvm.org/D64828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

efriedma added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:104 + + if (isNullStmtWithAttributes()) { +MaybeParseGNUAttributes(Attrs); If we're going to generally support statement attributes, it should be possible to apply them to non-null st

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

dschuff added a comment. I had a reply that got eaten here, so I'm going to keep trolling you on your CL since we don't have a design doc for this. The `offset` field of a data segment initializer can be a `global.get` on an imported global. (https://webassembly.github.io/spec/core/valid/instr

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum added a comment. In D64537#1588699 , @dschuff wrote: > I had a reply that got eaten here, so I'm going to keep trolling you on your > CL since we don't have a design doc for this. > The `offset` field of a data segment initializer can be a `globa

[PATCH] D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

mikerice created this revision. mikerice added reviewers: ABataev, cfe-commits. Herald added a subscriber: guansong. checkDecl is only valid for VarDecls or FieldDecls, since getCanonicalDecl expects only these. Prevent other Decl kinds (such as CXXMethodDecls and EnumConstantDecls) from enteri

[PATCH] D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64842/new/ https://reviews.llvm.org/D64842 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D64843: hwasan: Initialize the pass only once.

pcc created this revision. pcc added a reviewer: eugenis. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This will let us instrument globals during initialization. This required making the new PM pass a module pass, which should still provide access to analys

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

vsapsai added inline comments. Comment at: clang/test/SemaObjC/typo-correction-subscript.m:1 // RUN: %clang_cc1 -triple i386-apple-macosx10.10 -fobjc-arc -fsyntax-only -Wno-objc-root-class %s -verify -disable-free I think you can even remove `-disable-free` i

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In the following patch I have modified Include categories by adding a new field "sortInlcudes" which defines the priority of the sort. And priority field will now only be used for grouping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D64849: Add platform guards to PPC vector intrinsics headers.

qiucf created this revision. qiucf added reviewers: jsji, hfinkel, nemanjai, wschmidt, kbarton, hubert.reinterpretcast. qiucf added a project: clang. Herald added subscribers: cfe-commits, MaskRay, krytarowski. Intrinsic headers are supported only on 64-bit PowerPC. This patch is to move the pla

[PATCH] D64850: Remove use of malloc in PPC mm_malloc.

qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, jsji, wschmidt, nemanjai, kbarton. qiucf added a project: clang. Herald added a subscriber: cfe-commits. Remove dependency of `malloc` in implementation of `mm_malloc` function and alignment assumption on glibc. Reposi

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

rsmith added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:2130 + ParsedAttributesWithRange attrs(AttrFactory); + ParseGNUAttributes(attrs, nullptr, nullptr); + if (attrs.size() <= 0) { It's not correct in general to call arbitrary parsing ac

<    1   2