[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

jdoerfert added a comment. Could we generally require some message for all reviews and commits? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64423/new/ https://reviews.llvm.org/D64423 ___ cfe-commits mailing list cf

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 208709. xazax.hun added a comment. - Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaInit.cpp clang

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay added a comment. @ychen The GCC behavior ("omit" wins over "no-omit") makes sense because: in the 4 states: - 00) leaf retained, non-leaf retained - 01) leaf retained, non-leaf omitted - 10) leaf omitted, non-leaf retained - 11) leaf omitted, non-leaf omitted State 10) doesn't make sens

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:206 + llvm::SmallString<128> Path = Type.Path; + ::llvm::sys::path::append(Path, Type.Name + ".html"); + return genLink(Type.Name, Path); You shouldn't need the prefi

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but I agree, some general description would be good Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64423/new/ https://reviews.llvm.org/D64423 _

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson added a comment. In D63894#1574419 , @dblaikie wrote: > I would've assumed these conditionals were added by Sony folks for their > change in default dialect - that doesn't necessarily mean these tests are > needed upstream (the functionality ma

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

neil.hickey added inline comments. Comment at: docs/LanguageExtensions.rst:1538 +- ``dynamic_cast`` operator +- Only placement ``new``/``delete`` operators +- Standard C++ libraries. Currently there is no solution for alternative This seems weird, you say the fol

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson added a comment. In D63894#1576288 , @probinson wrote: > there is no reason to think those paths are tested elsewhere. Well that may be a tad strong. But I'm reluctant to remove them unless they are demonstrably tested elsewhere, and it's not

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong updated this revision to Diff 208727. martong added a comment. Herald added a reviewer: shafik. - Add test which crashes in baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64075/new/ https://reviews.llvm.org/D64075 Files: clang/li

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

fhahn added a comment. In D64128#1572504 , @rjmccall wrote: > I would be opposed to any addition of a `-f` flag for this absent any > evidence that it's valuable for some actual C code; this patch appears to be > purely speculative. I certainly don't th

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

mantognini added a comment. Here are a few comments from me but keep in mind that English is not my primary language Comment at: docs/LanguageExtensions.rst:1562-1565 +C style cast will follow OpenCL C v2.0 rules (s6.5.5). All cast operators will +permit implicit conversion to

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

rjmccall added a comment. I wouldn't favor adding something really obscure that was only useful for clang, but I think builtins to set and clear mask bits while promising to preserve object-reference identity would be more generally useful for libraries. For example, there might be somewhere i

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong added a comment. In D64075#1572676 , @a_sidorin wrote: > Hi Gabor, > The patch looks good, but it looks to me that it has a relation to > https://reviews.llvm.org/D64078 that is kind of questionable to me. Let's > delay landing this patch until

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:118 + DirectoryHasCDB[Path] = false; + return false; +}); return P

r365518 - [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

Author: epilk Date: Tue Jul 9 10:29:40 2019 New Revision: 365518 URL: http://llvm.org/viewvc/llvm-project?rev=365518&view=rev Log: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL rdar://51954400 Differential revision: https://reviews.llvm.org/D63912 Added

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

This revision was automatically updated to reflect the committed changes. Closed by commit rL365518: [ObjC] Add a warning for implicit conversions of a constant non-boolean value… (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

hintonda updated this revision to Diff 208736. hintonda added a comment. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Make GeneralCategory a ManagedStatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D63954: Add lifetime categories attributes

xazax.hun added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4177 + let Content = [{ +When annotating a class ``P`` with ``[[gsl::Pointer(T)]]``, it assumed to be a +non-owning type whose objects can point to ``T`` type objects or dangle. a

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208739. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Remove empty line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D63857 Files: clang-tools-extra/clang-doc/CMak

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208741. emmettneyman marked 6 inline comments as done. emmettneyman added a comment. Small changes in response to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/

[clang-tools-extra] r365522 - [clangd] Show documentation in hover, and fetch docs from index if needed.

Author: sammccall Date: Tue Jul 9 10:59:50 2019 New Revision: 365522 URL: http://llvm.org/viewvc/llvm-project?rev=365522&view=rev Log: [clangd] Show documentation in hover, and fetch docs from index if needed. Summary: I assume showing docs is going to be part of structured hover rendering, but

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur added a comment. Ping Comment at: llvm/lib/Passes/PassBuilder.cpp:576 +// dramatically increase code size. +MPM.addPass(GlobalDCEPass()); + } I moved this pass under the condition when Early inline is enabled. I'm under the impression that the int

[PATCH] D64257: [clangd] Added highlighting for class and enum types

sammccall added a comment. (Thanks for addressing my comments earlier. I don't have more concerns, but haven't been following the last revisions in detail so will leave approval to Haojian) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/

r365528 - [AMDGPU] gfx908 clang target

Author: rampitec Date: Tue Jul 9 11:19:00 2019 New Revision: 365528 URL: http://llvm.org/viewvc/llvm-project?rev=365528&view=rev Log: [AMDGPU] gfx908 clang target Differential Revision: https://reviews.llvm.org/D64430 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/trunk/lib/Basic/Cu

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:101-102 // intended for API modeling that is not controlled by the target triple. def APIModeling : Package<"apiModeling">, Hidden; def GoogleAPIModeling : Package<"google">, ParentP

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

aganea added a comment. In D64301#1574304 , @rnk wrote: > I think @zturner wanted to teach lit to completely remove the Output/ > directory for every test so we don't have to deal with stale files from > previous tests hanging around. I remember objectin

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

aganea added a comment. In D64301#1576615 , @aganea wrote: > In D64301#1574304 , @rnk wrote: > > > I think @zturner wanted to teach lit to completely remove the Output/ > > directory for every test so we don't have

[clang-tools-extra] r365531 - [clangd] Rewrite of logic to rebuild the background index serving structures.

Author: sammccall Date: Tue Jul 9 11:30:49 2019 New Revision: 365531 URL: http://llvm.org/viewvc/llvm-project?rev=365531&view=rev Log: [clangd] Rewrite of logic to rebuild the background index serving structures. Summary: Previously it was rebuilding every 5s by default, which was much too frequ

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

hfinkel added a comment. > Do we have any policies against using clang-only builtins in the codebase? No, but obviously it will need to be protected with appropriate ifdefs and integrated in some maintainable fashion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

pcc updated this revision to Diff 208758. pcc marked 3 inline comments as done. pcc added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63908/new/ https://reviews.llvm.org/D63908 Files: clang/docs/HardwareAss

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

pcc added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_allocator.cpp:159 ? (t ? t->GenerateRandomTag() : kFallbackAllocTag) : 0; +uptr tag_size = orig_size ? orig_size : 1; eugenis wrote: > When !(flags(

[libunwind] r365539 - Revert merge of r360861:

Author: dim Date: Tue Jul 9 12:14:43 2019 New Revision: 365539 URL: http://llvm.org/viewvc/llvm-project?rev=365539&view=rev Log: Revert merge of r360861: r360861 | mstorsjo | 2019-05-15 23:49:13 -0700 (Wed, 15 May 2019) | 1

[PATCH] D64383: build: use multiple `install` rather than building up a list

smeenai accepted this revision. smeenai added a comment. Nice! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64383/new/ https://reviews.llvm.org/D64383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D64383: build: use multiple `install` rather than building up a list

smeenai added inline comments. Comment at: src/CMakeLists.txt:440 + endif() + if (LIBCXX_INSTALL_STATIC_LIBRARY) +install(TARGETS cxx_static Super nit: you don't have a newline here but do have a newline before the LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY condi

[libunwind] r365542 - Merging r360861, with an additional change to also add the PPC64_OPD1

Author: dim Date: Tue Jul 9 12:22:59 2019 New Revision: 365542 URL: http://llvm.org/viewvc/llvm-project?rev=365542&view=rev Log: Merging r360861, with an additional change to also add the PPC64_OPD1 and PPC64_OPD2 lines to the DEFINE_LIBUNWIND_PRIVATE_FUNCTION() macro, which was removed in r35764

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. Something like this: F9509417: photo_2019-07-09_12-21-46.jpg Like, you can construct a CFG for an arbitrary statement. CFG₁ is the CFG for xxx() and CFG₂ is the CFG for the CapturedStmt (and its children). I'm trying to say that even if

Re: [libunwind] r364217 - Merging r360861:

On 9 Jul 2019, at 04:54, Tom Stellard wrote: > > On 07/08/2019 11:51 AM, Dimitry Andric wrote: >> On 24 Jun 2019, at 20:40, Tom Stellard via cfe-commits >> wrote: >>> >>> Author: tstellar >>> Date: Mon Jun 24 11:40:58 2019 >>> New Revision: 364217 >>> >>> URL: http://llvm.org/viewvc/llvm-proj

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:214-216 + const Expr *BoundExpr = CondOp->getLHS()->IgnoreParenImpCasts(); + if (BoundExpr == Matches[0].getNodeAs("boundVarOperand")) +BoundExpr = CondOp->getRHS()->IgnoreParenImpCasts();

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

MaskRay updated this revision to Diff 208780. MaskRay edited the summary of this revision. MaskRay added a comment. Update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64423/new/ https://reviews.llvm.org/D64423 Files: lib/AST/ASTContext.cpp Inde

Re: [libunwind] r364217 - Merging r360861:

On 07/09/2019 12:28 PM, Dimitry Andric wrote: > On 9 Jul 2019, at 04:54, Tom Stellard wrote: >> >> On 07/08/2019 11:51 AM, Dimitry Andric wrote: >>> On 24 Jun 2019, at 20:40, Tom Stellard via cfe-commits >>> wrote: Author: tstellar Date: Mon Jun 24 11:40:58 2019 New Revision:

r365545 - [OpenMP] Simplify getFloatTypeSemantics

Author: maskray Date: Tue Jul 9 12:36:22 2019 New Revision: 365545 URL: http://llvm.org/viewvc/llvm-project?rev=365545&view=rev Log: [OpenMP] Simplify getFloatTypeSemantics When the float point representations are the same on the host and on the target device, (`&Target->getLongDoubleFormat() =

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

This revision was automatically updated to reflect the committed changes. Closed by commit rL365545: [OpenMP] Simplify getFloatTypeSemantics (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[PATCH] D63894: [CXX] Exercise all paths through these tests

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/linkage2.cpp:3 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98 // RUN: %cla

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev added a comment. In D64356#1576813 , @NoQ wrote: > Something like this: > > F9509417: photo_2019-07-09_12-21-46.jpg > > Like, you can construct a CFG for an arbitrary statement. CFG₁ is the CFG for > xxx() and C

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 ___ cfe-c

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre updated this revision to Diff 208785. mgehre added a comment. Move checks into AST matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 Files: clang-tools-extra/clang-tidy/readability/CMakeList

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

NoQ added a comment. Whoa, the new notes are amazing. Looks like you've found a pretty bad omission. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1436-1437 -} -ReturnVisitor::addVisitorIfNecessary(StoreSite, InitE->IgnoreParenCasts(), -

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

NoQ added a comment. I'd rather not abandon this patch, because it looks like a strict improvement over the lack of condition tracking, and it might as well still be an improvement over "zealous" condition tracking, as my counterexample is fairly artificial. It indicates that a slightly more so

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson marked an inline comment as done. probinson added inline comments. Comment at: clang/test/SemaCXX/linkage2.cpp:3 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98 // RUN: %clang_cc1 -fsyntax-only -verify -Wno

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

sammccall planned changes to this revision. sammccall added a comment. I'll give this a try. I expect it to feel quite glitchy when the enum type has a long name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63098/new/ https://reviews.llvm.org/D63098 ___

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

sammccall added a comment. Ping... it'd be nice to have for clangd-9, though it's getting late. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63085/new/ https://reviews.llvm.org/D63085 ___ cfe-commits mailing list cf

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

ldionne added a comment. Background question: I'm familiar with the behavior on Darwin, where we prefer C++ headers in the toolchain (alongside the driver), however do other platforms behave the same? I thought this was something specific to Darwin. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. In D64089#1576902 , @ldionne wrote: > Background question: I'm familiar with the behavior on Darwin, where we > prefer C++ headers in the toolchain (alongside the driver), however do other > platforms behave the same? I thought t

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63908/new/ https://reviews.llvm.org/D63908 _

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 208789. DiegoAstiazaran marked 5 inline comments as done. DiegoAstiazaran added a comment. The info path generated in serialization was the composite of the out directory and the parent namespaces. Now it's only the parent namespaces; the out directo

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

hfinkel added a comment. Ah, fun with overloaded, legacy command-line options... Comment at: lib/Driver/ToolChains/Clang.cpp:1825 + // that don't use the altivec abi. + if (!SeenOther) +ABIName = A->getValue(); This seems like an unintentional

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208792. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D63857 Files: clang-tools-extra/clang-doc/CMakeLists.txt clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Generators.h cla

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:567 + ParentI->Namespace = llvm::SmallVector( + Enum.Namespace.begin() + 1, Enum.Namespace.end()); + ParentI->Path = getInfoOutputFile(OutDirectory, ParentI->Namespace)

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause: device

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

keryell added a comment. Good improvement! Comment at: docs/LanguageExtensions.rst:1758 +to enqueue constructor initialization kernel that has a name +``@_GLOBAL__sub_I_``. This kernel is only present if there +are any global objects to be initialized in the compiled binary. On

r365551 - hwasan: Improve precision of checks using short granule tags.

Author: pcc Date: Tue Jul 9 13:22:36 2019 New Revision: 365551 URL: http://llvm.org/viewvc/llvm-project?rev=365551&view=rev Log: hwasan: Improve precision of checks using short granule tags. A short granule is a granule of size between 1 and `TG-1` bytes. The size of a short granule is stored at

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365551: hwasan: Improve precision of checks using short granule tags. (authored by pcc, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D63908?vs=

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause: devic

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jdenny updated this revision to Diff 208795. jdenny retitled this revision from "[Rewrite][NFC] Add FIXME about RemoveLineIfEmpty" to "[Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug". jdenny edited the summary of this revision. jdenny added a comment. Rebase, and add a unit test t

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi added a comment. Recommitted as https://reviews.llvm.org/rL365509 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63161/new/ https://reviews.llvm.org/D63161 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D62855: [clangd] Implementation of auto type expansion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, let's land this! We can enhance further later, but this covers the most common cases. (I think the remaining comments are trivial - then I/you can land without further review)

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

FYI, your test seems to fail on Windows: FAIL: Clang :: CodeGenOpenCL/pipe_builtin.cl (4679 of 15176) TEST 'Clang :: CodeGenOpenCL/pipe_builtin.cl' FAILED Script: -- : 'RUN: at line 1'; c:\b\slave\clang-x64-windows-msvc\build\build\stage1\bin\clang.exe -cc1

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. Yay, great! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64356/new/ https://reviews.llvm.org/D64356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

r365555 - [CXX] Exercise all paths through these tests.

Author: probinson Date: Tue Jul 9 13:49:07 2019 New Revision: 36 URL: http://llvm.org/viewvc/llvm-project?rev=36&view=rev Log: [CXX] Exercise all paths through these tests. Differential Revision: https://reviews.llvm.org/D63894 Modified: cfe/trunk/test/CXX/dcl.dcl/basic.namespace/na

[PATCH] D63894: [CXX] Exercise all paths through these tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL36: [CXX] Exercise all paths through these tests. (authored by probinson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r365556 - De-templatize non-dependent VS macro logic, NFC

Author: rnk Date: Tue Jul 9 13:57:28 2019 New Revision: 365556 URL: http://llvm.org/viewvc/llvm-project?rev=365556&view=rev Log: De-templatize non-dependent VS macro logic, NFC These macro definitions don't depend on the template parameter, so they don't need to be part of the template. Move the

r365557 - Use the Itanium C++ ABI for the pipe_builtin.cl test

Author: rnk Date: Tue Jul 9 14:02:06 2019 New Revision: 365557 URL: http://llvm.org/viewvc/llvm-project?rev=365557&view=rev Log: Use the Itanium C++ ABI for the pipe_builtin.cl test Certain OpenCL constructs cannot yet be mangled in the MS C++ ABI. Add a FIXME for it if anyone cares to implement

r365558 - XFAIL clang/test/Headers/max_align.c on i686

Author: andusy Date: Tue Jul 9 14:06:34 2019 New Revision: 365558 URL: http://llvm.org/viewvc/llvm-project?rev=365558&view=rev Log: XFAIL clang/test/Headers/max_align.c on i686 Modified: cfe/trunk/test/Headers/max_align.c Modified: cfe/trunk/test/Headers/max_align.c URL: http://llvm.org/vi

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ updated this revision to Diff 208807. NoQ added a comment. Bring back the option in order to preserve backwards compatibility. Sneak in an implicit conversion from `CheckName` to `StringRef` so that not to repeat myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ htt

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 208811. jdoerfert added a comment. Herald added a subscriber: jfb. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/At

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre created this revision. mgehre added reviewers: gribozavr, xazax.hun. Herald added a subscriber: rnkovacs. Herald added a project: clang. Make the DerefType, i.e. the argument of gsl::Owner/gsl::Pointer optional for now. The DerefType is used when infering lifetime annotations of functions

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208814. emmettneyman marked 3 inline comments as done. emmettneyman added a comment. Changed attribute spelling from GNU to CXX11 and renamed the 'required' attribute to 'designated_init_required' Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added a comment. > The tests are currently here > I think due to their dependency on a standard library, they are not a good > fit for clang/test/. Where else could I put them? Make some mocks that reproduce the salient parts of different libraries, the coding patterns they use, and

[PATCH] D64383: build: use multiple `install` rather than building up a list

compnerd closed this revision. compnerd added a comment. SVN r365562 Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64383/new/ https://reviews.llvm.org/D64383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert added a comment. I will update the table (hopefully tomorrow) and we can then see if we commit it and change it in-place or if we have more initial feedback. Thanks everyone for providing all this information! @lebedev.ri I'd like to see if we can transition this one into a more gener

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

lebedev.ri added a comment. In D64375#1577153 , @jdoerfert wrote: > @lebedev.ri I'd like to see if we can transition this one into a more generic > one with version numbers etc. Is that OK? I have no further comment at the moment. Repository: rG LLV

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added a comment. I've also just noticed that the YAML generator is missing from this -- could you add the `Path` fields to hat output as well? Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:213 + llvm::SmallString<128> Path = Type.Path; + llvm::sys::p

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. It would be nice to land this before 9.0 branch date... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208824. Charusso marked 6 inline comments as done. Charusso added a comment. - Move to `apiModeling.llvm`. - Prevent unknown casts. - Refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:58 +static std::string getCastName(const Expr *Cast) { + return Cast->getType()->getPointeeCXXRecordDecl()->getNameAsString(); +} You should still check if `Cast->getTy

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:172 + !CE->getArg(0)->getType()->getPointeeCXXRecordDecl()) +return false; + If we cannot obtain any of the CXXR

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Whoops. I underestimated you (: Ok, anyway, this was my last comment. Great job! Remember to make sure that it works on the actual LLVM, not only on tests; mocked-up test headers are very easy to g

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

xazax.hun added a comment. In D64448#1577109 , @gribozavr wrote: > > The tests are currently here > > I think due to their dependency on a standard library, they are not a good > > fit for clang/test/. Where else could I put them? > > Make some mocks tha

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208829. emmettneyman added a comment. Updated tests and diagnostic messages with new attribute spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: cl

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added a comment. In D64374#1577235 , @NoQ wrote: > Whoops. I underestimated you (: > > Ok, anyway, this was my last comment. Great job! Remember to make sure that > it works on the actual LLVM, not only on tests; mocked-up test headers are > ver

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208831. Charusso added a comment. - Add the forgotten `llvm` namespace to the `CallDescription`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers

r365574 - [clang] DirectoryWatcher

Author: jkorous Date: Tue Jul 9 15:44:48 2019 New Revision: 365574 URL: http://llvm.org/viewvc/llvm-project?rev=365574&view=rev Log: [clang] DirectoryWatcher Asynchronously monitors specified directory for changes and passes notifications to provided callback. Dependency for index-while-buildi

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added a comment. In D64374#1577262 , @Charusso wrote: > - Add the forgotten `llvm` namespace to the `CallDescription`. Nice! In D64374#1577254 , @Charusso wrote: > The only crash-able code was that: > > #0

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL365574: [clang] DirectoryWatcher (authored by jkorous, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58418?vs=

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added a comment. In D64374#1577266 , @NoQ wrote: > Can you provide more info, eg. the full backtrace? Well, `unique_dyn_cast<>` and `unique_dyn_cast_or_null<>` is used like 20 times in the LLVM codebase, whoops. We want to model it. Full info:

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added a comment. Mmm. Ok, am i understanding correctly that this was crashing because you bound a `0 (Loc)` to a prvalue expression of type `unique_ptr`? Yeah, right, don't do that :) > used like 20 times in the LLVM codebase That doesn't sound like it's high on our list. That's not too ma

[clang-tools-extra] r365576 - [clangd] fix assert in test after r365531.

Author: sammccall Date: Tue Jul 9 16:05:20 2019 New Revision: 365576 URL: http://llvm.org/viewvc/llvm-project?rev=365576&view=rev Log: [clangd] fix assert in test after r365531. Unverified because CMake/ninja seems to be broken... Modified: clang-tools-extra/trunk/clangd/unittests/Backgroun

r365579 - [MS] Treat ignored explicit calling conventions as an explicit __cdecl

Author: rnk Date: Tue Jul 9 16:17:43 2019 New Revision: 365579 URL: http://llvm.org/viewvc/llvm-project?rev=365579&view=rev Log: [MS] Treat ignored explicit calling conventions as an explicit __cdecl The CCCR_Ignore action is only used for Microsoft calling conventions, mainly because MSVC does

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: clang. Since clang-tidy supports use of the static analyzer there should be documentation of how to invoke the static a

<    1   2   3   >