[PATCH] D63857: [clang-doc] Structured HTML generator

jakehehrlich added a comment. Can you upload `git diff -U10 ` functions so that I can see the code without it being fragmented? It's hard to parse some of the more fragmented stuff here Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:191-194 +static std::vector>

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + rjmccall wrote: > ahatan

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't t

r364690 - [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test

Author: jkorous Date: Fri Jun 28 15:37:31 2019 New Revision: 364690 URL: http://llvm.org/viewvc/llvm-project?rev=364690&view=rev Log: [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test Clang <= 4 used the pre-C++11 rule about which structures can be passed in registers. Modified

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 207160. DiegoAstiazaran retitled this revision from "[clang-doc] Structured HTML generator" to "[clang-doc] Add a structured HTML generator". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added subscribers

[PATCH] D63857: [clang-doc] Add a structured HTML generator

jakehehrlich added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:228 + Out.emplace_back(llvm::make_unique(HTMLTag::TAG_H2, "Functions")); + Out.emplace_back(llvm::make_unique(HTMLTag::TAG_DIV)); + for (const auto &F : Functions) {

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak added a comment. Currently a block captures a variable (POD or non-POD) by reference if the enclosing lambda captures it by reference and captures by copy if the enclosing lambda captures by copy. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58164/new/

[PATCH] D63961: [clangd][xpc] pass it LSP value using data instead of string

arphaman created this revision. arphaman added a reviewer: jkorous. Herald added subscribers: kadircet, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. Use XPC's data type instead of string to pass the LSP value from Clangd. This will make it easier to use from sourcekit-lsp (

[PATCH] D63961: [clangd][xpc] pass the LSP value using data instead of string

arphaman updated this revision to Diff 207164. arphaman added a comment. Added missing `xpc_release` in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63961/new/ https://reviews.llvm.org/D63961 Files: clang-tools-extra/clangd/unittests/xpc/ConversionTests.cpp clang-tools-e

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

ahatanak updated this revision to Diff 207166. ahatanak marked an inline comment as done. ahatanak added a comment. Add function `Expr::hasNonOverloadPlaceholderType`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62645/new/ https://reviews.llvm.org/D62645 Files

[PATCH] D63155: [clang][NewPM] Fix broken profile test

davidxl added a comment. Rong, can you take a look at this patch? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63155/new/ https://reviews.llvm.org/D63155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D63793: Treat the range of representable values of floating-point types as [-inf, +inf] not as [-max, +max].

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. I don't have much experience with the front-end and have no experience with the sanitizers, but the changes match my understanding for this type of cast/conversion, so LGTM. ===

[PATCH] D63962: [clang-doc] Fix segfault in comment sorting

juliehockett created this revision. juliehockett added a reviewer: jakehehrlich. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D63962 Files: clang-tools-extra/clang-doc/Representation.h Index: clang-tools-extra/clang-doc/Representation.h ===

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 207174. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add a variable to use as a reference to the last item in a vector instead of doing vector.back(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added inline comments. Comment at: clang/test/Analysis/return-value-guaranteed.cpp:20 +struct Foo { int Field; }; +bool error(); +bool problem(); NoQ wrote: > `core.builtin.NoReturnFunctions` reacts on this function. You can easily see > it in the explodedgr

[PATCH] D63965: [analyzer] exploded-graph-rewriter: Add support for program point tags.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Keep it on a separate line for more visibility. F9428700: Screen Shot

[PATCH] D63965: [analyzer] exploded-graph-rewriter: Add support for program point tags.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Good idea! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63965/new/ https://reviews.llvm.org/D63965

[PATCH] D63155: [clang][NewPM] Fix broken profile test

xur added a comment. This patch does not make sense to me. The reason of failing with -fexperimental-new-pass-manager is because we don't do PGO instrumentation at -O0. This is due to the fact that PGO instrumentation/use passes are under PassBuilder::buildPerModuleDefaultPipeline. This patch

[PATCH] D63155: [clang][NewPM] Fix broken profile test

chandlerc added a comment. In D63155#1563229 , @xur wrote: > This patch does not make sense to me. > > The reason of failing with -fexperimental-new-pass-manager is because we > don't do PGO instrumentation at -O0. This is due to the fact that PGO > inst

[PATCH] D63155: [clang][NewPM] Fix broken profile test

leonardchan added a comment. In D63155#1563229 , @xur wrote: > This patch does not make sense to me. > > The reason of failing with -fexperimental-new-pass-manager is because we > don't do PGO instrumentation at -O0. This is due to the fact that PGO > in

[PATCH] D63155: [clang][NewPM] Fix broken profile test

leonardchan added a comment. > I mean, I'm happy for the patch to be reverted, but I still really don't > understand why this fixes the test to work *exactly* the same as w/ the old > pass manager and doesn't break any other tests if it is completely wrong? It > seems like there must be somethi

Re: [PATCH] D63155: [clang][NewPM] Fix broken profile test

they are not doing the exacly the same thing for old pass manager and new pass manger: old pass manger is doing instrumentation, while the new pass manager with this change is NOT. the test is not check instrumentation, (it only check the variables that generates by InstroProfiling pass). In this s

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

Charusso accepted this revision. Charusso added a comment. Great patch, thanks you! I wanted to make my own `IdentifierInfo` array previously. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1060 +public: + const static unsigned NoArgRequirement

[PATCH] D63155: [clang][NewPM] Fix broken profile test

chandlerc added a comment. In D63155#1563240 , @leonardchan wrote: > In D63155#1563229 , @xur wrote: > > > This patch does not make sense to me. > > > > The reason of failing with -fexperimental-new-pass-manager is

[PATCH] D63155: [clang][NewPM] Fix broken profile test

xur added a comment. they are not doing the exacly the same thing for old pass manager and new pass manger: old pass manger is doing instrumentation, while the new pass manager with this change is NOT. the test is not check instrumentation, (it only check the variables that generates by InstroP

[PATCH] D63155: [clang][NewPM] Fix broken profile test

leonardchan added a comment. Understood. I'll revert this patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63155/new/ https://reviews.llvm.org/D63155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

r364692 - Revert "[clang][NewPM] Fix broken profile test"

Author: leonardchan Date: Fri Jun 28 17:10:22 2019 New Revision: 364692 URL: http://llvm.org/viewvc/llvm-project?rev=364692&view=rev Log: Revert "[clang][NewPM] Fix broken profile test" This reverts commit ab2c0ed01edfec9a9402d03bdf8633b34b73f3a7. See https://reviews.llvm.org/D63155 Modified:

[PATCH] D63155: [clang][NewPM] Fix broken profile test

xur added a comment. In D63155#1563266 , @chandlerc wrote: > In D63155#1563240 , @leonardchan > wrote: > > > In D63155#1563229 , @xur wrote: > > > > > This patch does not ma

[PATCH] D63155: [clang][NewPM] Fix broken profile test

leonardchan added a comment. Reverted in r364692 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63155/new/ https://reviews.llvm.org/D63155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This helps with more efficient use of memset for pattern initialization Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63967 Files: clang/tes

[PATCH] D63155: [clang][NewPM] Fix broken profile test

chandlerc added a comment. In D63155#1563275 , @xur wrote: > In D63155#1563266 , @chandlerc wrote: > > > I just think we also need to understand why *no other test failed*, and why > > the only test we have for doi

Re: [PATCH] D63155: [clang][NewPM] Fix broken profile test

I agree that the test coverage needs to be improved eg better check etc. David On Fri, Jun 28, 2019 at 5:21 PM Chandler Carruth via Phabricator via llvm-commits wrote: > chandlerc added a comment. > > In D63155#1563275 , @xur wrote: > > > In D63155#156

[PATCH] D63968: [analyzer] Fix target region invalidation when returning into a ctor initializer.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Enabling pointer escape notification f

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D63968: [analyzer] Fix target region invalidation when returning into a ctor initializer.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. You have made a great use of that mistake by me. So that is why everything is so perfect, because it fires, just it should fire later. Thanks you! Repository: rC Clang CHANGES SINCE LA

r364704 - [Driver] Fix style issues of --print-supported-cpus after D63105

Author: maskray Date: Fri Jun 28 18:24:36 2019 New Revision: 364704 URL: http://llvm.org/viewvc/llvm-project?rev=364704&view=rev Log: [Driver] Fix style issues of --print-supported-cpus after D63105 Reviewed By: ziangwan Differential Revision: https://reviews.llvm.org/D63822 Modified: cfe/t

[PATCH] D63822: [Driver] Fix style issues of --print-supported-cpus

This revision was automatically updated to reflect the committed changes. Closed by commit rL364704: [Driver] Fix style issues of --print-supported-cpus after D63105 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

woodruffw added a comment. Yep, I'll add one in a bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63697/new/ https://reviews.llvm.org/D63697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D58164: Block+lambda: allow reference capture

rjmccall added a comment. Okay. In that case, yeah, it'd be good to get Richard's opinion about the right way to get that information here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58164/new/ https://reviews.llvm.org/D58164 _

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

rjmccall added a comment. Thanks, looks much better. Comment at: include/clang/Sema/Sema.h:2066 bool DeduceVariableDeclarationType(VarDecl *VDecl, bool DirectInit, - Expr *Init); + Expr *Init, bool Defau

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > > rjmccal

Re: r363429 - PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type

I don't see how the resolution of Core Issue 2140 changes the status of nullptr_t lvalue-to-rvalue conversion for constexpr evaluation. PR42440 has been opened concerning the change to constexpr evaluation. -- HT On Fri, Jun 14, 2019 at 1:43 PM Richard Smith via cfe-commits < cfe-commits@lists.ll

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Actually, I'm not yet ready to commit this. I want to enforce the 8548 -> e500 processor model before I call this ready. How do I do that with the mcpu? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org

[PATCH] D63956: [analyzer] NonnullGlobalConstants: Don't be confused with a _Nonnull attribute.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63956/new/ https://reviews.llvm.org/D63956

<    1   2