[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang added a comment. > Why isn't this using FileCheck variable matching in the first place? That's > the least fragile solution. No reason, just something I overlooked when I wrote it- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

leonardchan created this revision. leonardchan added reviewers: chandlerc, phosek, serge-sans-paille, echristo. leonardchan added a project: clang. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. leonardchan added a parent revision: D63156: [clang][NewPM] Add -fno-

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan updated this revision to Diff 205906. leonardchan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63156/new/ https://reviews.llvm.org/D63156 Files: clang/test/CodeGen/aggregate-assign-call.c clang/test

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan added inline comments. Comment at: clang/test/CodeGen/pgo-sample.c:12-14 +// NEWPM-DAG: PostOrderFunctionAttrsPass +// NEWPM-DAG: SimplifyCFGPass +// NEWPM-DAG: SampleProfileLoaderPass chandlerc wrote: > The DAG worries me a bit ... The point here is

[PATCH] D63578: AMDGPU: Add DS GWS sema builtins

arsenm closed this revision. arsenm added a comment. r363986 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63578/new/ https://reviews.llvm.org/D63578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus updated this revision to Diff 205909. Szelethus added a comment. Addressing reviewer feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp Index: clang/lib/A

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 ___ cfe-commits mailing list cfe-commits@

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rupprecht updated this revision to Diff 205912. rupprecht added a comment. - Use filecheck variable matching instead of an explicit -fno-discard-value-names option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rupprecht added a comment. Sounds good, changed to use variable matching instead. This passes w/ either `-fno-discard-value-names` or `-fdiscard-value-names` used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D

r363994 - [X86] Change LL to O in the definitions for the vp2intersect builtins.

Author: ctopper Date: Thu Jun 20 15:19:16 2019 New Revision: 363994 URL: http://llvm.org/viewvc/llvm-project?rev=363994&view=rev Log: [X86] Change LL to O in the definitions for the vp2intersect builtins. This is needed to support OpenCL where long long is 128 bits. This was done for the other b

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D63625 _

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rnk added a comment. Thanks. This is surprisingly the first time I've heard of fdiscard-value-names. Seems useful, since now you can test your IR both ways without having to completely recompile clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

r363995 - [analyzer] DeadStores: Update the crude suppression for files generated by IIG.

Author: dergachev Date: Thu Jun 20 15:29:40 2019 New Revision: 363995 URL: http://llvm.org/viewvc/llvm-project?rev=363995&view=rev Log: [analyzer] DeadStores: Update the crude suppression for files generated by IIG. They changed the comments that we were looking for. Modified: cfe/trunk/lib/

r363996 - [CodeGen][test] Use FileCheck variable matchers for better test support

Author: rupprecht Date: Thu Jun 20 15:35:52 2019 New Revision: 363996 URL: http://llvm.org/viewvc/llvm-project?rev=363996&view=rev Log: [CodeGen][test] Use FileCheck variable matchers for better test support Summary: Depending on how clang is built, it may discard the IR names and use names like

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

This revision was automatically updated to reflect the committed changes. Closed by commit rG73986707bd57: [CodeGen][test] Use FileCheck variable matchers for better test support (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

LLVM buildmaster will be off-line for about 30 minutes today at 5 pm

Hello everyone, LLVM buildmaster will be off-line for about 30 minutes today after 5 pm PST for maintenance. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus updated this revision to Diff 205916. Szelethus marked an inline comment as done. Szelethus added a comment. - Now using `CFGBlock::getTerminatorConditionExpr()` - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair instead of on `Expr` - Add a `TODO:` about caching

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus added a comment. Gentle ping :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D62619: [analyzer][IDF] Add a control dependency calculator + a new debug checker

Szelethus updated this revision to Diff 205917. Szelethus added a comment. Rebase on previous patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62619/new/ https://reviews.llvm.org/D62619 Files: clang/include/clang/Analysis/Analyses/Dominators.h clang/include/clang/Analysis/CFG

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/android/PosixReturnCheck.h:1 +//===--- PosixReturnCheck.h - clang-tidy*- C++ -*-// +// Please use - before *- C++ -* to fill line. See other checks as exam

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: aganea wrote: > arphaman wrote: > > aganea wrote: > > > Do you envision future u

[PATCH] D62888: [NewPM] Port Sancov

leonardchan updated this revision to Diff 205922. leonardchan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1231-1232 + MPM.addPass(ModuleSanitizerCoveragePass(SancovOpts)); + MPM.addPass( + createModuleToFunctionPassAdaptor(SanitizerCoveragePass(SancovOpts))); +} c

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

xazax.hun added a comment. In D62883#1552870 , @Szelethus wrote: > - Now using `CFGBlock::getTerminatorConditionExpr()` > - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair > instead of on `Expr` I would be surprised to see the s

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added a comment. Oh, wait, no, loops. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added a comment. In D62883#1552969 , @xazax.hun wrote: > In D62883#1552870 , @Szelethus wrote: > > > - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair > > instead of on `Expr` > > > I w

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan added a comment. In D63617#1552615 , @rnk wrote: > Even if `BRK #0xF000` is a Windows convention, it's still possible for ISel > to select different instructions for different OSs, and I'd prefer to > implement it that way. Ok, did the implement

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

nemanjai created this revision. nemanjai added reviewers: hfinkel, jsji, rzurob, saghir. Herald added a subscriber: kbarton. Herald added a project: clang. As we currently have it implemented in altivec.h, the offsets for these two intrinsics are element offsets. The documentation in the ABI (as

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman updated this revision to Diff 205938. arphaman added a comment. Use the shared stream as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63579/new/ https://reviews.llvm.org/D63579 Files: clang/include/clang/Frontend/Utils.h clang/lib/Frontend/DependencyFile.cpp

Re: LLVM buildmaster will be off-line for about 30 minutes today at 5 pm

Hello everyone, I was investigating the buildbot e-mail notifications. Some of you may receive old notifications, some might get some notifications again. Please ignore them. Sorry for the inconvenience and thanks for your understanding. Thanks Galina On Thu, Jun 20, 2019 at 3:41 PM Galina K

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63156/new/ https://reviews.llvm.org/D63156 _

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

chandlerc added reviewers: davidxl, tejohnson. chandlerc added a comment. See inline comment, but I think we should just drop the testing of the function attribute bit here rather than adjusting the pipeline. Comment at: llvm/lib/Passes/PassBuilder.cpp:665-668 +// We must

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Eh, this seems close enough now. I'd like a better approach for the x86 builtins, but no idea what it will end up being. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke added reviewers: 01alchemist, 4tXJ7f. fanjinke added a comment. Hi, Please help with the patch reveiw. Hi cryptoad, @cryptoad IS there anything incorrectly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm

[PATCH] D63498: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! There was some discussion about the potential stdout+stderr merging issues http://lists.llvm.org/pipermail/llvm-dev/2017-February/110469.html but I don't think it resulted in any new

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

craig.topper added a comment. I'm going to try to work on the X86 tests. Can we hold off on committing those? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 __

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult VerifyIntegerConstantExpression(Expr *E, llvm:

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker updated this revision to Diff 205944. Tyker marked an inline comment as done. Tyker added a comment. made the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h clang/include/

[PATCH] D63607: [DO NOT SUBMIT] [clang][driver] Prototype --driver-mode=fortran support for new flang

Hahnfeld added a comment. Even though I know you didn't send the email yet, can you please upload the diff with full context? Thanks :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 _

<    1   2