[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:908 --EI; llvm::Value *Addr = Builder.CreateStructGEP(nullptr, &*EI, Idx); Addr = Builder.CreateAlignedLoad(Addr, getPointerAlign(), "agg.result"); rnk wrote: > akhuan

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington updated this revision to Diff 205713. erik.pilkington marked 16 inline comments as done. erik.pilkington added a comment. Address review comments, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62825/new/ https://reviews.llvm.org/D62825 Files: clang/include/cla

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5461-5469 +case APValue::LValue: { + LValue LVal; + LVal.setFrom(Info.Ctx, Val); + APValue RVal; + if (!handleLValueToRValueConversion(Info, BCE, Ty.withConst(), +

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

NoQ added a comment. In D62899#1549715 , @Szelethus wrote: > Added a proper testfile. The only downside of it is that it doesn't test > anything. Use creduce! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62899/new/ https://reviews.llvm.org/D

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan updated this revision to Diff 205722. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 Files: clang/test/CodeGen/avx512-reduceMinMaxIntrin.c clang/test/CodeGen/avx512f-builtins.c clang/test/C

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. In D63174#1549601 , @chandlerc wrote: > OMG, I'm so sorry, I had no idea that the tests would explode like that... > Yeah, I don't think that's useful > > Maybe a better approach is to just explicitly run the code through

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi created this revision. plotfi added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63584 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp Index:

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

NoQ added a comment. I think this kinda makes sense, but also it looks like a risky change, because who knows how many times we have took the old behavior for granted. In particular, i'm slightly worried about this breaking the wonky logic of `ExprEngine::VisitLogicalExpr` (cf. D59857

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan updated this revision to Diff 205727. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 Files: clang/test/CodeGen/avx512-reduceMinMaxIntrin.c clang/test/CodeGen/avx512f-builtins.c clang/test/C

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi updated this revision to Diff 205728. plotfi added a comment. moving datalayout.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63584/new/ https://reviews.llvm.org/D63584 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom added a comment. In D57086#1550514 , @aaron.ballman wrote: > In D57086#1549632 , @domdom wrote: > > > clang-format the patch > > > Thanks! Do you need someone to commit on your behalf? You are very welcome

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi updated this revision to Diff 205729. plotfi added a comment. full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63584/new/ https://reviews.llvm.org/D63584 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp Index:

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/AST/Mangle.cpp:343 -std::vector -ASTNameGenerator::getAllManglings(const ObjCContainerDecl *OCD) { + std::vector getAllManglings(const ObjCContainerDecl *OCD) { StringRef ClassNam

[PATCH] D63577: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63577/new/ https://reviews.llvm.org/D63577 __

[PATCH] D63580: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, again, really nice. Tiny tweak below. Comment at: llvm/test/Other/available-externally-lto.ll:1 +; Ensure that we don't emit available_externally functions at -O2

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 205731. shixiao added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp

[PATCH] D63277: [CUDA][HIP] Don't set "comdat" attribute for CUDA device stub functions.

rjmccall accepted this revision. rjmccall added a comment. Alright, thanks. I agree that per the documentation this should be sufficient. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63277/new/ https://reviews.llvm.org/D63277 ___ cfe-comm

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

chandlerc added a comment. just a minor comment on one of these... Comment at: clang/test/CodeGen/pgo-sample.c:10 + +// The new pass manager analog to PrunEH is a combination of 'function-attrs' +// and 'function(simplify-cgf)'. s/PrunEH/PruneEH/

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Mangle.cpp:343 -std::vector -ASTNameGenerator::getAllManglings(const ObjCContainerDecl *OCD) { + std::vector getAllManglings(const ObjCCo

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

keryell added inline comments. Comment at: clang/test/SemaSYCL/device-attributes.cpp:3 + +[[clang::sycl_kernel]] int gv2 = 0; // expected-warning {{'sycl_kernel' attribute only applies to functions}} +__attribute((sycl_kernel)) int gv3 = 0; // expected-warning {{'sycl_kernel' a

[PATCH] D63227: [analyzer] Better timers.

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:228 -ExprEngine::~ExprEngine() { - BR.FlushReports(); NoQ wrote: > xazax.hun wrote: > > Hmm. Maybe add an assert that all the bug reports are flushed at this > > point?

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rL363908: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC). (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

r363908 - [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

Author: zer0 Date: Wed Jun 19 23:01:06 2019 New Revision: 363908 URL: http://llvm.org/viewvc/llvm-project?rev=363908&view=rev Log: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC). The original pimpl pattern used between CodegenNameGenerator and CodegenNameGeneratorImpl did a

<    1   2   3