[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

chandlerc added a comment. This really confused me. We shouldn't be seeing this kind of difference in the new PM. But I think I figured it out. Both PMs have to run *some* inliner at -O0. This is because we need to inline `always_inline` functions. The new PM has a *super* simple (and fast co

[PATCH] D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Code change LGTM. Can you update at least one of the tests to explicitly run both PMs so that we'll notice if this breaks in some weird way? Feel free to submit with that change. Repos

[PATCH] D63155: [clang][NewPM] Fix broken profile test

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Let's update the test to explicitly run w/ both PMs to make sure this keeps working. LGTM with that change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

chandlerc added a comment. I understand the change to explicitly say `-O2`. I also understand the change to add an explicit `-fno-experimental-new-pass-manager` to a `RUN` line when we have another `RUN` line that explicitly uses `-fexperiemntal-new-pass-manager`. But for many of these cases, t

[PATCH] D63168: [clang][NewPM] Fix split debug test

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Code change LGTM, but again, let's update the test to check both ways. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63168/new/ https://re

[PATCH] D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM. Bit annoying that we need to do this at O0, but fine... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63170/new/ https://reviews.llv

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

NoQ added a comment. Yup, this makes sense now! I'll do some nit-picking for a little longer. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:839 +// as a 'StmtPoint' so we have to bypass it. +const bool IsBypass = isa(S); + For now th

<    1   2