[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

2019-06-07 Thread Kan Shengchen via Phabricator via cfe-commits
skan updated this revision to Diff 203664. skan added a comment. make macro more compact CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 Files: lib/Frontend/HeaderIncludeGen.cpp test/Frontend/clang_H_opt.c Index: test/Frontend/clang_H_opt.

Re: [PATCH] D61914: [Support][Test] Time profiler: add regression test

2019-06-07 Thread Puyan Lotfi via cfe-commits
--target= Sent from ProtonMail Mobile On Fri, Jun 7, 2019 at 2:01 PM, Anton Afanasyev via Phabricator wrote: > anton-afanasyev marked an inline comment as done. > anton-afanasyev added a comment. > > In D61914#1534508 , @plotfi wrote: > >> cfe/trunk/tes

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

2019-06-07 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. I've tested the pre-normalization and it looks like I can commit it tomorrow. I noticed that the following three files appear to be unreferenced: clang/test/Analysis/Inputs/expected-plists/cstring-plist.c.plist clang/test/Analysis/Inputs/expected-plist

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

2019-06-07 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added a subscriber: jsji. Herald added a project: clang. As suggested in the review of D62949 , this patch updates the plist o

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

2019-06-07 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. @aaron.ballman, for similar cases in the plist output, it has been proposed - that the reference expected file be committed into the tree pre-normalized, and - that tool be modified such that the output file has a newline at the end of the file. Does tha

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

2019-06-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:842-849 + if (Optional CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S) break; - if (auto SP = Node->getLocationAs()) -i

<    1   2