[PATCH] D50147: clang-format: support external styles

sammccall added a comment. One thing that's unclear to me is whether your aim is to 1. solve a concrete problem for your organization 2. solve a family of problems for similar organizations 3. add a new way of configuring styles for many types of users/projects If it's 1) I think this is very re

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang updated this revision to Diff 203462. czhang marked an inline comment as done. czhang added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62829/new/ https://reviews.llvm.org/D62829 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

r362756 - Convert MemberExpr creation and serialization to work the same way as

Author: rsmith Date: Thu Jun 6 16:24:15 2019 New Revision: 362756 URL: http://llvm.org/viewvc/llvm-project?rev=362756&view=rev Log: Convert MemberExpr creation and serialization to work the same way as most / all other Expr subclasses. This reinstates r362551, reverted in r362597, with a fix to

r362757 - Factor out duplicated code building a MemberExpr and marking it

Author: rsmith Date: Thu Jun 6 16:24:18 2019 New Revision: 362757 URL: http://llvm.org/viewvc/llvm-project?rev=362757&view=rev Log: Factor out duplicated code building a MemberExpr and marking it referenced. This reinstates r362563, reverted in r362597. Modified: cfe/trunk/include/clang/Sem

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked an inline comment as done. czhang added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:40 +return; + Finder->addMatcher(varDecl().bind("var"), this); +} lebedev.ri wrote: > Most of the mat

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

lebedev.ri added a comment. Hmm, but there already is clang's `-Wglobal-constructors`, that fires on some of these: https://godbolt.org/z/rSnNuu You are sure those extra warning this check produces ontop of `-Wglobal-constructors` are correct? If so, maybe `-Wglobal-constructors` should be exten

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 203464. plotfi added a comment. Updated hidden parent/child class inheritance cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 203465. plotfi added a comment. git mv'ed hidden-class-inheritance.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td c

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang added a comment. In D62829#1533345 , @lebedev.ri wrote: > Hmm, but there already is clang's `-Wglobal-constructors`, that fires on some > of these: > https://godbolt.org/z/rSnNuu > You are sure those extra warning this check produces ontop of >

Buildmaster cleaning/ removing abandoned builders

Hello everyone, I am going to remove builders/slaves which are off-line for a long time now and seem abandoned. Here is the list: http://lab.llvm.org:8011/builders/clang-openbsd-amd64 http://lab.llvm.org:8011/builders/clang-native-aarch64-full http://lab.llvm.org:8011/builders/clang-bpf-build htt

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

Eugene.Zelenko added a comment. I think will be good idea to replace //upgrade// with //modernize// to be consistent with similar checks in other module. Comment at: clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp:170 + +llvm::StringRef getNewMethodName(llv

[PATCH] D62835: [X86] -march=cooperlake (clang)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62835/new/ https://reviews.llvm.org/D62835 ___ cfe-commits mailing list c

[PATCH] D62978: [analyzer] ReturnVisitor: Handle non-null ReturnStmts

NoQ added a comment. Ah, that positive! No, i don't think this is a valid way to suppress it. I'll tease you a bit more though, and only give a hint: the null value that we're null-dereferencing was in fact assumed to be null //in the top frame//, not within any inline function. Therefore the

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

NoQ added a comment. Aha, nice, that's much cleaner! Indeed, we have to skip the construct-expression, which is going to be on our way to the program point of new-expression which corresponds to calling the allocator, despite being nested within the new-expression. An annoying corner-case. I'd

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

NoQ added a comment. Looks great! Feel free to add a Driver flag as well (i.e., --analyzer-werror or something like that) so that not to type `-Xclang` every time. In D62885#1530573 , @xazax.hun wrote: > The only problem I see with this approach is that

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

NoQ added a comment. Thanks! I think we should: - Pre-normalize our expected outputs so that we didn't have to normalize them in every run-line. - Treat the lack of newline in plist output as a bug and try to fix it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

NoQ added a comment. In D59555#1514602 , @NoQ wrote: > I'm still in doubts on how to connect your work with the `CallDescription` > effort. I'll think more about that. I guess i'll just make a yaml reader for `CallDescription`s as soon as the interface

[PATCH] D62946: [analyzer] ProgramPoint: more explicit printJson()

NoQ added a comment. Fair enough! Tests are welcome. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62946/new/ https://reviews.llvm.org/D62946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 203492. wxiao3 edited the summary of this revision. wxiao3 added a reviewer: mgorny. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-arguments-linux.c

[PATCH] D62946: [analyzer] ProgramPoint: more explicit printJson()

Charusso added a comment. In D62946#1533592 , @NoQ wrote: > Fair enough! > > Tests are welcome. Is it possible? E.g. I have not found any case for `PostCondition` and may it requires 10+ of dot dumps which is very space-consuming. I think test to print

[PATCH] D62946: [analyzer] ProgramPoint: more explicit printJson()

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, ok, right! I wouldn't be surprised if some of these are entirely unused. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62946/new/ https://reviews.llvm.org/D629

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Thanks for the suggestions! I have updated the patch accordingly. Ok for merge now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533574 , @NoQ wrote: > I think we should: > > - Pre-normalize our expected outputs so that we didn't have to normalize them > in every run-line. Okay; I think this might be possible to do in a separate

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok! I'll be happy to have this addressed incrementally. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62949/new/ https://reviews.llvm.org/D62949 _

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

uabelho added inline comments. Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925 +// FIXME: this should only be set on CK_CurrentParameter. +Signal.ContainsActiveParameter = true; + } ilya-biryukov wrote: > ilya-biryukov wrote: > > uabelho

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge updated this revision to Diff 203495. nridge marked 16 inline comments as done. nridge added a comment. Addressed most review comments, also added some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 ___ cfe-commits mailing list c

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:107 + virtual void + relations(const SymbolID &Subject, index::SymbolRole Predicate, +llvm::function_ref Callback) const = 0; kadircet wrote: > We might need additional

<    1   2