[clang-tools-extra] r362679 - [clang-tidy] Fix make-unique tests on C++2a.

Author: hokein Date: Thu Jun 6 00:48:55 2019 New Revision: 362679 URL: http://llvm.org/viewvc/llvm-project?rev=362679&view=rev Log: [clang-tidy] Fix make-unique tests on C++2a. Summary: These test cases are illgal in C++2a ("new Foo{}" needs to see the default constructor), so move them to the C

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362679: [clang-tidy] Fix make-unique tests on C++2a. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

r362683 - Update AST matchers tutorial to use monorepo layout

Author: ibiryukov Date: Thu Jun 6 01:06:25 2019 New Revision: 362683 URL: http://llvm.org/viewvc/llvm-project?rev=362683&view=rev Log: Update AST matchers tutorial to use monorepo layout The docs were inconsistent: requesting the user to clone the monorepo, and then continuing with the `llvm/too

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925 +// FIXME: this should only be set on CK_CurrentParameter. +Signal.ContainsActiveParameter = true; + } ua

r362685 - [X86] Add ENQCMD instructions

Author: pengfei Date: Thu Jun 6 01:28:42 2019 New Revision: 362685 URL: http://llvm.org/viewvc/llvm-project?rev=362685&view=rev Log: [X86] Add ENQCMD instructions For more details about these instructions, please refer to the latest ISE document: https://software.intel.com/en-us/download/intel-a

[PATCH] D62282: [X86] Add ENQCMD intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362685: [X86] Add ENQCMD instructions (authored by pengfei, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6228

[clang-tools-extra] r362686 - [clangd] Remove unused signature help quality signal. NFC

Author: ibiryukov Date: Thu Jun 6 01:32:25 2019 New Revision: 362686 URL: http://llvm.org/viewvc/llvm-project?rev=362686&view=rev Log: [clangd] Remove unused signature help quality signal. NFC ContainsActiveParameter is not used anywhere, set incorrectly (see the removed FIXME) and has no unit t

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925 +// FIXME: this should only be set on CK_CurrentParameter. +Signal.ContainsActiveParameter = true; + } il

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 203306. nik marked 2 inline comments as done. nik added a comment. Addressed inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 Files: clang-tidy/ClangTidyDi

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:207 CheckNamesByDiagnosticID.try_emplace(ID, CheckName); + CustomDiagIdParamsByDiagnosticID.try_emplace( + ID, CustomDiagIdParams(Level, FormatString))

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

xazax.hun added a comment. Generally looks good, some nits inline. Please mark comments you already solved as done. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:73-75 static const unsigned InvalidArgIndex = UINT_MAX; /// Denotes the return vale. sta

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro created this revision. ro added reviewers: rsmith, fedor.sergeev. Herald added a subscriber: jyknight. Herald added a project: clang. `Clang :: Sema/wchar.c` has long been failing on Solaris: error: 'error' diagnostics expected but not seen: File /vol/llvm/src/clang/local/test/Sema/wcha

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:835-842 // First, find when we processed the statement. do { if (auto CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S)

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

Charusso updated this revision to Diff 203324. Charusso marked 4 inline comments as done. Charusso retitled this revision from "[analyzer] ReturnVisitor: Bypass everything to see inlined calls" to "[analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls". Charusso added a comme

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

Charusso updated this revision to Diff 203326. Charusso added a comment. - Better wording. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/ https://reviews.llvm.org/D62926 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang/test/Analysis/new-ctor-null-throw.c

[PATCH] D62835: [X86] -march=cooperlake (clang)

skan updated this revision to Diff 203327. skan added a comment. avoid implicit type conversion for intrinsic parameter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62835/new/ https://reviews.llvm.org/D62835 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp li

[PATCH] D62835: [X86] -march=cooperlake (clang)

skan updated this revision to Diff 203329. skan added a comment. uploaded a unrelated patch last time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62835/new/ https://reviews.llvm.org/D62835 Files: include/clang/Basic/X86Target.def lib/Basic/Targets/X86.cpp test/Driver/x86-march

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

skan updated this revision to Diff 203330. skan added a comment. avoid implicit type conversion for intrinsic parameter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp li

[PATCH] D62946: [analyzer] ProgramPoint: more explicit printJson()

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. Now we print out every possible kinds

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:835-842 // First, find when we processed the statement. do { if (auto CEE = Node->getLocationAs()) if (CEE->getCa

[PATCH] D62947: [clang-tidy] Fix an assertion failure in misc-redundant-expression.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. The assertion "isIntegerConstantExpr" is triggered in the isIntegerConstantExpr(), we should not call it if the expression is value dependent. Repository: rG L

[PATCH] D61486: [Basic] Introduce active dummy DiagnosticBuilder

gribozavr added a comment. Is this patch still needed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61486/new/ https://reviews.llvm.org/D61486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D57795: [RISCV] Add FreeBSD targets

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57795/new/ https://reviews.llvm.org/D57795 __

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

hokein added a comment. @juliehockett could you take a look on this patch? I think you have the best knowledge about this check and fuchsia stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62437/new/ https://reviews.llvm.org/D62437 ___

[clang-tools-extra] r362701 - [clang-tidy] Fix an assertion failure in misc-redundant-expression.

Author: hokein Date: Thu Jun 6 05:58:48 2019 New Revision: 362701 URL: http://llvm.org/viewvc/llvm-project?rev=362701&view=rev Log: [clang-tidy] Fix an assertion failure in misc-redundant-expression. Summary: The assertion "isIntegerConstantExpr" is triggered in the isIntegerConstantExpr(), we s

[PATCH] D62947: [clang-tidy] Fix an assertion failure in misc-redundant-expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362701: [clang-tidy] Fix an assertion failure in misc-redundant-expression. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 203335. djtodoro added a comment. -Explicitly enable the option only in the case of X86 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver

[clang-tools-extra] r362702 - [clang-tidy] Make the plugin honor NOLINT

Author: nik Date: Thu Jun 6 06:13:27 2019 New Revision: 362702 URL: http://llvm.org/viewvc/llvm-project?rev=362702&view=rev Log: [clang-tidy] Make the plugin honor NOLINT Instantiate a ClangTidyDiagnosticConsumer also for the plugin case and let it forward the diagnostics to the external diagnos

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 updated this revision to Diff 203339. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp lib/StaticAnalyzer/Checkers/Yaml.h test/Analysis/Inputs/taint-gen

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

This revision was automatically updated to reflect the committed changes. Closed by commit rL362702: [clang-tidy] Make the plugin honor NOLINT (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61486: [Basic] Introduce active dummy DiagnosticBuilder

nik added a comment. In D61486#1532272 , @gribozavr wrote: > Is this patch still needed? Nope, abandoning it now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61486/new/ https://reviews.llvm.org/D61486 _

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Thanks Dmitri! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D59744: Fix i386 ABI "__m64" type bug

mgorny added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1005 bool IsMCUABI; + bool IsLinuxABI; unsigned DefaultNumRegisterParameters; Maybe replace the two booleans with something alike `IsPassInMMXRegABI`? And while at it, include NetBSD the

[clang-tools-extra] r362706 - [clang-tidy] Another attempt to fix misc-redundant-expression check.

Author: hokein Date: Thu Jun 6 06:43:38 2019 New Revision: 362706 URL: http://llvm.org/viewvc/llvm-project?rev=362706&view=rev Log: [clang-tidy] Another attempt to fix misc-redundant-expression check. Correct the fix of rL3627011, the isValueDependent guard was added in a wrong place in rL36270

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/ https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. ping ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D50147: clang-format: support external styles

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

balazske added a comment. Is it a better fix to change getMacroInfoForLocation? static const MacroInfo *getMacroInfoForLocation(const Preprocessor &PP, const SourceManager &SM, const IdentifierIn

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

r362707 - [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

Author: ymandel Date: Thu Jun 6 07:20:29 2019 New Revision: 362707 URL: http://llvm.org/viewvc/llvm-project?rev=362707&view=rev Log: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s. Summary: `change()` is an all purpose function; the revision adds simple shortcuts f

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362707: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. This change makes sure we have a single mapping for each macro expansion, even if the result of expansion was empty. To achieve that, we take information from PPCallbacks::MacroExpands i

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a subscriber: kadircet. Herald added a project: clang. Used in clangd for a code tweak that expands a macro. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62954 Files: clang/include

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. ilya-biryukov added a child revision: D61681: [clangd] A code tweak to expand a macro. The first use of this is a

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov updated this revision to Diff 203358. ilya-biryukov added a comment. - Move logically separate parts to other changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61681/new/ https://reviews.llvm.org/D61681 Files: clang-tools-extra

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

Szelethus added a reviewer: aaron.ballman. Szelethus added a comment. Added Aaron as he wrote the this diagnostic output type :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62952/new/ https://reviews.llvm.org/D62952 __

[PATCH] D37813: clang-format: better handle namespace macros

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/ https://reviews.llvm.org/D37813 ___ cfe-commits mail

[PATCH] D57795: [RISCV] Add FreeBSD targets

jrtc27 updated this revision to Diff 203359. jrtc27 added a comment. Sorted OS case statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57795/new/ https://reviews.llvm.org/D57795 Files: clang/lib/Basic/Targets.cpp clang/lib/Driver/ToolCha

[PATCH] D62958: [clang-tidy] Fix descriptions for modernize-make-unique/shared checks.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62958 Files: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/c

[PATCH] D62960: SVE opaque type for C intrinsics demo

rsandifo-arm created this revision. Herald added subscribers: cfe-commits, arphaman, tschuett, javed.absar. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. A lightly-modified version of Graham Hunter's original patch: https://reviews.llvm.org/D5924

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm created this revision. Herald added subscribers: cfe-commits, jfb, kristof.beyls, javed.absar. Herald added a reviewer: rengolin. Herald added a project: clang. This patch adds the concept of "sizeless" types to C and C++. The documentation part of the patch describes the extension in

[PATCH] D62961: [AST] Add new Type queries for sizeless types

rsandifo-arm created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch adds new type queries: - isSizelessType - isDefiniteType - isIndefiniteType following the type classification described in the comments. The follow-on patch to support siz

[PATCH] D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types

rsandifo-arm abandoned this revision. rsandifo-arm added a comment. Herald added a subscriber: arphaman. Herald added a reviewer: rengolin. Herald added a project: clang. Abandoning in favour of: https://reviews.llvm.org/D62960 https://reviews.llvm.org/D62961 https://reviews.llvm.org/D62962 Rep

[PATCH] D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types

rsandifo-arm abandoned this revision. rsandifo-arm added a comment. Herald added a subscriber: jfb. Herald added a reviewer: rengolin. Herald added a project: clang. Abandoning in favour of: https://reviews.llvm.org/D62960 https://reviews.llvm.org/D62961 https://reviews.llvm.org/D62962 Reposito

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet updated this revision to Diff 203386. gchatelet added a comment. - Add documentation. - Fix permissive HasNoRuntimeAttribute - Mark interleave as disabled in the documentation. - Use no-builtin instead of no-runtime-for. - Adding an llvm.memcpy.inline intrinsic. - Adding __builtin_memcpy

[PATCH] D62965: [clang][HeaderSearch] Consider all path separators equal

kadircet created this revision. kadircet added reviewers: ilya-biryukov, sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62965 Files: clang/lib/Lex/HeaderSearch.cpp clang/unittests/Lex/HeaderSea

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

juliehockett added a comment. Sorry for the delay! Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsCallsCheck.cpp:24 + const auto *S = Result.Nodes.getNodeAs("stmt"); + if (S == nullptr) +return; Just `if (!S)` should be sufficient here.

[PATCH] D62965: [clang][HeaderSearch] Consider all path separators equal

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:1718 + // Ignore path separators. + if (NI->size() == 1 && DI->size() == 1 && I think "consi

[PATCH] D62965: [clang][HeaderSearch] Consider all path separators equal

kadircet updated this revision to Diff 203399. kadircet marked an inline comment as done. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62965/new/ https://reviews.llvm.org/D62965 Files: clang/lib/Lex/He

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:293 + // This map is used to figure out where to store relations. + llvm::DenseMap IDsToFiles; for (const auto &Sym : *Index.Symbols) { nit: rename to `SymbolIDToFile`?

[PATCH] D62970: [clang-doc] De-duplicate comments

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. De-duplicate comments in reduce function. When two files include the same header file, this file's content is mapped twice and commen

[PATCH] D62970: [clang-doc] De-duplicate comments

lebedev.ri added a comment. Test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62970/new/ https://reviews.llvm.org/D62970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. Just an idea: We could avoid the explicit calls to 'initializeXYZPass' in opt/bugpoint/clang by adding Polly.cpp as a source file or object library to the executables. This would guarantee that its static initializer is called without dynamic library. Repository:

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. Please add a test case to `unittests/clang-doc/MergeTest.cpp`. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124-127 +bool IsCommentUnique = std::find(Description.begin(), Description.end(), + Co

r362731 - [clang][HeaderSearch] Consider all path separators equal

Author: kadircet Date: Thu Jun 6 11:49:16 2019 New Revision: 362731 URL: http://llvm.org/viewvc/llvm-project?rev=362731&view=rev Log: [clang][HeaderSearch] Consider all path separators equal Reviewers: ilya-biryukov, sammccall Subscribers: cfe-commits Tags: #clang Differential Revision: https

[PATCH] D62965: [clang][HeaderSearch] Consider all path separators equal

This revision was automatically updated to reflect the committed changes. Closed by commit rL362731: [clang][HeaderSearch] Consider all path separators equal (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D62971: [HIP] Remove the assertion on match between host/device names.

hliao created this revision. hliao added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Under different ABIs, it's obvious that assertion is too strong. Even under the same ABI, once there are unnamed type not required to follow ODR rule, host- and d

[PATCH] D62971: [HIP] Remove the assertion on match between host/device names.

yaxunl added a comment. LGTM. It seems no reason to assume the mangled name to be same on host and device side once anonymous types are mangled differently in host and device code. On windows, kernel has totally different names on host and device side without issues. Repository: rG LLVM Git

[PATCH] D62975: Require stdcall etc parameters to be complete on ODR use

rnk created this revision. rnk added reviewers: thakis, rsmith, hans. Herald added a project: clang. Functions using stdcall, fastcall, or vectorcall with C linkage mangle in the size of the parameter pack. Calculating the size of the pack requires the parameter types to complete, which may requir

[PATCH] D62971: [HIP] Remove the assertion on match between host/device names.

hliao added a comment. a little explanation of the test case and what's issue is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62971/new/ https://reviews.llvm.org/D62971 ___ cfe-commits mailing list c

[PATCH] D62971: [HIP] Remove the assertion on match between host/device names.

hliao marked 2 inline comments as done. hliao added inline comments. Comment at: clang/test/CodeGenCUDA/unnamed-types.cu:5 + +// CHECK: @0 = private unnamed_addr constant [40 x i8] c"_Z2k0IZZ2f1PfENK3$_0clES0_EUlfE_EvS0_T_\00" + device-side mangled name, notice

[PATCH] D37813: clang-format: better handle namespace macros

Typz updated this revision to Diff 203425. Typz added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/ https://reviews.llvm.org/D37813 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp l

r362740 - clang-format: better handle namespace macros

Author: typz Date: Thu Jun 6 13:06:23 2019 New Revision: 362740 URL: http://llvm.org/viewvc/llvm-project?rev=362740&view=rev Log: clang-format: better handle namespace macros Summary: Other macros are used to declare namespaces, and should thus be handled similarly. This is the case for crpcut's

[PATCH] D37813: clang-format: better handle namespace macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL362740: clang-format: better handle namespace macros (authored by Typz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACT

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

astrelni created this revision. astrelni added reviewers: alexfh, hokein, aaron.ballman, JonasToth, EricWF. astrelni added a project: clang-tools-extra. Herald added subscribers: llvm-commits, cfe-commits, xazax.hun, mgorny. Herald added projects: clang, LLVM. Introduce a new check to upgrade user

[PATCH] D62971: [HIP] Remove the assertion on match between host/device names.

hliao added a comment. I took this back. I fab a case where anonymous type IDs mismatch between the device-side name between host-compilation and device-compilation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62971/new/ https://reviews.llvm.org

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

sammccall added a comment. Implementation looks good. I can't see a better way to solve this problem, it's just a bit unfortunate to have a sophisticated solution but not be able to turn it on by default. I think naming is important here: it's a fairly complicated feature that (I suppose) rela

[PATCH] D62975: Require stdcall etc parameters to be complete on ODR use

inglorion added a comment. Can you clarify "which will usually result in a linker error"? E.g. an example of link.exe rejecting the object file or the wrong function being called. The reason I ask is that if we can be sure at compile time that the resulting code will not work or do the wrong th

[PATCH] D62808: [clangd] Print the ignored variant symbols

sammccall added inline comments. Comment at: clang-tools-extra/clangd/include-mapping/gen_std.py:119 +( a list of tuple (symbol_name, relative_path_to_symbol_page), + a list of tuple (variant_symbol_name, caption_text) ) """ this is a significantly mo

[PATCH] D62978: [analyzer] ReturnVisitor: Handle non-null ReturnStmts

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. Charusso added a comment. Suppressed e

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. In D61446#1532848 , @Meinersbur wrote: > Just an idea: We could avoid the explicit calls to 'initializeXYZPass' in > opt/bugpoint/clang by adding Polly.cpp as a source file or object library to > the executables. This w

[PATCH] D62978: [analyzer] ReturnVisitor: Handle non-null ReturnStmts

Charusso added a comment. Suppressed example: F9091784: return-non-null.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62978/new/ https://reviews.llvm.org/D62978 ___ cfe-commi

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

Charusso added a comment. If I run `scan-build` on LLVM this is the only non-bypassed case since the first diff: F9091851: non-bypassed.html I think it is working well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/ https://reviews.llvm.or

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 203438. lildmh added a comment. Use __tgt instead of __kmpc for mapper runtime function names CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/ASTContext.cpp

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

lebedev.ri added a comment. By the way, much to my surprise, this didn't start diagnosing the loop i expected it to start diagnosing: https://godbolt.org/z/lsJTSS This is expected? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61827/new/ https://re

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 203447. DiegoAstiazaran added a comment. Complete documentation in ReleaseNotes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62437/new/ https://reviews.llvm.org/D62437 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt clang-to

[PATCH] D62855: Implementation of auto type expansion.

sammccall added a comment. Sorry about the delay here. Happy to chat offline if I'm being confusing. Comment at: clang-tools-extra/clangd/AST.cpp:172 +namespace { +/// Computes the deduced type at a given location by visiting the relevant It looks like this h

[PATCH] D62970: [clang-doc] De-duplicate comments

jakehehrlich added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124 + for (auto &Comment : Other.Description) { +bool IsCommentUnique = std::find(Description.begin(), Description.end(), + Comment) == Descript

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:122 + Warns if a function or method is called with default arguments. + This was previously done by fuchsia-default-arguments check, which has been + removed. Please high

[PATCH] D62970: [clang-doc] De-duplicate comments

jakehehrlich added a comment. Actually if we can make Description a hash set that would be best. I think using std::set would require an awkward < operator to be defined. There should be standard ways of getting hashes out of all the string and vector types and you can use hash_combine to combi

[PATCH] D62975: Require stdcall etc parameters to be complete on ODR use

rnk marked 2 inline comments as done. rnk added a comment. In D62975#1533019 , @inglorion wrote: > Can you clarify "which will usually result in a linker error"? E.g. an > example of link.exe rejecting the object file or the wrong function being > called

[PATCH] D61790: [C++20] add Basic consteval specifier

rsmith added a comment. Thank you! Comment at: clang/include/clang/AST/DeclBase.h:1497 + +/// kind of Contexpr specifier as defined by ConstexprSpecKind. +uint64_t ConstexprKind : 2; "kind" -> "Kind" "Contexpr" -> "constexpr" Comment

[PATCH] D62975: Require stdcall etc parameters to be complete on ODR use

inglorion accepted this revision. inglorion added a comment. This revision is now accepted and ready to land. Thank you. Given that proceeding with the wrong value will result in either an undefined reference or a reference to what might well be the wrong function at link time, I think making th

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. In D62970#1533229 , @jakehehrlich wrote: > Actually if we can make Description a hash set that would be best. I think > using std::set would require an awkward < operator to be defined. There > should be standard ways of ge

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. clang currently disallows fields of non-trivial types (e.g., `__strong`) in unions in C mode since it's not possible for the compiler to determine h

[PATCH] D62697: AMDGPU: Disable errno by default

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62697/new/ https://reviews.llvm.org/D62697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62696: AMDGPU: Use AMDGPU toolchain for other OSes

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62696/new/ https://reviews.llvm.org/D62696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >