[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:40 +return; + Finder->addMatcher(varDecl().bind("var"), this); +} Most of the matching should be done here, not in `check()`. Repository

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rL362459: Add clang source minimizer that reduces source to directives (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

quantum created this revision. quantum added reviewers: tlively, aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. LSan is currently being ported to Emscripten and mostly works. Enabling the support in upstream would simpli

r362462 - Remove test/CodeGen/builtin-stackaddress.c as it duplicates

Author: echristo Date: Mon Jun 3 16:16:06 2019 New Revision: 362462 URL: http://llvm.org/viewvc/llvm-project?rev=362462&view=rev Log: Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c. Differential Revision: https://reviews.llvm.org/D

r362463 - Fix windows build for commit r362459

Author: arphaman Date: Mon Jun 3 16:17:21 2019 New Revision: 362463 URL: http://llvm.org/viewvc/llvm-project?rev=362463&view=rev Log: Fix windows build for commit r362459 Modified: cfe/trunk/lib/Lex/DependencyDirectivesSourceMinimizer.cpp Modified: cfe/trunk/lib/Lex/DependencyDirectivesSour

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

echristo added a comment. done thusly: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: d91813ca8c7 Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c. Deleting cfe/trunk/test/CodeGen/builtin-stackaddress.c C

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL362462: Remove test/CodeGen/builtin-stackaddress.c as it duplicates (authored by echristo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington, pete, gottesmm. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This is needed to enable the optimization in this patch: https://reviews.llvm.org/D62433 Repository: rC Clang h

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7762-7787 // Ensure none of the TypoExprs have multiple typo correction candidates // with the same edit length that pass all the checks and filters. //

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

ahatanak updated this revision to Diff 202821. ahatanak marked an inline comment as done. ahatanak added a comment. Just set `isClassMessage` instead of passing a separate flag to `tryGenerateSpecializedMessageSend`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

daltenty updated this revision to Diff 202822. daltenty added a comment. Fix grammar in comments. Fix up the way we define the macros for Google Test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62533/new/ https://reviews.llvm.org/D62533 Files:

r362464 - Add a release note entry for the change made in r362034.

Author: ahatanak Date: Mon Jun 3 16:48:14 2019 New Revision: 362464 URL: http://llvm.org/viewvc/llvm-project?rev=362464&view=rev Log: Add a release note entry for the change made in r362034. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llv

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

jkorous updated this revision to Diff 202827. jkorous added a comment. Fix in the header file from which the documentation is actually generated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61729/new/ https://reviews.llvm.org/D61729 Files: clang/docs/ClangFormatStyleOptions.rst c

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

jkorous added a comment. Thanks, I didn't know it's generated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61729/new/ https://reviews.llvm.org/D61729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

jfb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9716 +def err_bit_cast_non_trivially_copyable : Error< + "__builtin_bit_cast %select{source|destination}0 type must be a trivially copyable">; +def err_bit_cast_type_size_mismatch : Error< -

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. I thinks this looks good, aside from a null concern. Comment at: lib/CodeGen/CGObjC.cpp:460 + const Expr *SelfInClassMethod = nullptr; + if (const auto *C

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added a comment. Can we also use the same bit reader/writer implementation to generalize the current implementation of `__builtin_memcpy` and friends? (I don't think we can remove the existing implementation, sadly, since we allow copying arrays of the same trivially-copyable type today

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:37 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + // FIXME: Add matchers. + if (!getLangOpts().CPlusPlus) ---

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

jfb added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5447 + +case APValue::LValue: { + LValue LVal; rsmith wrote: > This will permit bitcasts from `nullptr_t`, providing a zero value. I think > that's wrong; the bit representation of `n

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

beanz added a comment. I have a thought for how we can make the CMake interface for this better. Instead of `LLVM_EXTENSIONS` being a global property if it were a pre-defined list like `LLVM_ALL_PROJECTS`, then the `LLVM_LINK__INTO_TOOLS` variables can be generated by LLVM's configuration inste

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202830. jcai19 added a comment. Update description based on comments and remove CHECK-MESSAGES-NOT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files: clang-tools-e

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked 4 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:20 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: 'pipe2' should use O_CLOEXEC where possible [android-cl

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43226/new/ https://reviews.llvm.org/D43226 ___

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202832. jcai19 added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files: clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp clang-t

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 3 inline comments as done. jkorous added a comment. I fixed the rest. There are still some questions you raised that I just responded to and kept them as not Done. Feel free to take a look. If nothing comes up I'll commit this on Wednesday. Comment at: clang/l

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 202833. jkorous added a comment. linux implementation - factory method for SemaphorePipe - *_CLOEXEC flags CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/Direc

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5447 + +case APValue::LValue: { + LValue LVal; jfb wrote: > rsmith wrote: > > This will permit bitcasts from `nullptr_t`, providing a zero value. I think > > that's wrong; the bit

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 202835. jcai19 added a comment. Update the test function names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files: clang-tools-extra/clang-tidy/android/AndroidTidy

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 marked an inline comment as done. jcai19 added a comment. Thanks for all the comments. george.burgess.iv will submit this change for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 ___

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. @daltenty, I believe that you have had a good number of patches committed into the project already (rL360898 , rL361410

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

jfb added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5447 + +case APValue::LValue: { + LValue LVal; rsmith wrote: > jfb wrote: > > rsmith wrote: > > > This will permit bitcasts from `nullptr_t`, providing a zero value. I > > > think tha

[PATCH] D62835: support -march=cooperlake (clang part)

skan created this revision. skan added reviewers: craig.topper, LuoYuanke, xiangzhangllvm, pengfei. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D62835 Files: include/clang/Basic/X86Target.def lib/Basic/Targets/X86.cpp

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

aheejin added a comment. Oh, can we have a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

george.burgess.iv added a comment. Will submit once gribozavr indicates that they're happy with the new test names. Thanks again for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 _

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge added a comment. In D62471#1527085 , @kadircet wrote: > LGTM, thanks! Thanks for the reviews so far! > I suppose there are only two patches left now? > > - Exposing relations in `SymbolIndex`. > - Implementing children resolution using that info

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added a subscriber: cfe-commits. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62471: [clangd] SymbolCollector support for relations

This revision was automatically updated to reflect the committed changes. Closed by commit rL362467: [clangd] SymbolCollector support for relations (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Remaining work: - BackgroundIndex implementation - Dex implementation Repository: rG LLVM Github Monorepo https:/

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

nridge added a comment. This isn't quite ready for a thorough review, but I have a question for now: in `BackgroundIndex::update`, there is a step where we partition symbols and references into files. For relations, should we include a copy in both the file containing the definition of the sub

[PATCH] D62282: [X86] Add ENQCMD intrinsics.

tianqing updated this revision to Diff 202856. tianqing added a comment. Added doxygen comments of intrinsics in enqcmdintrin.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62282/new/ https://reviews.llvm.org/D62282 Files: docs/ClangCommandLineReference.rst include/clang/Basic/Bu

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62282: [X86] Add ENQCMD intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62282/new/ https://reviews.llvm.org/D62282 ___ cfe-commits mailing list c

<    1   2