[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202502. NoQ marked 12 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot clang/test/Analysis/explod

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = Eugene.Zelenko wr

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. Also switched to python2 because it seems to be the default. The differences are minimal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits mailing list cfe-commit

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:151 +super(ExplodedGraph, self).__init__() +self.nodes = collections.defaultdict(ExplodedNode) +self.root_id = None Charusso wrote: > `nodes` -> `graph`

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = gribozavr wr

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:151 +super(ExplodedGraph, self).__init__() +self.nodes = collections.defaultdict(ExplodedNode) +self.root_id = None NoQ wrote: > Charusso wrote: >

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added a comment. In D62638#1525823 , @NoQ wrote: > Also switched to python2 because it seems to be the default. The differences > are minimal. What about the state of the patch itself? Planned stuff WIP, could I take it to SVGify, or? CHANGE

Re: r356569 - [NFC][clang][astdump] Some baseline tests for OpenMP

On Sat, Jun 1, 2019 at 2:00 AM Richard Smith wrote: > > These are change detector tests > (https://testing.googleblog.com/2015/01/testing-on-toilet-change-detector-tests.html) > and create a significant maintenance burden that exceeds their value. > > Please either reduce these to tests that act

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = Eugene.Zelenko wr

[clang-tools-extra] r362279 - Revise the google-objc-global-variable-declaration check to match the style guide.

Author: stephanemoore Date: Fri May 31 16:41:15 2019 New Revision: 362279 URL: http://llvm.org/viewvc/llvm-project?rev=362279&view=rev Log: Revise the google-objc-global-variable-declaration check to match the style guide. Summary: Revise the google-objc-global-variable-declaration check to matc

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362279: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. In D62638#1525843 , @Charusso wrote: > In D62638#1525823 , @NoQ wrote: > > > Also switched to python2 because it seems to be the default. The > > differences are minimal. > > > What about the s

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json)

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json) NoQ wrote: > Charusso wr

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202511. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot clang/test/Analysis/exploded-graph-rewriter/empty.dot clang/

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json)

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a comment. NoQ added a parent

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ added a comment. I'll add some tests as soon as i'm sure tests for this thing actually work (by landing D62638 ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 ___

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 202514. NoQ added a comment. Remove "-" from program point dumps because it resembles a removal marker in diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files: clang/utils/analyzer/exploded-graph-rewr

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added a comment. In D62761#1525917 , @NoQ wrote: > Remove "-" from program point dumps because it resembles a removal marker in > diffs. Could you add an image? I have not seen any problematic stuff, just that. CHANGES SINCE LAST ACTION htt

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Let us see those tests! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits mai

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

jkorous edited reviewers, added: owenpan; removed: llvm-commits. jkorous added a subscriber: owenpan. jkorous added a comment. You're right, thanks for letting me know. It was changed in 806d5741aa7f . @owenpan was that intend

<    1   2