t.p.northover added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61939/new/
https://reviews.llvm.org/D61939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: cbieneman
Date: Thu May 30 15:25:48 2019
New Revision: 362169
URL: http://llvm.org/viewvc/llvm-project?rev=362169&view=rev
Log:
Support codesigning bundles and forcing
Summary:
Clangd's framework is assembled by copying binaries from the lib and bin
directories into a bundle shape. This
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362169: Support codesigning bundles and forcing (authored by
cbieneman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62693?vs=202239&id=202320#toc
Repository:
rL LLVM
CHANGES S
fhahn added a comment.
Hi Tim. Would it be possible to split this in the 'trivial' changes (extending
the triple handling for example) and the arm64_32 related changes to size, ABI
stuff and so on? The trivial changes look good to me and by splitting them off
people can focus on reviewing the
Author: rsmith
Date: Thu May 30 16:21:14 2019
New Revision: 362172
URL: http://llvm.org/viewvc/llvm-project?rev=362172&view=rev
Log:
Refactor OpenMP stack management.
Instead of duplicating access to the directive stack throughout
SemaOpenMP.cpp, consolidate it to a few methods and call those
eve
Author: rsmith
Date: Thu May 30 16:21:13 2019
New Revision: 362171
URL: http://llvm.org/viewvc/llvm-project?rev=362171&view=rev
Log:
Fix "fallthrough annotation in unreachable code" warning.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
http://llvm
rjmccall created this revision.
rjmccall added a reviewer: scanon.
Herald added subscribers: cfe-commits, Anastasia.
Herald added a project: clang.
Fix the predefined exponent limit macros for the 16-bit IEEE format.
The magnitude range of normalized _Float16 is 2^-14 (~6e-5) to (2-2^-10)
Hello everyone,
Below are some buildbot numbers for the week of 05/12/2019 - 05/18/2019.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 05/19/2019 -
05/25/2019.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
sbc100 created this revision.
Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith,
steven_wu, aheejin, hiraditya, mgorny, mehdi_amini.
Herald added projects: clang, LLVM.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D62709
Files:
clang/lib/CodeGen/CMakeList
thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.
Sorry about this! This LGTM, thanks for fixing it!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62709/new/
https://reviews.llvm.org/D62709
Author: rsmith
Date: Thu May 30 17:45:09 2019
New Revision: 362178
URL: http://llvm.org/viewvc/llvm-project?rev=362178&view=rev
Log:
Defer capture initialization for blocks until after we've left the
function scope.
This removes one of the last few cases where we build expressions in the
wrong fu
Author: rsmith
Date: Thu May 30 17:45:10 2019
New Revision: 362179
URL: http://llvm.org/viewvc/llvm-project?rev=362179&view=rev
Log:
Defer capture initialization for captured regions until after we've left
the captured region scope.
This removes a case where we would build expressions (and mark
d
Author: sbc
Date: Thu May 30 18:04:00 2019
New Revision: 362180
URL: http://llvm.org/viewvc/llvm-project?rev=362180&view=rev
Log:
Fix -DBUILD_SHARED_LIBS=ON build after rL362160
Differential Revision: https://reviews.llvm.org/D62709
Modified:
cfe/trunk/lib/CodeGen/CMakeLists.txt
Modified: c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362180: Fix -DBUILD_SHARED_LIBS=ON build after rL362160
(authored by sbc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62709?vs=202335&id=202343#toc
Repository:
rL LLVM
CHANGES
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich, juliehockett.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: EricWF.
Herald added a project: clang.
Since we share headers between host and target builds, we need to use
the same version for both
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62712/new/
https://reviews.llvm.org/D62712
___
cfe-commit
Author: phosek
Date: Thu May 30 18:16:43 2019
New Revision: 362181
URL: http://llvm.org/viewvc/llvm-project?rev=362181&view=rev
Log:
[CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
Since we share headers between host and target builds, we need to use
the same version for both.
Differential
Author: rsmith
Date: Thu May 30 18:17:04 2019
New Revision: 362182
URL: http://llvm.org/viewvc/llvm-project?rev=362182&view=rev
Log:
Defer building 'this' captures until we have left the capturing region
and returned to the context in which 'this' should be captured.
This means we now always mark
Hello,
this causes this diagnostic when building on Windows:
In file included from
../../ui/accessibility/platform/ax_platform_node_textchildprovider_win.cc:10:
../..\ui/accessibility/platform/ax_platform_node_textprovider_win.h(22,3):
error: 'nothrow' attribute conflicts with exception specifica
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
(authored by phosek, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great, thx!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62658/new/
https://reviews.llvm.org/D62658
___
cfe-commits m
Author: rjmccall
Date: Thu May 30 18:21:36 2019
New Revision: 362183
URL: http://llvm.org/viewvc/llvm-project?rev=362183&view=rev
Log:
Fix the predefined exponent limit macros for the 16-bit IEEE format.
The magnitude range of normalized _Float16 is 2^-14 (~6e-5) to
(2-2^-10)*2^15 (65504). You m
rjmccall closed this revision.
rjmccall added a comment.
r362183
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62708/new/
https://reviews.llvm.org/D62708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
Author: rsmith
Date: Thu May 30 18:25:16 2019
New Revision: 362184
URL: http://llvm.org/viewvc/llvm-project?rev=362184&view=rev
Log:
PR39728: When completing a class, complete the destructor first.
We need to know whether the destructor is trivial in order to tell
whether other parts of the class
xiangzhangllvm updated this revision to Diff 202350.
xiangzhangllvm added a comment.
rebase
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62367/new/
https://reviews.llvm.org/D62367
Files:
docs/ClangCommandLineReference.rst
include/clang/Basic/BuiltinsX86.def
xiangzhangllvm added a comment.
Hi Dear friends, could you help merge this patch? Thank you very much!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62367/new/
https://reviews.llvm.org/D62367
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362185: [CMake] Provide an option to use relative paths in
debug info (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62622?vs=202310&id=202351#toc
Repository:
Author: phosek
Date: Thu May 30 18:34:51 2019
New Revision: 362185
URL: http://llvm.org/viewvc/llvm-project?rev=362185&view=rev
Log:
[CMake] Provide an option to use relative paths in debug info
CMake always uses absolute file paths in the generated compiler
invocation which results in absolute f
pengfei reopened this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
Reverted by https://reviews.llvm.org/rL362186
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60748/new/
https://reviews.llvm.org/D60748
___
craig.topper added inline comments.
Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39
+
+/// This instruction writes an even/odd pair of mask registers. The mask
+/// register destination indicated in the MODRM.REG field is used to form
This doesn't really
Author: rtrieu
Date: Thu May 30 19:23:33 2019
New Revision: 362187
URL: http://llvm.org/viewvc/llvm-project?rev=362187&view=rev
Log:
Redirect test output to /dev/null
Modified:
cfe/trunk/test/Driver/armv8.1m.main.s
Modified: cfe/trunk/test/Driver/armv8.1m.main.s
URL:
http://llvm.org/viewvc/
rjmccall added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:8219
+ // to allow skipping it. However we are not visiting all qual
+ // currently and therefore there is no condition yet.
Diag(SL, diag::err_invalid_qualified_constructor)
---
wxiao3 added a comment.
Thanks for the information!
We have reverted the patch and will resubmit it when we have a complete fix.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60748/new/
https://reviews.llvm.org/D60748
__
xiangzhangllvm updated this revision to Diff 202359.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62367/new/
https://reviews.llvm.org/D62367
Files:
docs/ClangCommandLineReference.rst
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/
xiangzhangllvm marked 3 inline comments as done.
xiangzhangllvm added a comment.
Done, Thank you very much!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62367/new/
https://reviews.llvm.org/D62367
___
cfe-commits mai
NoQ created this revision.
NoQ added a reviewer: Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a project: clang.
Now they're valid JSON.
Repository:
rC Clang
https://reviews.llvm
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62367/new/
https://reviews.llvm.org/D62367
___
cf
jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for fixing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62121/new/
https://reviews.llvm.org/D62121
___
cfe-commits mailing li
nridge updated this revision to Diff 202369.
nridge added a comment.
Address latest review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59407/new/
https://reviews.llvm.org/D59407
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-t
nridge updated this revision to Diff 202370.
nridge marked 8 inline comments as done.
nridge added a comment.
Addressed most review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62459/new/
https://reviews.llvm.org/D62459
Files:
clang-to
nridge added inline comments.
Comment at: clang-tools-extra/clangd/index/Serialization.h:81
+// Used for serializing SymbolRole as used in Relation.
+enum class RelationKind : uint8_t { ChildOf = 1, BaseOf };
+llvm::Expected symbolRoleToRelationKind(index::SymbolRole);
--
nridge updated this revision to Diff 202371.
nridge marked 11 inline comments as done.
nridge added a comment.
Addressed most review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62471/new/
https://reviews.llvm.org/D62471
Files:
clang-t
nridge added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:298
+
+ processRelations(*ND, *ID, Relations);
+
kadircet wrote:
> why do we want to process these relations for references?
The `RelationBaseOf` is not present in the `
Author: pengfei
Date: Thu May 30 23:09:35 2019
New Revision: 362196
URL: http://llvm.org/viewvc/llvm-project?rev=362196&view=rev
Log:
[X86] Add VP2INTERSECT instructions
Support intel AVX512 VP2INTERSECT instructions in clang
Patch by Xiang Zhang (xiangzhangllvm)
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362196: [X86] Add VP2INTERSECT instructions (authored by
pengfei, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
Not sure why I was blind here, thanks you!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62716/new/
https://reviews.llvm.org/D62716
101 - 147 of 147 matches
Mail list logo