[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rC362034: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs (authored by ahatanak, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/n

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak added a comment. In D61974#1521334 , @theraven wrote: > LGTM. I wonder if we have any other ugly GCC bug compatibility parts in > clang's Objective-C implementation... I see a couple of FIXME comments in ASTContext.cpp that seem to suggest cla

[PATCH] D62167: CodeView - add static data members to global variable debug info.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/D62167 ___ cfe-

r362038 - CodeView - add static data members to global variable debug info.

Author: akhuang Date: Wed May 29 14:45:34 2019 New Revision: 362038 URL: http://llvm.org/viewvc/llvm-project?rev=362038&view=rev Log: CodeView - add static data members to global variable debug info. Summary: Add static data members to IR debug info's list of global variables so that they are emi

[PATCH] D62167: CodeView - add static data members to global variable debug info.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362038: CodeView - add static data members to global variable debug info. (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D62167?vs=202027&id=202063#toc Reposito

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake llvm/r

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:48 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES-NOT: warning: + TEMP_FAILURE_RETRY(pipe2(pipefd, O_NONBLOCK)); Much like line 39 (which covers both lines

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202072. jcai19 marked an inline comment as done. jcai19 added a comment. Remove redundant CHECK-MESSAGES-NOT checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 File

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Everything looks great. Thanks for adding these improvements. While it's probably safe to commit this, perhaps you should give it 24 hours in case some of the other clang-tidy folks have dif

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik added a comment. So an alternative to testing could be matching the AST output from a `clang-import-test` like we did here: https://reviews.llvm.org/D61140 although it unfortunately looks like only only the AST dump of `NamespaceDecl` output the `SourceLocation` you are fixing, see it o

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

aprantl added a comment. -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false impression. Is there a name that emphasizes that this affects the debug info of the built compiler? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D626

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > Can we just link with gtest_main instead of having this? Unfortunately not easily. `generate_compiler_rt_tests` builds each test

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202078. hctim marked 21 inline comments as done. hctim added a comment. - Apologies about the delay on this. Updated with Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, aprantl. Herald added projects: clang, LLVM. Keeps track of the enums that were used by saving them as DIGlobalVariables, since CodeView emits debug info for global constants. Repos

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik added a comment. I think the AST dump for `EnumDecl` and `ClassTemplateSpecializationDecl` should be dumping the missing `SourceLocations` but I am having trouble tracking down where that should be done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 added a comment. In D62049#1522203 , @srhines wrote: > Everything looks great. Thanks for adding these improvements. While it's > probably safe to commit this, perhaps you should give it 24 hours in case > some of the other clang-tidy folks have d

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. I totally agree about the space before the opening curly, but the space before the opening paren is a matter of style. Certainly it does match LLVM style better, but it does not match s

[PATCH] D62636: Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition flag.

pcc created this revision. pcc added a reviewer: rsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62636 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeGen/CodeGenModule.cpp clang/

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 202084. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov marked 2 inline comments as done. slavapestov added inline comments. Comment at: clang/include/clang/Basic/Attr.td:297 def CUDA : LangOpt<"CUDA">; -def COnly : LangOpt<"CPlusPlus", 1>; +def COnly : LangOpt<"COnly", "!LangOpts.CPlusPlus">; def CPlusPlus : LangOpt<"CP

r362045 - clang support gnu asm goto.

Author: jyu2 Date: Wed May 29 18:05:46 2019 New Revision: 362045 URL: http://llvm.org/viewvc/llvm-project?rev=362045&view=rev Log: clang support gnu asm goto. Syntax: asm [volatile] goto ( AssemblerTemplate : : InputOperands : Clo

[PATCH] D62638: [analyzer][WIP] A Python script to prettify the ExplodedGraph dumps.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, george.karpenkov. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. That's my attempt on

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

morehouse added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} hctim wrote: > morehouse wrote: > > Can we just link with gtest_main instead of having this? > Unfortunately not easily. `generate_compiler_rt_

[libunwind] r362048 - [runtimes] Support ELF dependent libraries feature

Author: phosek Date: Wed May 29 18:34:41 2019 New Revision: 362048 URL: http://llvm.org/viewvc/llvm-project?rev=362048&view=rev Log: [runtimes] Support ELF dependent libraries feature As of r360984, LLD supports dependent libraries feature for ELF. libunwind, libc++abi and libc++ have library dep

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. In D62623#1521999 , @kwk wrote: > @serge-sans-paille testing it now. Unfortunately, the error for me is similar (or the same) to before; [692/2860] Building CXX object lib/Target/AMDGPU/Utils/CMakeFiles/LLVMAMDGPUUtils.dir/AMDGPU

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1522247 , @aprantl wrote: > -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false > impression. Is there a name that emphasizes that this affects the debug info > of the built compiler? How about `L

[PATCH] D62638: [analyzer][WIP] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202091. NoQ added a comment. Abstract away raw prints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot clang/test/Analysis/exploded-graph-rewriter/

<    1   2   3