[PATCH] D62056: Use ASTDumper to dump the AST from clang-query

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62056/new/ https://reviews.llvm.org/D62056 __

[PATCH] D62056: Use ASTDumper to dump the AST from clang-query

aaron.ballman added a comment. If you wanted to expand test coverage for the changes covered in this, that would be a good thing. However, I'm not certain how testable the newly colorized output is, which is why this LG as-is. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION h

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea added a comment. In D60568#1508909 , @ABataev wrote: > Looks good, in general. Just one more question: will __tgt_register_requires > be emitted if only -fopenmp is used? If -fopenmp-targets is not provided, > this function should not be called,

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200355. gtbercea added a comment. - Avoid requires registration when no targets are specified. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: include/clang/Basic/LangOption

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

andrew.w.kaylor added inline comments. Comment at: include/llvm/IR/IRBuilder.h:234 + /// Set the exception handling to be used with constrained floating point + void setDefaultConstrainedExcept(MDNode *NewExcept) { +DefaultConstrainedExcept = NewExcept; I

[PATCH] D62160: [LibTooling] Update Stencil to use RangeSelector

ymandel created this revision. ymandel added a reviewer: sbenza. Herald added a project: clang. Replace Stencil's specialized operators `node` and `sNode` with general support for any RangeSelector. This change allows Stencil to support any RangeSelector and avoids redundancy between the two libr

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. I changed the approach in the last revision. the information is now propagated using the expression evaluation context and then via booleans. I should have added a comment to make it clear. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added a comment. Thank you MaskRay! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak added a comment. Yes, I think we can add something to the release note. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.org/D61974 ___ cfe-commits mailing list cfe-commits@lists

r361205 - [Sema] Fix for build on some iOS programs.

Author: leonardchan Date: Mon May 20 15:42:19 2019 New Revision: 361205 URL: http://llvm.org/viewvc/llvm-project?rev=361205&view=rev Log: [Sema] Fix for build on some iOS programs. Nullability attributes weren't being stripped for AttributedTypes that were wrapped in a MacroQualifiedType. This fi

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Thanks for bringing this up! I submitted r361205 which should fix this. The problem seemed to be that stripOuterNullability() was missing checks for AttributedTypes that were wrapped in the MacroQualifiedType which this patch introduces, so I just added a check for that type also. The reason replac

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

hintonda added a comment. Great idea. Please see D61747 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. If no further comments, I'll commit it for you tomorrow. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61747/new/ https://reviews.llvm

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman updated this revision to Diff 200371. arphaman marked 8 inline comments as done. arphaman added a comment. - Added diagnostic support. - Fixed the issue with C++14 number separators. - Other fixes requested by @Bigcheese . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett abandoned this revision. juliehockett added a comment. @hintonda Aha so it is :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman added inline comments. Comment at: include/clang/Lex/DependencyDirectivesSourceMinimizer.h:36 + pp_import, + pp_at_import, + pp_pragma_import, Bigcheese wrote: > Is `@import` actually a preprocessor directive? For C++20 modules all the > modules bits

[PATCH] D62009: [clang] perform semantic checking in constant context

rsmith added a comment. Interesting. I think all of the new warnings in the test cases here are undesirable (they duplicate errors produced by the constant evaluator), but the removed warnings all look like improvements. Generally, I think our goals should be: For code patterns that might lead

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

hintonda added a comment. In D62157#1509289 , @juliehockett wrote: > @hintonda Aha so it is :) I don't think it's at all controversial, so I'll commit D61747 tomorrow unless someone raises an issue. Thanks... CHANG

r361208 - Give 'fixit-cxx0x.cpp' a more modern name.

Author: rsmith Date: Mon May 20 16:37:18 2019 New Revision: 361208 URL: http://llvm.org/viewvc/llvm-project?rev=361208&view=rev Log: Give 'fixit-cxx0x.cpp' a more modern name. Added: cfe/trunk/test/FixIt/fixit-c++11.cpp - copied, changed from r361193, cfe/trunk/test/FixIt/fixit-cxx0x.cp

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman updated this revision to Diff 200376. arphaman added a comment. Remove some outdated commented out code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Driv

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, aprantl. Herald added projects: clang, LLVM. Add static data members to IR debug info's list of global variables so that they are emitted as S_CONSTANT records. Related to https://bu

r361209 - Try to fix build with older gccs after r361152

Author: nico Date: Mon May 20 17:27:26 2019 New Revision: 361209 URL: http://llvm.org/viewvc/llvm-project?rev=361209&view=rev Log: Try to fix build with older gccs after r361152 Also merge the cmake change there to the gn build. Modified: cfe/trunk/unittests/Tooling/RangeSelectorTest.cpp Mo

Re: r361152 - [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

+ LLVMSupport + LLVMTestingSupport clang/unittests/Tooling/CMakeLists already has this at the top: set(LLVM_LINK_COMPONENTS ${LLVM_TARGETS_TO_BUILD} Support ) I think we link Support twice now. Did adding TestingSupport up there not work? I'd expect that your addition would break shared l

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 200380. trixirt added a comment. Change the GuardStyle data type from a string to an enum. Add test cases for explicitly setting valid style. Document valid style values. Reduce llvm-header-guard doc to point to bugprone-header-guard. Repository: rCTE Clan

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. Latest change addresses most of issues. Outstanding is adding a test when garbage GuardStyle value is fed into config. The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases. Looking for something similar in the ot

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan marked 2 inline comments as done. skan added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); lebedev.ri wrote: > xiangzhangll

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

craig.topper added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); skan wrote: > lebedev.ri wrote: > > xiangzhangllvm wrote: > > >

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan marked an inline comment as done. skan added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); craig.topper wrote: > skan wrote

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory) http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/21622/steps/check-cfi-and-supported%20in%20gcc%20build/logs/stdio 100%] Running the cfi regression tests

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. In D62050#1509384 , @vitalybuka wrote: > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in > empty directory) I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right appro

Re: r361152 - [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Nice, thanks for r361208. As for support -- no, I didn't try that. I was following a pattern I saw elsewhere. Do you suggest that I make that change? If so, any particular way to test it? thanks On Mon, May 20, 2019 at 8:26 PM Nico Weber wrote: > + LLVMSupport > + LLVMTestingSupport > > cla

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv updated this revision to Diff 200388. george.burgess.iv added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/ https://reviews.llvm.org/D38479 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/inc

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added a comment. In D62050#1509400 , @vitalybuka wrote: > In D62050#1509384 , @vitalybuka > wrote: > > > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake > > in empty directory)

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 36 inline comments as done. jkorous added a comment. I addressed most of the comments. What is left: - rewrite test with gmock matchers - write test for metadata of a file in watched dir being changed Comment at: clang/include/clang/DirectoryWatcher/DirectoryWa

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 200389. jkorous marked 4 inline comments as done. jkorous added a comment. Addressed comments. Changed semantics of one of std::atomic in linux implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200393. plotfi added a comment. adding a nice inline test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200399. yaqiji marked 2 inline comments as done. yaqiji added a comment. Herald added a subscriber: mgorny. Modified CMakeList to include tests, otherwise clangTidyGoogleModule wouldn't compile. Added k_Alpha test case back. Added Extern case so that if it i

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200401. yaqiji added a comment. Simplified method signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. Should you also consider Windows path separators here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek created this revision. phosek added reviewers: hintonda, vitalybuka, Szelethus. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. These are needed to avoid undefined symbols which aren't satisfied by Clang itself. Repository: rC Clang http

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek added a comment. This is an alternative to D62154 . With just the change to `HandleLLVMOptions.cmake`, we're seeing errors in Analysis plugins due to undefined symbols: error: 'error' diagnostics seen but not expected: (frontend): unable to load plu

<    1   2