[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

NoQ updated this revision to Diff 199534. NoQ marked an inline comment as done. NoQ added a comment. > What about "the most derived class" Sounds great! > It would be cool to say "by A" or something more simple and precise. We can't do that in all cases (we don't necessarily see the constructor

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

jfb added a comment. In D60593#1498622 , @hctim wrote: > In D60593#1495428 , @gribozavr wrote: > > > What does GWP stand for? > > > Google Wide Profiling >

[PATCH] D61925: [analyzer] MIGChecker: Add support for os_ref_retain().

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Suppress MIG checker false positives that occur when the pr

[PATCH] D61925: [analyzer] MIGChecker: Add support for os_ref_retain().

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:118-119 +static const ParmVarDecl *getOriginParam(SVal V, CheckerContext &C, + bool IncludeBaseRegions = false) {

[PATCH] D61925: [analyzer] MIGChecker: Add support for os_ref_retain().

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61925/new/ https://reviews.llvm.org/D61925 ___

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

eugenis added a comment. Ha, I think it matches LLVM perfectly :) G, of course, stands for "Galaxy". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60593/new/ https://reviews.llvm.org/D60593 ___ cfe-com

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 199541. hctim marked 10 inline comments as done. hctim added a comment. Herald added subscribers: cfe-commits, srhines. Herald added a reviewer: jfb. Herald added a project: clang. - Working copy of mutex. - >>! In D61923#1502245

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. In D61923#1502245 , @jfb wrote: > Seems a shame to duplicate mutex again... Why can't use use the STL's version > again? It doesn't allocate. We can't use `std::mutex` as we must be C-compatible (and can't make the strong guarant

r360737 - [analyzer] MIGChecker: Add support for os_ref_retain().

Author: dergachev Date: Tue May 14 18:19:19 2019 New Revision: 360737 URL: http://llvm.org/viewvc/llvm-project?rev=360737&view=rev Log: [analyzer] MIGChecker: Add support for os_ref_retain(). Suppress MIG checker false positives that occur when the programmer increments the reference count before

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

eugenis added a comment. I think the idea is that implementing our own spinlock is not much harder than having 3 platform-specific implementations (posix, window, fuchsia). Also, scudo_standalone is doing the same ( @cryptoad, why? ). As Mitch mentioned, we should move the implementation into a

[PATCH] D61925: [analyzer] MIGChecker: Add support for os_ref_retain().

This revision was automatically updated to reflect the committed changes. Closed by commit rC360737: [analyzer] MIGChecker: Add support for os_ref_retain(). (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61925?vs=199537&id=199543#toc Repository: rC

Re: r360403 - Change -gz and -Wa, --compress-debug-sections to use gABI compression (SHF_COMPRESSED)

It's fine :) The problem may be that users with older pre-2.26 binutils may have older GNU as as well. Their GNU as may not recognize --compress-debug-sections=zlib. On Wed, May 15, 2019 at 3:39 AM Eric Christopher wrote: > Hi Ray, > > I've temporarily reverted this here: > > echristo@jhereg ~/s

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim added a comment. In D60593#1502266 , @jfb wrote: > Hello I'm here to bikeshed, and this is a terrible name for an LLVM project. > Or super appropriate because LLVM itself is a terrible name? In any case, > backronym it to something else, or rename

r360739 - [analyzer] MIGChecker: Fix redundant semicolon.

Author: dergachev Date: Tue May 14 18:36:41 2019 New Revision: 360739 URL: http://llvm.org/viewvc/llvm-project?rev=360739&view=rev Log: [analyzer] MIGChecker: Fix redundant semicolon. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MIGChecker.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Checke

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. http://lists.llvm.org/pipermail/cfe-dev/2019-May/062298.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

jfb added a comment. In D61923#1502323 , @hctim wrote: > In D61923#1502245 , @jfb wrote: > > > Seems a shame to duplicate mutex again... Why can't use use the STL's > > version again? It doesn't allocate. > > > We

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge updated this revision to Diff 199551. nridge marked 9 inline comments as done. nridge added a comment. Address review comments, except for the derived class one, about which I have a question Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D609

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:243 +// future). +class ClangdDiagnosticConsumer : public StoreDiags { +public: sammccall wrote: > Thanks, this is much cleaner. > > I think we don't need the subclass at all thoug

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge updated this revision to Diff 199552. nridge marked 2 inline comments as done. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61841/new/ https://reviews.llvm.org/D61841 Files: clang-tools-extr

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:346 + std::string CheckName = CTContext->getCheckName(Info.getID()); + if (!CheckName.empty() && WarningAsErrorFilter->contains(CheckName)) { +Level = DiagnosticsEngine::Error; ---

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. I did some quick testing. I used cmake and ninja to build `llvm` and enabled `clang;lld;compiler-rt` subprojects: $ cd build-beanz-clang-shlib-2-add-debug-BUILD-LINK_DYNLIB-ON $ cmake ../llvm -G Ninja '-DLLVM_ENABLE_PROJECTS=clang;lld;compiler-rt' -DCMAKE_INSTA

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. Questions: - Should we only build `libclang_shared.so` if `LLVM_BUILD_LLVM_DYLIB` is ON? - Should we use link clang-9 to libclang_shared.so when `LLVM_LINK_LLVM_DYLIB` is ON? - Or maybe we should define `BUILD_CLANG_DYLIB` and `LINK_CLANG_DYLIB` or ... ? Repository

[PATCH] D61909: Add Clang shared library with C++ exports

winksaville added a comment. I did some quick testing. I used cmake and ninja to build `llvm` and enabled `clang;lld;compiler-rt` subprojects: $ cd build-beanz-clang-shlib-2-add-debug-BUILD-LINK_DYNLIB-ON $ cmake ../llvm -G Ninja '-DLLVM_ENABLE_PROJECTS=clang;lld;compiler-rt' -DCMAKE_INSTA

[PATCH] D61909: Add Clang shared library with C++ exports

winksaville added a comment. Questions: - Should we only build `libclang_shared.so` if `LLVM_BUILD_LLVM_DYLIB` is ON? - Should we use link clang-9 to libclang_shared.so when `LLVM_LINK_LLVM_DYLIB` is ON? - Or maybe we should define `BUILD_CLANG_DYLIB` and `LINK_CLANG_DYLIB` or ... ? Repository

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. Sorry, the two previous comments were meant for D61909 and I've moved them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61804/new/ https://reviews.llvm.org/D61804

[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

MaskRay created this revision. MaskRay added reviewers: danalbert, pirama, rprichard, srhines. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. See D61825 for the temporary lld option --android-tls. Repository:

<    1   2