[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman added a comment. In D60910#1495673 , @rsmith wrote: > If you're happy with these two conditions, then I have no concerns with this > moving forward: > > - There is no implied stability for the content or format of the dump between > major r

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61742/new/ https://reviews.llvm.org/D61742 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

torbjoernk updated this revision to Diff 199326. torbjoernk edited the summary of this revision. torbjoernk added a comment. Herald added subscribers: jdoerfert, jfb. Fixed the issues pointed out by Don Hinton and added note on OpenMP to the check's docs as suggested by Roman Lebedev. Also fixed

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

lebedev.ri added a comment. Sounds good, thank you! Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-loop-convert.rst:262 +not been used on code with a compatibility requirements of OpenMP prior to +version 5. I would add a cross-reference to `NO

[PATCH] D61839: [analyzer][WIP] Hide developer-only checker/package options by default

NoQ added a comment. In D57858#1499414 , @Szelethus wrote: > Checker options are a different kind of animal entirely. I think we should > definitely let the user fine-tune some modeling checkers, for instance, > `unix.DynamicMemoryModeling:Optimistic`, d

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I can't say "no" to more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits maili

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. In D61804#1500445 , @winksaville wrote: > In D61804#1500409 , @beanz wrote: > > > My change should not have decreased build time from trunk, nor should it > > have reduced the number of

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

NoQ accepted this revision. NoQ added a comment. I don't see any problems with adding more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:314 insertOptionToCollection(StringRef FullName, T &Collection, - const CheckerRegistry::CmdLineOption &&Option) { + const CheckerRegistry::CmdL

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D61765#1500457 , @gtbercea wrote: > This won't affect CUDA in any way, all we have added is OpenMP specific. LGTM for CUDA. I'll leave the question of te

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

jdoerfert added a comment. In D61765#1500351 , @gtbercea wrote: > - Exclude clock functions. Reverse inclusion order. LGTM from my side. I don't have strong feelings about testing libc++ now, though it is probably a good idea to have such a testbed. I a

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre marked 17 inline comments as done. mgehre added inline comments. Comment at: clang-tools-extra/test/clang-tidy/readability-static-const-method.cpp:312 +return const_cast(this)->get(); + } + JonasToth wrote: > mgehre wrote: > > JonasToth wrote: > > >

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre updated this revision to Diff 199329. mgehre marked an inline comment as done. mgehre added a comment. Remove ``const`` part from this PR. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D6

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Awesome, thanks... LGTM, but you may want to give @alexfh or @aaron.ballman a day to comment before you commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61827/new/ https://

r360622 - Introduce the ability to dump the AST to JSON.

Author: aaronballman Date: Mon May 13 14:39:55 2019 New Revision: 360622 URL: http://llvm.org/viewvc/llvm-project?rev=360622&view=rev Log: Introduce the ability to dump the AST to JSON. This adds the -ast-dump=json cc1 flag (in addition to -ast-dump=default, which is the default if no dump forma

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

mgehre updated this revision to Diff 199330. mgehre added a comment. Fix wrong merge of ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24892/new/ https://reviews.llvm.org/D24892 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/P

[PATCH] D61874: [clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance (bug 40544)

mgehre created this revision. mgehre added reviewers: aaron.ballman, alexfh, xazax.hun. mgehre added projects: clang, clang-tools-extra. Herald added a subscriber: rnkovacs. Fixed https://bugs.llvm.org/show_bug.cgi?id=40544 Before, we would generate a fixit like `(anonymous namespace)::Foo::fun();

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r360622. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60910/new/ https://reviews.llvm.org/D60910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. In D57858#146 , @dkrupp wrote: > Some alpha checkers are considerably more mature than others and are quite > usable. In our experience, there are some users who are keen to run these > checkers on their code and report back any

[PATCH] D61370: Add a C2x mode and allow attributes in it

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Frontend/CompilerInvocation.cpp:2593-2596 + // Enable [[]] attributes in C++11 and C2x by default. + Opts.DoubleSquareBracketAttributes = Args.hasFlag(

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai added a comment. Thanks for the review, Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61619/new/ https://reviews.llvm.org/D61619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D61136: [Analyzer] Refactor begin and end symbol creation

NoQ accepted this revision. NoQ added a comment. Thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61136/new/ https://reviews.llvm.org/D61136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

r360625 - Make language option `GNUAsm` discoverable with `__has_extension` macro.

Author: vsapsai Date: Mon May 13 15:11:10 2019 New Revision: 360625 URL: http://llvm.org/viewvc/llvm-project?rev=360625&view=rev Log: Make language option `GNUAsm` discoverable with `__has_extension` macro. This can be used for better support of `-fno-gnu-inline-asm` builds. rdar://problem/49540

r360626 - [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

Author: gbercea Date: Mon May 13 15:11:44 2019 New Revision: 360626 URL: http://llvm.org/viewvc/llvm-project?rev=360626&view=rev Log: [OpenMP][Clang][BugFix] Split declares and math functions inclusion. Summary: This patches fixes an issue in which the __clang_cuda_cmath.h header is being includ

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

stephanemoore accepted this revision. stephanemoore added a comment. I believe that all the feedback from @gribozavr has been addressed modulo one small nit. Once that nit has been addressed, I can land this. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewChec

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 199338. mwyman added a comment. Update for comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp clang-tools-extra/clang-tidy/google

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360625: Make language option `GNUAsm` discoverable with `__has_extension` macro. (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D6

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360626: [OpenMP][Clang][BugFix] Split declares and math functions inclusion. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61765?vs=199304&id=199340#toc Repos

r360628 - Removing an unused member variable; NFC.

Author: aaronballman Date: Mon May 13 15:29:16 2019 New Revision: 360628 URL: http://llvm.org/viewvc/llvm-project?rev=360628&view=rev Log: Removing an unused member variable; NFC. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h UR

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

stephanemoore requested changes to this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp:112 + Result.No

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. In D57858#1500635 , @NoQ wrote: > In D57858#146 , @dkrupp wrote: > > > Some alpha checkers are considerably more mature than others and are quite > > usable. In our experience, there

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai added a comment. In D61621#1497027 , @rnk wrote: > lgtm, thanks! > > In D61621#1496978 , @vsapsai wrote: > > > Didn't use `-fms-compatibility` in the test and it seems to be working fine. > > Don't know if

r360630 - [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

Author: vsapsai Date: Mon May 13 15:40:11 2019 New Revision: 360630 URL: http://llvm.org/viewvc/llvm-project?rev=360630&view=rev Log: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. Currently `immintrin.h` includes `pconfigintrin.h` and `sgxintrin.h` which contain i

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 199341. mwyman added a comment. Added +new declaration for ProxyFoo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp clang-tools-extra/

r360634 - [AMDGPU] gfx1010 clang target

Author: rampitec Date: Mon May 13 16:15:59 2019 New Revision: 360634 URL: http://llvm.org/viewvc/llvm-project?rev=360634&view=rev Log: [AMDGPU] gfx1010 clang target Differential Revision: https://reviews.llvm.org/D61875 Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/trunk/inc

r360635 - [c++20] P1064R0: Allow virtual function calls in constant expression

Author: rsmith Date: Mon May 13 16:35:21 2019 New Revision: 360635 URL: http://llvm.org/viewvc/llvm-project?rev=360635&view=rev Log: [c++20] P1064R0: Allow virtual function calls in constant expression evaluation. This reinstates r360559, reverted in r360580, with a fix to avoid crashing if evalu

[PATCH] D61845: [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits

efriedma added a comment. Adding "Z" makes sense. If you're going to mess with the 64-bit builtins, it's probably worth adding a testcase that can be built with gcc to show that int64_t is actually correct. You should be able to write a C++ testcase using decltype (declare a variable of type

[PATCH] D61845: [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits

efriedma added inline comments. Comment at: test/CodeGen/avr-builtins.c:1 +// REQUIRES: avr-registered-target +// RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s I don't think this needs avr-registered-target; it doesn't actually in

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. @beanz I found what I think is the reason libclang_shared.so isn't being created. I added a bunch of debug output using `message` to add_llvm_subdirectory: 1041 function(add_llvm_subdirectory project type name) 1042message(STATUS "add_llvm_subdirectory ${pr

r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

Author: rsmith Date: Mon May 13 17:27:16 2019 New Revision: 360637 URL: http://llvm.org/viewvc/llvm-project?rev=360637&view=rev Log: PR41817: Fix regression in r359260 that caused the MS compatibility extension allowing a "static" declaration to follow an "extern" declaration to stop working. Add

[PATCH] D61875: [AMDGPU] gfx1010 clang target

This revision was automatically updated to reflect the committed changes. Closed by commit rC360634: [AMDGPU] gfx1010 clang target (authored by rampitec, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION http

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

NoQ added a comment. > Note that a similar functionality is necessary for destructors of virtual > bases, but it remains to be done for now. We should be able to re-use the > same terminator kind. It's not really that important because virtual base destructors don't have sub-expressions that m

[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

NoQ updated this revision to Diff 199351. NoQ added a comment. Improve note text so that to avoid the singular/plural problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61817/new/ https://reviews.llvm.org/D61817 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReport

Below are some buildbot numbers for the week of 04/28/2019 - 05/04/2019

Hello everyone, Below are some buildbot numbers for the week of 04/28/2019 - 05/04/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 05/05/2019 - 05/11/2019

Hello everyone, Below are some buildbot numbers for the last week of 05/05/2019 - 05/11/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot cleaning for github migration

Hello everyone, As all of you know, we migrate to github monorepo. I'm working on preparing the build bot for this transition. We would do our best to make the transition as smooth and transparent to the majority of LLVM community, as possible. As the next step, I'll be cleaning zorg. I'm goin

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith, steven_wu, modocache, hiraditya, eraman, mgorny, mehdi_amini. Herald added projects: clang, LLVM. vitalybuka planned changes to this revision. I don't want to invest into improving this patch.

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 199358. trixirt added a comment. llvm-header-guard is an alias to bugprone-header-guard. The style is passed through the option 'GuardStyle' A regression test was added for llvm-header-guard. llvm unit tests were modified to the new class and option interface

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 updated this revision to Diff 199360. wxiao3 edited the summary of this revision. Herald added a subscriber: krytarowski. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-align-linux.

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 added a comment. Yes, the ABI bug will cause SEGV in Linux where a lot of libraries are built by GCC. I have restricted the fix to Linux only in the latest revision. Any other comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748

[PATCH] D61804: Support building shared and static libraries simultaneously

tstellar added a comment. > ! In D61804#149 , @beanz wrote: > I apologize that I missed your thread on the dev list, because that would > have been a much better place to have this conversation. Having gone back and > read it now, it sounds to me lik

[PATCH] D61804: Support building shared and static libraries simultaneously

MaskRay added a comment. @winksaville I asked why on Arch Linux, extra/clang is built with `-DBUILD_SHARED_LIBS=ON` while extra/llvm extra/lldb are built with `-DBUILD_SHARED_LIBS=ON` https://bugs.archlinux.org/task/60512 . I think `extra/clang` is just not suitable for development. If you real

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

madsravn accepted this revision. madsravn added a comment. This revision is now accepted and ready to land. Looks good to me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61861/new/ https://reviews.llvm.org/D61861

<    1   2