[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

TomTan updated this revision to Diff 197208. TomTan added a comment. Herald added a subscriber: jholewinski. Added test cases and also merged this alignment adjustment to `getMinGlobalAlign` in `MicrosoftARM64TargetInfo`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus updated this revision to Diff 197210. Szelethus added a comment. Uploaded the correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 Files: test/Analysis/checker-plugins.c test/Analysis/plugins/CMakeLists.txt test/Analysis

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

Szelethus added a comment. I think you can commit this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59279/new/ https://reviews.llvm.org/D59279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk updated this revision to Diff 197211. rnk added a comment. - update test to check IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55229/new/ https://reviews.llvm.org/D55229 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGenCXX/

r359513 - Re-land r359250, [COFF] Statically link certain runtime library functions

Author: rnk Date: Mon Apr 29 16:05:47 2019 New Revision: 359513 URL: http://llvm.org/viewvc/llvm-project?rev=359513&view=rev Log: Re-land r359250, [COFF] Statically link certain runtime library functions Reverts the revert of r359251, this time with fixed tests. Differential Revision: https://re

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483240 , @plotfi wrote: > Me and @compnerd had discussed a more abstracted format like this but decided > it was best to just use the same names that are in the ELF already. > Is there any compelling reason not to

[PATCH] D55229: [COFF] Statically link certain runtime library functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC359513: Re-land r359250, [COFF] Statically link certain runtime library functions (authored by rnk, committed by ). Chang

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

rsmith added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/include/clang/AST/Type.h:4174 +/// Sugar type that represents a type that was defined in a macro. +class MacroQualifiedType : public Type { This comment is out of date. "[...]

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. > I think the !tbd-elf-v1 versioning can help with any changes or alterations > we want to make along the way too. I think this is good. I kind of glanced over it and mentioned a Version field. Version is handled explicitly by a VersionTuple in llvm-elfabi. I think

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added inline comments. Comment at: clang/include/clang/Driver/Types.def:91 TYPE("ast", AST, INVALID, "ast", "u") +TYPE("ifso", IFSO, INVALID, "ifso", "u") TYPE("pcm",

[PATCH] D59520: [WebAssembly] Address review comments on r352930

sunfish updated this revision to Diff 197215. sunfish added a comment. Implemented proper diagnostics for import_name/import_module on functions with definitions, and updated the test. I'm unsure of the `DIAG_SIZE_SEMA` change, but without it, the build fails with this error: /llvm/tools/cla

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 updated this revision to Diff 197216. xbolva00 added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 Files: include/clang/Basic/DiagnosticGroups.td test/Sema/compare.c test/Sema/tautological-constant-compare.c

r359516 - [Diagnostics] Support -Wtype-limits for GCC compatibility

Author: xbolva00 Date: Mon Apr 29 16:24:00 2019 New Revision: 359516 URL: http://llvm.org/viewvc/llvm-project?rev=359516&view=rev Log: [Diagnostics] Support -Wtype-limits for GCC compatibility Summary: GCC's -Wtype-limits (part of -Wextra): Warn if a comparison is always true or always false due

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rC359516: [Diagnostics] Support -Wtype-limits for GCC compatibility (authored by xbolva00, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://r

[PATCH] D59843: [PowerPC] Add support for __dcbf builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rC359517: Add __builtin_dcbf support for PPC (authored by saghir, committed by ). Herald added subscribers: cfe-commits, kristina. Herald added a project: clang. Changed prior to commit: https://reviews.l

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:667 if (Name == "avx512bw" && !Enabled) Features["avx512vbmi"] = Features["avx512vbmi2"] = Features["avx512bitalg"] = false; craig.topper wrote: > Need to also disable av

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. When I see `->*` I go mad, but we should handle unknown stuff, cool patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61285/new/ https://reviews.llvm.or

r359523 - [NFC] typo

Author: jfb Date: Mon Apr 29 17:11:53 2019 New Revision: 359523 URL: http://llvm.org/viewvc/llvm-project?rev=359523&view=rev Log: [NFC] typo Modified: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/include/clang/AST/ASTContext.h URL: http:/

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483209 , @jakehehrlich wrote: > I think I know the format that I'd like *roughly*. I haven't worked out how > to handle COMDAT and section groups yet. Roland seems to think that COMDAT > and section groups will be an

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

riccibruno updated this revision to Diff 197225. riccibruno retitled this revision from "[Sema] Fix the lookup for a declaration conflicting with an enumerator (bogus use of LookupResult::getAsSingle)" to "[Sema] Fix the lookup for a declaration conflicting with an enumerator". riccibruno edited

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 created this revision. xbolva00 added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61288 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticIDs.h

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 updated this revision to Diff 197229. xbolva00 added a comment. Removed redundant line in DiagnosticGroups CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61288/new/ https://reviews.llvm.org/D61288 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/Diagnostic

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

riccibruno marked 3 inline comments as done. riccibruno added inline comments. Comment at: test/CXX/dcl.dcl/dcl.enum/p11-enumerator_scope.cpp:107 enum { typedef_type };// expected-error {{redefinition of 'typedef_type'}} }; riccibruno wrote

r359524 - [NFC] typo

Author: jfb Date: Mon Apr 29 17:19:43 2019 New Revision: 359524 URL: http://llvm.org/viewvc/llvm-project?rev=359524&view=rev Log: [NFC] typo Modified: cfe/trunk/lib/Sema/Sema.cpp Modified: cfe/trunk/lib/Sema/Sema.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.cpp?rev=3

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483265 , @jakehehrlich wrote: > In D60974#1483240 , @plotfi wrote: > > > Me and @compnerd had discussed a more abstracted format like this but > > decided it was best to just use

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

riccibruno added a comment. Is it intentional to warn even if all the cases are covered ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61288/new/ https://reviews.llvm.org/D61288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith marked 2 inline comments as done. rsmith added a comment. Thanks, this is looking really good. (Lots of comments but they're mostly mechanical at this point.) Comment at: clang/include/clang/AST/DeclBase.h:1539-1541 +uint64_t NumCtorInitializers : 64 - NumDeclContex

[PATCH] D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997)

riccibruno added a comment. @rsmith Do you have an opinion on whether this ADL rule should be implemented ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60665/new/ https://reviews.llvm.org/D60665 ___ cfe-commits mai

[PATCH] D61142: Set LoopInterleaved in the PassManagerBuilder.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, maybe add a comment here to archive some of the reasoning? (IE, that when unrolling is disabled we disable both literal unrolling but also interleaving for historical reasons) Re

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 added a comment. GCC warns even for for that case, so this patch implements GCC's behaviour for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61288/new/ https://reviews.llvm.org/D61288 ___ cfe-commits mailing list cfe-commits

[PATCH] D61264: Fix inconsistency in calculating DIAG_START values

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Thanks for thefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61264/new/ https://reviews.llvm.org/D61264 _

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar updated this revision to Diff 197233. tstellar added a comment. - Fix install directory - Use a separate install targets for each sub-directory like it was done before r355253. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ http

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483380 , @plotfi wrote: > Also, curious on the lack of denoting the sections and which symbols go in > which sections? Do you just assume that "Type: Object" goes into .data? You don't need that information and t

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483399 , @plotfi wrote: > In D60974#1483265 , @jakehehrlich > wrote: > > > In D60974#1483240 , @plotfi wrote: > > > > > Me and @comp

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. With respect to group handeling. I think we should just check that the details of every symbol across all unmerged files that are being merged are consistent and then ignore duplicates. For symbols that are not defined in sections that are a part of a comdat group

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added a comment. OK, this should work while clang_generate_header() is used for plain files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220 ___ cfe-co

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

xazax.hun accepted this revision. xazax.hun added a comment. LG! These mistakes are so easy to make. Maybe we should add nullability annotations (or use optionals) in the future? (Or just make every non-null pointer a reference and make it a convention to always check for nulls?) Repository:

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek updated this revision to Diff 197241. phosek retitled this revision from "[runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/" to "[runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++". phosek edited the summary of this revision. phosek

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1159 + getToolChain().getTriple().isNVPTX()) +getToolChain().AddMathDeviceFunctions(Args, CmdArgs); + Here is another "NVPTX" specialization that I don't think we need. At least

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar updated this revision to Diff 197244. tstellar marked an inline comment as done. tstellar added a comment. Make sure to install the generated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

jdoerfert added subscribers: xtian, gregrodgers, ddibyend. jdoerfert added a comment. Herald added a subscriber: ormris. Could you sketch for me how this will (potentially) work if we have multiple target vendors? The fatbin solution seems tailored to NVIDIA, but maybe I'm wrong here. In any ca

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ updated this revision to Diff 197248. NoQ added a comment. Crystallize the `isHuge()` function and document more stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 Files: clang/include/clang/Analysis/CFG.h clang/include/clang/StaticA

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

NoQ added a comment. The whole AST consists in passing raw unannotated pointers around and i suspect it'll be annoying to deal with `Stmt &`s and `Decl &`s specifically in the Analyzer when all AST APIs accept pointers. I guess we'll have to go with some sort of nullability annotations, yeah. B

r359530 - [analyzer] SmartPtrModeling: Fix a null dereference.

Author: dergachev Date: Mon Apr 29 20:00:57 2019 New Revision: 359530 URL: http://llvm.org/viewvc/llvm-project?rev=359530&view=rev Log: [analyzer] SmartPtrModeling: Fix a null dereference. Don't crash when trying to model a call in which the callee is unknown in compile time, eg. a pointer-to-mem

r359531 - [analyzer] Treat functions without run-time branches as "small".

Author: dergachev Date: Mon Apr 29 20:01:02 2019 New Revision: 359531 URL: http://llvm.org/viewvc/llvm-project?rev=359531&view=rev Log: [analyzer] Treat functions without run-time branches as "small". Currently we always inline functions that have no branches, i.e. have exactly three CFG blocks:

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359530: [analyzer] SmartPtrModeling: Fix a null dereference. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61285?vs=197222&id=197251#toc Repository: rC Cl

[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

ymandel updated this revision to Diff 197250. ymandel added a comment. Herald added a subscriber: jfb. Add test for new behavior. In the process, tweak the handling of errors from TextGenerators in Transformer: instead of printing to `llvm::errs`, we set the error in the AtomicChange. Repositor

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

This revision was automatically updated to reflect the committed changes. Closed by commit rC359531: [analyzer] Treat functions without run-time branches as "small". (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61051?vs=197248&id=197253#toc Reposit

[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

ymandel updated this revision to Diff 197255. ymandel added a comment. Updates comments on Transformer to make explicit the error reporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61015/new/ https://reviews.llvm.org/D61015 Files: clang/in

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

hfinkel added a comment. In D60907#1479370 , @gtbercea wrote: > In D60907#1479142 , @hfinkel wrote: > > > In D60907#1479118 , @gtbercea > > wrote: > > > > > Ping @hfinkel @t

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483480 , @jakehehrlich wrote: > In D60974#1483399 , @plotfi wrote: > > > In D60974#1483265 , @jakehehrlich > > wrote: > > > > > In D60974

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

jdoerfert added a comment. In D47849#1435770 , @hfinkel wrote: > We need to make progress on this, and I'd like to suggest a path forward... > > First, we have a fundamental problem here: Using host headers to declare > functions for the device execution

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added a comment. In D60907#1483615 , @hfinkel wrote: > In D60907#1479370 , @gtbercea wrote: > > > In D60907#1479142 , @hfinkel wrote: > > > > > In D60907#1479118

r359517 - Add __builtin_dcbf support for PPC

Author: saghir Date: Mon Apr 29 16:25:33 2019 New Revision: 359517 URL: http://llvm.org/viewvc/llvm-project?rev=359517&view=rev Log: Add __builtin_dcbf support for PPC Summary: This patch adds support for __builtin_dcbf for PPC. __builtin_dcbf copies the contents of a modified block from the dat

<    1   2