[PATCH] D60872: Add new warning knob for unknown attribute namespaces

2019-04-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems pretty good to me - if you'd like to wait for more/other feedback from @rsmith or the like, that's OK too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60872/new/ https://

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

2019-04-18 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 195793. gtbercea added a comment. - Lower case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/O

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

2019-04-18 Thread Matthew Voss via Phabricator via cfe-commits
ormris added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } Quick nit: This test won't work on Windows as it only tests for POSIX-s

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

2019-04-18 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch avoids the emission of maps for target link variables when unified memory is present. Repository: rC Clang https:/

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

2019-04-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 ___ cfe-commits ma

r358705 - [LibTooling] Fix build breakage from commit 7b7ce6683ee.

2019-04-18 Thread Yitzhak Mandelbaum via cfe-commits
Author: ymandel Date: Thu Apr 18 12:19:01 2019 New Revision: 358705 URL: http://llvm.org/viewvc/llvm-project?rev=358705&view=rev Log: [LibTooling] Fix build breakage from commit 7b7ce6683ee. On configurations with -Werror,-Wmissing-field-initializers, the commit does not compile. This commit fix

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D59168#1470578 , @phosek wrote: > In D59168#1469186 , @jdenny wrote: > > > > > > I was also thinking about alternative names for the library path, > specifically for headers we use `inclu

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

2019-04-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: test/OpenMP/openmp_offload_registration.cpp:40 +// CHECK: ret void +// CHECK: declare void @__tgt_register_requires(i64) + ABataev wrote: > Why do you need this check? Again, this check is not required

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

2019-04-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956 +// If using unified memory, no need to do the mappings. +if (CGF.CGM.getOpenMPRuntime().hasUnifiedAddressingSupport()) + return; Hmm, what about regular declare target d

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

2019-04-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC358709: [OpenMP] Add checks for requires and target directives. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D60875?vs=195793&id=195803#toc Repository: rC C

r358709 - [OpenMP] Add checks for requires and target directives.

2019-04-18 Thread Gheorghe-Teodor Bercea via cfe-commits
Author: gbercea Date: Thu Apr 18 12:53:43 2019 New Revision: 358709 URL: http://llvm.org/viewvc/llvm-project?rev=358709&view=rev Log: [OpenMP] Add checks for requires and target directives. Summary: The requires directive containing target related clauses must appear before any target region in

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

2019-04-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } ormris wrote: > Quick nit: This test won't work on Windows as it onl

r358710 - [clang-format] Fix incorrect formatting of keyword macro definition

2019-04-18 Thread Owen Pan via cfe-commits
Author: owenpan Date: Thu Apr 18 13:17:08 2019 New Revision: 358710 URL: http://llvm.org/viewvc/llvm-project?rev=358710&view=rev Log: [clang-format] Fix incorrect formatting of keyword macro definition See PR39719 Differential Revision: https://reviews.llvm.org/D60853 Modified: cfe/trunk/li

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

2019-04-18 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966 + QualType PointeeTy = D.getTypePtr()->getPointeeType(); + llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc)); + CI->setMetadata("heapallocsite", DI); akhuang wrote:

[PATCH] D60853: clang-format converts a keyword macro definition to a macro function

2019-04-18 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358710: [clang-format] Fix incorrect formatting of keyword macro definition (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

2019-04-18 Thread Matthew Voss via Phabricator via cfe-commits
ormris added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } sammccall wrote: > ormris wrote: > > Quick nit: This test won't work on

[PATCH] D60886: [OpenMP][NFC] Fix requires target test.

2019-04-18 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea created this revision. gtbercea added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. Fix requires target test. Repository: rC Clang https://reviews.llvm.org/D60886 Files: test/OpenMP/requires_target_messages.cpp In

r358711 - [OpenMP][NFC] Fix requires target test.

2019-04-18 Thread Gheorghe-Teodor Bercea via cfe-commits
Author: gbercea Date: Thu Apr 18 13:34:43 2019 New Revision: 358711 URL: http://llvm.org/viewvc/llvm-project?rev=358711&view=rev Log: [OpenMP][NFC] Fix requires target test. Summary: Fix requires target test. Reviewers: ABataev Subscribers: guansong, jdoerfert, cfe-commits Tags: #clang Diffe

[PATCH] D60886: [OpenMP][NFC] Fix requires target test.

2019-04-18 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC358711: [OpenMP][NFC] Fix requires target test. (authored by gbercea, committed by ). Repository: rC Clang CHANGES SIN

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

2019-04-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. (also fix typo in the function name) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

2019-04-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 195810. NoQ added a comment. This revision is now accepted and ready to land. Don't canonicalize the decl in the body farm. The decl supplied by the AnalysisDeclContext is already the correct one (and not necessarily the canonical one). Keep the defensive behav

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

2019-04-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } ormris wrote: > sammccall wrote: > > ormris wrote: > > > Quick nit:

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D60845#1471741 , @jdenny wrote: > In D60845#1471002 , @rsmith wrote: > > > I've seen a few projects outside of clang use `-verify` mode for their own > > testing of various things. > > >

r358713 - [c++2a] Add semantic support for private module fragments.

2019-04-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Apr 18 14:12:54 2019 New Revision: 358713 URL: http://llvm.org/viewvc/llvm-project?rev=358713&view=rev Log: [c++2a] Add semantic support for private module fragments. Added: cfe/trunk/test/CXX/basic/basic.link/p2.cpp cfe/trunk/test/CXX/module/module.interface/

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D60845#1472291 , @rsmith wrote: > In D60845#1471741 , @jdenny wrote: > > > In D60845#1471002 , @rsmith wrote: > > > > > I've seen a few projects ou

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

2019-04-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 195818. akhuang marked 2 inline comments as done. akhuang added a comment. - Pass void metadata as null DIType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files:

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

2019-04-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D58367#1462026 , @Szelethus wrote: > Hmmm, interesting. Could there be an issue with `NoteTag` not being trivially > destructible? Yeah, i think you're right. Which means we cannot allocate it in a `BumpPtrAllocator`. Reposito

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D59712#1469760 , @lebedev.ri wrote: > In D59712#1469693 , @jdenny wrote: > > > In D59712#1469392 , @lebedev.ri > > wrote: > > > > > In D59712#1469

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

2019-04-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 195821. akhuang marked 2 inline comments as done. akhuang added a comment. - Changed test case back to original Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files:

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

2019-04-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri resigned from this revision. lebedev.ri added a comment. In D59712#1472318 , @jdenny wrote: > In D59712#1469760 , @lebedev.ri > wrote: > > > In D59712#1469693 , @

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

2019-04-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang marked an inline comment as done. akhuang added inline comments. Comment at: llvm/test/CodeGen/X86/label-heapallocsite.ll:1 +; RUN: llc -O0 < %s | FileCheck %s +; FIXME: Add test for llc with optimizations once it is implemented. hans wrote: > Does llc ha

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D59712#1472342 , @lebedev.ri wrote: > In D59712#1472318 , @jdenny wrote: > > > For me, check-all's success is not affected by the current patch. I built > > all subprojects except llgo,

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

2019-04-18 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with a minor whitespace issue Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1972 } - CI->setMetadata("heapallocsite", node); Please revert the white spa

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

2019-04-18 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In D59712#1472318 , @jdenny wrote: > In D59712#1469760 , @lebedev.ri > wrote: > > > In D59712#1469693 , @jdenny wrote: > > > > > In D59712#1469392 <

[PATCH] D60892: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter

2019-04-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie created this revision. dblaikie added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code is/was already correct for the case where a parameter is a parameter of its enclosing lexical DeclContext (functions and classes). But for other templa

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

2019-04-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 195835. NoQ added a comment. Fall back to the previous `std::vector>` approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58367/new/ https://reviews.llvm.org/D58367 Files: clang/include/clang/Analysis/ProgramPoint.h clang/include/clang/StaticAn

r358719 - [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix.

2019-04-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Apr 18 16:17:58 2019 New Revision: 358719 URL: http://llvm.org/viewvc/llvm-project?rev=358719&view=rev Log: [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix. This -verify=prefix feature is quite underrated. Differential Revision: https://reviews.llvm.

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358719: [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r358720 - [analyzer] NFC: Make reusable unittest mocks reusable.

2019-04-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Apr 18 16:24:50 2019 New Revision: 358720 URL: http://llvm.org/viewvc/llvm-project?rev=358720&view=rev Log: [analyzer] NFC: Make reusable unittest mocks reusable. Put them in a header for other Analyzer unittests to include. Differential Revision: https://reviews.llvm

[PATCH] D60739: [analyzer] NFC: Re-use reusable unittest mocks.

2019-04-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358720: [analyzer] NFC: Make reusable unittest mocks reusable. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

r358722 - [analyzer] Make default bindings to variables actually work.

2019-04-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Apr 18 16:35:56 2019 New Revision: 358722 URL: http://llvm.org/viewvc/llvm-project?rev=358722&view=rev Log: [analyzer] Make default bindings to variables actually work. Default RegionStore bindings represent values that can be obtained by loading from anywhere within t

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

2019-04-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC358722: [analyzer] Make default bindings to variables actually work. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60742?vs=195500&id=195842#toc Repository:

[PATCH] D44352: [Concepts] Constrained template parameters

2019-04-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This needs revision to reflect changes between the Concepts TS and C++20. In particular, only the name of a //type-concept// can be used to declare a //template-parameter// in the ne

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

2019-04-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:177 + /// conjunction ("and"). + llvm::SmallVector getAssociatedConstraints() const; + Returning a `SmallVector` by value is not idiomatic. If you need to make a copy here, you should t

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D59712#1472358 , @hfinkel wrote: > > I've never tried running the other tests you mention, for any patch. I > > thought people normally left those to the bots. Should this patch be > > handled differently? > > We have a lot o

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

2019-04-18 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In D59712#1472544 , @jdenny wrote: > In D59712#1472358 , @hfinkel wrote: > > > > I've never tried running the other tests you mention, for any patch. I > > > thought people normally left t

r358724 - Add header guard to Reusables.h [NFC]

2019-04-18 Thread Ali Tamur via cfe-commits
Author: tamur Date: Thu Apr 18 17:42:54 2019 New Revision: 358724 URL: http://llvm.org/viewvc/llvm-project?rev=358724&view=rev Log: Add header guard to Reusables.h [NFC] Modified: cfe/trunk/unittests/StaticAnalyzer/Reusables.h Modified: cfe/trunk/unittests/StaticAnalyzer/Reusables.h URL: ht

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

2019-04-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 195850. NoQ added a comment. Separate the canonicalization change that unbreaks body farms into a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 Files: clang/include/clang/StaticAnalyzer/Core

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

2019-04-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 195851. NoQ marked an inline comment as done. NoQ added a comment. Add space before `\`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnosti

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

2019-04-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb, a.sidorin, JDevlieghere, szepet, kristof.beyls, javed.absar. Herald added a project:

r358729 - [analyzer] Fix -Wunused-local-typedef after rC358695

2019-04-18 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Apr 18 18:54:36 2019 New Revision: 358729 URL: http://llvm.org/viewvc/llvm-project?rev=358729&view=rev Log: [analyzer] Fix -Wunused-local-typedef after rC358695 Modified: cfe/trunk/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp Modified: cfe/trunk/lib/StaticAnalyze

r358731 - Fix typo in function name [NFC]

2019-04-18 Thread Ali Tamur via cfe-commits
Author: tamur Date: Thu Apr 18 19:15:57 2019 New Revision: 358731 URL: http://llvm.org/viewvc/llvm-project?rev=358731&view=rev Log: Fix typo in function name [NFC] Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/li

r358733 - Fix overly-long line after r358731.

2019-04-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Apr 18 19:46:50 2019 New Revision: 358733 URL: http://llvm.org/viewvc/llvm-project?rev=358733&view=rev Log: Fix overly-long line after r358731. Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tru

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

2019-04-18 Thread Ronan Keryell via Phabricator via cfe-commits
keryell added a comment. In D60455#1470402 , @Anastasia wrote: > > In the interest of speeding up the upstreaming work, would you be able to > highlight the differences and similarity at least for SYCL and OpenCL kernel > modes? Not sure if you are f

<    1   2